Fixing rshd/rlogind configuration and make target

PATCH New universe II 2 participants 2 messages Nov 18, 2013 – Apr 12, 2014

Share & tools

universe II

author

2013-11-18 14:34 UTC #0 lore raw

PATCH 1/1 Fixing rshd/rlogind configuration and make target

All,
I found out that build of rshd and rlogind is commented out in Config.in of package rsh-redone. Re-activating them lead to compile errors of the rsh-redone package (when linking with pam). After a while I found the root cause. The make targets are wrong: rshd and rlogind must be replaces by in.rshd and in.rlogind. With these changes rshd and rlogind are compiled and are running fine on my target. Just activate them in inetd.conf and adjust some PAM settings. That's all.

Regards,
Andreas

Signed-off-by Andreas Ehmanns <[email protected]>

Config.in 2013-10-24 08:22:47.324184620 +0200 renamed from Config.in 2013-09-17 13:42:07.000000000 +0200 +6 -6

diff -Naur rsh-redone_org/Config.in rsh-redone/Config.in
@@ -17,15 +17,15 @@
         depends on BR2_PACKAGE_RSH_REDONE
 
  # requires PAM
-#config BR2_PACKAGE_RSH_REDONE_RLOGIND
-#      bool "rlogind"
-#      depends on BR2_PACKAGE_RSH_REDONE
+config BR2_PACKAGE_RSH_REDONE_RLOGIND
+       bool "rlogind"
+       depends on BR2_PACKAGE_RSH_REDONE
 
  config BR2_PACKAGE_RSH_REDONE_RSH
         bool "rsh"
         depends on BR2_PACKAGE_RSH_REDONE
 
  # requires PAM
-#config BR2_PACKAGE_RSH_REDONE_RSHD
-#      bool "rshd"
-#      depends on BR2_PACKAGE_RSH_REDONE
+config BR2_PACKAGE_RSH_REDONE_RSHD
+       bool "rshd"
+       depends on BR2_PACKAGE_RSH_REDONE

rsh-redone.mk 2013-10-24 08:23:00.643065545 +0200 renamed from rsh-redone.mk 2013-09-17 13:42:07.000000000 +0200 +2 -2

diff -Naur rsh-redone_org/rsh-redone.mk rsh-redone/rsh-redone.mk
@@ -13,8 +13,8 @@
  rsh-redone-bin-$(BR2_PACKAGE_RSH_REDONE_RLOGIN) += rlogin
  rsh-redone-bin-$(BR2_PACKAGE_RSH_REDONE_RSH) += rsh
  rsh-redone-sbin-y =
-rsh-redone-sbin-$(BR2_PACKAGE_RSH_REDONE_RLOGIND) += rlogind
-rsh-redone-sbin-$(BR2_PACKAGE_RSH_REDONE_RSHD) += rshd
+rsh-redone-sbin-$(BR2_PACKAGE_RSH_REDONE_RLOGIND) += in.rlogind
+rsh-redone-sbin-$(BR2_PACKAGE_RSH_REDONE_RSHD) += in.rshd
 
  define RSH_REDONE_BUILD_CMDS
         $(TARGET_CONFIGURE_OPTS) $(MAKE) -C $(@D)

BIN="$(rsh-redone-bin-y)" SBIN="$(rsh-redone-sbin-y)"

Thomas Petazzoni

2014-04-12 15:12 UTC #1 lore raw

PATCH 1/1 Fixing rshd/rlogind configuration and make target

Dear universe II,

Config.in 2013-10-24 08:22:47.324184620 +0200 line 22

Quoted 3 lines · universe II

Config.in 2013-10-24 08:22:47.324184620 +0200 renamed from Config.in 2013-09-17 13:42:07.000000000 +0200 +3 -0
+config BR2_PACKAGE_RSH_REDONE_RLOGIND
+       bool "rlogind"
+       depends on BR2_PACKAGE_RSH_REDONE

Dependency on BR2_PACKAGE_LINUX_PAM was missing here.

Config.in 2013-10-24 08:22:47.324184620 +0200 line 31

Quoted 12 lines

config BR2_PACKAGE_RSH_REDONE_RSH
bool "rsh"
depends on BR2_PACKAGE_RSH_REDONE
  # requires PAM
Config.in 2013-10-24 08:22:47.324184620 +0200 renamed from Config.in 2013-09-17 13:42:07.000000000 +0200 +3 -3
-#config BR2_PACKAGE_RSH_REDONE_RSHD
-#      bool "rshd"
-#      depends on BR2_PACKAGE_RSH_REDONE
+config BR2_PACKAGE_RSH_REDONE_RSHD
+       bool "rshd"
+       depends on BR2_PACKAGE_RSH_REDONE

and here.

rsh-redone.mk 2013-10-24 08:23:00.643065545 +0200 line 17

Quoted 11 lines

diff -Naur rsh-redone_org/rsh-redone.mk rsh-redone/rsh-redone.mk
rsh-redone.mk 2013-10-24 08:23:00.643065545 +0200 renamed from rsh-redone.mk 2013-09-17 13:42:07.000000000 +0200 +2 -2
@@ -13,8 +13,8 @@
  rsh-redone-bin-$(BR2_PACKAGE_RSH_REDONE_RLOGIN) += rlogin
  rsh-redone-bin-$(BR2_PACKAGE_RSH_REDONE_RSH) += rsh
  rsh-redone-sbin-y =
-rsh-redone-sbin-$(BR2_PACKAGE_RSH_REDONE_RLOGIND) += rlogind
-rsh-redone-sbin-$(BR2_PACKAGE_RSH_REDONE_RSHD) += rshd
+rsh-redone-sbin-$(BR2_PACKAGE_RSH_REDONE_RLOGIND) += in.rlogind
+rsh-redone-sbin-$(BR2_PACKAGE_RSH_REDONE_RSHD) += in.rshd

and here as well.

I've fixed that up and committed.

Thanks!

Thomas

Signature · 3 lines

Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com