Skip to contentSkip to conversation

USB 2.0 host on Lager

PATCH In review Ulrich Hecht 2 participants 3 messages Nov 20, 2013 – Nov 21, 2013 SuperH

lore
Share & tools
lore
#0 lore raw

cover USB 2.0 host on Lager

This is a collection of patches developed by Valentine Barshak towards support of the PCI-attached USB 2.0 host controllers on Lager, with some glue supplied by me:

- added missing PCI host clock (MSTP703)
- bound PCI USB HCIs to the USB phy
- added PCI host platform devices on Lager

I chose to do incremental patches on top of Valentine's stuff because his patches are already in various states of upstream acceptance; please tell me if you need this packaged differently.

CU
Uli

Ulrich Hecht (4):
pci: rcar-gen2: enable clock
ARM: shmobile: r8a7790: add internal PCI clock
usb: phy: rcar-gen2: register using usb_add_phy_dev()
ARM: shmobile: lager: add PCI USB host controllers

Valentine Barshak (5):
pci: Add R-Car Gen2 internal PCI support
usb: hcd: Remove USB phy if needed
usb: hcd: Initialize USB phy if needed
usb: phy: Add RCAR Gen2 USB phy
arm: shmobile: lager: Add USBHS support

 arch/arm/mach-shmobile/Kconfig                  |   1 +
 arch/arm/mach-shmobile/board-lager.c            | 138 ++++++++++
 arch/arm/mach-shmobile/clock-r8a7790.c          |   5 +-
 drivers/pci/host/Kconfig                        |   8 +
 drivers/pci/host/Makefile                       |   1 +
 drivers/pci/host/pci-rcar-gen2.c                | 347 ++++++++++++++++++++++++
 drivers/usb/core/hcd.c                          |  34 ++-
 drivers/usb/phy/Kconfig                         |  13 +
 drivers/usb/phy/Makefile                        |   1 +
 drivers/usb/phy/phy-rcar-gen2-usb.c             | 249 +++++++++++++++++
 include/linux/platform_data/usb-rcar-gen2-phy.h |  22 ++
 include/linux/usb/hcd.h                         |   1 +
 12 files changed, 818 insertions(+), 2 deletions(-)
 create mode 100644 drivers/pci/host/pci-rcar-gen2.c
 create mode 100644 drivers/usb/phy/phy-rcar-gen2-usb.c
 create mode 100644 include/linux/platform_data/usb-rcar-gen2-phy.h
Signature · 1 line
1.8.4
#1 lore raw
Quoted 10 lines · Ulrich Hecht

This is a collection of patches developed by Valentine Barshak towards support of the PCI-attached USB 2.0 host controllers on Lager, with some glue supplied by me:

- added missing PCI host clock (MSTP703)
- bound PCI USB HCIs to the USB phy
- added PCI host platform devices on Lager

I chose to do incremental patches on top of Valentine's stuff because his patches are already in various states of upstream acceptance;

Why re-post them then?
In fact I was going to add USB Host support once USBHS support is commited.

Quoted 12 lines

please tell me
if you need this packaged differently.

CU
Uli

Ulrich Hecht (4):
pci: rcar-gen2: enable clock
ARM: shmobile: r8a7790: add internal PCI clock
usb: phy: rcar-gen2: register using usb_add_phy_dev()
ARM: shmobile: lager: add PCI USB host controllers

Quoted 6 lines

Valentine Barshak (5):
pci: Add R-Car Gen2 internal PCI support
usb: hcd: Remove USB phy if needed
usb: hcd: Initialize USB phy if needed
usb: phy: Add RCAR Gen2 USB phy
arm: shmobile: lager: Add USBHS support

You've missed one more patch here, which helps to initialize the PHY for PCI host correctly:
usb: phy: phy-rcar-gen2-usb: Fix phy initialization

Quoted 14 lines
  arch/arm/mach-shmobile/Kconfig                  |   1 +
  arch/arm/mach-shmobile/board-lager.c            | 138 ++++++++++
  arch/arm/mach-shmobile/clock-r8a7790.c          |   5 +-
  drivers/pci/host/Kconfig                        |   8 +
  drivers/pci/host/Makefile                       |   1 +
  drivers/pci/host/pci-rcar-gen2.c                | 347 ++++++++++++++++++++++++
  drivers/usb/core/hcd.c                          |  34 ++-
  drivers/usb/phy/Kconfig                         |  13 +
  drivers/usb/phy/Makefile                        |   1 +
  drivers/usb/phy/phy-rcar-gen2-usb.c             | 249 +++++++++++++++++
  include/linux/platform_data/usb-rcar-gen2-phy.h |  22 ++
  include/linux/usb/hcd.h                         |   1 +
  12 files changed, 818 insertions(+), 2 deletions(-)
Quoted 4 lines

create mode 100644 drivers/pci/host/pci-rcar-gen2.c create mode 100644 drivers/usb/phy/phy-rcar-gen2-usb.c create mode 100644 include/linux/platform_data/usb-rcar-gen2-phy.h

Thanks,
Val.

#2 lore raw
In reply to Ulrich Hecht
Quoted 5 lines · Valentine
Quoted 2 lines · Ulrich Hecht

I chose to do incremental patches on top of Valentine's stuff because his patches are already in various states of upstream acceptance;

Why re-post them then?

Because I am not entirely sure about the status of all of them.

Quoted 1 line

In fact I was going to add USB Host support once USBHS support is commited.

I was not aware of your intention to do so (could I have been?), and I have a deadline on the 29th.

CU
Uli