Skip to contentSkip to conversation

tinymembench: package not supported on MIPS64

PATCH New Vicente Olivert Riera 3 participants 3 messages Nov 22, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v3 1/1 tinymembench: package not supported on MIPS64

Fixes:

http://autobuild.buildroot.net/results/bab/bab68bcf8714f215ac0b0c2546fa06608377fbb0/

This package is only supported on MIPS32 platforms. The mips-32.S file included in the source code of this package only makes sense to be compiled for MIPS32, and also contains hardcoded MIPS32 instructions which are illegal on MIPS64. Trying to compile this package on a MIPS64 platform will end with a linkage failure due to undefined references.

---
 package/tinymembench/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/tinymembench/Config.in +1 -0
index 0d45532..0555b19 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_TINYMEMBENCH
 	bool "tinymembench"
+	depends on !BR2_mips64 && !BR2_mips64el
 	help
 	  Tinymembench is a simple memory benchmark program, which
 	  tries to measure the peak bandwidth of sequential memory
Signature · 1 line
1.7.1
#1 lore raw

PATCH v3 1/1 tinymembench: package not supported on MIPS64

Quoted 21 lines · Vicente Olivert Riera

Fixes:

    http://autobuild.buildroot.net/results/bab/bab68bcf8714f215ac0b0c2546fa06608377fbb0/

This package is only supported on MIPS32 platforms. The mips-32.S file included in the source code of this package only makes sense to be compiled for MIPS32, and also contains hardcoded MIPS32 instructions which are illegal on MIPS64. Trying to compile this package on a MIPS64 platform will end with a linkage failure due to undefined references.

---
  package/tinymembench/Config.in |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
package/tinymembench/Config.in +0 -0
index 0d45532..0555b19 100644

package/tinymembench/Config.in line 6

Quoted 6 lines
package/tinymembench/Config.in +1 -0
@@ -1,5 +1,6 @@
  config BR2_PACKAGE_TINYMEMBENCH
  	bool "tinymembench"
+	depends on !BR2_mips64 && !BR2_mips64el
  	help
  	  Tinymembench is a simple memory benchmark program, which
  	  tries to measure the peak bandwidth of sequential memory

I guess you could move the 'Fixes $URL' part just above your Signed-off-by line. But in any case, it looks good to me. Thanks

Signature · 1 line
markos
#2 lore raw

PATCH v3 1/1 tinymembench: package not supported on MIPS64

In reply to Vicente Olivert Riera
Quoted 5 lines
Quoted 1 line
Quoted 1 line
Quoted 1 line
Quoted 1 line

"Vicente" == Vicente Olivert Riera <[email protected]> writes:

Fixes:

   http://autobuild.buildroot.net/results/bab/bab68bcf8714f215ac0b0c2546fa06608377fbb0/
Quoted 8 lines

This package is only supported on MIPS32 platforms. The mips-32.S file included in the source code of this package only makes sense to be compiled for MIPS32, and also contains hardcoded MIPS32 instructions which are illegal on MIPS64. Trying to compile this package on a MIPS64 platform will end with a linkage failure due to undefined references.

Committed, thanks.

Signature · 1 line
Bye, Peter Korsgaard