Skip to contentSkip to conversation

dt-bindings: add ARMv8 PMU binding

PATCH In review Rob Herring 3 participants 6 messages Nov 22, 2013 – Nov 25, 2013 Device tree bindings

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 dt-bindings: add ARMv8 PMU binding

From: Rob Herring <rob.herring-bsGFqQB8/[email protected]>

Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.

---
 Documentation/devicetree/bindings/arm/pmu.txt | 1 +
 1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/pmu.txt +1 -0
index 343781b..3e1e498 100644
@@ -7,6 +7,7 @@ representation in the device tree should be done as under:-
 Required properties:
 
 - compatible : should be one of
+	"arm,armv8-pmuv3"
 	"arm,cortex-a15-pmu"
 	"arm,cortex-a9-pmu"
 	"arm,cortex-a8-pmu"
Signature · 6 lines
1.8.1.2

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw
Quoted 21 lines · Rob Herring

From: Rob Herring <rob.herring-bsGFqQB8/[email protected]>

Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.

---
Documentation/devicetree/bindings/arm/pmu.txt | 1 +

1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/pmu.txt +0 -0
index 343781b..3e1e498 100644
@@ -7,6 +7,7 @@ representation in the device tree should be done as under:-

Required properties:

- compatible : should be one of

Documentation/devicetree/bindings/arm/pmu.txt

Quoted 1 line
Documentation/devicetree/bindings/arm/pmu.txt +1 -0
+	"arm,armv8-pmuv3”

what about arm,armv8-pmu-v3?

- k

Quoted 10 lines
	"arm,cortex-a15-pmu"
	"arm,cortex-a9-pmu"
	"arm,cortex-a8-pmu"
Signature · 6 lines
1.8.1.2

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Signature · 7 lines
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#2 lore raw
Quoted 23 lines · Kumar Gala
Quoted 20 lines · Rob Herring

From: Rob Herring <rob.herring-bsGFqQB8/[email protected]>

Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.

---
Documentation/devicetree/bindings/arm/pmu.txt | 1 +

1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/pmu.txt +0 -0
index 343781b..3e1e498 100644
@@ -7,6 +7,7 @@ representation in the device tree should be done as under:-

Required properties:

Quoted 4 lines

Documentation/devicetree/bindings/arm/pmu.txt

Quoted 2 lines

- compatible : should be one of

Documentation/devicetree/bindings/arm/pmu.txt +1 -0
+	"arm,armv8-pmuv3”

what about arm,armv8-pmu-v3?

I'm just documenting what is already being used:

arch/arm64/boot/dts/foundation-v8.dts: compatible =
"arm,armv8-pmuv3";
arch/arm64/boot/dts/rtsm_ve-aemv8a.dts: compatible =
"arm,armv8-pmuv3";

Do we want to change those?

Rob

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 29 lines · Rob Herring
Quoted 23 lines · Kumar Gala
Quoted 20 lines · Rob Herring

From: Rob Herring <rob.herring-bsGFqQB8/[email protected]>

Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.

---
Documentation/devicetree/bindings/arm/pmu.txt | 1 +

1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/pmu.txt +0 -0
index 343781b..3e1e498 100644
@@ -7,6 +7,7 @@ representation in the device tree should be done as under:-

Required properties:

Quoted 4 lines

Documentation/devicetree/bindings/arm/pmu.txt

Quoted 2 lines

- compatible : should be one of

Documentation/devicetree/bindings/arm/pmu.txt +1 -0
+	"arm,armv8-pmuv3”

what about arm,armv8-pmu-v3?

Quoted 8 lines

I'm just documenting what is already being used:

arch/arm64/boot/dts/foundation-v8.dts: compatible =
"arm,armv8-pmuv3";
arch/arm64/boot/dts/rtsm_ve-aemv8a.dts: compatible =
"arm,armv8-pmuv3";

Do we want to change those?

It would probably have been nicer to have the '-' from the start, but adding it now is only going to expand the set of compatible strings for no appreciable benefit.

I don't see any value in adding a new form of the string, and we can't change the existing one as it's already in use.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

#4 lore raw
Quoted 37 lines · Mark Rutland
Quoted 36 lines · Rob Herring
Quoted 23 lines · Kumar Gala
Quoted 20 lines · Rob Herring

From: Rob Herring <rob.herring-bsGFqQB8/[email protected]>

Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.

---
Documentation/devicetree/bindings/arm/pmu.txt | 1 +

1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/pmu.txt +0 -0
index 343781b..3e1e498 100644
@@ -7,6 +7,7 @@ representation in the device tree should be done as under:-

Required properties:

Quoted 4 lines
Quoted 2 lines

- compatible : should be one of
+ "arm,armv8-pmuv3”

what about arm,armv8-pmu-v3?

I'm just documenting what is already being used:

arch/arm64/boot/dts/foundation-v8.dts: compatible =
"arm,armv8-pmuv3";
arch/arm64/boot/dts/rtsm_ve-aemv8a.dts: compatible =
"arm,armv8-pmuv3";

Quoted 8 lines
Quoted 1 line

Do we want to change those?

It would probably have been nicer to have the '-' from the start, but adding it now is only going to expand the set of compatible strings for no appreciable benefit.

I don't see any value in adding a new form of the string, and we can't change the existing one as it's already in use.

Is that an ack then?
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Acked-by
#5 lore raw
Quoted 40 lines · Rob Herring
Quoted 39 lines · Mark Rutland
Quoted 37 lines · Rob Herring
Quoted 23 lines · Kumar Gala
Quoted 20 lines · Rob Herring

From: Rob Herring <rob.herring-bsGFqQB8/[email protected]>

Add missing "arm,armv8-pmuv3" compatible property for ARMv8 PMU.

---
Documentation/devicetree/bindings/arm/pmu.txt | 1 +

1 file changed, 1 insertion(+)
Documentation/devicetree/bindings/arm/pmu.txt +0 -0
index 343781b..3e1e498 100644
@@ -7,6 +7,7 @@ representation in the device tree should be done as under:-

Required properties:

Quoted 4 lines
Quoted 2 lines

- compatible : should be one of
+ "arm,armv8-pmuv3”

what about arm,armv8-pmu-v3?

I'm just documenting what is already being used:

arch/arm64/boot/dts/foundation-v8.dts: compatible =
"arm,armv8-pmuv3";
arch/arm64/boot/dts/rtsm_ve-aemv8a.dts: compatible =
"arm,armv8-pmuv3";

Do we want to change those?

Quoted 9 lines
Quoted 6 lines

It would probably have been nicer to have the '-' from the start, but adding it now is only going to expand the set of compatible strings for no appreciable benefit.

I don't see any value in adding a new form of the string, and we can't change the existing one as it's already in use.

Is that an ack then?

Sure:

Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html