spi: davinci: Fix the build warning with CONFIG_ARM_LPAE=y
PATCH 1/1 spi: davinci: Fix the build warning with CONFIG_ARM_LPAE=y
With CONFIG_ARM_LPAE=y spi driver throws below warning
drivers/spi/spi-davinci.c: In function ?davinci_spi_probe?:drivers/spi/spi-davinci.c:965:3: warning: format ?%d? expects argument of type ?int?, but argument 3 has type ?resource_size_t? [-Wformat] drivers/spi/spi-davinci.c:965:3: warning: format ?%d? expects argument of type ?int?, but argument 4 has type ?resource_size_t? [-Wformat]
Lets use '%pa' to properly print 'resource_size_t' type variables.
--- drivers/spi/spi-davinci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/spi/spi-davinci.c +2 -2
@@ -962,8 +962,8 @@ static int davinci_spi_probe(struct platform_device *pdev) goto free_clk;dev_info (&pdev->dev,"DMA: supported\n" ); -dev_info (&pdev->dev,"DMA: RX channel: %d, TX channel: %d, " -"event queue: %d\n" , dma_rx_chan, dma_tx_chan, +dev_info (&pdev->dev,"DMA: RX channel: %pa, TX channel: %pa, " +"event queue: %d\n" , &dma_rx_chan, &dma_tx_chan, pdata->dma_event_q); }
Signature · 1 line
1.7.9.5
Mark Brown
maintainerPATCH 1/1 spi: davinci: Fix the build warning with CONFIG_ARM_LPAE=y
Quoted 1 line · Santosh Shilimkar
With
CONFIG_ARM_LPAE=yspi driver throws below warning
Applied, thanks.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131001/c9966945/attachment.sig>
PATCH 1/1 spi: davinci: Fix the build warning with CONFIG_ARM_LPAE=y
Hi,
Quoted 4 lines · Mark Brown
Quoted 1 line · Santosh Shilimkar
With
CONFIG_ARM_LPAE=yspi driver throws below warningApplied, thanks.
These warnings are showing up (again?), so wherever it was applied is not making it into -next. Did it fall between the cracks?
-Olof
Mark Brown
maintainerPATCH 1/1 spi: davinci: Fix the build warning with CONFIG_ARM_LPAE=y
Quoted 6 lines · Olof Johansson
Quoted 1 line · Mark Brown
Applied, thanks.
These warnings are showing up (again?), so wherever it was applied is not making it into -next. Did it fall between the cracks?
Looks lie it never got pushed and nobody looked at the warnings for over
a month. Oh well, sorry about that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131113/1d7b541a/attachment.sig>
PATCH 1/1 spi: davinci: Fix the build warning with CONFIG_ARM_LPAE=y
Quoted 10 lines · Mark Brown
Quoted 6 lines · Olof Johansson
Quoted 1 line · Mark Brown
Applied, thanks.
These warnings are showing up (again?), so wherever it was applied is not making it into -next. Did it fall between the cracks?
Looks lie it never got pushed and nobody looked at the warnings for over a month. Oh well, sorry about that.
No worries.
I've been eyeing the warnings but not doing anything about it. Didn't notice that there was a patch until I started looking for existing patches to take care of it (and post patches where needed).
-Olof
PATCH 1/1 spi: davinci: Fix the build warning with CONFIG_ARM_LPAE=y
In reply to Mark BrownMark,
Quoted 11 lines · Mark Brown
Quoted 6 lines · Olof Johansson
Quoted 1 line · Mark Brown
Applied, thanks.
These warnings are showing up (again?), so wherever it was applied is not making it into -next. Did it fall between the cracks?
Looks lie it never got pushed and nobody looked at the warnings for over a month. Oh well, sorry about that.
Are you going to push this one ? The warning is still showing up at 3.13-rc1.
Regards,
Santosh
Mark Brown
maintainerPATCH 1/1 spi: davinci: Fix the build warning with CONFIG_ARM_LPAE=y
Quoted 7 lines · Santosh Shilimkar
Quoted 2 lines · Mark Brown
Looks lie it never got pushed and nobody looked at the warnings for over a month. Oh well, sorry about that.
Are you going to push this one ? The warning is still showing up at 3.13-rc1.
It's a warning fix only so no, I was going to leave it till the next
merge window. It'll appear in -next as soon as Linus releases -rc1.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131124/32bd6646/attachment.sig>