riscv: Fix vdso_install target with CONFIG_COMPAT=y
PATCH 1/1 riscv: Fix vdso_install target with CONFIG_COMPAT=y
The recipe for vdso_install in arch/riscv/Makefile invokes targets of the same name in arch/riscv/kernel/vdso and .../compat_vdso, but the target in the latter is called compat_vdso_install. Change the recipe to use the right target name.
--- arch/riscv/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/Makefile +1 -1
@@ -110,7 +110,7 @@ PHONY += vdso_install vdso_install: $(Q)$(MAKE) $(build)=arch/riscv/kernel/vdso $@ $(if $(CONFIG_COMPAT),$(Q)$(MAKE) \ - $(build)=arch/riscv/kernel/compat_vdso $@) + $(build)=arch/riscv/kernel/compat_vdso compat_vdso_install) ifeq ($(KBUILD_EXTMOD),) ifeq ($(CONFIG_MMU),y)
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 17 lines · Ben Hutchings
The recipe for
vdso_installinarch/riscv/Makefileinvokes targets of the same name inarch/riscv/kernel/vdsoand .../compat_vdso, but the target in the latter is calledcompat_vdso_install. Change the recipe to use the right target name.Fixes 0715372a06ce ("riscv: compat: vdso: Add COMPAT_VDSO base code ...")Signed-off-by Ben Hutchings <[email protected]>--- arch/riscv/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/riscv/Makefile +0
-0
arch/riscv/Makefile PHONY += vdso_install · line 113
Quoted 5 lines
arch/riscv/Makefile +1
-1@@ -110,7 +110,7 @@ PHONY += vdso_install vdso_install: $(Q)$(MAKE) $(build)=arch/riscv/kernel/vdso $@ $(if $(CONFIG_COMPAT),$(Q)$(MAKE) \ - $(build)=arch/riscv/kernel/compat_vdso $@) + $(build)=arch/riscv/kernel/compat_vdso compat_vdso_install)
Good catch, but what's the problem you've met?
Quoted 3 lines
arch/riscv/Makefile +0
-0ifeq ($(KBUILD_EXTMOD),) ifeq ($(CONFIG_MMU),y)
Signature · 7 lines
Best Regards Guo Ren _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 13 lines · Guo Ren
Quoted 12 lines · Ben Hutchings
The recipe for
vdso_installinarch/riscv/Makefileinvokes targets of the same name inarch/riscv/kernel/vdsoand .../compat_vdso, but the target in the latter is calledcompat_vdso_install. Change the recipe to use the right target name.Fixes 0715372a06ce ("riscv: compat: vdso: Add COMPAT_VDSO base code ...")Signed-off-by Ben Hutchings <[email protected]>--- arch/riscv/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Quoted 11 lines
arch/riscv/Makefile PHONY += vdso_install · line 113
Quoted 10 lines
arch/riscv/Makefile +1
-1@@ -110,7 +110,7 @@ PHONY += vdso_install vdso_install: $(Q)$(MAKE) $(build)=arch/riscv/kernel/vdso $@ $(if $(CONFIG_COMPAT),$(Q)$(MAKE) \ - $(build)=arch/riscv/kernel/compat_vdso $@) + $(build)=arch/riscv/kernel/compat_vdso compat_vdso_install)Good catch, but what's the problem you've met?
It broke the Debian package build
<https://buildd.debian.org/status/fetch.php?pkg=linux&arch=riscv64&ver=5.19%7Erc6-1%7Eexp1&stamp=1657777338&raw=0>:
[...] /usr/bin/make [...] -C debian/build/build_riscv64_none_riscv64 vdso_install INSTALL_MOD_PATH='/<<PKGBUILDDIR>>'/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug
make[3]: Entering directory '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
[...]/usr/bin/make -f /<<PKGBUILDDIR>>/scripts/Makefile.build obj=arch/riscv/kernel/vdso vdso_install
[...]
gcc-11 -Wp,-MMD,arch/riscv/kernel/vdso/.vgettimeofday.o.d -nostdinc -I/<<PKGBUILDDIR>>/arch/riscv/include -I./arch/riscv/include/generated -I/<<PKGBUILDDIR>>/include -I./include -I/<<PKGBUILDDIR>>/arch/riscv/include/uapi -I./arch/riscv/include/generated/uapi -I/<<PKGBUILDDIR>>/include/uapi -I./include/generated/uapi -include /<<PKGBUILDDIR>>/include/linux/compiler-version.h -include /<<PKGBUILDDIR>>/include/linux/kconfig.h -include /<<PKGBUILDDIR>>/include/linux/compiler_types.h -D__KERNEL__ -DCC_USING_PATCHABLE_FUNCTION_ENTRY -fmacro-prefix-map=/<<PKGBUILDDIR>>/= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu11 -mabi=lp64 -march=rv64imac_zicsr_zifencei -mno-save-restore -DCONFIG_PAGE_OFFSET=0xff60000000000000 -mcmodel=medany -fno-omit-frame-pointer -mstrict-align -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=2048 -fstack-protector-strong -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-stack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -g -fdebug-prefix-map=/<<PKGBUILDDIR>>/= -fno-stack-protector -fPIC -include /<<PKGBUILDDIR>>/lib/vdso/gettimeofday.c -I /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso -I ./arch/riscv/kernel/vdso -DKBUILD_MODFILE='"arch/riscv/kernel/vdso/vgettimeofday"' -DKBUILD_BASENAME='"vgettimeofday"' -DKBUILD_MODNAME='"vgettimeofday"' -D__KBUILD_MODNAME=kmod_vgettimeofday -c -o arch/riscv/kernel/vdso/vgettimeofday.o /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso/vgettimeofday.c
[...]
/<<PKGBUILDDIR>>/scripts/check-local-export arch/riscv/kernel/vdso/vgettimeofday.o
if nm arch/riscv/kernel/vdso/vgettimeofday.o 2>/dev/null | grep -q __ksymtab; then gcc-11 -E -D__GENKSYMS__ -Wp,-MMD,arch/riscv/kernel/vdso/.vgettimeofday.o.d -nostdinc -I/<<PKGBUILDDIR>>/arch/riscv/include -I./arch/riscv/include/generated -I/<<PKGBUILDDIR>>/include -I./include -I/<<PKGBUILDDIR>>/arch/riscv/include/uapi -I./arch/riscv/include/generated/uapi -I/<<PKGBUILDDIR>>/include/uapi -I./include/generated/uapi -include /<<PKGBUILDDIR>>/include/linux/compiler-version.h -include /<<PKGBUILDDIR>>/include/linux/kconfig.h -include /<<PKGBUILDDIR>>/include/linux/compiler_types.h -D__KERNEL__ -DCC_USING_PATCHABLE_FUNCTION_ENTRY -fmacro-prefix-map=/<<PKGBUILDDIR>>/= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu11 -mabi=lp64 -march=rv64imac_zicsr_zifencei -mno-save-restore -DCONFIG_PAGE_OFFSET=0xff60000000000000 -mcmodel=medany -fno-omit-frame-pointer -mstrict-align -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=2048 -fstack-protector-strong -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-stack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -g -fdebug-prefix-map=/<<PKGBUILDDIR>>/= -fno-stack-protector -fPIC -include /<<PKGBUILDDIR>>/lib/vdso/gettimeofday.c -I /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso -I ./arch/riscv/kernel/vdso -DKBUILD_MODFILE='"arch/riscv/kernel/vdso/vgettimeofday"' -DKBUILD_BASENAME='"vgettimeofday"' -DKBUILD_MODNAME='"vgettimeofday"' -D__KBUILD_MODNAME=kmod_vgettimeofday /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso/vgettimeofday.c | scripts/genksyms/genksyms -r /dev/null >> arch/riscv/kernel/vdso/.vgettimeofday.o.cmd; fi
ld -melf64lriscv -shared -S -soname=linux-vdso.so.1 --build-id=sha1 --hash-style=both --eh-frame-hdr -T arch/riscv/kernel/vdso/vdso.lds arch/riscv/kernel/vdso/rt_sigreturn.o arch/riscv/kernel/vdso/vgettimeofday.o arch/riscv/kernel/vdso/getcpu.o arch/riscv/kernel/vdso/flush_icache.o arch/riscv/kernel/vdso/note.o -o arch/riscv/kernel/vdso/vdso.so.dbg.tmp && objcopy -G __vdso_rt_sigreturn -G __vdso_vgettimeofday -G __vdso_getcpu -G __vdso_flush_icache arch/riscv/kernel/vdso/vdso.so.dbg.tmp arch/riscv/kernel/vdso/vdso.so.dbg && rm arch/riscv/kernel/vdso/vdso.so.dbg.tmp cp arch/riscv/kernel/vdso/vdso.so.dbg /<<PKGBUILDDIR>>/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug/lib/modules/5.19.0-rc6-riscv64/vdso/vdso.so
:/usr/bin/make -f /<<PKGBUILDDIR>>/scripts/Makefile.build obj=arch/riscv/kernel/compat_vdso vdso_install
[...]
make[4]: *** No rule to make target 'vdso_install'. Stop.
make[3]: *** [/<<PKGBUILDDIR>>/arch/riscv/Makefile:112: vdso_install] Error 2
make[3]: Leaving directory '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
make[2]: *** [debian/rules.real:513: install-image-dbg_riscv64_none_riscv64] Error 2
make[2]: *** Waiting for unfinished jobs....
Ben.
Quoted 7 lines
Quoted 4 lines
arch/riscv/Makefile +0
-0ifeq ($(KBUILD_EXTMOD),) ifeq ($(CONFIG_MMU),y)
Signature · 2 lines
Ben Hutchings This sentence contradicts itself - no actually it doesn't.
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Guo Ren
Reviewed-byI'm just curious who is using vdso_install, thx. Would you mind put below into the commit log?
It broke the Debian package build/usr/bin/make [...] -C debian/build/build_riscv64_none_riscv64vdso_install INSTALL_MOD_PATH='/<<PKGBUILDDIR>>'/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug make[3]: Entering directory
'/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
[...]
make[4]: *** No rule to make target 'vdso_install'. Stop.
Quoted 63 lines · Ben Hutchings
Quoted 13 lines · Guo Ren
Quoted 12 lines · Ben Hutchings
The recipe for
vdso_installinarch/riscv/Makefileinvokes targets of the same name inarch/riscv/kernel/vdsoand .../compat_vdso, but the target in the latter is calledcompat_vdso_install. Change the recipe to use the right target name.Fixes 0715372a06ce ("riscv: compat: vdso: Add COMPAT_VDSO base code ...")Signed-off-by Ben Hutchings <[email protected]>--- arch/riscv/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 11 lines
arch/riscv/Makefile PHONY += vdso_install · line 113
Quoted 10 lines
arch/riscv/Makefile +1
-1@@ -110,7 +110,7 @@ PHONY += vdso_install vdso_install: $(Q)$(MAKE) $(build)=arch/riscv/kernel/vdso $@ $(if $(CONFIG_COMPAT),$(Q)$(MAKE) \ - $(build)=arch/riscv/kernel/compat_vdso $@) + $(build)=arch/riscv/kernel/compat_vdso compat_vdso_install)Good catch, but what's the problem you've met?
It broke the Debian package build
<https://buildd.debian.org/status/fetch.php?pkg=linux&arch=riscv64&ver=5.19%7Erc6-1%7Eexp1&stamp=1657777338&raw=0>:[...]
/usr/bin/make[...] -C debian/build/build_riscv64_none_riscv64vdso_installINSTALL_MOD_PATH='/<<PKGBUILDDIR>>'/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug
make[3]: Entering directory '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
[...]/usr/bin/make-f /<<PKGBUILDDIR>>/scripts/Makefile.build obj=arch/riscv/kernel/vdsovdso_install
[...]
gcc-11 -Wp,-MMD,arch/riscv/kernel/vdso/.vgettimeofday.o.d -nostdinc -I/<<PKGBUILDDIR>>/arch/riscv/include -I./arch/riscv/include/generated -I/<<PKGBUILDDIR>>/include -I./include -I/<<PKGBUILDDIR>>/arch/riscv/include/uapi -I./arch/riscv/include/generated/uapi -I/<<PKGBUILDDIR>>/include/uapi -I./include/generated/uapi -include /<<PKGBUILDDIR>>/include/linux/compiler-version.h -include /<<PKGBUILDDIR>>/include/linux/kconfig.h -include /<<PKGBUILDDIR>>/include/linux/compiler_types.h -D__KERNEL__ -DCC_USING_PATCHABLE_FUNCTION_ENTRY -fmacro-prefix-map=/<<PKGBUILDDIR>>/= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu11 -mabi=lp64 -march=rv64imac_zicsr_zifencei -mno-save-restore -DCONFIG_PAGE_OFFSET=0xff60000000000000 -mcmodel=medany -fno-omit-frame-pointer -mstrict-align -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=2048 -fstack-protector-strong -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-stack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -g -fdebug-prefix-map=/<<PKGBUILDDIR>>/= -fno-stack-protector -fPIC -include /<<PKGBUILDDIR>>/lib/vdso/gettimeofday.c -I /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso -I./arch/riscv/kernel/vdso-DKBUILD_MODFILE='"arch/riscv/kernel/vdso/vgettimeofday"' -DKBUILD_BASENAME='"vgettimeofday"' -DKBUILD_MODNAME='"vgettimeofday"' -D__KBUILD_MODNAME=kmod_vgettimeofday -c -oarch/riscv/kernel/vdso/vgettimeofday.o/<<PKGBUILDDIR>>/arch/riscv/kernel/vdso/vgettimeofday.c
[...]
/<<PKGBUILDDIR>>/scripts/check-local-exportarch/riscv/kernel/vdso/vgettimeofday.o
if nmarch/riscv/kernel/vdso/vgettimeofday.o2>/dev/null | grep -q__ksymtab; then gcc-11 -E -D__GENKSYMS__ -Wp,-MMD,arch/riscv/kernel/vdso/.vgettimeofday.o.d -nostdinc -I/<<PKGBUILDDIR>>/arch/riscv/include -I./arch/riscv/include/generated -I/<<PKGBUILDDIR>>/include -I./include -I/<<PKGBUILDDIR>>/arch/riscv/include/uapi -I./arch/riscv/include/generated/uapi -I/<<PKGBUILDDIR>>/include/uapi -I./include/generated/uapi -include /<<PKGBUILDDIR>>/include/linux/compiler-version.h -include /<<PKGBUILDDIR>>/include/linux/kconfig.h -include /<<PKGBUILDDIR>>/include/linux/compiler_types.h -D__KERNEL__ -DCC_USING_PATCHABLE_FUNCTION_ENTRY -fmacro-prefix-map=/<<PKGBUILDDIR>>/= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu11 -mabi=lp64 -march=rv64imac_zicsr_zifencei -mno-save-restore -DCONFIG_PAGE_OFFSET=0xff60000000000000 -mcmodel=medany -fno-omit-frame-pointer -mstrict-align -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=2048 -fstack-protector-strong -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-stack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -g -fdebug-prefix-map=/<<PKGBUILDDIR>>/= -fno-stack-protector -fPIC -include /<<PKGBUILDDIR>>/lib/vdso/gettimeofday.c -I /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso -I./arch/riscv/kernel/vdso-DKBUILD_MODFILE='"arch/riscv/kernel/vdso/vgettimeofday"' -DKBUILD_BASENAME='"vgettimeofday"' -DKBUILD_MODNAME='"vgettimeofday"' -D__KBUILD_MODNAME=kmod_vgettimeofday /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso/vgettimeofday.c |scripts/genksyms/genksyms-r/dev/null>>arch/riscv/kernel/vdso/.vgettimeofday.o.cmd; fi
ld -melf64lriscv -shared -S -soname=linux-vdso.so.1 --build-id=sha1 --hash-style=both --eh-frame-hdr -Tarch/riscv/kernel/vdso/vdso.ldsarch/riscv/kernel/vdso/rt_sigreturn.oarch/riscv/kernel/vdso/vgettimeofday.oarch/riscv/kernel/vdso/getcpu.oarch/riscv/kernel/vdso/flush_icache.oarch/riscv/kernel/vdso/note.o-oarch/riscv/kernel/vdso/vdso.so.dbg.tmp&& objcopy -G__vdso_rt_sigreturn-G__vdso_vgettimeofday-G__vdso_getcpu-G__vdso_flush_icachearch/riscv/kernel/vdso/vdso.so.dbg.tmparch/riscv/kernel/vdso/vdso.so.dbg&& rmarch/riscv/kernel/vdso/vdso.so.dbg.tmpcparch/riscv/kernel/vdso/vdso.so.dbg/<<PKGBUILDDIR>>/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug/lib/modules/5.19.0-rc6-riscv64/vdso/vdso.so
:/usr/bin/make-f /<<PKGBUILDDIR>>/scripts/Makefile.build obj=arch/riscv/kernel/compat_vdsovdso_install
[...]
make[4]: *** No rule to make target 'vdso_install'. Stop.
make[3]: *** [/<<PKGBUILDDIR>>/arch/riscv/Makefile:112:vdso_install] Error 2
make[3]: Leaving directory '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
make[2]: *** [debian/rules.real:513: install-image-dbg_riscv64_none_riscv64] Error 2
make[2]: *** Waiting for unfinished jobs....Ben.
Quoted 7 lines
arch/riscv/Makefile PHONY += vdso_install · line 116
Quoted 4 lines
arch/riscv/Makefile +0
-0ifeq ($(KBUILD_EXTMOD),) ifeq ($(CONFIG_MMU),y)--
Ben Hutchings
This sentence contradicts itself - no actually it doesn't.
Signature · 7 lines
Best Regards Guo Ren _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 12 lines · Guo Ren
I'm just curious who is using
vdso_install, thx. Would you mind put below into the commit log?It broke the Debian package build
/usr/bin/make[...] -C debian/build/build_riscv64_none_riscv64vdso_installINSTALL_MOD_PATH='/<<PKGBUILDDIR>>'/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug make[3]: Entering directory
'/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
[...]
make[4]: *** No rule to make target 'vdso_install'. Stop.
Quoted 1 line
Reviewed-by Guo Ren <[email protected]>
I don't mind which version goes in, but just for reference there is already this patch on the mailing list:
https://lore.kernel.org/linux-riscv/[email protected]/
/Emil
Quoted 71 lines · Ben Hutchings
Quoted 30 lines · Guo Ren
Quoted 13 lines · Ben Hutchings
Quoted 12 lines
The recipe for
vdso_installinarch/riscv/Makefileinvokes targets of the same name inarch/riscv/kernel/vdsoand .../compat_vdso, but the target in the latter is calledcompat_vdso_install. Change the recipe to use the right target name.Fixes 0715372a06ce ("riscv: compat: vdso: Add COMPAT_VDSO base code ...")Signed-off-by Ben Hutchings <[email protected]>--- arch/riscv/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 11 lines
arch/riscv/Makefile PHONY += vdso_install · line 113
Quoted 10 lines
arch/riscv/Makefile +1
-1@@ -110,7 +110,7 @@ PHONY += vdso_install vdso_install: $(Q)$(MAKE) $(build)=arch/riscv/kernel/vdso $@ $(if $(CONFIG_COMPAT),$(Q)$(MAKE) \ - $(build)=arch/riscv/kernel/compat_vdso $@) + $(build)=arch/riscv/kernel/compat_vdso compat_vdso_install)Good catch, but what's the problem you've met?
It broke the Debian package build
<https://buildd.debian.org/status/fetch.php?pkg=linux&arch=riscv64&ver=5.19%7Erc6-1%7Eexp1&stamp=1657777338&raw=0>:Quoted 6 lines
[...]
/usr/bin/make[...] -C debian/build/build_riscv64_none_riscv64vdso_installINSTALL_MOD_PATH='/<<PKGBUILDDIR>>'/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug
make[3]: Entering directory '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
[...]/usr/bin/make-f /<<PKGBUILDDIR>>/scripts/Makefile.build obj=arch/riscv/kernel/vdsovdso_install
[...]
gcc-11 -Wp,-MMD,arch/riscv/kernel/vdso/.vgettimeofday.o.d -nostdinc -I/<<PKGBUILDDIR>>/arch/riscv/include -I./arch/riscv/include/generated -I/<<PKGBUILDDIR>>/include -I./include -I/<<PKGBUILDDIR>>/arch/riscv/include/uapi -I./arch/riscv/include/generated/uapi -I/<<PKGBUILDDIR>>/include/uapi -I./include/generated/uapi -include /<<PKGBUILDDIR>>/include/linux/compiler-version.h -include /<<PKGBUILDDIR>>/include/linux/kconfig.h -include /<<PKGBUILDDIR>>/include/linux/compiler_types.h -D__KERNEL__ -DCC_USING_PATCHABLE_FUNCTION_ENTRY -fmacro-prefix-map=/<<PKGBUILDDIR>>/= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu11 -mabi=lp64 -march=rv64imac_zicsr_zifencei -mno-save-restore -DCONFIG_PAGE_OFFSET=0xff60000000000000 -mcmodel=medany -fno-omit-frame-pointer -mstrict-align -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=2048 -fstack-protector-strong -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-stack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -g -fdebug-prefix-map=/<<PKGBUILDDIR>>/= -fno-stack-protector -fPIC -include /<<PKGBUILDDIR>>/lib/vdso/gettimeofday.c -I /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso -I
./arch/riscv/kernel/vdso-DKBUILD_MODFILE='"arch/riscv/kernel/vdso/vgettimeofday"' -DKBUILD_BASENAME='"vgettimeofday"' -DKBUILD_MODNAME='"vgettimeofday
"' -D__KBUILD_MODNAME=kmod_vgettimeofday -c -oarch/riscv/kernel/vdso/vgettimeofday.o/<<PKGBUILDDIR>>/arch/riscv/kernel/vdso/vgettimeofday.cQuoted 3 lines
[...]
/<<PKGBUILDDIR>>/scripts/check-local-exportarch/riscv/kernel/vdso/vgettimeofday.o
if nmarch/riscv/kernel/vdso/vgettimeofday.o2>/dev/null | grep -q__ksymtab; then gcc-11 -E -D__GENKSYMS__ -Wp,-MMD,arch/riscv/kernel/vdso/.vgettimeofday.o.d -nostdinc -I/<<PKGBUILDDIR>>/arch/riscv/include -I./arch/riscv/include/generated -I/<<PKGBUILDDIR>>/include -I./include -I/<<PKGBUILDDIR>>/arch/riscv/include/uapi -I./arch/riscv/include/generated/uapi -I/<<PKGBUILDDIR>>/include/uapi -I./include/generated/uapi -include /<<PKGBUILDDIR>>/include/linux/compiler-version.h -include /<<PKGBUILDDIR>>/include/linux/kconfig.h -include /<<PKGBUILDDIR>>/include/linux/compiler_types.h -D__KERNEL__ -DCC_USING_PATCHABLE_FUNCTION_ENTRY -fmacro-prefix-map=/<<PKGBUILDDIR>>/= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu11 -mabi=lp64 -march=rv64imac_zicsr_zifencei -mno-save-restore -DCONFIG_PAGE_OFFSET=0xff60000000000000-mcmodel=medany -fno-omit-frame-pointer -mstrict-align -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=2048 -fstack-protector-strong -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-stack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -g -fdebug-prefix-map=/<<PKGBUILDDIR>>/= -fno-stack-protector -fPIC -include /<<PKGBUILDDIR>>/lib/vdso/gettimeofday.c -I /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso -I
./arch/riscv/kernel/vdso-DKBUILD_MODFILE='"arch/r
iscv/kernel/vdso/vgettimeofday"' -DKBUILD_BASENAME='"vgettimeofday"' -DKBUILD_MODNAME='"vgettimeofday"' -D__KBUILD_MODNAME=kmod_vgettimeofday /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso/vgettimeofday.c |scripts/genksyms/genksyms-r/dev/null>>arch/riscv/kernel/vdso/.vgettimeofday.o.cmd; fiQuoted 21 lines
ld -melf64lriscv -shared -S -soname=linux-vdso.so.1 --build-id=sha1 --hash-style=both --eh-frame-hdr -T
arch/riscv/kernel/vdso/vdso.ldsarch/riscv/kernel/vdso/rt_sigreturn.oarch/riscv/kernel/vdso/vgettimeofday.oarch/riscv/kernel/vdso/getcpu.oarch/riscv/kernel/vdso/flush_icache.oarch/riscv/kernel/vdso/note.o-oarch/riscv/kernel/vdso/vdso.so.dbg.tmp&& objcopy -G__vdso_rt_sigreturn-G__vdso_vgettimeofday-G__vdso_getcpu-G__vdso_flush_icachearch/riscv/kernel/vdso/vdso.so.dbg.tmparch/riscv/kernel/vdso/vdso.so.dbg&& rmarch/riscv/kernel/vdso/vdso.so.dbg.tmpcparch/riscv/kernel/vdso/vdso.so.dbg/<<PKGBUILDDIR>>/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug/lib/modules/5.19.0-rc6-riscv64/vdso/vdso.so
:/usr/bin/make-f /<<PKGBUILDDIR>>/scripts/Makefile.build obj=arch/riscv/kernel/compat_vdsovdso_install
[...]
make[4]: *** No rule to make target 'vdso_install'. Stop.
make[3]: *** [/<<PKGBUILDDIR>>/arch/riscv/Makefile:112:vdso_install] Error 2
make[3]: Leaving directory '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
make[2]: *** [debian/rules.real:513: install-image-dbg_riscv64_none_riscv64] Error 2
make[2]: *** Waiting for unfinished jobs....Ben.
Quoted 7 lines
arch/riscv/Makefile PHONY += vdso_install · line 116
Quoted 4 lines
arch/riscv/Makefile +0
-0ifeq ($(KBUILD_EXTMOD),) ifeq ($(CONFIG_MMU),y)Quoted 3 lines
--
Ben Hutchings
This sentence contradicts itself - no actually it doesn't.
Quoted 8 lines
--
Best Regards
Guo Ren_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Sorry, I missed your patch. You are the first person to catch that.
+ $(build)=arch/riscv/kernel/compat_vdso compat_$@)
The above is also good for me.
For that one, Could you add "Fixes: 0715372a06ce ("riscv: compat:
vdso: Add COMPAT_VDSO base code ...")" in your next version of the patch from Ben's and add "Ben Hutchings as Co-developed-by:"?
Quoted 101 lines · Emil Renner Berthing
Quoted 12 lines · Guo Ren
I'm just curious who is using
vdso_install, thx. Would you mind put below into the commit log?It broke the Debian package build
/usr/bin/make[...] -C debian/build/build_riscv64_none_riscv64vdso_installINSTALL_MOD_PATH='/<<PKGBUILDDIR>>'/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug make[3]: Entering directory
'/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
[...]
make[4]: *** No rule to make target 'vdso_install'. Stop.Quoted 1 line
Reviewed-by Guo Ren <[email protected]>I don't mind which version goes in, but just for reference there is already this patch on the mailing list:
https://lore.kernel.org/linux-riscv/[email protected]//Emil
Quoted 79 lines · Ben Hutchings
Quoted 30 lines · Guo Ren
Quoted 13 lines · Ben Hutchings
Quoted 12 lines
The recipe for
vdso_installinarch/riscv/Makefileinvokes targets of the same name inarch/riscv/kernel/vdsoand .../compat_vdso, but the target in the latter is calledcompat_vdso_install. Change the recipe to use the right target name.Fixes 0715372a06ce ("riscv: compat: vdso: Add COMPAT_VDSO base code ...")Signed-off-by Ben Hutchings <[email protected]>--- arch/riscv/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)Quoted 11 lines
arch/riscv/Makefile PHONY += vdso_install · line 113
Quoted 10 lines
arch/riscv/Makefile +1
-1@@ -110,7 +110,7 @@ PHONY += vdso_install vdso_install: $(Q)$(MAKE) $(build)=arch/riscv/kernel/vdso $@ $(if $(CONFIG_COMPAT),$(Q)$(MAKE) \ - $(build)=arch/riscv/kernel/compat_vdso $@) + $(build)=arch/riscv/kernel/compat_vdso compat_vdso_install)Good catch, but what's the problem you've met?
It broke the Debian package build
<https://buildd.debian.org/status/fetch.php?pkg=linux&arch=riscv64&ver=5.19%7Erc6-1%7Eexp1&stamp=1657777338&raw=0>:Quoted 6 lines
[...]
/usr/bin/make[...] -C debian/build/build_riscv64_none_riscv64vdso_installINSTALL_MOD_PATH='/<<PKGBUILDDIR>>'/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug
make[3]: Entering directory '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
[...]/usr/bin/make-f /<<PKGBUILDDIR>>/scripts/Makefile.build obj=arch/riscv/kernel/vdsovdso_install
[...]
gcc-11 -Wp,-MMD,arch/riscv/kernel/vdso/.vgettimeofday.o.d -nostdinc -I/<<PKGBUILDDIR>>/arch/riscv/include -I./arch/riscv/include/generated -I/<<PKGBUILDDIR>>/include -I./include -I/<<PKGBUILDDIR>>/arch/riscv/include/uapi -I./arch/riscv/include/generated/uapi -I/<<PKGBUILDDIR>>/include/uapi -I./include/generated/uapi -include /<<PKGBUILDDIR>>/include/linux/compiler-version.h -include /<<PKGBUILDDIR>>/include/linux/kconfig.h -include /<<PKGBUILDDIR>>/include/linux/compiler_types.h -D__KERNEL__ -DCC_USING_PATCHABLE_FUNCTION_ENTRY -fmacro-prefix-map=/<<PKGBUILDDIR>>/= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu11 -mabi=lp64 -march=rv64imac_zicsr_zifencei -mno-save-restore -DCONFIG_PAGE_OFFSET=0xff60000000000000 -mcmodel=medany -fno-omit-frame-pointer -mstrict-align -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=2048 -fstack-protector-strong -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-stack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -g -fdebug-prefix-map=/<<PKGBUILDDIR>>/= -fno-stack-protector -fPIC -include /<<PKGBUILDDIR>>/lib/vdso/gettimeofday.c -I /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso -I
./arch/riscv/kernel/vdso-DKBUILD_MODFILE='"arch/riscv/kernel/vdso/vgettimeofday"' -DKBUILD_BASENAME='"vgettimeofday"' -DKBUILD_MODNAME='"vgettimeofday
"' -D__KBUILD_MODNAME=kmod_vgettimeofday -c -oarch/riscv/kernel/vdso/vgettimeofday.o/<<PKGBUILDDIR>>/arch/riscv/kernel/vdso/vgettimeofday.cQuoted 3 lines
[...]
/<<PKGBUILDDIR>>/scripts/check-local-exportarch/riscv/kernel/vdso/vgettimeofday.o
if nmarch/riscv/kernel/vdso/vgettimeofday.o2>/dev/null | grep -q__ksymtab; then gcc-11 -E -D__GENKSYMS__ -Wp,-MMD,arch/riscv/kernel/vdso/.vgettimeofday.o.d -nostdinc -I/<<PKGBUILDDIR>>/arch/riscv/include -I./arch/riscv/include/generated -I/<<PKGBUILDDIR>>/include -I./include -I/<<PKGBUILDDIR>>/arch/riscv/include/uapi -I./arch/riscv/include/generated/uapi -I/<<PKGBUILDDIR>>/include/uapi -I./include/generated/uapi -include /<<PKGBUILDDIR>>/include/linux/compiler-version.h -include /<<PKGBUILDDIR>>/include/linux/kconfig.h -include /<<PKGBUILDDIR>>/include/linux/compiler_types.h -D__KERNEL__ -DCC_USING_PATCHABLE_FUNCTION_ENTRY -fmacro-prefix-map=/<<PKGBUILDDIR>>/= -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs -fno-strict-aliasing -fno-common -fshort-wchar -fno-PIE -Werror=implicit-function-declaration -Werror=implicit-int -Werror=return-type -Wno-format-security -std=gnu11 -mabi=lp64 -march=rv64imac_zicsr_zifencei -mno-save-restore -DCONFIG_PAGE_OFFSET=0xff60000000000000-mcmodel=medany -fno-omit-frame-pointer -mstrict-align -fno-delete-null-pointer-checks -Wno-frame-address -Wno-format-truncation -Wno-format-overflow -Wno-address-of-packed-member -O2 -fno-allow-store-data-races -Wframe-larger-than=2048 -fstack-protector-strong -Wimplicit-fallthrough=5 -Wno-main -Wno-unused-but-set-variable -Wno-unused-const-variable -fno-omit-frame-pointer -fno-optimize-sibling-calls -fno-stack-clash-protection -Wdeclaration-after-statement -Wvla -Wno-pointer-sign -Wcast-function-type -Wno-stringop-truncation -Wno-stringop-overflow -Wno-restrict -Wno-maybe-uninitialized -Wno-alloc-size-larger-than -fno-strict-overflow -fno-stack-check -fconserve-stack -Werror=date-time -Werror=incompatible-pointer-types -Werror=designated-init -Wno-packed-not-aligned -g -fdebug-prefix-map=/<<PKGBUILDDIR>>/= -fno-stack-protector -fPIC -include /<<PKGBUILDDIR>>/lib/vdso/gettimeofday.c -I /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso -I
./arch/riscv/kernel/vdso-DKBUILD_MODFILE='"arch/r
iscv/kernel/vdso/vgettimeofday"' -DKBUILD_BASENAME='"vgettimeofday"' -DKBUILD_MODNAME='"vgettimeofday"' -D__KBUILD_MODNAME=kmod_vgettimeofday /<<PKGBUILDDIR>>/arch/riscv/kernel/vdso/vgettimeofday.c |scripts/genksyms/genksyms-r/dev/null>>arch/riscv/kernel/vdso/.vgettimeofday.o.cmd; fiQuoted 21 lines
ld -melf64lriscv -shared -S -soname=linux-vdso.so.1 --build-id=sha1 --hash-style=both --eh-frame-hdr -T
arch/riscv/kernel/vdso/vdso.ldsarch/riscv/kernel/vdso/rt_sigreturn.oarch/riscv/kernel/vdso/vgettimeofday.oarch/riscv/kernel/vdso/getcpu.oarch/riscv/kernel/vdso/flush_icache.oarch/riscv/kernel/vdso/note.o-oarch/riscv/kernel/vdso/vdso.so.dbg.tmp&& objcopy -G__vdso_rt_sigreturn-G__vdso_vgettimeofday-G__vdso_getcpu-G__vdso_flush_icachearch/riscv/kernel/vdso/vdso.so.dbg.tmparch/riscv/kernel/vdso/vdso.so.dbg&& rmarch/riscv/kernel/vdso/vdso.so.dbg.tmpcparch/riscv/kernel/vdso/vdso.so.dbg/<<PKGBUILDDIR>>/debian/linux-image-5.19.0-rc6-riscv64-dbg/usr/lib/debug/lib/modules/5.19.0-rc6-riscv64/vdso/vdso.so
:/usr/bin/make-f /<<PKGBUILDDIR>>/scripts/Makefile.build obj=arch/riscv/kernel/compat_vdsovdso_install
[...]
make[4]: *** No rule to make target 'vdso_install'. Stop.
make[3]: *** [/<<PKGBUILDDIR>>/arch/riscv/Makefile:112:vdso_install] Error 2
make[3]: Leaving directory '/<<PKGBUILDDIR>>/debian/build/build_riscv64_none_riscv64'
make[2]: *** [debian/rules.real:513: install-image-dbg_riscv64_none_riscv64] Error 2
make[2]: *** Waiting for unfinished jobs....Ben.
Quoted 7 lines
arch/riscv/Makefile PHONY += vdso_install · line 116
Quoted 4 lines
arch/riscv/Makefile +0
-0ifeq ($(KBUILD_EXTMOD),) ifeq ($(CONFIG_MMU),y)Quoted 3 lines
--
Ben Hutchings
This sentence contradicts itself - no actually it doesn't.--
Best Regards
Guo Ren_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Signature · 7 lines
Best Regards Guo Ren _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 4 lines · Guo Ren
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Sorry, I missed your patch. You are the first person to catch that.
Quoted 9 lines
+ $(build)=arch/riscv/kernel/compat_vdso compat_$@)
The above is also good for me.
For that one, Could you add "Fixes:
0715372a06ce("riscv: compat:
vdso: AddCOMPAT_VDSObase code ...")" in your next version of the patch from Ben's and add "Ben Hutchings as Co-developed-by:"?
Why would Ben get a Co-developed-by?
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 10 lines · On Tue, Jul 19, 2022 at 6:29 PM <[email protected]> wrote:
Quoted 8 lines · Guo Ren
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Sorry, I missed your patch. You are the first person to catch that.
+ $(build)=arch/riscv/kernel/compat_vdso compat_$@)
The above is also good for me.
Quoted 7 lines
Quoted 5 lines
For that one, Could you add "Fixes:
0715372a06ce("riscv: compat:
vdso: AddCOMPAT_VDSObase code ...")" in your next version of the patch from Ben's and add "Ben Hutchings as Co-developed-by:"?Why would Ben get a Co-developed-by?
Just a suggestion to "Emil Renner Berthing".
My reason is:
1. I think the "Fixes:" is also necessary, and Emil could directly use it from Ben's patch.
2. He also found that problem and shared the information with us. The key effect is to make Emil's patch quickly reviewed (Although I missed that patch).
Signature · 7 lines
Best Regards Guo Ren _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 19 lines · Guo Ren
Quoted 10 lines · On Tue, Jul 19, 2022 at 6:29 PM <[email protected]> wrote:
Quoted 8 lines · Guo Ren
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Sorry, I missed your patch. You are the first person to catch that.
+ $(build)=arch/riscv/kernel/compat_vdso compat_$@)
The above is also good for me.
Quoted 7 lines
Quoted 5 lines
For that one, Could you add "Fixes:
0715372a06ce("riscv: compat:
vdso: AddCOMPAT_VDSObase code ...")" in your next version of the patch from Ben's and add "Ben Hutchings as Co-developed-by:"?Why would Ben get a Co-developed-by?
Quoted 8 lines
Just a suggestion to "Emil Renner Berthing".
My reason is:
1. I think the "Fixes:" is also necessary, and Emil could directly use it from Ben's patch.
2. He also found that problem and shared the information with us. The key effect is to make Emil's patch quickly reviewed (Although I missed that patch).
Tbh, I don't think either of those would result in a Co-developed-by.
Thanks,
Conor.
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 19 lines · Guo Ren
Quoted 10 lines · On Tue, Jul 19, 2022 at 6:29 PM <[email protected]> wrote:
Quoted 8 lines · Guo Ren
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Sorry, I missed your patch. You are the first person to catch that.
+ $(build)=arch/riscv/kernel/compat_vdso compat_$@)
The above is also good for me.
Quoted 7 lines
Quoted 5 lines
For that one, Could you add "Fixes:
0715372a06ce("riscv: compat:
vdso: AddCOMPAT_VDSObase code ...")" in your next version of the patch from Ben's and add "Ben Hutchings as Co-developed-by:"?Why would Ben get a Co-developed-by?
Quoted 8 lines
Just a suggestion to "Emil Renner Berthing".
My reason is:
1. I think the "Fixes:" is also necessary, and Emil could directly use it from Ben's patch.
2. He also found that problem and shared the information with us. The key effect is to make Emil's patch quickly reviewed (Although I missed that patch).
Please just let's get this applied. I don't need credit for a trivial fix or commit id.
Ben.
Signature · 6 lines
Sent from my Android device with K-9 Mail. Please excuse my brevity. _______________________________________________ linux-riscv mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-riscv
Quoted 22 lines · Ben Hutchings
Quoted 21 lines · Guo Ren
Quoted 10 lines · On Tue, Jul 19, 2022 at 6:29 PM <[email protected]> wrote:
Quoted 8 lines · Guo Ren
EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
Sorry, I missed your patch. You are the first person to catch that.
+ $(build)=arch/riscv/kernel/compat_vdso compat_$@)
The above is also good for me.
Quoted 7 lines
Quoted 5 lines
For that one, Could you add "Fixes:
0715372a06ce("riscv: compat:
vdso: AddCOMPAT_VDSObase code ...")" in your next version of the patch from Ben's and add "Ben Hutchings as Co-developed-by:"?Why would Ben get a Co-developed-by?
Just a suggestion to "Emil Renner Berthing".
Quoted 8 lines
Quoted 6 lines
My reason is:
1. I think the "Fixes:" is also necessary, and Emil could directly use it from Ben's patch.
2. He also found that problem and shared the information with us. The key effect is to make Emil's patch quickly reviewed (Although I missed that patch).Please just let's get this applied.
That's always the goal :)
Quoted 1 line
I don't need credit for a trivial fix or commit id.
I was more curious as to whether Guo knew something I didn't!
_______________________________________________
linux-riscv mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/linux-riscv