Skip to contentSkip to conversation

backport: need reinit_completion() for kernel before v3.13

PATCH In review Arend van Spriel 2 participants 5 messages Nov 25, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 backport: need reinit_completion() for kernel before v3.13

The use of INIT_COMPLETION() has been replaced by reinit_completion() in v3.13-rc1. This patch backports that inline function.

---
 backport/backport-include/linux/completion.h |   29 ++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 backport/backport-include/linux/completion.h
backport/backport-include/linux/completion.h new file +29 -0
new file mode 100644
index 0000000..ed30d8a
@@ -0,0 +1,29 @@
+#ifndef _BACKPORTS_LINUX_COMPLETION_H
+#define _BACKPORTS_LINUX_COMPLETION_H
+#include_next <linux/completion.h>
+#include <linux/version.h>
+
+#if (LINUX_VERSION_CODE < KERNEL_VERSION(3,13,0))
+/**
+ * backport of:
+ *
+ * commit c32f74ab2872994bc8336ed367313da3139350ca
+ * Author: Wolfram Sang <[email protected]>
+ * Date:   Thu Nov 14 14:32:01 2013 -0800
+ *
+ *   sched: replace INIT_COMPLETION with reinit_completion
+ */
+/**
+ * reinit_completion - reinitialize a completion structure
+ * @x:  pointer to completion structure that is to be reinitialized
+ *
+ * This inline function should be used to reinitialize a completion structure so it can
+ * be reused. This is especially important after complete_all() is used.
+ */
+static inline void reinit_completion(struct completion *x)
+{
+	x->done = 0;
+}
+#endif
+
+#endif /* _BACKPORTS_LINUX_COMPLETION_H */
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 10 lines · Arend van Spriel

The use of INIT_COMPLETION() has been replaced by reinit_completion() in v3.13-rc1. This patch backports that inline function.

---
 backport/backport-include/linux/completion.h |   29 ++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 backport/backport-include/linux/completion.h

This was already added in this commit:
https://github.com/hauke/backports/commit/d9cb7a967513482c399d44e390429cea3de1d86d

You should use backports for this repository:
https://github.com/hauke/backports.git

Hauke

#2 lore raw
Quoted 12 lines · Hauke Mehrtens
Quoted 10 lines · Arend van Spriel

The use of INIT_COMPLETION() has been replaced by reinit_completion() in v3.13-rc1. This patch backports that inline function.

---
  backport/backport-include/linux/completion.h |   29 ++++++++++++++++++++++++++
  1 file changed, 29 insertions(+)

create mode 100644 backport/backport-include/linux/completion.h

Quoted 5 lines

This was already added in this commit:
https://github.com/hauke/backports/commit/d9cb7a967513482c399d44e390429cea3de1d86d

You should use backports for this repository:
https://github.com/hauke/backports.git

Ok. With my fingers crossed: Did you also solve the whole genl patch series that Johannes did in net-next?

Gr. AvS

Quoted 6 lines

Hauke
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html

#3 lore raw
Quoted 18 lines · Arend van Spriel
Quoted 17 lines · Hauke Mehrtens
Quoted 11 lines · Arend van Spriel

The use of INIT_COMPLETION() has been replaced by reinit_completion() in v3.13-rc1. This patch backports that inline function.

---
  backport/backport-include/linux/completion.h |   29
++++++++++++++++++++++++++
  1 file changed, 29 insertions(+)

create mode 100644 backport/backport-include/linux/completion.h

This was already added in this commit:
https://github.com/hauke/backports/commit/d9cb7a967513482c399d44e390429cea3de1d86d

Quoted 7 lines
Quoted 2 lines

You should use backports for this repository:
https://github.com/hauke/backports.git

Ok. With my fingers crossed: Did you also solve the whole genl patch series that Johannes did in net-next?

Gr. AvS

Yes, Johannes solved that already. It works with current linux-next and 3.13-rc1.

Hauke

#4 lore raw
Quoted 22 lines · Hauke Mehrtens
Quoted 21 lines · Arend van Spriel
Quoted 19 lines · Hauke Mehrtens
Quoted 11 lines · Arend van Spriel

The use of INIT_COMPLETION() has been replaced by reinit_completion() in v3.13-rc1. This patch backports that inline function.

---
   backport/backport-include/linux/completion.h |   29
++++++++++++++++++++++++++
   1 file changed, 29 insertions(+)

create mode 100644 backport/backport-include/linux/completion.h

This was already added in this commit:
https://github.com/hauke/backports/commit/d9cb7a967513482c399d44e390429cea3de1d86d

You should use backports for this repository:
https://github.com/hauke/backports.git

Quoted 7 lines
Quoted 4 lines

Ok. With my fingers crossed: Did you also solve the whole genl patch series that Johannes did in net-next?

Gr. AvS

Yes, Johannes solved that already. It works with current linux-next and 3.13-rc1.

I recently started using backports so I can run brcm80211 drivers on our testrigs that have a fixed kernel version on FC19, FC15, and even FC11. I guess I should go an subscribe on backports mailing list to keep taps on it. Thanks.

Gr. AvS