rtc: pxa: drop usage of CLOCK_TICK_RATE
PATCH 1/1 rtc: pxa: drop usage of CLOCK_TICK_RATE
The symbol CLOCK_TICK_RATE is (at least on ARM) defined in an platform specific header <mach/timex.h>. There are plans to stop using and kill these platform specific headers. So fix the only user of pxa's <mach/timex.h> to not use it.
---
It would be nice to use the clk API to find the tick rate, but I didn't find any clk to use.
--- drivers/rtc/rtc-pxa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rtc/rtc-pxa.c +1 -1
@@ -32,7 +32,7 @@#include <mach/hardware.h> -#define TIMER_FREQ CLOCK_TICK_RATE +#define TIMER_FREQ get_clock_tick_rate()#define RTC_DEF_DIVIDER (32768 - 1)#define RTC_DEF_TRIM 0#define MAXFREQ_PERIODIC 1000
Signature · 1 line
1.7.10.4
PATCH 1/1 rtc: pxa: drop usage of CLOCK_TICK_RATE
Quoted 27 lines · Uwe Kleine-K?nig
The symbol
CLOCK_TICK_RATEis (at least on ARM) defined in an platform specific header <mach/timex.h>. There are plans to stop using and kill these platform specific headers. So fix the only user of pxa's <mach/timex.h> to not use it.Signed-off-by Uwe Kleine-K?nig <[email protected]>---
It would be nice to use the clk API to find the tick rate, but I didn't find any clk to use.--- drivers/rtc/rtc-pxa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/rtc/rtc-pxa.c +1
-2@@ -32,7 +32,7 @@#include <mach/hardware.h> -#define TIMER_FREQ CLOCK_TICK_RATE +#define TIMER_FREQ get_clock_tick_rate()#define RTC_DEF_DIVIDER (32768 - 1)#define RTC_DEF_TRIM 0#define MAXFREQ_PERIODIC 1000 --
Quoted 2 lines
1.7.10.4
PATCH 1/1 rtc: pxa: drop usage of CLOCK_TICK_RATE
In reply to Uwe Kleine-KönigHello,
[Cc: += akpm]
Quoted 6 lines · Uwe Kleine-K?nig
The symbol
CLOCK_TICK_RATEis (at least on ARM) defined in an platform specific header <mach/timex.h>. There are plans to stop using and kill these platform specific headers. So fix the only user of pxa's <mach/timex.h> to not use it.Signed-off-by Uwe Kleine-K?nig <[email protected]>
Who is looking for this patch?
Best regards
Uwe
Quoted 28 lines
---
It would be nice to use the clk API to find the tick rate, but I didn't find any clk to use.--- drivers/rtc/rtc-pxa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/rtc/rtc-pxa.c +1
-1@@ -32,7 +32,7 @@#include <mach/hardware.h> -#define TIMER_FREQ CLOCK_TICK_RATE +#define TIMER_FREQ get_clock_tick_rate()#define RTC_DEF_DIVIDER (32768 - 1)#define RTC_DEF_TRIM 0#define MAXFREQ_PERIODIC 1000Signature · 7 lines
1.7.10.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel at lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 2 lines
Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | http://www.pengutronix.de/ |
PATCH 1/1 rtc: pxa: drop usage of CLOCK_TICK_RATE
Quoted 40 lines · Uwe Kleine-K?nig
Hello,
[Cc: += akpm]
Quoted 6 lines · Uwe Kleine-K?nig
The symbol
CLOCK_TICK_RATEis (at least on ARM) defined in an platform specific header <mach/timex.h>. There are plans to stop using and kill these platform specific headers. So fix the only user of pxa's <mach/timex.h> to not use it.Signed-off-by Uwe Kleine-K?nig <[email protected]>Who is looking for this patch?
Best regards
UweQuoted 24 lines
---
It would be nice to use the clk API to find the tick rate, but I didn't find any clk to use.--- drivers/rtc/rtc-pxa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/rtc/rtc-pxa.c +1
-2@@ -32,7 +32,7 @@#include <mach/hardware.h> -#define TIMER_FREQ CLOCK_TICK_RATE +#define TIMER_FREQ get_clock_tick_rate()#define RTC_DEF_DIVIDER (32768 - 1)#define RTC_DEF_TRIM 0#define MAXFREQ_PERIODIC 1000 --1.7.10.4
Quoted 5 lines
Quoted 4 lines
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
I think that Alessandro could help to merge.
Alessandro,
Is it right?
Regards
Haojian
PATCH 1/1 rtc: pxa: drop usage of CLOCK_TICK_RATE
Quoted 9 lines · Haojian Zhuang
Quoted 8 lines · Uwe Kleine-K?nig
Hello,
[Cc: += akpm]
Quoted 3 lines · Uwe Kleine-K?nig
The symbol
CLOCK_TICK_RATEis (at least on ARM) defined in an platform specific header <mach/timex.h>. There are plans to stop using and kill these platform specific headers. So fix the only user of pxa's
n>>> <mach/timex.h> to not use it.
Quoted 4 lines
Quoted 4 lines
Quoted 2 lines
Signed-off-by Uwe Kleine-K?nig <[email protected]>Who is looking for this patch?
Quoted 8 lines
Quoted 2 lines
Best regards
UweAcked-by Haojian Zhuang <[email protected]>I think that Alessandro could help to merge.
Alessandro,
Is it right?
Why won't you just remove TIMER_FREQ all together instead ?
I don't remember why I put that in, but looking back at it, I don't find any use, so why don't we remove the line ?
Cheers.
--
Robert
PATCH v2 1/1 rtc: pxa: drop unused #define TIMER_FREQ
It seems this symbol was unused since the driver was introduced in commit dc94436 (rtc: driver for pxa27x and pxa3xx SoC) back in 2009.
As a by-product this patch makes the driver stop "using" the symbol CLOCK_TICK_RATE which is about to be removed very soon (for ARM).
---
Changes since (implicit) v1, sent with Message-id:1383942318-12569-1-git-send-email-u.kleine-koenig at pengutronix.de:
- drop define instead of s/CLOCK_TICK_RATE/get_clock_tick_rate()/; thanks to Robert Jarzmik for pointing that out.
Note I intend to send this patch as part of a series that removes <mach/timex.h> (and so CLOCK_TICK_RATE) on ARM. So dear maintainer please don't take this patch but give your blessing that I can take it. (Note, I'm not sure who's ack I need here; according to MAINTAINERS Alessandro Zummo maintains the rtc subsystem, but he doesn't seem to be that active for some time and it's mostly akpm who takes patches.)
drivers/rtc/rtc-pxa.c | 1 - 1 file changed, 1 deletion(-)
drivers/rtc/rtc-pxa.c +0 -1
@@ -32,7 +32,6 @@#include <mach/hardware.h> -#define TIMER_FREQ CLOCK_TICK_RATE#define RTC_DEF_DIVIDER (32768 - 1)#define RTC_DEF_TRIM 0#define MAXFREQ_PERIODIC 1000
Signature · 1 line
1.8.4.3
PATCH v2 1/1 rtc: pxa: drop unused #define TIMER_FREQ
Quoted 14 lines · Uwe Kleine-K?nig
It seems this symbol was unused since the driver was introduced in commit dc94436 (rtc: driver for pxa27x and pxa3xx SoC) back in 2009.
As a by-product this patch makes the driver stop "using" the symbol
CLOCK_TICK_RATEwhich is about to be removed very soon (for ARM).Signed-off-by Uwe Kleine-K?nig <[email protected]>---
Changes since (implicit) v1, sent with Message-id:1383942318-12569-1-git-send-email-u.kleine-koenig at pengutronix.de:- drop define instead of s/CLOCK_TICK_RATE/get_clock_tick_rate()/; thanks to Robert Jarzmik for pointing that out.
Quoted 6 lines
Note I intend to send this patch as part of a series that removes <
mach/timex.h> (and soCLOCK_TICK_RATE) on ARM. So dear maintainer please don't take this patch but give your blessing that I can take it. (Note, I'm not sure who's ack I need here; according toMAINTAINERSAlessandro Zummo maintains the rtc subsystem, but he doesn't seem to be that active for some time and it's mostly akpm who takes patches.)
And you're right, Andrew took the last patches to RTC.
Cheers.
--
Robert