Skip to contentSkip to conversation

ARM: DT: imx6qdl: fix can clocks

PATCH New Markus Niebel 2 participants 3 messages Nov 27, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: DT: imx6qdl: fix can clocks

From: Markus Niebel <[email protected]>

per and ipg clock numbers are exchanged. This leads to wrong bitrate calculation.

---
 arch/arm/boot/dts/imx6qdl.dtsi |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6qdl.dtsi +2 -2
index 59154dc..797f007 100644
@@ -329,7 +329,7 @@
 				compatible = "fsl,imx6q-flexcan";
 				reg = <0x02090000 0x4000>;
 				interrupts = <0 110 0x04>;
-				clocks = <&clks 108>, <&clks 109>;
+				clocks = <&clks 109>, <&clks 108>;
 				clock-names = "ipg", "per";
 			};
 
@@ -337,7 +337,7 @@
 				compatible = "fsl,imx6q-flexcan";
 				reg = <0x02094000 0x4000>;
 				interrupts = <0 111 0x04>;
-				clocks = <&clks 110>, <&clks 111>;
+				clocks = <&clks 111>, <&clks 110>;
 				clock-names = "ipg", "per";
 			};
 
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: DT: imx6qdl: fix can clocks

Am Mittwoch, den 27.11.2013, 14:14 +0100 schrieb Markus Niebel:

Quoted 5 lines

From: Markus Niebel <[email protected]>

per and ipg clock numbers are exchanged. This leads to wrong bitrate calculation.

NACK

According to the clock driver clock numbers are IPG->PER. I think this is the same problem we encountered on i.MX5 and is fixed with commit "can: flexcan: use correct clock as base for bit rate calculation"

Quoted 27 lines
---
 arch/arm/boot/dts/imx6qdl.dtsi |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6qdl.dtsi +2 -2
index 59154dc..797f007 100644
@@ -329,7 +329,7 @@
 				compatible = "fsl,imx6q-flexcan";
 				reg = <0x02090000 0x4000>;
 				interrupts = <0 110 0x04>;
-				clocks = <&clks 108>, <&clks 109>;
+				clocks = <&clks 109>, <&clks 108>;
 				clock-names = "ipg", "per";
 			};
 
@@ -337,7 +337,7 @@
 				compatible = "fsl,imx6q-flexcan";
 				reg = <0x02094000 0x4000>;
 				interrupts = <0 111 0x04>;
-				clocks = <&clks 110>, <&clks 111>;
+				clocks = <&clks 111>, <&clks 110>;
 				clock-names = "ipg", "per";
 			};
 
Signature · 4 lines
Pengutronix e.K.                           | Lucas Stach                 |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-5076 |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
#2 lore raw

PATCH 1/1 ARM: DT: imx6qdl: fix can clocks

Am 27.11.2013 14:08, wrote Lucas Stach:

Quoted 6 lines

Am Mittwoch, den 27.11.2013, 14:14 +0100 schrieb Markus Niebel:

Quoted 5 lines

From: Markus Niebel <[email protected]>

per and ipg clock numbers are exchanged. This leads to wrong bitrate calculation.

Quoted 7 lines

NACK

According to the clock driver clock numbers are IPG->PER. I think this is the same problem we encountered on i.MX5 and is fixed with commit "can: flexcan: use correct clock as base for bit rate calculation"

Sorry for the noise, was not aware of this patch. You are right.

Quoted 28 lines
Quoted 27 lines
---
 arch/arm/boot/dts/imx6qdl.dtsi |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/imx6qdl.dtsi +2 -2
index 59154dc..797f007 100644
@@ -329,7 +329,7 @@
 				compatible = "fsl,imx6q-flexcan";
 				reg = <0x02090000 0x4000>;
 				interrupts = <0 110 0x04>;
-				clocks = <&clks 108>, <&clks 109>;
+				clocks = <&clks 109>, <&clks 108>;
 				clock-names = "ipg", "per";
 			};
 
@@ -337,7 +337,7 @@
 				compatible = "fsl,imx6q-flexcan";
 				reg = <0x02094000 0x4000>;
 				interrupts = <0 111 0x04>;
-				clocks = <&clks 110>, <&clks 111>;
+				clocks = <&clks 111>, <&clks 110>;
 				clock-names = "ipg", "per";
 			};