trats: usb: Add usb_cable_connected() function
PATCH 1/1 trats: usb: Add usb_cable_connected() function
Changes:
- define function usb_cable_connected() in trats board file which returns 1 if cable is connected and 0 otherwise
- trats.h: add CONFIG_USB_CHECK_CABLE
--- board/samsung/trats/trats.c | 10 ++++++++++ include/configs/trats.h | 1 + 2 files changed, 11 insertions(+)
board/samsung/trats/trats.c +10 -0
@@ -500,6 +500,16 @@ void board_usb_init(void)debug ("USB_udc_probe\n" ); s3c_udc_probe(&s5pc210_otg_data); } + +#ifdef CONFIG_USB_CABLE_CHECK +int usb_cable_connected (void ) +{ +struct pmic *muic =pmic_get ("MAX8997_MUIC" ); +int cable_connected = muic->chrg->chrg_type (muic); + +return !!cable_connected; +} +#endif #endif static void pmic_reset (void )
include/configs/trats.h +1 -0
@@ -300,6 +300,7 @@#define CONFIG_USB_GADGET_S3C_UDC_OTG #define CONFIG_USB_GADGET_DUALSPEED #define CONFIG_USB_GADGET_VBUS_DRAW 2 +#define CONFIG_USB_CABLE_CHECK /* LCD */ #define CONFIG_EXYNOS_FB
Signature · 1 line
1.7.9.5
PATCH 1/1 trats: usb: Add usb_cable_connected() function
Hello Minkyu,
Quoted 7 lines · Przemyslaw Marczak
Changes:
- define functionusb_cable_connected()in trats board file which returns 1 if cable is connected and 0 otherwise
-trats.h: addCONFIG_USB_CHECK_CABLESigned-off-by Przemyslaw Marczak <[email protected]>Cc Minkyu Kang <[email protected]>
Could you review this patch, please?
Thanks
Signature · 4 lines
Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com
PATCH 1/1 trats: usb: Add usb_cable_connected() function
In reply to Przemyslaw MarczakDear Przemyslaw Marczak,
Quoted 17 lines · Przemyslaw Marczak
Changes:
- define functionusb_cable_connected()in trats board file which returns 1 if cable is connected and 0 otherwise
-trats.h: addCONFIG_USB_CHECK_CABLESigned-off-by Przemyslaw Marczak <[email protected]>Cc Minkyu Kang <[email protected]>--- board/samsung/trats/trats.c | 10 ++++++++++ include/configs/trats.h | 1 + 2 files changed, 11 insertions(+)board/samsung/trats/trats.c +0
-0
board/samsung/trats/trats.c void board_usb_init(void) · line 507
Quoted 8 lines
board/samsung/trats/trats.c +5
-0@@ -500,6 +500,16 @@ void board_usb_init(void)debug ("USB_udc_probe\n" );s3c_udc_probe (&s5pc210_otg_data); } + +#ifdef CONFIG_USB_CABLE_CHECK +int usb_cable_connected (void ) +{ +struct pmic *muic =pmic_get ("MAX8997_MUIC" );
Please check that muic is available.
board/samsung/trats/trats.c void board_usb_init(void) · line 510
Quoted 3 lines
board/samsung/trats/trats.c +3
-0+int cable_connected = muic->chrg->chrg_type (muic); + +return !!cable_connected;
I think, cable_connected is unnecessary.
return !!muic->chrg->chrg_type(muic);
Quoted 11 lines
board/samsung/trats/trats.c +2
-0+} +#endif #endif static void pmic_reset (void )include/configs/trats.h +0
-0
include/configs/trats.h line 306
Quoted 7 lines
include/configs/trats.h +1
-0@@ -300,6 +300,7 @@#define CONFIG_USB_GADGET_S3C_UDC_OTG #define CONFIG_USB_GADGET_DUALSPEED #define CONFIG_USB_GADGET_VBUS_DRAW 2 +#define CONFIG_USB_CABLE_CHECK /* LCD */ #define CONFIG_EXYNOS_FB
Thanks,
Minkyu Kang.
PATCH v2 1/1 trats: usb: Add usb_cable_connected() function
In reply to Przemyslaw MarczakChanges:
- define function usb_cable_connected() in trats board file which returns 1 if cable is connected and 0 otherwise
- trats.h: add CONFIG_USB_CHECK_CABLE
Changes v2:
- add muic avaibility check
--- board/samsung/trats/trats.c | 11 +++++++++++ include/configs/trats.h | 1 + 2 files changed, 12 insertions(+)
board/samsung/trats/trats.c +11 -0
@@ -501,6 +501,17 @@ int board_usb_init(int index, enum usb_init_type init)debug ("USB_udc_probe\n" ); return s3c_udc_probe(&s5pc210_otg_data); } + +#ifdef CONFIG_USB_CABLE_CHECK +int usb_cable_connected (void ) +{ +struct pmic *muic =pmic_get ("MAX8997_MUIC" ); +if (!muic) +return 0 ; + +return !!muic->chrg->chrg_type (muic); +} +#endif #endif static void pmic_reset (void )
include/configs/trats.h +1 -0
@@ -308,6 +308,7 @@#define CONFIG_USB_GADGET_S3C_UDC_OTG #define CONFIG_USB_GADGET_DUALSPEED #define CONFIG_USB_GADGET_VBUS_DRAW 2 +#define CONFIG_USB_CABLE_CHECK /* LCD */ #define CONFIG_EXYNOS_FB
Signature · 1 line
1.7.9.5
PATCH v2 1/1 trats: usb: Add usb_cable_connected() function
Quoted 7 lines · Przemyslaw Marczak
Changes:
- define functionusb_cable_connected()in trats board file which returns 1 if cable is connected and 0 otherwise
-trats.h: addCONFIG_USB_CHECK_CABLEChanges v2:
- add muic avaibility check
Change log should be under --- line.
This is not a commit message.
Quoted 8 lines
Signed-off-by Przemyslaw Marczak <[email protected]>Cc Minkyu Kang <[email protected]>--- board/samsung/trats/trats.c | 11 +++++++++++ include/configs/trats.h | 1 + 2 files changed, 12 insertions(+)
Anyway...
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
PATCH v2 1/1 trats: usb: Add usb_cable_connected() function
Hello,
Quoted 21 lines · Minkyu Kang
Quoted 7 lines · Przemyslaw Marczak
Changes:
- define functionusb_cable_connected()in trats board file which returns 1 if cable is connected and 0 otherwise
-trats.h: addCONFIG_USB_CHECK_CABLEChanges v2:
- add muic avaibility checkChange log should be under --- line.
This is not a commit message.Quoted 8 lines
Signed-off-by Przemyslaw Marczak <[email protected]>Cc Minkyu Kang <[email protected]>--- board/samsung/trats/trats.c | 11 +++++++++++ include/configs/trats.h | 1 + 2 files changed, 12 insertions(+)
Quoted 7 lines
Anyway...
applied to u-boot-samsung.Thanks,
Minkyu Kang.
Sorry for this issue and thank you for patch apply. Could you also check my patch to s5p gpio?
Regards
Signature · 4 lines
Przemyslaw Marczak Samsung R&D Institute Poland Samsung Electronics p.marczak at samsung.com