kobject: fix memory leak in kobject_set_name_vargs
Subsystems (2)
A message that is not in the archive (sent off-list or not yet received): [email protected]
PATCH 1/1 kobject: fix memory leak in kobject_set_name_vargs
If the call to kvasprintf fails then the old name of the object will be leaked, this patch fixes the bug by restoring the old name before returning ENOMEM.
Signed-off-by Maurizio Lombardi <[email protected]>
--- lib/kobject.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
lib/kobject.c +3 -1
@@ -247,8 +247,10 @@ int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,return 0 ; kobj->name =kvasprintf (GFP_KERNEL , fmt, vargs); -if (!kobj->name) +if (!kobj->name) { + kobj->name = old_name;return -ENOMEM ; + }/* ewww... some of these buggers have '/' in the name ... */ while ((s =strchr (kobj->name,'/' )))
Signature · 1 line
Maurizio Lombardi