Skip to contentSkip to conversation

kobject: fix memory leak in kobject_set_name_vargs

PATCH New Maurizio Lombardi 1 participant 1 message Nov 28, 2013 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

PATCH 1/1 kobject: fix memory leak in kobject_set_name_vargs

If the call to kvasprintf fails then the old name of the object will be leaked, this patch fixes the bug by restoring the old name before returning ENOMEM.

---
 lib/kobject.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
lib/kobject.c +3 -1
index 5b4b888..c2cb934 100644
@@ -247,8 +247,10 @@ int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
 		return 0;
 
 	kobj->name = kvasprintf(GFP_KERNEL, fmt, vargs);
-	if (!kobj->name)
+	if (!kobj->name) {
+		kobj->name = old_name;
 		return -ENOMEM;
+	}
 
 	/* ewww... some of these buggers have '/' in the name ... */
 	while ((s = strchr(kobj->name, '/')))
Signature · 1 line
Maurizio Lombardi