Skip to contentSkip to conversation

qt: Disable QtScript on MIPS64

PATCH New Vicente Olivert Riera 3 participants 7 messages Nov 27, 2013 – Nov 28, 2013

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/2 qt: Disable QtScript on MIPS64

There is no support for MIPS64 in QtScript right now, so buildroot upstream suggested to disable the possibility of enabling QtScript on MIPS64 as a quick fix for the 2013.11 release:

http://lists.busybox.net/pipermail/buildroot/2013-November/083157.html

QtScript doesn't build because it uses JavaScriptCore, so we re-use the existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists which platforms are supported by JavaScriptCore in Qt4.

In addition, a proposed fix to add support for MIPS64 has already been sent to Qt:

https://bugreports.qt-project.org/browse/QTBUG-35030

Fixes:

http://autobuild.buildroot.net/results/fd7/fd7e7e53290f235b540ed5f3c784e2584fdb41e0/

---
 package/qt/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/qt/Config.in +1 -0
index 2651d55..dd2b6d9 100644
@@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
 
 config BR2_PACKAGE_QT_SCRIPT
 	bool "Script Module"
+	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 	default y
 	help
 	  Build the Qt Script module.
Signature · 1 line
1.7.1
#1 lore raw

PATCH v2 2/2 grantlee: Disable on MIPS64

This package selects BR2_PACKAGE_QT_SCRIPT which is not supported on MIPS64. To prevent this behaviour we use the same solution as we applied for BR2_PACKAGE_QT_SCRIPT

---
 package/grantlee/Config.in |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
package/grantlee/Config.in +1 -0
index 84afad2..09ec70c 100644
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_GRANTLEE
 	bool "grantlee"
+	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
 	select BR2_PACKAGE_QT_STL
 	select BR2_PACKAGE_QT_SCRIPT
 	select BR2_PACKAGE_QT_GUI_MODULE
Signature · 1 line
1.7.1
#2 lore raw

PATCH v2 1/2 qt: Disable QtScript on MIPS64

In reply to Vicente Olivert Riera
Quoted 30 lines · Vicente Olivert Riera

There is no support for MIPS64 in QtScript right now, so buildroot upstream suggested to disable the possibility of enabling QtScript on MIPS64 as a quick fix for the 2013.11 release:

    http://lists.busybox.net/pipermail/buildroot/2013-November/083157.html

QtScript doesn't build because it uses JavaScriptCore, so we re-use the existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists which platforms are supported by JavaScriptCore in Qt4.

In addition, a proposed fix to add support for MIPS64 has already been sent to Qt:

    https://bugreports.qt-project.org/browse/QTBUG-35030

Fixes:

    http://autobuild.buildroot.net/results/fd7/fd7e7e53290f235b540ed5f3c784e2584fdb41e0/
---
  package/qt/Config.in |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
package/qt/Config.in +0 -0
index 2651d55..dd2b6d9 100644

package/qt/Config.in config BR2_PACKAGE_QT_OPENSSL · line 391

Quoted 7 lines
package/qt/Config.in +1 -0
@@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
 
  config BR2_PACKAGE_QT_SCRIPT
  	bool "Script Module"
+	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
  	default y
  	help
  	  Build the Qt Script module.

Technically, this set of patches should have been "v3" because there is a confusion now on which patch series is the good one.

Having said that, it looks good to me.

Signature · 1 line
markos
#3 lore raw

PATCH v2 1/2 qt: Disable QtScript on MIPS64

Quoted 45 lines · Markos Chandras
Quoted 33 lines · Vicente Olivert Riera

There is no support for MIPS64 in QtScript right now, so buildroot upstream suggested to disable the possibility of enabling QtScript on MIPS64 as a quick fix for the 2013.11 release:

http://lists.busybox.net/pipermail/buildroot/2013-November/083157.html

QtScript doesn't build because it uses JavaScriptCore, so we re-use the existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists which platforms are supported by JavaScriptCore in Qt4.

In addition, a proposed fix to add support for MIPS64 has already been sent to Qt:

    https://bugreports.qt-project.org/browse/QTBUG-35030

Fixes:

http://autobuild.buildroot.net/results/fd7/fd7e7e53290f235b540ed5f3c784e2584fdb41e0/

---
  package/qt/Config.in |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
package/qt/Config.in +0 -0
index 2651d55..dd2b6d9 100644

package/qt/Config.in config BR2_PACKAGE_QT_OPENSSL · line 391

Quoted 7 lines
package/qt/Config.in +1 -0
@@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
 
  config BR2_PACKAGE_QT_SCRIPT
      bool "Script Module"
+    depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
      default y
      help
        Build the Qt Script module.

Technically, this set of patches should have been "v3" because there is a confusion now on which patch series is the good one.

Quoted 2 lines

Having said that, it looks good to me.

The Subject is no longer accurate. You are not disabling this package just for MIPS64 but on other arches as well.

Signature · 1 line
markos
#4 lore raw

PATCH v2 1/2 qt: Disable QtScript on MIPS64

Quoted 47 lines · Markos Chandras
Quoted 46 lines · Markos Chandras
Quoted 34 lines · Vicente Olivert Riera

There is no support for MIPS64 in QtScript right now, so buildroot upstream suggested to disable the possibility of enabling QtScript on MIPS64 as a quick fix for the 2013.11 release:

http://lists.busybox.net/pipermail/buildroot/2013-November/083157.html

QtScript doesn't build because it uses JavaScriptCore, so we re-use the existing BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT option which already lists which platforms are supported by JavaScriptCore in Qt4.

In addition, a proposed fix to add support for MIPS64 has already been sent to Qt:

    https://bugreports.qt-project.org/browse/QTBUG-35030

Fixes:

http://autobuild.buildroot.net/results/fd7/fd7e7e53290f235b540ed5f3c784e2584fdb41e0/

---
  package/qt/Config.in |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
package/qt/Config.in +0 -0
index 2651d55..dd2b6d9 100644

package/qt/Config.in config BR2_PACKAGE_QT_OPENSSL · line 391

Quoted 7 lines
package/qt/Config.in +1 -0
@@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
 
  config BR2_PACKAGE_QT_SCRIPT
      bool "Script Module"
+    depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT
      default y
      help
        Build the Qt Script module.

Technically, this set of patches should have been "v3" because there is a confusion now on which patch series is the good one.

Quoted 5 lines
Quoted 2 lines

Having said that, it looks good to me.

The Subject is no longer accurate. You are not disabling this package just for MIPS64 but on other arches as well.

V3 sent with the subject amended. Please, take a look.

Thanks :-)

Signature · 1 line
Vincent
#5 lore raw

PATCH v2 1/2 qt: Disable QtScript on MIPS64

In reply to Vicente Olivert Riera

Dear Vicente Olivert Riera,

package/qt/Config.in config BR2_PACKAGE_QT_OPENSSL · line 388

Quoted 9 lines · Vicente Olivert Riera
package/qt/Config.in +1 -0
index 2651d55..dd2b6d9 100644
@@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
 
 config BR2_PACKAGE_QT_SCRIPT
 	bool "Script Module"
+	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT

I'm wondering if we shouldn't rename this option to something more
exact: ARCH_SUPPORTS_JAVASCRIPTCORE. But I don't know, and we don't have well established best practices for this kind of things.

Thomas

Signature · 3 lines
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
#6 lore raw

PATCH v2 1/2 qt: Disable QtScript on MIPS64

Quoted 18 lines · Thomas Petazzoni

Dear Vicente Olivert Riera,

package/qt/Config.in config BR2_PACKAGE_QT_OPENSSL · line 388

Quoted 9 lines · Vicente Olivert Riera
package/qt/Config.in +1 -0
index 2651d55..dd2b6d9 100644
@@ -385,6 +385,7 @@ config BR2_PACKAGE_QT_OPENSSL
 
  config BR2_PACKAGE_QT_SCRIPT
  	bool "Script Module"
+	depends on BR2_PACKAGE_QT_ARCH_SUPPORTS_WEBKIT

I'm wondering if we shouldn't rename this option to something more
exact: ARCH_SUPPORTS_JAVASCRIPTCORE. But I don't know, and we don't have well established best practices for this kind of things.

Quoted 2 lines

Thomas

Maybe we could keep it as is by now, apply the quick fix for the next release, and decide what to do in the future. What do you think?

Signature · 1 line
Vincent