Skip to contentSkip to conversation

arch: hexagon: kernel: hexagon_ksyms.c remove useless __hexagon_*i3()

PATCH In review Chen Gang 1 participant 2 messages Nov 29, 2013 Qualcomm hexagon architecture

lore
Share & tools
lore

Chen Gang

author
#0 lore raw

PATCH 1/1 arch: hexagon: kernel: hexagon_ksyms.c remove useless __hexagon_*i3()

Only find "DECLARE_EXPORT(__hexagon_*i3)", no related implementations and callers, so remove them, or will cause ld issue with allmodconfig, the related error:

LD init/built-in.o
arch/hexagon/kernel/built-in.o:(___ksymtab+__hexagon_umodsi3+0x0): undefined reference to __hexagon_umodsi3' arch/hexagon/kernel/built-in.o:(___ksymtab+__hexagon_udivsi3+0x0): undefined reference to __hexagon_udivsi3' arch/hexagon/kernel/built-in.o:(___ksymtab+__hexagon_modsi3+0x0): undefined reference to __hexagon_modsi3' arch/hexagon/kernel/built-in.o:(___ksymtab+__hexagon_divsi3+0x0): undefined reference to __hexagon_divsi3'

---
 arch/hexagon/kernel/hexagon_ksyms.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
arch/hexagon/kernel/hexagon_ksyms.c +0 -5
index 32b1379..1257c85 100644
@@ -33,8 +33,3 @@ EXPORT_SYMBOL(memset);
 
 /* Symbols found in libgcc that assorted kernel modules need */
 DECLARE_EXPORT(__hexagon_memcpy_likely_aligned_min32bytes_mult8bytes);
-
-DECLARE_EXPORT(__hexagon_divsi3);
-DECLARE_EXPORT(__hexagon_modsi3);
-DECLARE_EXPORT(__hexagon_udivsi3);
-DECLARE_EXPORT(__hexagon_umodsi3);
Signature · 1 line
1.7.7.6
author
#1 lore raw
Quoted 10 lines · Chen Gang

Only find "DECLARE_EXPORT(__hexagon_*i3)", no related implementations and callers, so remove them, or will cause ld issue with allmodconfig, the related error:

LD init/built-in.o
arch/hexagon/kernel/built-in.o:(___ksymtab+__hexagon_umodsi3+0x0): undefined reference to __hexagon_umodsi3' arch/hexagon/kernel/built-in.o:(___ksymtab+__hexagon_udivsi3+0x0): undefined reference to __hexagon_udivsi3' arch/hexagon/kernel/built-in.o:(___ksymtab+__hexagon_modsi3+0x0): undefined reference to __hexagon_modsi3' arch/hexagon/kernel/built-in.o:(___ksymtab+__hexagon_divsi3+0x0): undefined reference to __hexagon_divsi3'

Oh, sorry, this patch need improved, we can not only remove them simply (although really no related callers and implementations), I will send patch v2 later when finish allmodconfig.

Thanks.

Quoted 20 lines
---
 arch/hexagon/kernel/hexagon_ksyms.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)
arch/hexagon/kernel/hexagon_ksyms.c +0 -5
index 32b1379..1257c85 100644
@@ -33,8 +33,3 @@ EXPORT_SYMBOL(memset);
 
 /* Symbols found in libgcc that assorted kernel modules need */
 DECLARE_EXPORT(__hexagon_memcpy_likely_aligned_min32bytes_mult8bytes);
-
-DECLARE_EXPORT(__hexagon_divsi3);
-DECLARE_EXPORT(__hexagon_modsi3);
-DECLARE_EXPORT(__hexagon_udivsi3);
-DECLARE_EXPORT(__hexagon_umodsi3);
Signature · 1 line
Chen Gang