mmc: dw_mmc: remove the exynos specific code in dw-mmc.c
Subsystems (2)
PATCH 1/1 mmc: dw_mmc: remove the exynos specific code in dw-mmc.c
dw-mmc.c is the general driver file.
So, remove the exynos specific code at dw-mmc.c. Instead, exynos specific cod can be move into exynos-dw_mmc.c.
--- drivers/mmc/dw_mmc.c | 12 ++---------- drivers/mmc/exynos_dw_mmc.c | 14 ++++++++++++++ include/dwmmc.h | 1 + 3 files changed, 17 insertions(+), 10 deletions(-)
drivers/mmc/dw_mmc.c +2 -10
@@ -11,7 +11,6 @@#include <mmc.h> #include <dwmmc.h> #include <asm-generic/errno.h> -#include <asm/arch/dwmmc.h> #define PAGE_SIZE 4096
@@ -302,15 +301,8 @@ static int dwmci_init(struct mmc *mmc)struct dwmci_host *host = (struct dwmci_host *)mmc->priv;u32 fifo_size; -if (host->quirks &DWMCI_QUIRK_DISABLE_SMU ) { -dwmci_writel (host,EMMCP_MPSBEGIN0 ,0 ); -dwmci_writel (host,EMMCP_SEND0 ,0 ); -dwmci_writel (host,EMMCP_CTRL0 , -MPSCTRL_SECURE_READ_BIT | -MPSCTRL_SECURE_WRITE_BIT | -MPSCTRL_NON_SECURE_READ_BIT | -MPSCTRL_NON_SECURE_WRITE_BIT |MPSCTRL_VALID ); - } +if (host->board_init) + host->board_init (host);dwmci_writel (host,DWMCI_PWREN ,1 );
drivers/mmc/exynos_dw_mmc.c +14 -0
@@ -34,6 +34,19 @@ unsigned int exynos_dwmci_get_clk(int dev_index)return get_mmc_clk (dev_index); } +static void exynos_dwmci_board_init (struct dwmci_host *host) +{ +if (host->quirks &DWMCI_QUIRK_DISABLE_SMU ) { +dwmci_writel (host,EMMCP_MPSBEGIN0 ,0 ); +dwmci_writel (host,EMMCP_SEND0 ,0 ); +dwmci_writel (host,EMMCP_CTRL0 , +MPSCTRL_SECURE_READ_BIT | +MPSCTRL_SECURE_WRITE_BIT | +MPSCTRL_NON_SECURE_READ_BIT | +MPSCTRL_NON_SECURE_WRITE_BIT |MPSCTRL_VALID ); + } +} +/* * This function adds the mmc channel to be registered with mmc core. * index - mmc channel number.
@@ -65,6 +78,7 @@ int exynos_dwmci_add_port(int index, u32 regbase, int bus_width, u32 clksel)#ifdef CONFIG_EXYNOS5420 host->quirks =DWMCI_QUIRK_DISABLE_SMU ;#endif + host->board_init = exynos_dwmci_board_init;if (clksel) { host->clksel_val = clksel;
include/dwmmc.h +1 -0
@@ -141,6 +141,7 @@ struct dwmci_host {struct mmc *mmc;void (*clksel)(struct dwmci_host *host); +void (*board_init)(struct dwmci_host *host);unsigned int (*get_mmc_clk)(int dev_index); };
Signature · 1 line
1.7.9.5
PATCH 1/1 mmc: dw_mmc: remove the exynos specific code in dw-mmc.c
Quoted 5 lines · Jaehoon Chung
dw-mmc.cis the general driver file.
So, remove the exynos specific code atdw-mmc.c. Instead, exynos specific cod can be move intoexynos-dw_mmc.c.Signed-off-by Jaehoon Chung <[email protected]>
PATCH 1/1 mmc: dw_mmc: remove the exynos specific code in dw-mmc.c
Hi,
Had raised this point when I had got comments for the patch "[10/10,V4] DWMMC: SMDK5420: Disable SMU for eMMC"
https://patches.linaro.org/20666/
Regards,
Rajeshwari Shinde
Quoted 13 lines · Alexey Brodkin
Acked-by Alexey Brodkin <[email protected]>Quoted 5 lines · Jaehoon Chung
dw-mmc.cis the general driver file.
So, remove the exynos specific code atdw-mmc.c. Instead, exynos specific cod can be move intoexynos-dw_mmc.c.Signed-off-by Jaehoon Chung <[email protected]>_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Signature · 2 lines
Regards, Rajeshwari Shinde
PATCH 1/1 mmc: dw_mmc: remove the exynos specific code in dw-mmc.c
In reply to Jaehoon ChungHi Jaehoon,
Looks good
Quoted 87 lines · Jaehoon Chung
dw-mmc.cis the general driver file.
So, remove the exynos specific code atdw-mmc.c. Instead, exynos specific cod can be move intoexynos-dw_mmc.c.Signed-off-by Jaehoon Chung <[email protected]>---
drivers/mmc/dw_mmc.c | 12 ++---------- drivers/mmc/exynos_dw_mmc.c | 14 ++++++++++++++ include/dwmmc.h | 1 + 3 files changed, 17 insertions(+), 10 deletions(-)drivers/mmc/dw_mmc.c +2
-10@@ -11,7 +11,6 @@#include <mmc.h> #include <dwmmc.h> #include <asm-generic/errno.h> -#include <asm/arch/dwmmc.h> #define PAGE_SIZE 4096@@ -302,15 +301,8 @@ static int dwmci_init(struct mmc *mmc)struct dwmci_host *host = (struct dwmci_host *)mmc->priv;u32 fifo_size; -if (host->quirks &DWMCI_QUIRK_DISABLE_SMU ) { -dwmci_writel (host,EMMCP_MPSBEGIN0 ,0 ); -dwmci_writel (host,EMMCP_SEND0 ,0 ); -dwmci_writel (host,EMMCP_CTRL0 , -MPSCTRL_SECURE_READ_BIT | -MPSCTRL_SECURE_WRITE_BIT | -MPSCTRL_NON_SECURE_READ_BIT | -MPSCTRL_NON_SECURE_WRITE_BIT |MPSCTRL_VALID ); - } +if (host->board_init) + host->board_init (host);dwmci_writel (host,DWMCI_PWREN ,1 );drivers/mmc/exynos_dw_mmc.c +14
-0@@ -34,6 +34,19 @@ unsigned int exynos_dwmci_get_clk(int dev_index)return get_mmc_clk (dev_index); } +static void exynos_dwmci_board_init (struct dwmci_host *host) +{ +if (host->quirks &DWMCI_QUIRK_DISABLE_SMU ) { +dwmci_writel (host,EMMCP_MPSBEGIN0 ,0 ); +dwmci_writel (host,EMMCP_SEND0 ,0 ); +dwmci_writel (host,EMMCP_CTRL0 , +MPSCTRL_SECURE_READ_BIT | +MPSCTRL_SECURE_WRITE_BIT | +MPSCTRL_NON_SECURE_READ_BIT | +MPSCTRL_NON_SECURE_WRITE_BIT |MPSCTRL_VALID ); + } +} +/* * This function adds the mmc channel to be registered with mmc core. * index - mmc channel number. @@ -65,6 +78,7 @@ int exynos_dwmci_add_port(int index, u32 regbase, int bus_width, u32 clksel)#ifdef CONFIG_EXYNOS5420 host->quirks =DWMCI_QUIRK_DISABLE_SMU ;#endif + host->board_init = exynos_dwmci_board_init;if (clksel) { host->clksel_val = clksel;include/dwmmc.h +1
-0@@ -141,6 +141,7 @@ struct dwmci_host {struct mmc *mmc;void (*clksel)(struct dwmci_host *host); +void (*board_init)(struct dwmci_host *host);unsigned int (*get_mmc_clk)(int dev_index); };Signature · 1 line
1.7.9.5
PATCH 1/1 mmc: dw_mmc: remove the exynos specific code in dw-mmc.c
Quoted 91 lines · Pantelis Antoniou
Hi Jaehoon,
Looks good
Quoted 85 lines · Jaehoon Chung
dw-mmc.cis the general driver file.
So, remove the exynos specific code atdw-mmc.c. Instead, exynos specific cod can be move intoexynos-dw_mmc.c.Signed-off-by Jaehoon Chung <[email protected]>---
drivers/mmc/dw_mmc.c | 12 ++---------- drivers/mmc/exynos_dw_mmc.c | 14 ++++++++++++++ include/dwmmc.h | 1 + 3 files changed, 17 insertions(+), 10 deletions(-)drivers/mmc/dw_mmc.c +2
-10@@ -11,7 +11,6 @@#include <mmc.h> #include <dwmmc.h> #include <asm-generic/errno.h> -#include <asm/arch/dwmmc.h> #define PAGE_SIZE 4096@@ -302,15 +301,8 @@ static int dwmci_init(struct mmc *mmc)struct dwmci_host *host = (struct dwmci_host *)mmc->priv;u32 fifo_size; -if (host->quirks &DWMCI_QUIRK_DISABLE_SMU ) { -dwmci_writel (host,EMMCP_MPSBEGIN0 ,0 ); -dwmci_writel (host,EMMCP_SEND0 ,0 ); -dwmci_writel (host,EMMCP_CTRL0 , -MPSCTRL_SECURE_READ_BIT | -MPSCTRL_SECURE_WRITE_BIT | -MPSCTRL_NON_SECURE_READ_BIT | -MPSCTRL_NON_SECURE_WRITE_BIT |MPSCTRL_VALID ); - } +if (host->board_init) + host->board_init (host);dwmci_writel (host,DWMCI_PWREN ,1 );drivers/mmc/exynos_dw_mmc.c +14
-0@@ -34,6 +34,19 @@ unsigned int exynos_dwmci_get_clk(int dev_index)return get_mmc_clk (dev_index); } +static void exynos_dwmci_board_init (struct dwmci_host *host) +{ +if (host->quirks &DWMCI_QUIRK_DISABLE_SMU ) { +dwmci_writel (host,EMMCP_MPSBEGIN0 ,0 ); +dwmci_writel (host,EMMCP_SEND0 ,0 ); +dwmci_writel (host,EMMCP_CTRL0 , +MPSCTRL_SECURE_READ_BIT | +MPSCTRL_SECURE_WRITE_BIT | +MPSCTRL_NON_SECURE_READ_BIT | +MPSCTRL_NON_SECURE_WRITE_BIT |MPSCTRL_VALID ); + } +} +/* * This function adds the mmc channel to be registered with mmc core. * index - mmc channel number. @@ -65,6 +78,7 @@ int exynos_dwmci_add_port(int index, u32 regbase, int bus_width, u32 clksel)#ifdef CONFIG_EXYNOS5420 host->quirks =DWMCI_QUIRK_DISABLE_SMU ;#endif + host->board_init = exynos_dwmci_board_init;if (clksel) { host->clksel_val = clksel;include/dwmmc.h +1
-0@@ -141,6 +141,7 @@ struct dwmci_host {struct mmc *mmc;void (*clksel)(struct dwmci_host *host); +void (*board_init)(struct dwmci_host *host);unsigned int (*get_mmc_clk)(int dev_index); };
Quoted 5 lines
Quoted 2 lines
Signature · 1 line
1.7.9.5
Thanks,
Minkyu Kang.