hid: add NOGET quirk and device id for Logitech Dual Action gamepads support
PATCH 1/1 hid: add NOGET quirk and device id for Logitech Dual Action gamepads support
Issue description: I have two Logitech Dual Action gamepads, both have same Vendor/Device id pair. Newest gamepad (A) can switch between old mode (HID) and XBox gamepad emulation mode. Old gamepad (B) can only work in HID mode. In HID mode gamepad A sends many EPIPE errors during initialization and was disconnected immediately after connect to usb port. It works fine in Win and Mac. After adding NOGET quirk in driver, it was working properly. Gamepad B works fine before and after changes. I tested both gamepads with 3.8.0 and 3.11.6 kernels with modified driver. Follow patch can apply for current git kernel version. I can send pcap log from usb bus with both gamepads or any other additional information if it is needed
drivers/hid/hid-ids.h +1 -0
@@ -552,6 +552,7 @@#define USB_DEVICE_ID_LOGITECH_RUMBLEPAD_CORD 0xc20a#define USB_DEVICE_ID_LOGITECH_RUMBLEPAD 0xc211#define USB_DEVICE_ID_LOGITECH_EXTREME_3D 0xc215 +#define USB_DEVICE_ID_LOGITECH_DUAL_ACTION 0xc216#define USB_DEVICE_ID_LOGITECH_RUMBLEPAD2 0xc218#define USB_DEVICE_ID_LOGITECH_RUMBLEPAD2_2 0xc219#define USB_DEVICE_ID_LOGITECH_WINGMAN_F3D 0xc283
drivers/hid/hid-lg.c +2 -0
@@ -758,6 +758,8 @@ static const struct hid_device_id lg_dev { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_EXTREME_3D), .driver_data = LG_NOGET }, + { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DUAL_ACTION), + .driver_data = LG_NOGET }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WHEEL), .driver_data = LG_NOGET | LG_FF4 },
Quoted 11 lines · Zawullon
Issue description: I have two Logitech Dual Action gamepads, both have same Vendor/Device id pair. Newest gamepad (A) can switch between old mode (HID) and XBox gamepad emulation mode. Old gamepad (B) can only work in HID mode. In HID mode gamepad A sends many EPIPE errors during initialization and was disconnected immediately after connect to usb port. It works fine in Win and Mac. After adding NOGET quirk in driver, it was working properly. Gamepad B works fine before and after changes. I tested both gamepads with 3.8.0 and 3.11.6 kernels with modified driver. Follow patch can apply for current git kernel version. I can send pcap log from usb bus with both gamepads or any other additional information if it is needed
Please provide your Signed-off-by: line so that I could apply the patch. Thanks.
Quoted 24 lines
diff -uprN -X linux-git/Documentation/dontdiff
linux-git/drivers/hid/hid-ids.hlinux-my/drivers/hid/hid-ids.hdrivers/hid/hid-ids.h +1
-0@@ -552,6 +552,7 @@#define USB_DEVICE_ID_LOGITECH_RUMBLEPAD_CORD 0xc20a#define USB_DEVICE_ID_LOGITECH_RUMBLEPAD 0xc211#define USB_DEVICE_ID_LOGITECH_EXTREME_3D 0xc215 +#define USB_DEVICE_ID_LOGITECH_DUAL_ACTION 0xc216#define USB_DEVICE_ID_LOGITECH_RUMBLEPAD2 0xc218#define USB_DEVICE_ID_LOGITECH_RUMBLEPAD2_2 0xc219#define USB_DEVICE_ID_LOGITECH_WINGMAN_F3D 0xc283diff -uprN -X linux-git/Documentation/dontdiff
linux-git/drivers/hid/hid-lg.clinux-my/drivers/hid/hid-lg.cdrivers/hid/hid-lg.c +2
-0@@ -758,6 +758,8 @@ static const struct hid_device_id lg_dev { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_EXTREME_3D), .driver_data = LG_NOGET }, + { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_DUAL_ACTION), + .driver_data = LG_NOGET }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_WHEEL), .driver_data = LG_NOGET | LG_FF4 },
Signature · 2 lines
Jiri Kosina SUSE Labs
Quoted 2 lines · Jiri Kosina
Please provide your Signed-off-by: line so that I could apply the patch. Thanks.
Oh, of course. Sorry.
Quoted 6 lines · Zawullon
Quoted 2 lines
Please provide your Signed-off-by: line so that I could apply the patch. Thanks.
Oh, of course. Sorry.
Signed-off-by Vitaly Katraew <[email protected]>
Now applied (with the name above as authorship as well). Thanks,
Signature · 2 lines
Jiri Kosina SUSE Labs