Skip to contentSkip to conversation

sctp: check the rto_min and rto_max

PATCH Superseded wangweidong 3 participants 4 messages Nov 30, 2013 – Dec 2, 2013

Subsystems (3)

v1 of 7 Superseded Latest is v7 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 sctp: check the rto_min and rto_max

rto_min should be smaller than rto_max while rto_max should be larger than rto_min. so just add the check.

---
 net/sctp/sysctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
net/sctp/sysctl.c +2 -2
index 6b36561..7637e8e 100644
@@ -104,7 +104,7 @@ static struct ctl_table sctp_net_table[] = {
 		.mode		= 0644,
 		.proc_handler	= proc_dointvec_minmax,
 		.extra1         = &one,
-		.extra2         = &timer_max
+		.extra2         = &init_net.sctp.rto_max
 	},
 	{
 		.procname	= "rto_max",
@@ -112,7 +112,7 @@ static struct ctl_table sctp_net_table[] = {
 		.maxlen		= sizeof(unsigned int),
 		.mode		= 0644,
 		.proc_handler	= proc_dointvec_minmax,
-		.extra1         = &one,
+		.extra1         = &init_net.sctp.rto_min,
 		.extra2         = &timer_max
 	},
 	{
Signature · 1 line
1.7.12
Acked-by on v1 1/1
#1 lore raw
Quoted 35 lines · wangweidong

rto_min should be smaller than rto_max while rto_max should be larger than rto_min. so just add the check.

---
 net/sctp/sysctl.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
net/sctp/sysctl.c +2 -2
index 6b36561..7637e8e 100644
@@ -104,7 +104,7 @@ static struct ctl_table sctp_net_table[] = {
 		.mode		= 0644,
 		.proc_handler	= proc_dointvec_minmax,
 		.extra1         = &one,
-		.extra2         = &timer_max
+		.extra2         = &init_net.sctp.rto_max
 	},
 	{
 		.procname	= "rto_max",
@@ -112,7 +112,7 @@ static struct ctl_table sctp_net_table[] = {
 		.maxlen		= sizeof(unsigned int),
 		.mode		= 0644,
 		.proc_handler	= proc_dointvec_minmax,
-		.extra1         = &one,
+		.extra1         = &init_net.sctp.rto_min,
 		.extra2         = &timer_max
 	},
 	{
Signature · 1 line
1.7.12
maintainer
#2 lore raw
In reply to wangweidong

From: wangweidong <[email protected]>
Date: Sat, 30 Nov 2013 18:23:52 +0800

Quoted 4 lines

rto_min should be smaller than rto_max while rto_max should be larger than rto_min. so just add the check.

Please fix your submission process such that your real full name appears in the "From: " field of your patch emails, instead of just "wangweidong", which is your username not your real full name.

I'm not applying your patches until you correct this and submit the patch properly, thanks.

#3 lore raw
Quoted 8 lines · David Miller

From: wangweidong <[email protected]>
Date: Sat, 30 Nov 2013 18:23:52 +0800

Quoted 4 lines

rto_min should be smaller than rto_max while rto_max should be larger than rto_min. so just add the check.

Quoted 8 lines

Please fix your submission process such that your real full name appears in the "From: " field of your patch emails, instead of just "wangweidong", which is your username not your real full name.

I'm not applying your patches until you correct this and submit the patch properly, thanks.

Ok, I will fix it in v2.
Thanks.

Quoted 1 line