lksctp: fix a problem when do test_1_to_1_sockopt
PATCH 1/1 lksctp: fix a problem when do test_1_to_1_sockopt
From: Wang Weidong <[email protected]>
When I do the test_1_to_1_sockopt, I got a Segmentation fault:DUMP_CORE test_1_to_1_sockopt.c: 343.
I used the kernel is 3.12.
The problem is that the SOCK_MIN_SNDBUF is (TCP_SKB_MIN_TRUESIZE * 2) while TCP_SKB_MIN_TRUESIZE is 2048 + SKB_DATA_ALIGN(sizeof(struct sk_buff)) The SKB_DATA_ALIGN I test is 256, so I make the sndbuf_val_set to 2304.
--- src/func_tests/test_1_to_1_sockopt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
src/func_tests/test_1_to_1_sockopt.c +1 -1
@@ -320,7 +320,7 @@ main(void)"got value differs Set Value=%d Get Value=%d" , (2*rcvbuf_val_set), rcvbuf_val_get); - sndbuf_val_set =2048 ; + sndbuf_val_set =2304 ;/* TEST17: Test case for setsockopt SO_SNDBUF */ error =setsockopt (sk2,SOL_SOCKET ,SO_SNDBUF , &sndbuf_val_set, len);if (error <0 )
Signature · 1 line
1.7.12
Quoted 20 lines · Wang Weidong
From: Wang Weidong <[email protected]>
When I do the
test_1_to_1_sockopt, I got a Segmentation fault:DUMP_COREtest_1_to_1_sockopt.c: 343.
I used the kernel is 3.12.
The problem is that theSOCK_MIN_SNDBUFis (TCP_SKB_MIN_TRUESIZE* 2) whileTCP_SKB_MIN_TRUESIZEis 2048 +SKB_DATA_ALIGN(sizeof(struct sk_buff))TheSKB_DATA_ALIGNI test is 256, so I make thesndbuf_val_setto 2304.Signed-off-by Wang Weidong <[email protected]>--- src/func_tests/test_1_to_1_sockopt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)src/func_tests/test_1_to_1_sockopt.c +0
-0
src/func_tests/test_1_to_1_sockopt.c main(void) · line 326
Quoted 8 lines
src/func_tests/test_1_to_1_sockopt.c +1
-1@@ -320,7 +320,7 @@ main(void)"got value differs Set Value=%d Get Value=%d" , (2*rcvbuf_val_set), rcvbuf_val_get); - sndbuf_val_set =2048 ; + sndbuf_val_set =2304 ;/* TEST17: Test case for setsockopt SO_SNDBUF */ error =setsockopt (sk2,SOL_SOCKET ,SO_SNDBUF , &sndbuf_val_set, len);if (error <0 )
Sorry for that I didn't send it to Vlad and Daniel. Just ignore it. I will resend it.