Skip to contentSkip to conversation

trats: enable dfu and thor protocol for Tizen download

PATCH New Piotr Wilczek 3 participants 5 messages Nov 12, 2013 – Dec 2, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 trats: enable dfu and thor protocol for Tizen download

Trats2 config is updated to support DFU mode. Malloc pool must be increased for DFU buffer allocation.

---
This patch is based on
http://patchwork.ozlabs.org/patch/289378/

 include/configs/trats2.h |   22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)
include/configs/trats2.h +18 -4
index 66b1c95..52bb5e5 100644
@@ -65,10 +65,9 @@
 
 #define CONFIG_DISPLAY_CPUINFO
 
-/*
- * Size of malloc() pool
- */
-#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (2 << 20))
+#include <asm/sizes.h>
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (80 * SZ_1M))
 
 /* select serial console configuration */
 #define CONFIG_SERIAL2
@@ -100,6 +99,7 @@
 #define CONFIG_CMD_CACHE
 #define CONFIG_CMD_I2C
 #define CONFIG_CMD_MMC
+#define CONFIG_CMD_DFU
 #define CONFIG_CMD_GPT
 #define CONFIG_CMD_PMIC
 
@@ -115,12 +115,19 @@
 
 /* USB Composite download gadget - g_dnl */
 #define CONFIG_USBDOWNLOAD_GADGET
+#define CONFIG_SYS_DFU_DATA_BUF_SIZE SZ_32M
 #define CONFIG_DFU_FUNCTION
 #define CONFIG_DFU_MMC
 
+/* TIZEN THOR downloader support */
+#define CONFIG_CMD_THOR_DOWNLOAD
+#define CONFIG_THOR_FUNCTION
+
 /* USB Samsung's IDs */
 #define CONFIG_G_DNL_VENDOR_NUM 0x04E8
 #define CONFIG_G_DNL_PRODUCT_NUM 0x6601
+#define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM
+#define CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D
 #define CONFIG_G_DNL_MANUFACTURER "Samsung"
 
 /* To use the TFTPBOOT over USB, Please enable the CONFIG_CMD_NET */
@@ -165,6 +172,12 @@
 	"name="PARTS_CSC",size=150MiB,uuid=${uuid_gpt_"PARTS_CSC"};" \
 	"name="PARTS_UMS",size=-,uuid=${uuid_gpt_"PARTS_UMS"}\0" \
 
+#define CONFIG_DFU_ALT \
+	"u-boot mmc 80 400;" \
+	"uImage ext4 0 2;" \
+	"exynos4412-trats2.dtb ext4 0 2;" \
+	""PARTS_ROOT" part 0 5\0"
+
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"bootk=" \
 		"run loaddtb; run loaduimage; bootm 0x40007FC0 - ${fdtaddr}\0" \
@@ -197,6 +210,7 @@
 	"mmcrootpart=5\0" \
 	"opts=always_resume=1\0" \
 	"partitions=" PARTS_DEFAULT \
+	"dfu_alt_info=" CONFIG_DFU_ALT \
 	"uartpath=ap\0" \
 	"usbpath=ap\0" \
 	"consoleon=set console console=ttySAC2,115200n8; save; reset\0" \
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 trats: enable dfu and thor protocol for Tizen download

Hi Piotr,

I think good that used the "trats2:xxx" instead of "trats: xxx" at subject.

Quoted 60 lines · Piotr Wilczek

Trats2 config is updated to support DFU mode. Malloc pool must be increased for DFU buffer allocation.

---
This patch is based on
http://patchwork.ozlabs.org/patch/289378/

 include/configs/trats2.h |   22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)
include/configs/trats2.h +11 -4
index 66b1c95..52bb5e5 100644
@@ -65,10 +65,9 @@
 
 #define CONFIG_DISPLAY_CPUINFO
 
-/*
- * Size of malloc() pool
- */
-#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (2 << 20))
+#include <asm/sizes.h>
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (80 * SZ_1M))
 
 /* select serial console configuration */
 #define CONFIG_SERIAL2
@@ -100,6 +99,7 @@
 #define CONFIG_CMD_CACHE
 #define CONFIG_CMD_I2C
 #define CONFIG_CMD_MMC
+#define CONFIG_CMD_DFU
 #define CONFIG_CMD_GPT
 #define CONFIG_CMD_PMIC
 
@@ -115,12 +115,19 @@
 
 /* USB Composite download gadget - g_dnl */
 #define CONFIG_USBDOWNLOAD_GADGET
+#define CONFIG_SYS_DFU_DATA_BUF_SIZE SZ_32M
 #define CONFIG_DFU_FUNCTION
 #define CONFIG_DFU_MMC
 
+/* TIZEN THOR downloader support */
+#define CONFIG_CMD_THOR_DOWNLOAD
+#define CONFIG_THOR_FUNCTION
+
 /* USB Samsung's IDs */
 #define CONFIG_G_DNL_VENDOR_NUM 0x04E8
 #define CONFIG_G_DNL_PRODUCT_NUM 0x6601
+#define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM
+#define CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D
 #define CONFIG_G_DNL_MANUFACTURER "Samsung"
 
 /* To use the TFTPBOOT over USB, Please enable the CONFIG_CMD_NET */

include/configs/trats2.h line 176

Quoted 5 lines
include/configs/trats2.h +2 -0
@@ -165,6 +172,12 @@
 	"name="PARTS_CSC",size=150MiB,uuid=${uuid_gpt_"PARTS_CSC"};" \
 	"name="PARTS_UMS",size=-,uuid=${uuid_gpt_"PARTS_UMS"}\0" \
 
+#define CONFIG_DFU_ALT \
+	"u-boot mmc 80 400;" \

I recommend the "u-boot mmc 80 800"

Best Regards,
Jaehoon Chung

Quoted 16 lines
include/configs/trats2.h +5 -0
+	"uImage ext4 0 2;" \
+	"exynos4412-trats2.dtb ext4 0 2;" \
+	""PARTS_ROOT" part 0 5\0"
+
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"bootk=" \
 		"run loaddtb; run loaduimage; bootm 0x40007FC0 - ${fdtaddr}\0" \
@@ -197,6 +210,7 @@
 	"mmcrootpart=5\0" \
 	"opts=always_resume=1\0" \
 	"partitions=" PARTS_DEFAULT \
+	"dfu_alt_info=" CONFIG_DFU_ALT \
 	"uartpath=ap\0" \
 	"usbpath=ap\0" \
 	"consoleon=set console console=ttySAC2,115200n8; save; reset\0" \
#2 lore raw

PATCH 1/1 trats: enable dfu and thor protocol for Tizen download

Hi Jaehoon,

Quoted 8 lines

-----Original Message-----
From: Jaehoon Chung [mailto:jh80.chung at samsung.com]
Sent: Tuesday, November 12, 2013 10:23 AM
To: Piotr Wilczek; u-boot at lists.denx.de
Cc: Kyungmin Park
Subject: Re: [U-Boot] [PATCH] trats: enable dfu and thor protocol for Tizen download

Quoted 4 lines

Hi Piotr,

I think good that used the "trats2:xxx" instead of "trats: xxx" at subject.

Yes, I overlook that, will fix.

Quoted 22 lines · Piotr Wilczek

include/configs/trats2.h

Quoted 14 lines

Trats2 config is updated to support DFU mode. Malloc pool must be increased for DFU buffer allocation.

---
This patch is based on
http://patchwork.ozlabs.org/patch/289378/

 include/configs/trats2.h |   22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)
include/configs/trats2.h +0 -0

index

Quoted 5 lines

66b1c95..52bb5e5 100644

include/configs/trats2.h +0 -0
@@ -65,10 +65,9 @@
 
Quoted 6 lines

include/configs/trats2.h

Quoted 6 lines
include/configs/trats2.h +0 -4
 #define CONFIG_DISPLAY_CPUINFO
 
-/*
- * Size of malloc() pool
- */
-#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (2 <<

20))

Quoted 31 lines

include/configs/trats2.h

Quoted 3 lines
include/configs/trats2.h +3 -0
+#include <asm/sizes.h>
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (80 *

SZ_1M))

Quoted 27 lines
include/configs/trats2.h +1 -1
 /* select serial console configuration */  #define CONFIG_SERIAL2 @@
-100,6 +99,7 @@  #define CONFIG_CMD_CACHE  #define CONFIG_CMD_I2C
 #define CONFIG_CMD_MMC
+#define CONFIG_CMD_DFU

#define CONFIG_CMD_GPT
#define CONFIG_CMD_PMIC

include/configs/trats2.h +0 -0
@@ -115,12 +115,19 @@
 
 /* USB Composite download gadget - g_dnl */  #define

CONFIG_USBDOWNLOAD_GADGET

include/configs/trats2.h +5 -0
+#define CONFIG_SYS_DFU_DATA_BUF_SIZE SZ_32M
 #define CONFIG_DFU_FUNCTION
 #define CONFIG_DFU_MMC
 
+/* TIZEN THOR downloader support */
+#define CONFIG_CMD_THOR_DOWNLOAD
+#define CONFIG_THOR_FUNCTION
+
 /* USB Samsung's IDs */
 #define CONFIG_G_DNL_VENDOR_NUM 0x04E8  #define

CONFIG_G_DNL_PRODUCT_NUM 0x6601

include/configs/trats2.h +2 -0
+#define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM #define
+CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D
 #define CONFIG_G_DNL_MANUFACTURER "Samsung"
Quoted 8 lines

include/configs/trats2.h line 176

Quoted 7 lines

/* To use the TFTPBOOT over USB, Please enable the CONFIG_CMD_NET */

include/configs/trats2.h +2 -0
@@ -165,6 +172,12 @@
 	"name="PARTS_CSC",size=150MiB,uuid=${uuid_gpt_"PARTS_CSC"};" \
 	"name="PARTS_UMS",size=-,uuid=${uuid_gpt_"PARTS_UMS"}\0" \
 
+#define CONFIG_DFU_ALT \
+	"u-boot mmc 80 400;" \

I recommend the "u-boot mmc 80 800"

Ok

Quoted 11 lines

Best Regards,
Jaehoon Chung

include/configs/trats2.h

Quoted 7 lines
include/configs/trats2.h +4 -0
+	"uImage ext4 0 2;" \
+	"exynos4412-trats2.dtb ext4 0 2;" \
+	""PARTS_ROOT" part 0 5\0"
+
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"bootk=" \
 		"run loaddtb; run loaduimage; bootm 0x40007FC0 -

${fdtaddr}\0" \ @@

Quoted 9 lines

include/configs/trats2.h line 216

Quoted 9 lines

-197,6 +210,7 @@

include/configs/trats2.h +1 -0
 	"mmcrootpart=5\0" \
 	"opts=always_resume=1\0" \
 	"partitions=" PARTS_DEFAULT \
+	"dfu_alt_info=" CONFIG_DFU_ALT \
 	"uartpath=ap\0" \
 	"usbpath=ap\0" \
 	"consoleon=set console console=ttySAC2,115200n8; save; reset\0" \

Best regards,
Piotr Wilczek

#3 lore raw

PATCH v2 1/1 trats2: enable dfu and thor protocol for Tizen download

In reply to Piotr Wilczek

Trats2 config is updated to support DFU mode. Malloc pool must be increased for DFU buffer allocation.

---
Changes for v2:
- modified subject to reflect that the patch is for Trats2;
- changed u-boot write size to 0x800 in dfu alts;

This patch is based on
http://patchwork.ozlabs.org/patch/289378/

 include/configs/trats2.h |   22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)
include/configs/trats2.h +18 -4
index 66b1c95..bf49dd5 100644
@@ -65,10 +65,9 @@
 
 #define CONFIG_DISPLAY_CPUINFO
 
-/*
- * Size of malloc() pool
- */
-#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (2 << 20))
+#include <asm/sizes.h>
+/* Size of malloc() pool */
+#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + (80 * SZ_1M))
 
 /* select serial console configuration */
 #define CONFIG_SERIAL2
@@ -100,6 +99,7 @@
 #define CONFIG_CMD_CACHE
 #define CONFIG_CMD_I2C
 #define CONFIG_CMD_MMC
+#define CONFIG_CMD_DFU
 #define CONFIG_CMD_GPT
 #define CONFIG_CMD_PMIC
 
@@ -115,12 +115,19 @@
 
 /* USB Composite download gadget - g_dnl */
 #define CONFIG_USBDOWNLOAD_GADGET
+#define CONFIG_SYS_DFU_DATA_BUF_SIZE SZ_32M
 #define CONFIG_DFU_FUNCTION
 #define CONFIG_DFU_MMC
 
+/* TIZEN THOR downloader support */
+#define CONFIG_CMD_THOR_DOWNLOAD
+#define CONFIG_THOR_FUNCTION
+
 /* USB Samsung's IDs */
 #define CONFIG_G_DNL_VENDOR_NUM 0x04E8
 #define CONFIG_G_DNL_PRODUCT_NUM 0x6601
+#define CONFIG_G_DNL_THOR_VENDOR_NUM CONFIG_G_DNL_VENDOR_NUM
+#define CONFIG_G_DNL_THOR_PRODUCT_NUM 0x685D
 #define CONFIG_G_DNL_MANUFACTURER "Samsung"
 
 /* To use the TFTPBOOT over USB, Please enable the CONFIG_CMD_NET */
@@ -165,6 +172,12 @@
 	"name="PARTS_CSC",size=150MiB,uuid=${uuid_gpt_"PARTS_CSC"};" \
 	"name="PARTS_UMS",size=-,uuid=${uuid_gpt_"PARTS_UMS"}\0" \
 
+#define CONFIG_DFU_ALT \
+	"u-boot mmc 80 800;" \
+	"uImage ext4 0 2;" \
+	"exynos4412-trats2.dtb ext4 0 2;" \
+	""PARTS_ROOT" part 0 5\0"
+
 #define CONFIG_EXTRA_ENV_SETTINGS \
 	"bootk=" \
 		"run loaddtb; run loaduimage; bootm 0x40007FC0 - ${fdtaddr}\0" \
@@ -197,6 +210,7 @@
 	"mmcrootpart=5\0" \
 	"opts=always_resume=1\0" \
 	"partitions=" PARTS_DEFAULT \
+	"dfu_alt_info=" CONFIG_DFU_ALT \
 	"uartpath=ap\0" \
 	"usbpath=ap\0" \
 	"consoleon=set console console=ttySAC2,115200n8; save; reset\0" \
Signature · 1 line
1.7.9.5
#4 lore raw

PATCH v2 1/1 trats2: enable dfu and thor protocol for Tizen download

Dear Piotr Wilczek,

Quoted 11 lines · Piotr Wilczek

Trats2 config is updated to support DFU mode. Malloc pool must be increased for DFU buffer allocation.

---
Changes for v2:
- modified subject to reflect that the patch is for Trats2;
- changed u-boot write size to 0x800 in dfu alts;

Quoted 6 lines

This patch is based on
http://patchwork.ozlabs.org/patch/289378/

 include/configs/trats2.h |   22 ++++++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

applied to u-boot-samsung.

Thanks,
Minkyu Kang.