fixed unresolved symbol "at91_pm_set_standby" when built without CONFIG_PM
PATCH 1/1 fixed unresolved symbol "at91_pm_set_standby" when built without CONFIG_PM
If CONFIG_PM is not defined, then arch/arm/mach-at91/pm.c is not compiled in. This patch creates an inline function that does nothing if CONFIG_PM is not defined.
--- arch/arm/mach-at91/pm.h | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm/mach-at91/pm.h +4 -0
@@ -16,7 +16,11 @@#include <mach/at91_ramc.h> #include <mach/at91rm9200_sdramc.h> +#ifdef CONFIG_PM extern void at91_pm_set_standby (void (*at91_standby)(void )); +#else +static inline void at91_pm_set_standby (void (*at91_standby)(void )) { } +#endif /* * The AT91RM9200 goes into self-refresh mode with this command, and will
--
1.8.3.2
PATCH 1/1 fixed unresolved symbol "at91_pm_set_standby" when built without CONFIG_PM
On 24/11/2013 19:02, Brent Taylor :
Quoted 3 lines
If
CONFIG_PMis not defined, thenarch/arm/mach-at91/pm.cis not compiled in. This patch creates an inline function that does nothing ifCONFIG_PMis not defined.
Your "Signed-off-by" line is missing. Can you please quickly send it to me (by just replying to this email)?
Otherwise, seems reasonable:
Quoted 28 lines
--- arch/arm/mach-at91/pm.h | 4 ++++ 1 file changed, 4 insertions(+)arch/arm/mach-at91/pm.h +4
-1@@ -16,7 +16,11 @@#include <mach/at91_ramc.h> #include <mach/at91rm9200_sdramc.h> +#ifdef CONFIG_PM extern void at91_pm_set_standby (void (*at91_standby)(void )); +#else +static inline void at91_pm_set_standby (void (*at91_standby)(void )) { } +#endif /* * The AT91RM9200 goes into self-refresh mode with this command, and will -- 1.8.3.2
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Signature · 1 line
Nicolas Ferre
A message that is not in the archive (sent off-list or not yet received): CAP+RiCBHRiQ+exZ1iqVawDOb3teQVZkb8C7WmtXPJVN_O_GaBA@mail.gmail.com
PATCH 1/1 fixed unresolved symbol "at91_pm_set_standby" when built without CONFIG_PM
On 02/12/2013 14:12, Brent Taylor :
Quoted 1 line
Signed-off-by Brent Taylor <[email protected]>
Thanks. it is now queued in at91-3.13-fixes.
Best regards,
Quoted 50 lines · Nicolas Ferre
Quoted 47 lines
On 24/11/2013 19:02, Brent Taylor :
Quoted 4 lines
If
CONFIG_PMis not defined, thenarch/arm/mach-at91/pm.cis not compiled in. This patch creates an inline function that does nothing ifCONFIG_PMis not defined.Your "Signed-off-by" line is missing. Can you please quickly send it to me (by just replying to this email)?
Otherwise, seems reasonable:
Acked-by Nicolas Ferre <[email protected]>Quoted 24 lines
--- arch/arm/mach-at91/pm.h | 4 ++++ 1 file changed, 4 insertions(+)arch/arm/mach-at91/pm.h +4
-0@@ -16,7 +16,11 @@#include <mach/at91_ramc.h> #include <mach/at91rm9200_sdramc.h> +#ifdef CONFIG_PM extern void at91_pm_set_standby (void (*at91_standby)(void )); +#else +static inline void at91_pm_set_standby (void (*at91_standby)(void )) { } +#endif /* * The AT91RM9200 goes into self-refresh mode with this command, and will
--
1.8.3.2Quoted 5 lines
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel--
Nicolas Ferre
Signature · 1 line
Nicolas Ferre