base.bbclass: fix nondeterministic PACKAGECONFIG processing order
PATCH 1/1 base.bbclass: fix nondeterministic PACKAGECONFIG processing order
The PACKAGECONFIG flags were iterated over using dict.items(), but this returns the items in an undefined order. As this order determines the EXTRA_OECONF append order, we can get EXTRA_OECONF which are functionally equivalent, but whose contents differ, resulting in not using shared state archives we should be using.
--- meta/classes/base.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
meta/classes/base.bbclass +1 -1
@@ -433,7 +433,7 @@ python () { extradeps = [] extrardeps = [] extraconf = [] - for flag, flagval in pkgconfigflags.items(): + for flag, flagval in sorted(pkgconfigflags.items()): if flag == "defaultval": continue items = flagval.split(",")
Signature · 1 line
1.8.3.4
Quoted 7 lines · Christopher Larson
The PACKAGECONFIG flags were iterated over using
dict.items(), but this returns the items in an undefined order. As this order determines theEXTRA_OECONFappend order, we can getEXTRA_OECONFwhich are functionally equivalent, but whose contents differ, resulting in not using shared state archives we should be using.Signed-off-by Christopher Larson <[email protected]>
Robert,
Can this commit be pulled into dora?
More deterministic behaviour is more supportable behaviour!
It's:
843a5dd
base.bbclass: fix nondeterministic PACKAGECONFIG processing order
on master.
../Randy
Quoted 18 lines
--- meta/classes/base.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)meta/classes/base.bbclass +1
-1@@ -433,7 +433,7 @@ python () { extradeps = [] extrardeps = [] extraconf = [] - for flag, flagval in pkgconfigflags.items(): + for flag, flagval in sorted(pkgconfigflags.items()): if flag == "defaultval": continue items = flagval.split(",")
Signature · 2 lines
# Randy MacLeod. SMTS, Linux, Wind River Direct: 613.963.1350
Quoted 13 lines · Randy MacLeod
Quoted 8 lines · Christopher Larson
The PACKAGECONFIG flags were iterated over using
dict.items(), but this returns the items in an undefined order. As this order determines theEXTRA_OECONFappend order, we can getEXTRA_OECONFwhich are functionally equivalent, but whose contents differ, resulting in not using shared state archives we should be using.Signed-off-by Christopher Larson <[email protected]>Robert,
Quoted 7 lines
Can this commit be pulled into dora?
More deterministic behaviour is more supportable behaviour!It's:
843a5dd
base.bbclass: fix nondeterministic PACKAGECONFIG processing order
on master.
I agree; this is a very good bugfix and improve sstate-cache reuse.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750