perf/x86/intel: remove DEFINE_PCI_DEVICE_TABLE macro
Subsystems (151)
A message that is not in the archive (sent off-list or not yet received): 001501ceefb1$69c96820$3d5c3860$%[email protected]
PATCH 1/39 perf/x86/intel: remove DEFINE_PCI_DEVICE_TABLE macro
Don't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- arch/x86/kernel/cpu/perf_event_intel_uncore.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/perf_event_intel_uncore.c +2 -2
@@ -901,7 +901,7 @@ static struct intel_uncore_type *snbep_pci_uncores[] = { NULL, }; -static DEFINE_PCI_DEVICE_TABLE (snbep_uncore_pci_ids) = { +static const struct pci_device_id snbep_uncore_pci_ids[] = { {/* Home Agent */ PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_UNC_HA ), .driver_data =UNCORE_PCI_DEV_DATA (SNBEP_PCI_UNCORE_HA ,0 ),
@@ -1460,7 +1460,7 @@ static struct intel_uncore_type *ivt_pci_uncores[] = { NULL, }; -static DEFINE_PCI_DEVICE_TABLE (ivt_uncore_pci_ids) = { +static const struct pci_device_id ivt_uncore_pci_ids[] = { {/* Home Agent 0 */ PCI_DEVICE (PCI_VENDOR_ID_INTEL ,0xe30 ), .driver_data =UNCORE_PCI_DEV_DATA (IVT_PCI_UNCORE_HA ,0 ),
Signature · 1 line
1.7.10.4
PATCH 2/39 bcma: pci: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/bcma/host_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/bcma/host_pci.c +1 -1
@@ -270,7 +270,7 @@ static SIMPLE_DEV_PM_OPS(bcma_pm_ops, bcma_host_pci_suspend,#endif /* CONFIG_PM_SLEEP */ -static DEFINE_PCI_DEVICE_TABLE (bcma_pci_bridge_tbl) = { +static const struct pci_device_id bcma_pci_bridge_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_BROADCOM ,0x0576 ) }, {PCI_DEVICE (PCI_VENDOR_ID_BROADCOM ,0x4313 ) }, {PCI_DEVICE (PCI_VENDOR_ID_BROADCOM ,43224 ) },
Signature · 1 line
1.7.10.4
PATCH 3/39 block: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/block/mtip32xx/mtip32xx.c | 2 +- drivers/block/nvme-core.c | 2 +- drivers/block/rsxx/core.c | 2 +- drivers/block/skd_main.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-)
drivers/block/mtip32xx/mtip32xx.c +1 -1
@@ -4762,7 +4762,7 @@ static void mtip_pci_shutdown(struct pci_dev *pdev) }/* Table of device ids supported by this driver. */ -static DEFINE_PCI_DEVICE_TABLE (mtip_pci_tbl) = { +static const struct pci_device_id mtip_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_MICRON ,P320H_DEVICE_ID ) }, {PCI_DEVICE (PCI_VENDOR_ID_MICRON ,P320M_DEVICE_ID ) }, {PCI_DEVICE (PCI_VENDOR_ID_MICRON ,P320S_DEVICE_ID ) },
drivers/block/nvme-core.c +1 -1
@@ -2263,7 +2263,7 @@ static const struct pci_error_handlers nvme_err_handler = {/* Move to pci_ids.h later */ #define PCI_CLASS_STORAGE_EXPRESS 0x010802 -static DEFINE_PCI_DEVICE_TABLE (nvme_id_table) = { +static const struct pci_device_id nvme_id_table[] = { {PCI_DEVICE_CLASS (PCI_CLASS_STORAGE_EXPRESS ,0xffffff ) }, {0 , } };
drivers/block/rsxx/core.c +1 -1
@@ -1137,7 +1137,7 @@ static const struct pci_error_handlers rsxx_err_handler = { .slot_reset = rsxx_slot_reset, }; -static DEFINE_PCI_DEVICE_TABLE (rsxx_pci_ids) = { +static const struct pci_device_id rsxx_pci_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_IBM ,PCI_DEVICE_ID_FS70_FLASH )}, {PCI_DEVICE (PCI_VENDOR_ID_IBM ,PCI_DEVICE_ID_FS80_FLASH )}, {0 ,},
drivers/block/skd_main.c +1 -1
@@ -4788,7 +4788,7 @@ static const struct block_device_operations skd_blockdev_ops = {***************************************************************************** */ -static DEFINE_PCI_DEVICE_TABLE (skd_pci_tbl) = { +static const struct pci_device_id skd_pci_tbl[] = { {PCI_VENDOR_ID_STEC ,PCI_DEVICE_ID_S1120 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 , }, {0 }/* terminate list */
Signature · 1 line
1.7.10.4
PATCH 4/39 char: amd64-agp: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/char/agp/amd64-agp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/char/agp/amd64-agp.c +1 -1
@@ -735,7 +735,7 @@ static struct pci_device_id agp_amd64_pci_table[] = {MODULE_DEVICE_TABLE (pci, agp_amd64_pci_table); -static DEFINE_PCI_DEVICE_TABLE (agp_amd64_pci_promisc_table) = { +static const struct pci_device_id agp_amd64_pci_promisc_table[] = { {PCI_DEVICE_CLASS (0 ,0 ) }, { } };
Signature · 1 line
1.7.10.4
PATCH 5/39 cpufreq: nforce2: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/cpufreq/cpufreq-nforce2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpufreq/cpufreq-nforce2.c +1 -1
@@ -379,7 +379,7 @@ static struct cpufreq_driver nforce2_driver = { };#ifdef MODULE -static DEFINE_PCI_DEVICE_TABLE (nforce2_ids) = { +static const struct pci_device_id nforce2_ids[] = { {PCI_VENDOR_ID_NVIDIA ,PCI_DEVICE_ID_NVIDIA_NFORCE2 }, {} };
Signature · 1 line
1.7.10.4
Re: [PATCH 05/39] cpufreq: nforce2: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 13 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>--- drivers/cpufreq/cpufreq-nforce2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/cpufreq/cpufreq-nforce2.c +0
-0
drivers/cpufreq/cpufreq-nforce2.c static struct cpufreq_driver nforce2_driver = { · line 385
Quoted 8 lines
drivers/cpufreq/cpufreq-nforce2.c +1
-1@@ -379,7 +379,7 @@ static struct cpufreq_driver nforce2_driver = { };#ifdef MODULE -static DEFINE_PCI_DEVICE_TABLE (nforce2_ids) = { +static const struct pci_device_id nforce2_ids[] = { {PCI_VENDOR_ID_NVIDIA ,PCI_DEVICE_ID_NVIDIA_NFORCE2 }, {} };
PATCH 6/39 dma: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/dma/dw/pci.c | 2 +- drivers/dma/pch_dma.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/dma/dw/pci.c +1 -1
@@ -75,7 +75,7 @@ static void dw_pci_remove(struct pci_dev *pdev)dev_warn (&pdev->dev,"can't remove device properly: %d\n" , ret); } -static DEFINE_PCI_DEVICE_TABLE (dw_pci_id_table) = { +static const struct pci_device_id dw_pci_id_table[] = {/* Medfield */ {PCI_VDEVICE (INTEL ,0x0827 ), (kernel_ulong_t)&dw_pci_pdata }, {PCI_VDEVICE (INTEL ,0x0830 ), (kernel_ulong_t)&dw_pci_pdata },
drivers/dma/pch_dma.c +1 -1
@@ -996,7 +996,7 @@ static void pch_dma_remove(struct pci_dev *pdev)#define PCI_DEVICE_ID_ML7831_DMA1_8CH 0x8810#define PCI_DEVICE_ID_ML7831_DMA2_4CH 0x8815 -DEFINE_PCI_DEVICE_TABLE (pch_dma_id_table) = { +const struct pci_device_id pch_dma_id_table[] = { {PCI_VDEVICE (INTEL ,PCI_DEVICE_ID_EG20T_PCH_DMA_8CH ),8 }, {PCI_VDEVICE (INTEL ,PCI_DEVICE_ID_EG20T_PCH_DMA_4CH ),4 }, {PCI_VDEVICE (ROHM ,PCI_DEVICE_ID_ML7213_DMA1_8CH ),8 },/* UART Video */
Signature · 1 line
1.7.10.4
Joe Perches
maintainerRe: [PATCH 06/39] dma: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 2 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.
[]
drivers/dma/pch_dma.c
Quoted 1 line
drivers/dma/pch_dma.c +0
-0
[]
drivers/dma/pch_dma.c static void pch_dma_remove(struct pci_dev *pdev) · line 1002
Quoted 9 lines
drivers/dma/pch_dma.c +1
-1@@ -996,7 +996,7 @@ static void pch_dma_remove(struct pci_dev *pdev)#define PCI_DEVICE_ID_ML7831_DMA1_8CH 0x8810#define PCI_DEVICE_ID_ML7831_DMA2_4CH 0x8815 -DEFINE_PCI_DEVICE_TABLE (pch_dma_id_table) = { +const struct pci_device_id pch_dma_id_table[] = { {PCI_VDEVICE (INTEL ,PCI_DEVICE_ID_EG20T_PCH_DMA_8CH ),8 }, {PCI_VDEVICE (INTEL ,PCI_DEVICE_ID_EG20T_PCH_DMA_4CH ),4 }, {PCI_VDEVICE (ROHM ,PCI_DEVICE_ID_ML7213_DMA1_8CH ),8 },/* UART Video */
As you do these, please check/verify if the converted table should also be static and add it where appropriate.
$ git grep -w pch_dma_id_table
drivers/dma/pch_dma.c:DEFINE_PCI_DEVICE_TABLE(pch_dma_id_table) = {
drivers/dma/pch_dma.c: .id_table = pch_dma_id_table,
drivers/dma/pch_dma.c:MODULE_DEVICE_TABLE(pci, pch_dma_id_table);Re: [PATCH 06/39] dma: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to Jingoo HanQuoted 2 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.
I'm sorry, but Documentation/PCI/pci.txt still says "is the preferred method".
Is there any link to patch for Documentation and discussion why change is established?
Quoted 33 lines
Signed-off-by Jingoo Han <[email protected]>--- drivers/dma/dw/pci.c | 2 +- drivers/dma/pch_dma.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)drivers/dma/dw/pci.c +1
-1@@ -75,7 +75,7 @@ static void dw_pci_remove(struct pci_dev *pdev)dev_warn (&pdev->dev,"can't remove device properly: %d\n" , ret); } -static DEFINE_PCI_DEVICE_TABLE (dw_pci_id_table) = { +static const struct pci_device_id dw_pci_id_table[] = {/* Medfield */ {PCI_VDEVICE (INTEL ,0x0827 ), (kernel_ulong_t)&dw_pci_pdata }, {PCI_VDEVICE (INTEL ,0x0830 ), (kernel_ulong_t)&dw_pci_pdata },drivers/dma/pch_dma.c +1
-1@@ -996,7 +996,7 @@ static void pch_dma_remove(struct pci_dev *pdev)#define PCI_DEVICE_ID_ML7831_DMA1_8CH 0x8810#define PCI_DEVICE_ID_ML7831_DMA2_4CH 0x8815 -DEFINE_PCI_DEVICE_TABLE (pch_dma_id_table) = { +const struct pci_device_id pch_dma_id_table[] = { {PCI_VDEVICE (INTEL ,PCI_DEVICE_ID_EG20T_PCH_DMA_8CH ),8 }, {PCI_VDEVICE (INTEL ,PCI_DEVICE_ID_EG20T_PCH_DMA_4CH ),4 }, {PCI_VDEVICE (ROHM ,PCI_DEVICE_ID_ML7213_DMA1_8CH ),8 },/* UART Video */
Signature · 13 lines
Andy Shevchenko <[email protected]> Intel Finland Oy --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. ���{.n�+�������+%�����ݶ��w��{.n�+����{��G�����{ay�ʇڙ�,j��f���h��������z_�(�階�ݢj"���m������G������?����&���~��iO��z��v�^�m����������?�I�
Re: [PATCH 06/39] dma: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 9 lines · Andriy
Quoted 2 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.I'm sorry, but
Documentation/PCI/pci.txtstill says "is the preferred method".Is there any link to patch for Documentation and discussion why change is established?
(+cc Joe Perches, Jonas Bonn)
Since last week, there has been discussion about this. There is no special reason to use DEFINE_PCI_DEVICE_TABLE macro.
According to the Greg Kroah-Hartman,
"Yeah, and it's a horrid macro that deserves to be removed, please don't use it in more places."
Currently, there is no other bus that has something like this macro for their device ids. Thus, DEFINE_PCI_DEVICE_TABLE macro should be removed.
Jonas Bonn (author of DEFINE_PCI_DEVICE_TABLE macro) also agreed to remove this macro. According to Jonas Bonn, "Actually, I think I submitted an even uglier macro called DECLARE_PCI_DEVICE_TABLE... might have been the first kernel Patch I ever sent? In any case, it should certainly have been kindly rejected."
After Joe Perches's patch[1] is merged, I will send these patches to each subsystem maintainer.
[1][PATCH] pci/checkpatch: Deprecate DEFINE_PCI_DEVICE_TABLE
(http://lkml.org/lkml/2013/12/2/400)
In this patch, Joe Perches fixed 'Documentation/PCI/pci.txt', and 'scripts/checkpatch.pl', in order to guide to use 'struct pci_device_id' instead of 'DEFINE_PCI_DEVICE_TABLE' macro.
Thank you.
Best regards,
Jingoo Han
Best regards,
Jingoo Han
Re: [PATCH 06/39] dma: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 34 lines · Jingoo Han
Quoted 9 lines · Andriy
Quoted 2 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.I'm sorry, but
Documentation/PCI/pci.txtstill says "is the preferred method".Is there any link to patch for Documentation and discussion why change is established?
(+cc Joe Perches, Jonas Bonn)
Since last week, there has been discussion about this. There is no special reason to use
DEFINE_PCI_DEVICE_TABLEmacro.According to the Greg Kroah-Hartman,
"Yeah, and it's a horrid macro that deserves to be removed, please don't use it in more places."Currently, there is no other bus that has something like this macro for their device ids. Thus,
DEFINE_PCI_DEVICE_TABLEmacro should be removed.Jonas Bonn (author of
DEFINE_PCI_DEVICE_TABLEmacro) also agreed to remove this macro. According to Jonas Bonn, "Actually, I think I submitted an even uglier macro calledDECLARE_PCI_DEVICE_TABLE... might have been the first kernel Patch I ever sent? In any case, it should certainly have been kindly rejected."After Joe Perches's patch[1] is merged, I will send these patches to each subsystem maintainer.
Quoted 6 lines
[1][PATCH] pci/checkpatch: Deprecate
DEFINE_PCI_DEVICE_TABLE(http://lkml.org/lkml/2013/12/2/400)In this patch, Joe Perches fixed '
Documentation/PCI/pci.txt', and 'scripts/checkpatch.pl', in order to guide to use 'structpci_device_id' instead of 'DEFINE_PCI_DEVICE_TABLE' macro.
Thanks for the detailed explanation!
Thus, give you my
for drivers/dma/dw/ part.
Signature · 2 lines
Andy Shevchenko <[email protected]> Intel Finland Oy
PATCH 7/39 edac: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/edac/amd64_edac.c | 2 +- drivers/edac/amd76x_edac.c | 2 +- drivers/edac/e752x_edac.c | 2 +- drivers/edac/e7xxx_edac.c | 2 +- drivers/edac/i3000_edac.c | 2 +- drivers/edac/i3200_edac.c | 2 +- drivers/edac/i5000_edac.c | 2 +- drivers/edac/i5100_edac.c | 2 +- drivers/edac/i5400_edac.c | 2 +- drivers/edac/i7300_edac.c | 2 +- drivers/edac/i7core_edac.c | 2 +- drivers/edac/i82443bxgx_edac.c | 2 +- drivers/edac/i82860_edac.c | 2 +- drivers/edac/i82875p_edac.c | 2 +- drivers/edac/i82975x_edac.c | 2 +- drivers/edac/r82600_edac.c | 2 +- drivers/edac/sb_edac.c | 2 +- drivers/edac/x38_edac.c | 2 +- 18 files changed, 18 insertions(+), 18 deletions(-)
drivers/edac/amd64_edac.c +1 -1
@@ -2795,7 +2795,7 @@ static void amd64_remove_one_instance(struct pci_dev *pdev)* PCI core identifies what devices are on a system during boot, and then * inquiry this table to see if this driver is for a given device found. */ -static DEFINE_PCI_DEVICE_TABLE (amd64_pci_table) = { +static const struct pci_device_id amd64_pci_table[] = { { .vendor =PCI_VENDOR_ID_AMD , .device =PCI_DEVICE_ID_AMD_K8_NB_MEMCTL ,
drivers/edac/amd76x_edac.c +1 -1
@@ -333,7 +333,7 @@ static void amd76x_remove_one(struct pci_dev *pdev)edac_mc_free (mci); } -static DEFINE_PCI_DEVICE_TABLE (amd76x_pci_tbl) = { +static const struct pci_device_id amd76x_pci_tbl[] = { {PCI_VEND_DEV (AMD ,FE_GATE_700C ),PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,AMD762 },
drivers/edac/e752x_edac.c +1 -1
@@ -1421,7 +1421,7 @@ static void e752x_remove_one(struct pci_dev *pdev)edac_mc_free (mci); } -static DEFINE_PCI_DEVICE_TABLE (e752x_pci_tbl) = { +static const struct pci_device_id e752x_pci_tbl[] = { { PCI_VEND_DEV(INTEL, 7520_0), PCI_ANY_ID, PCI_ANY_ID, 0, 0,E7520 },
drivers/edac/e7xxx_edac.c +1 -1
@@ -555,7 +555,7 @@ static void e7xxx_remove_one(struct pci_dev *pdev)edac_mc_free (mci); } -static DEFINE_PCI_DEVICE_TABLE (e7xxx_pci_tbl) = { +static const struct pci_device_id e7xxx_pci_tbl[] = { { PCI_VEND_DEV(INTEL, 7205_0), PCI_ANY_ID, PCI_ANY_ID, 0, 0,E7205 },
drivers/edac/i3000_edac.c +1 -1
@@ -487,7 +487,7 @@ static void i3000_remove_one(struct pci_dev *pdev)edac_mc_free (mci); } -static DEFINE_PCI_DEVICE_TABLE (i3000_pci_tbl) = { +static const struct pci_device_id i3000_pci_tbl[] = { { PCI_VEND_DEV(INTEL, 3000_HB), PCI_ANY_ID, PCI_ANY_ID, 0, 0,I3000 },
drivers/edac/i3200_edac.c +1 -1
@@ -466,7 +466,7 @@ static void i3200_remove_one(struct pci_dev *pdev)edac_mc_free (mci); } -static DEFINE_PCI_DEVICE_TABLE (i3200_pci_tbl) = { +static const struct pci_device_id i3200_pci_tbl[] = { { PCI_VEND_DEV(INTEL, 3200_HB), PCI_ANY_ID, PCI_ANY_ID, 0, 0,I3200 },
drivers/edac/i5000_edac.c +1 -1
@@ -1530,7 +1530,7 @@ static void i5000_remove_one(struct pci_dev *pdev)* * The "E500P" device is the first device supported. */ -static DEFINE_PCI_DEVICE_TABLE (i5000_pci_tbl) = { +static const struct pci_device_id i5000_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_I5000_DEV16 ), .driver_data =I5000P },
drivers/edac/i5100_edac.c +1 -1
@@ -1213,7 +1213,7 @@ static void i5100_remove_one(struct pci_dev *pdev)edac_mc_free (mci); } -static DEFINE_PCI_DEVICE_TABLE (i5100_pci_tbl) = { +static const struct pci_device_id i5100_pci_tbl[] = {/* Device 16, Function 0, Channel 0 Memory Map, Error Flag/Mask, ... */ {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_5100_16 ) }, {0 , }
drivers/edac/i5400_edac.c +1 -1
@@ -1416,7 +1416,7 @@ static void i5400_remove_one(struct pci_dev *pdev)* * The "E500P" device is the first device supported. */ -static DEFINE_PCI_DEVICE_TABLE (i5400_pci_tbl) = { +static const struct pci_device_id i5400_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_5400_ERR )}, {0 ,}/* 0 terminated list. */ };
drivers/edac/i7300_edac.c +1 -1
@@ -1160,7 +1160,7 @@ static void i7300_remove_one(struct pci_dev *pdev)* * Has only 8086:360c PCI ID */ -static DEFINE_PCI_DEVICE_TABLE (i7300_pci_tbl) = { +static const struct pci_device_id i7300_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_I7300_MCH_ERR )}, {0 ,}/* 0 terminated list. */ };
drivers/edac/i7core_edac.c +1 -1
@@ -394,7 +394,7 @@ static const struct pci_id_table pci_dev_table[] = {/* * pci_device_id table for which devices we are looking for */ -static DEFINE_PCI_DEVICE_TABLE (i7core_pci_tbl) = { +static const struct pci_device_id i7core_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_X58_HUB_MGMT )}, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_LYNNFIELD_QPI_LINK0 )}, {0 ,}/* 0 terminated list. */
drivers/edac/i82443bxgx_edac.c +1 -1
@@ -386,7 +386,7 @@ static void i82443bxgx_edacmc_remove_one(struct pci_dev *pdev)EXPORT_SYMBOL_GPL (i82443bxgx_edacmc_remove_one); -static DEFINE_PCI_DEVICE_TABLE (i82443bxgx_pci_tbl) = { +static const struct pci_device_id i82443bxgx_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_82443BX_0 )}, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_82443BX_2 )}, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_82443GX_0 )},
drivers/edac/i82860_edac.c +1 -1
@@ -288,7 +288,7 @@ static void i82860_remove_one(struct pci_dev *pdev)edac_mc_free (mci); } -static DEFINE_PCI_DEVICE_TABLE (i82860_pci_tbl) = { +static const struct pci_device_id i82860_pci_tbl[] = { { PCI_VEND_DEV(INTEL, 82860_0), PCI_ANY_ID, PCI_ANY_ID, 0, 0,I82860 },
drivers/edac/i82875p_edac.c +1 -1
@@ -527,7 +527,7 @@ static void i82875p_remove_one(struct pci_dev *pdev)edac_mc_free (mci); } -static DEFINE_PCI_DEVICE_TABLE (i82875p_pci_tbl) = { +static const struct pci_device_id i82875p_pci_tbl[] = { { PCI_VEND_DEV(INTEL, 82875_0), PCI_ANY_ID, PCI_ANY_ID, 0, 0,I82875P },
drivers/edac/i82975x_edac.c +1 -1
@@ -628,7 +628,7 @@ static void i82975x_remove_one(struct pci_dev *pdev)edac_mc_free (mci); } -static DEFINE_PCI_DEVICE_TABLE (i82975x_pci_tbl) = { +static const struct pci_device_id i82975x_pci_tbl[] = { { PCI_VEND_DEV(INTEL, 82975_0), PCI_ANY_ID, PCI_ANY_ID, 0, 0,I82975X
drivers/edac/r82600_edac.c +1 -1
@@ -383,7 +383,7 @@ static void r82600_remove_one(struct pci_dev *pdev)edac_mc_free (mci); } -static DEFINE_PCI_DEVICE_TABLE (r82600_pci_tbl) = { +static const struct pci_device_id r82600_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_RADISYS ,R82600_BRIDGE_ID ) },
drivers/edac/sb_edac.c +1 -1
@@ -461,7 +461,7 @@ static const struct pci_id_table pci_dev_descr_ibridge_table[] = {/* * pci_device_id table for which devices we are looking for */ -static DEFINE_PCI_DEVICE_TABLE (sbridge_pci_tbl) = { +static const struct pci_device_id sbridge_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_SBRIDGE_IMC_TA )}, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_IBRIDGE_IMC_HA0_TA )}, {0 ,}/* 0 terminated list. */
drivers/edac/x38_edac.c +1 -1
@@ -448,7 +448,7 @@ static void x38_remove_one(struct pci_dev *pdev)edac_mc_free (mci); } -static DEFINE_PCI_DEVICE_TABLE (x38_pci_tbl) = { +static const struct pci_device_id x38_pci_tbl[] = { {PCI_VEND_DEV (INTEL ,X38_HB ),PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,X38 },
Signature · 1 line
1.7.10.4
Borislav Petkov
maintainerRe: [PATCH 07/39] edac: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 2 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.
Says who and why?
The author of the commit message (that is you) should explain to the onlooker (that is me) why this patch needs to be applied.
Thanks.
Signature · 5 lines
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--Re: [PATCH 07/39] edac: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 8 lines · Borislav Petkov
Quoted 2 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Says who and why?
The author of the commit message (that is you) should explain to the onlooker (that is me) why this patch needs to be applied.
(+cc Joe Perches, Bjorn Helgaas)
Hi Borislav Petkov,
According to the Greg Kroah-Hartman,
"Yeah, and it's a horrid macro that deserves to be removed, please don't use it in more places."
Currently, there is no other bus that has something like this macro for their device ids. Thus, DEFINE_PCI_DEVICE_TABLE macro should be removed.
I hope that these patches will be merged through Greg Kroah-Hartman's 'driver-core.git', with 'Acked-by' of each subsystem maintainer.
Best regards,
Jingoo Han
Re: [PATCH 07/39] edac: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to Jingoo HanQuoted 4 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>
Applied, thanks.
Signature · 5 lines
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--PATCH 8/39 gpio: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/gpio/gpio-amd8111.c | 2 +- drivers/gpio/gpio-bt8xx.c | 2 +- drivers/gpio/gpio-intel-mid.c | 2 +- drivers/gpio/gpio-ml-ioh.c | 2 +- drivers/gpio/gpio-pch.c | 2 +- drivers/gpio/gpio-sodaville.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)
drivers/gpio/gpio-amd8111.c +1 -1
@@ -60,7 +60,7 @@* register a pci_driver, because someone else might one day * want to register another driver on the same PCI id. */ -static DEFINE_PCI_DEVICE_TABLE (pci_tbl) = { +static const struct pci_device_id pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_AMD ,PCI_DEVICE_ID_AMD_8111_SMBUS ),0 }, {0 , },/* terminate list */ };
drivers/gpio/gpio-bt8xx.c +1 -1
@@ -308,7 +308,7 @@ static int bt8xxgpio_resume(struct pci_dev *pdev)#define bt8xxgpio_resume NULL#endif /* CONFIG_PM */ -static DEFINE_PCI_DEVICE_TABLE (bt8xxgpio_pci_tbl) = { +static const struct pci_device_id bt8xxgpio_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_BROOKTREE ,PCI_DEVICE_ID_BT848 ) }, {PCI_DEVICE (PCI_VENDOR_ID_BROOKTREE ,PCI_DEVICE_ID_BT849 ) }, {PCI_DEVICE (PCI_VENDOR_ID_BROOKTREE ,PCI_DEVICE_ID_BT878 ) },
drivers/gpio/gpio-intel-mid.c +1 -1
@@ -275,7 +275,7 @@ static const struct intel_mid_gpio_ddata gpio_tangier = { .chip_irq_type = INTEL_MID_IRQ_TYPE_EDGE, }; -static DEFINE_PCI_DEVICE_TABLE (intel_gpio_ids) = { +static const struct pci_device_id intel_gpio_ids[] = { {/* Lincroft */ PCI_DEVICE (PCI_VENDOR_ID_INTEL ,0x080f ),
drivers/gpio/gpio-ml-ioh.c +1 -1
@@ -596,7 +596,7 @@ static int ioh_gpio_resume(struct pci_dev *pdev)#define ioh_gpio_resume NULL#endif -static DEFINE_PCI_DEVICE_TABLE (ioh_gpio_pcidev_id) = { +static const struct pci_device_id ioh_gpio_pcidev_id[] = { {PCI_DEVICE (PCI_VENDOR_ID_ROHM ,0x802E ) }, {0 , } };
drivers/gpio/gpio-pch.c +1 -1
@@ -518,7 +518,7 @@ static int pch_gpio_resume(struct pci_dev *pdev)#endif #define PCI_VENDOR_ID_ROHM 0x10DB -static DEFINE_PCI_DEVICE_TABLE (pch_gpio_pcidev_id) = { +static const struct pci_device_id pch_gpio_pcidev_id[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,0x8803 ) }, {PCI_DEVICE (PCI_VENDOR_ID_ROHM ,0x8014 ) }, {PCI_DEVICE (PCI_VENDOR_ID_ROHM ,0x8043 ) },
drivers/gpio/gpio-sodaville.c +1 -1
@@ -270,7 +270,7 @@ static void sdv_gpio_remove(struct pci_dev *pdev)kfree (sd); } -static DEFINE_PCI_DEVICE_TABLE (sdv_gpio_pci_ids) = { +static const struct pci_device_id sdv_gpio_pci_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_SDV_GPIO ) }, {0 , }, };
Signature · 1 line
1.7.10.4
Re: [PATCH 08/39] gpio: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 4 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>
Patch applied to the GPIO tree.
Yours,
Linus Walleij
PATCH 9/39 drm: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/gpu/drm/ast/ast_drv.c | 2 +- drivers/gpu/drm/cirrus/cirrus_drv.c | 2 +- drivers/gpu/drm/gma500/oaktrail_hdmi.c | 2 +- drivers/gpu/drm/gma500/psb_drv.c | 2 +- drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +- drivers/gpu/drm/qxl/qxl_drv.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/ast/ast_drv.c +1 -1
@@ -51,7 +51,7 @@ static struct drm_driver driver; .subdevice = PCI_ANY_ID, \ .driver_data = (unsigned long) info } -static DEFINE_PCI_DEVICE_TABLE (pciidlist) = { +static const struct pci_device_id pciidlist[] = {AST_VGA_DEVICE (PCI_CHIP_AST2000 ,NULL ),AST_VGA_DEVICE (PCI_CHIP_AST2100 ,NULL ),/* AST_VGA_DEVICE(PCI_CHIP_AST1180, NULL), - don't bind to 1180 for now */
drivers/gpu/drm/cirrus/cirrus_drv.c +1 -1
@@ -28,7 +28,7 @@ module_param_named(modeset, cirrus_modeset, int, 0400);static struct drm_driver driver;/* only bind to the cirrus chip in qemu */ -static DEFINE_PCI_DEVICE_TABLE (pciidlist) = { +static const struct pci_device_id pciidlist[] = { {PCI_VENDOR_ID_CIRRUS ,PCI_DEVICE_ID_CIRRUS_5446 ,0x1af4 ,0x1100 ,0 ,0 ,0 }, {0 ,}
drivers/gpu/drm/gma500/oaktrail_hdmi.c +1 -1
@@ -681,7 +681,7 @@ failed_connector:kfree (gma_encoder); } -static DEFINE_PCI_DEVICE_TABLE (hdmi_ids) = { +static const struct pci_device_id hdmi_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,0x080d ) }, {0 } };
drivers/gpu/drm/gma500/psb_drv.c +1 -1
@@ -45,7 +45,7 @@ MODULE_PARM_DESC(trap_pagefaults, "Error and reset on MMU pagefaults");module_param_named (trap_pagefaults, drm_psb_trap_pagefaults, int,0600 ); -static DEFINE_PCI_DEVICE_TABLE (pciidlist) = { +static const struct pci_device_id pciidlist[] = { {0x8086 ,0x8108 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 , (long ) &psb_chip_ops }, {0x8086 ,0x8109 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 , (long ) &psb_chip_ops }, #if defined(CONFIG_DRM_GMA600)
drivers/gpu/drm/mgag200/mgag200_drv.c +1 -1
@@ -28,7 +28,7 @@ module_param_named(modeset, mgag200_modeset, int, 0400);static struct drm_driver driver; -static DEFINE_PCI_DEVICE_TABLE (pciidlist) = { +static const struct pci_device_id pciidlist[] = { {PCI_VENDOR_ID_MATROX ,0x522 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,G200_SE_A }, {PCI_VENDOR_ID_MATROX ,0x524 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,G200_SE_B }, {PCI_VENDOR_ID_MATROX ,0x530 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,G200_EV },
drivers/gpu/drm/qxl/qxl_drv.c +1 -1
@@ -38,7 +38,7 @@#include "qxl_object.h" extern int qxl_max_ioctls; -static DEFINE_PCI_DEVICE_TABLE (pciidlist) = { +static const struct pci_device_id pciidlist[] = { {0x1b36 ,0x100 ,PCI_ANY_ID ,PCI_ANY_ID ,PCI_CLASS_DISPLAY_VGA <<8 ,0xffff00 ,0 }, {0x1b36 ,0x100 ,PCI_ANY_ID ,PCI_ANY_ID ,PCI_CLASS_DISPLAY_OTHER <<8 ,
Signature · 1 line
1.7.10.4
PATCH 10/39 hwmon: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/hwmon/fam15h_power.c | 2 +- drivers/hwmon/k10temp.c | 2 +- drivers/hwmon/k8temp.c | 2 +- drivers/hwmon/sis5595.c | 2 +- drivers/hwmon/via686a.c | 2 +- drivers/hwmon/vt8231.c | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-)
drivers/hwmon/fam15h_power.c +1 -1
@@ -249,7 +249,7 @@ static void fam15h_power_remove(struct pci_dev *pdev)sysfs_remove_group (&dev->kobj, &fam15h_power_attr_group); } -static DEFINE_PCI_DEVICE_TABLE (fam15h_power_id_table) = { +static const struct pci_device_id fam15h_power_id_table[] = { {PCI_VDEVICE (AMD ,PCI_DEVICE_ID_AMD_15H_NB_F4 ) }, {PCI_VDEVICE (AMD ,PCI_DEVICE_ID_AMD_16H_NB_F4 ) }, {}
drivers/hwmon/k10temp.c +1 -1
@@ -204,7 +204,7 @@ static void k10temp_remove(struct pci_dev *pdev) &sensor_dev_attr_temp1_crit_hyst.dev_attr); } -static DEFINE_PCI_DEVICE_TABLE (k10temp_id_table) = { +static const struct pci_device_id k10temp_id_table[] = { {PCI_VDEVICE (AMD ,PCI_DEVICE_ID_AMD_10H_NB_MISC ) }, {PCI_VDEVICE (AMD ,PCI_DEVICE_ID_AMD_11H_NB_MISC ) }, {PCI_VDEVICE (AMD ,PCI_DEVICE_ID_AMD_CNB17H_F3 ) },
drivers/hwmon/k8temp.c +1 -1
@@ -135,7 +135,7 @@ static SENSOR_DEVICE_ATTR_2(temp3_input, S_IRUGO, show_temp, NULL, 1, 0); static SENSOR_DEVICE_ATTR_2(temp4_input, S_IRUGO, show_temp, NULL, 1, 1); static DEVICE_ATTR(name, S_IRUGO, show_name, NULL); -static DEFINE_PCI_DEVICE_TABLE (k8temp_ids) = { +static const struct pci_device_id k8temp_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_AMD ,PCI_DEVICE_ID_AMD_K8_NB_MISC ) }, {0 }, };
drivers/hwmon/sis5595.c +1 -1
@@ -752,7 +752,7 @@ static struct sis5595_data *sis5595_update_device(struct device *dev)return data; } -static DEFINE_PCI_DEVICE_TABLE (sis5595_pci_ids) = { +static const struct pci_device_id sis5595_pci_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_SI ,PCI_DEVICE_ID_SI_503 ) }, {0 , } };
drivers/hwmon/via686a.c +1 -1
@@ -824,7 +824,7 @@ static struct via686a_data *via686a_update_device(struct device *dev)return data; } -static DEFINE_PCI_DEVICE_TABLE (via686a_pci_ids) = { +static const struct pci_device_id via686a_pci_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C686_4 ) }, { } };
drivers/hwmon/vt8231.c +1 -1
@@ -766,7 +766,7 @@ static struct platform_driver vt8231_driver = { .remove = vt8231_remove, }; -static DEFINE_PCI_DEVICE_TABLE (vt8231_pci_ids) = { +static const struct pci_device_id vt8231_pci_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_8231_4 ) }, {0 , } };
Signature · 8 lines
1.7.10.4 _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Re: [PATCH 10/39] hwmon: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 4 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Jean Delvare
Acked-byRe: [PATCH 10/39] hwmon: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 7 lines · Guenter Roeck
Quoted 4 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>Acked-by Guenter Roeck <[email protected]>
too. I never liked this macro and I'm very happy to see it go.
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Guenter Roeck
maintainerRe: [PATCH 10/39] hwmon: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 5 lines · Jean Delvare
Quoted 4 lines · Guenter Roeck
Quoted 3 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.
Quoted 8 lines
Quoted 3 lines
Quoted 1 line
Signed-off-by Jingoo Han <[email protected]>Acked-by Guenter Roeck <[email protected]>Acked-by Jean Delvare <[email protected]>too. I never liked this macro and I'm very happy to see it go.
Same here. I'll take it through my -next tree.
Thanks,
Guenter
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Re: [PATCH 10/39] hwmon: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to Jingoo HanQuoted 4 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>
Applied to hwmon-next
Guenter
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
PATCH 11/39 i2c: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/i2c/busses/i2c-ali1535.c | 2 +- drivers/i2c/busses/i2c-ali1563.c | 2 +- drivers/i2c/busses/i2c-ali15x3.c | 2 +- drivers/i2c/busses/i2c-amd756.c | 2 +- drivers/i2c/busses/i2c-amd8111.c | 2 +- drivers/i2c/busses/i2c-designware-pcidrv.c | 2 +- drivers/i2c/busses/i2c-eg20t.c | 2 +- drivers/i2c/busses/i2c-hydra.c | 2 +- drivers/i2c/busses/i2c-i801.c | 2 +- drivers/i2c/busses/i2c-ismt.c | 2 +- drivers/i2c/busses/i2c-nforce2.c | 2 +- drivers/i2c/busses/i2c-pasemi.c | 2 +- drivers/i2c/busses/i2c-piix4.c | 2 +- drivers/i2c/busses/i2c-pxa-pci.c | 2 +- drivers/i2c/busses/i2c-sis5595.c | 2 +- drivers/i2c/busses/i2c-sis630.c | 2 +- drivers/i2c/busses/i2c-sis96x.c | 2 +- drivers/i2c/busses/i2c-via.c | 2 +- drivers/i2c/busses/i2c-viapro.c | 2 +- drivers/i2c/busses/scx200_acb.c | 2 +- 20 files changed, 20 insertions(+), 20 deletions(-)
drivers/i2c/busses/i2c-ali1535.c +1 -1
@@ -495,7 +495,7 @@ static struct i2c_adapter ali1535_adapter = { .algo = &smbus_algorithm, }; -static DEFINE_PCI_DEVICE_TABLE (ali1535_ids) = { +static const struct pci_device_id ali1535_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_AL ,PCI_DEVICE_ID_AL_M7101 ) }, { }, };
drivers/i2c/busses/i2c-ali1563.c +1 -1
@@ -417,7 +417,7 @@ static void ali1563_remove(struct pci_dev *dev)ali1563_shutdown (dev); } -static DEFINE_PCI_DEVICE_TABLE (ali1563_id_table) = { +static const struct pci_device_id ali1563_id_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_AL ,PCI_DEVICE_ID_AL_M1563 ) }, {}, };
drivers/i2c/busses/i2c-ali15x3.c +1 -1
@@ -477,7 +477,7 @@ static struct i2c_adapter ali15x3_adapter = { .algo = &smbus_algorithm, }; -static DEFINE_PCI_DEVICE_TABLE (ali15x3_ids) = { +static const struct pci_device_id ali15x3_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_AL ,PCI_DEVICE_ID_AL_M7101 ) }, {0 , } };
drivers/i2c/busses/i2c-amd756.c +1 -1
@@ -308,7 +308,7 @@ static const char* chipname[] = { "nVidia nForce", "AMD8111", }; -static DEFINE_PCI_DEVICE_TABLE (amd756_ids) = { +static const struct pci_device_id amd756_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_AMD ,PCI_DEVICE_ID_AMD_VIPER_740B ), .driver_data =AMD756 }, {PCI_DEVICE (PCI_VENDOR_ID_AMD ,PCI_DEVICE_ID_AMD_VIPER_7413 ),
drivers/i2c/busses/i2c-amd8111.c +1 -1
@@ -415,7 +415,7 @@ static const struct i2c_algorithm smbus_algorithm = { }; -static DEFINE_PCI_DEVICE_TABLE (amd8111_ids) = { +static const struct pci_device_id amd8111_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_AMD ,PCI_DEVICE_ID_AMD_8111_SMBUS2 ) }, {0 , } };
drivers/i2c/busses/i2c-designware-pcidrv.c +1 -1
@@ -309,7 +309,7 @@ static void i2c_dw_pci_remove(struct pci_dev *pdev)/* work with hotplug and coldplug */ MODULE_ALIAS ("i2c_designware-pci" ); -static DEFINE_PCI_DEVICE_TABLE (i2_designware_pci_ids) = { +static const struct pci_device_id i2_designware_pci_ids[] = {/* Moorestown */ {PCI_VDEVICE (INTEL ,0x0802 ), moorestown_0 }, {PCI_VDEVICE (INTEL ,0x0803 ), moorestown_1 },
drivers/i2c/busses/i2c-eg20t.c +1 -1
@@ -187,7 +187,7 @@ static DEFINE_MUTEX(pch_mutex);#define PCI_DEVICE_ID_ML7223_I2C 0x8010#define PCI_DEVICE_ID_ML7831_I2C 0x8817 -static DEFINE_PCI_DEVICE_TABLE (pch_pcidev_id) = { +static const struct pci_device_id pch_pcidev_id[] = { {PCI_VDEVICE (INTEL ,PCI_DEVICE_ID_PCH_I2C ),1 , }, {PCI_VDEVICE (ROHM ,PCI_DEVICE_ID_ML7213_I2C ),2 , }, {PCI_VDEVICE (ROHM ,PCI_DEVICE_ID_ML7223_I2C ),1 , },
drivers/i2c/busses/i2c-hydra.c +1 -1
@@ -105,7 +105,7 @@ static struct i2c_adapter hydra_adap = { .algo_data = &hydra_bit_data, }; -static DEFINE_PCI_DEVICE_TABLE (hydra_ids) = { +static const struct pci_device_id hydra_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_APPLE ,PCI_DEVICE_ID_APPLE_HYDRA ) }, {0 , } };
drivers/i2c/busses/i2c-i801.c +1 -1
@@ -789,7 +789,7 @@ static const struct i2c_algorithm smbus_algorithm = { .functionality = i801_func, }; -static DEFINE_PCI_DEVICE_TABLE (i801_ids) = { +static const struct pci_device_id i801_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_82801AA_3 ) }, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_82801AB_3 ) }, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_82801BA_2 ) },
drivers/i2c/busses/i2c-ismt.c +1 -1
@@ -183,7 +183,7 @@ struct ismt_priv {/** * ismt_ids - PCI device IDs supported by this driver */ -static DEFINE_PCI_DEVICE_TABLE (ismt_ids) = { +static const struct pci_device_id ismt_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_S1200_SMT0 ) }, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_S1200_SMT1 ) }, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_AVOTON_SMT ) },
drivers/i2c/busses/i2c-nforce2.c +1 -1
@@ -307,7 +307,7 @@ static struct i2c_algorithm smbus_algorithm = { }; -static DEFINE_PCI_DEVICE_TABLE (nforce2_ids) = { +static const struct pci_device_id nforce2_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_NVIDIA ,PCI_DEVICE_ID_NVIDIA_NFORCE2_SMBUS ) }, {PCI_DEVICE (PCI_VENDOR_ID_NVIDIA ,PCI_DEVICE_ID_NVIDIA_NFORCE2S_SMBUS ) }, {PCI_DEVICE (PCI_VENDOR_ID_NVIDIA ,PCI_DEVICE_ID_NVIDIA_NFORCE3_SMBUS ) },
drivers/i2c/busses/i2c-pasemi.c +1 -1
@@ -401,7 +401,7 @@ static void pasemi_smb_remove(struct pci_dev *dev)kfree (smbus); } -static DEFINE_PCI_DEVICE_TABLE (pasemi_smb_ids) = { +static const struct pci_device_id pasemi_smb_ids[] = { {PCI_DEVICE (0x1959 ,0xa003 ) }, {0 , } };
drivers/i2c/busses/i2c-piix4.c +1 -1
@@ -522,7 +522,7 @@ static const struct i2c_algorithm smbus_algorithm = { .functionality = piix4_func, }; -static DEFINE_PCI_DEVICE_TABLE (piix4_ids) = { +static const struct pci_device_id piix4_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_82371AB_3 ) }, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_82443MX_3 ) }, {PCI_DEVICE (PCI_VENDOR_ID_EFAR ,PCI_DEVICE_ID_EFAR_SLC90E66_3 ) },
drivers/i2c/busses/i2c-pxa-pci.c +1 -1
@@ -148,7 +148,7 @@ static void ce4100_i2c_remove(struct pci_dev *dev)kfree (sds); } -static DEFINE_PCI_DEVICE_TABLE (ce4100_i2c_devices) = { +static const struct pci_device_id ce4100_i2c_devices[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,0x2e68 )}, { }, };
drivers/i2c/busses/i2c-sis5595.c +1 -1
@@ -369,7 +369,7 @@ static struct i2c_adapter sis5595_adapter = { .algo = &smbus_algorithm, }; -static DEFINE_PCI_DEVICE_TABLE (sis5595_ids) = { +static const struct pci_device_id sis5595_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_SI ,PCI_DEVICE_ID_SI_503 ) }, {0 , } };
drivers/i2c/busses/i2c-sis630.c +1 -1
@@ -511,7 +511,7 @@ static struct i2c_adapter sis630_adapter = { .retries = 3 }; -static DEFINE_PCI_DEVICE_TABLE (sis630_ids) = { +static const struct pci_device_id sis630_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_SI ,PCI_DEVICE_ID_SI_503 ) }, {PCI_DEVICE (PCI_VENDOR_ID_SI ,PCI_DEVICE_ID_SI_LPC ) }, {PCI_DEVICE (PCI_VENDOR_ID_SI ,PCI_DEVICE_ID_SI_964 ) },
drivers/i2c/busses/i2c-sis96x.c +1 -1
@@ -245,7 +245,7 @@ static struct i2c_adapter sis96x_adapter = { .algo = &smbus_algorithm, }; -static DEFINE_PCI_DEVICE_TABLE (sis96x_ids) = { +static const struct pci_device_id sis96x_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_SI ,PCI_DEVICE_ID_SI_SMBUS ) }, {0 , } };
drivers/i2c/busses/i2c-via.c +1 -1
@@ -89,7 +89,7 @@ static struct i2c_adapter vt586b_adapter = { }; -static DEFINE_PCI_DEVICE_TABLE (vt586b_ids) = { +static const struct pci_device_id vt586b_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C586_3 ) }, {0 , } };
drivers/i2c/busses/i2c-viapro.c +1 -1
@@ -442,7 +442,7 @@ release_region:return error; } -static DEFINE_PCI_DEVICE_TABLE (vt596_ids) = { +static const struct pci_device_id vt596_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C596_3 ), .driver_data =SMBBA1 }, {PCI_DEVICE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_82C596B_3 ),
drivers/i2c/busses/scx200_acb.c +1 -1
@@ -556,7 +556,7 @@ static struct platform_driver scx200_pci_driver = { .remove = scx200_remove, }; -static DEFINE_PCI_DEVICE_TABLE (scx200_isa) = { +static const struct pci_device_id scx200_isa[] = { {PCI_DEVICE (PCI_VENDOR_ID_NS , PCI_DEVICE_ID_NS_SCx200_BRIDGE) }, {PCI_DEVICE (PCI_VENDOR_ID_NS ,PCI_DEVICE_ID_NS_SC1100_BRIDGE ) }, {0 , }
Signature · 1 line
1.7.10.4
PATCH 12/39 IB: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/infiniband/hw/mlx5/main.c | 2 +- drivers/infiniband/hw/qib/qib_init.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/infiniband/hw/mlx5/main.c +1 -1
@@ -1484,7 +1484,7 @@ static void remove_one(struct pci_dev *pdev)ib_dealloc_device (&dev->ib_dev); } -static DEFINE_PCI_DEVICE_TABLE (mlx5_ib_pci_table) = { +static const struct pci_device_id mlx5_ib_pci_table[] = { {PCI_VDEVICE (MELLANOX ,4113 ) },/* MT4113 Connect-IB */ {0 , } };
drivers/infiniband/hw/qib/qib_init.c +1 -1
@@ -1184,7 +1184,7 @@ static int qib_init_one(struct pci_dev *, const struct pci_device_id *);#define DRIVER_LOAD_MSG "Intel " QIB_DRV_NAME " loaded: "#define PFX QIB_DRV_NAME ": " -static DEFINE_PCI_DEVICE_TABLE (qib_pci_tbl) = { +static const struct pci_device_id qib_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_PATHSCALE ,PCI_DEVICE_ID_QLOGIC_IB_6120 ) }, {PCI_DEVICE (PCI_VENDOR_ID_QLOGIC ,PCI_DEVICE_ID_QLOGIC_IB_7220 ) }, {PCI_DEVICE (PCI_VENDOR_ID_QLOGIC ,PCI_DEVICE_ID_QLOGIC_IB_7322 ) },
Signature · 7 lines
1.7.10.4 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
PATCH 13/39 ipack: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/ipack/carriers/tpci200.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ipack/carriers/tpci200.c +1 -1
@@ -618,7 +618,7 @@ static void tpci200_pci_remove(struct pci_dev *dev)__tpci200_pci_remove (tpci200); } -static DEFINE_PCI_DEVICE_TABLE (tpci200_idtable) = { +static const struct pci_device_id tpci200_idtable[] = { {TPCI200_VENDOR_ID ,TPCI200_DEVICE_ID ,TPCI200_SUBVENDOR_ID ,TPCI200_SUBDEVICE_ID }, {0 , },
Signature · 1 line
1.7.10.4
PATCH 14/39 leds: leds-ss4200: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/leds/leds-ss4200.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/leds/leds-ss4200.c +1 -1
@@ -63,7 +63,7 @@ MODULE_LICENSE("GPL");/* * PCI ID of the Intel ICH7 LPC Device within which the GPIO block lives. */ -static DEFINE_PCI_DEVICE_TABLE (ich7_lpc_pci_id) = { +static const struct pci_device_id ich7_lpc_pci_id[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_ICH7_0 ) }, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_ICH7_1 ) }, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_ICH7_30 ) },
Signature · 1 line
1.7.10.4
PATCH 15/39 media: pci: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/media/pci/cx25821/cx25821-alsa.c | 2 +- drivers/media/pci/cx25821/cx25821-core.c | 2 +- drivers/media/pci/sta2x11/sta2x11_vip.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/media/pci/cx25821/cx25821-alsa.c +1 -1
@@ -618,7 +618,7 @@ static int snd_cx25821_pcm(struct cx25821_audio_dev *chip, int device,* Only boards with eeprom and byte 1 at eeprom=1 have it */ -static DEFINE_PCI_DEVICE_TABLE (cx25821_audio_pci_tbl) = { +static const struct pci_device_id cx25821_audio_pci_tbl[] = { {0x14f1 ,0x0920 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 }, {0 ,} };
drivers/media/pci/cx25821/cx25821-core.c +1 -1
@@ -1361,7 +1361,7 @@ static void cx25821_finidev(struct pci_dev *pci_dev)kfree (dev); } -static DEFINE_PCI_DEVICE_TABLE (cx25821_pci_tbl) = { +static const struct pci_device_id cx25821_pci_tbl[] = { {/* CX25821 Athena */ .vendor =0x14f1 ,
drivers/media/pci/sta2x11/sta2x11_vip.c +1 -1
@@ -1303,7 +1303,7 @@ static int sta2x11_vip_resume(struct pci_dev *pdev)#endif -static DEFINE_PCI_DEVICE_TABLE (sta2x11_vip_pci_tbl) = { +static const struct pci_device_id sta2x11_vip_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_STMICRO ,PCI_DEVICE_ID_STMICRO_VIP )}, {0 ,} };
Signature · 1 line
1.7.10.4
PATCH 16/39 mfd: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/mfd/cs5535-mfd.c | 2 +- drivers/mfd/janz-cmodio.c | 2 +- drivers/mfd/lpc_ich.c | 2 +- drivers/mfd/lpc_sch.c | 2 +- drivers/mfd/rdc321x-southbridge.c | 2 +- drivers/mfd/rtsx_pcr.c | 2 +- drivers/mfd/sm501.c | 2 +- drivers/mfd/sta2x11-mfd.c | 2 +- drivers/mfd/timberdale.c | 2 +- drivers/mfd/vx855.c | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-)
drivers/mfd/cs5535-mfd.c +1 -1
@@ -172,7 +172,7 @@ static void cs5535_mfd_remove(struct pci_dev *pdev)pci_disable_device (pdev); } -static DEFINE_PCI_DEVICE_TABLE (cs5535_mfd_pci_tbl) = { +static const struct pci_device_id cs5535_mfd_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_NS ,PCI_DEVICE_ID_NS_CS5535_ISA ) }, {PCI_DEVICE (PCI_VENDOR_ID_AMD ,PCI_DEVICE_ID_AMD_CS5536_ISA ) }, {0 , }
drivers/mfd/janz-cmodio.c +1 -1
@@ -265,7 +265,7 @@ static void cmodio_pci_remove(struct pci_dev *dev)#define PCI_VENDOR_ID_JANZ 0x13c3/* The list of devices that this module will support */ -static DEFINE_PCI_DEVICE_TABLE (cmodio_pci_ids) = { +static const struct pci_device_id cmodio_pci_ids[] = { {PCI_VENDOR_ID_PLX ,PCI_DEVICE_ID_PLX_9030 ,PCI_VENDOR_ID_JANZ ,0x0101 }, {PCI_VENDOR_ID_PLX ,PCI_DEVICE_ID_PLX_9050 ,PCI_VENDOR_ID_JANZ ,0x0100 }, {0 , }
drivers/mfd/lpc_ich.c +1 -1
@@ -517,7 +517,7 @@ static struct lpc_ich_info lpc_chipset_info[] = {* pci_driver, because the I/O Controller Hub has also other * functions that probably will be registered by other drivers. */ -static DEFINE_PCI_DEVICE_TABLE (lpc_ich_ids) = { +static const struct pci_device_id lpc_ich_ids[] = { {PCI_VDEVICE (INTEL ,0x2410 ),LPC_ICH }, {PCI_VDEVICE (INTEL ,0x2420 ),LPC_ICH0 }, {PCI_VDEVICE (INTEL ,0x2440 ),LPC_ICH2 },
drivers/mfd/lpc_sch.c +1 -1
@@ -76,7 +76,7 @@ static struct mfd_cell wdt_sch_cell = { .ignore_resource_conflicts = true, }; -static DEFINE_PCI_DEVICE_TABLE (lpc_sch_ids) = { +static const struct pci_device_id lpc_sch_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_SCH_LPC ) }, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_ITC_LPC ) }, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_CENTERTON_ILB ) },
drivers/mfd/rdc321x-southbridge.c +1 -1
@@ -96,7 +96,7 @@ static void rdc321x_sb_remove(struct pci_dev *pdev)mfd_remove_devices (&pdev->dev); } -static DEFINE_PCI_DEVICE_TABLE (rdc321x_sb_table) = { +static const struct pci_device_id rdc321x_sb_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_RDC ,PCI_DEVICE_ID_RDC_R6030 ) }, {} };
drivers/mfd/rtsx_pcr.c +1 -1
@@ -50,7 +50,7 @@ static struct mfd_cell rtsx_pcr_cells[] = { }, }; -static DEFINE_PCI_DEVICE_TABLE (rtsx_pci_ids) = { +static const struct pci_device_id rtsx_pci_ids[] = { {PCI_DEVICE (0x10EC ,0x5209 ),PCI_CLASS_OTHERS <<16 ,0xFF0000 }, {PCI_DEVICE (0x10EC ,0x5229 ),PCI_CLASS_OTHERS <<16 ,0xFF0000 }, {PCI_DEVICE (0x10EC ,0x5289 ),PCI_CLASS_OTHERS <<16 ,0xFF0000 },
drivers/mfd/sm501.c +1 -1
@@ -1710,7 +1710,7 @@ static int sm501_plat_remove(struct platform_device *dev)return 0 ; } -static DEFINE_PCI_DEVICE_TABLE (sm501_pci_tbl) = { +static const struct pci_device_id sm501_pci_tbl[] = { {0x126f ,0x0501 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 }, {0 , }, };
drivers/mfd/sta2x11-mfd.c +1 -1
@@ -642,7 +642,7 @@ err_disable:return err; } -static DEFINE_PCI_DEVICE_TABLE (sta2x11_mfd_tbl) = { +static const struct pci_device_id sta2x11_mfd_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_STMICRO ,PCI_DEVICE_ID_STMICRO_GPIO )}, {PCI_DEVICE (PCI_VENDOR_ID_STMICRO ,PCI_DEVICE_ID_STMICRO_VIC )}, {0 ,},
drivers/mfd/timberdale.c +1 -1
@@ -851,7 +851,7 @@ static void timb_remove(struct pci_dev *dev)kfree (priv); } -static DEFINE_PCI_DEVICE_TABLE (timberdale_pci_tbl) = { +static const struct pci_device_id timberdale_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_TIMB ,PCI_DEVICE_ID_TIMB ) }, {0 } };
drivers/mfd/vx855.c +1 -1
@@ -118,7 +118,7 @@ static void vx855_remove(struct pci_dev *pdev)pci_disable_device (pdev); } -static DEFINE_PCI_DEVICE_TABLE (vx855_pci_tbl) = { +static const struct pci_device_id vx855_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_VX855 ) }, {0 , } };
Signature · 1 line
1.7.10.4
Re: [PATCH 16/39] mfd: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 4 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>
Quoted 12 lines
--- drivers/mfd/cs5535-mfd.c | 2 +- drivers/mfd/janz-cmodio.c | 2 +- drivers/mfd/lpc_ich.c | 2 +- drivers/mfd/lpc_sch.c | 2 +- drivers/mfd/rdc321x-southbridge.c | 2 +- drivers/mfd/rtsx_pcr.c | 2 +- drivers/mfd/sm501.c | 2 +- drivers/mfd/sta2x11-mfd.c | 2 +- drivers/mfd/timberdale.c | 2 +- drivers/mfd/vx855.c | 2 +- 10 files changed, 10 insertions(+), 10 deletions(-)
Patch looks good to me, so unless The List cries blue murder I've tentatively applied it.
Signature · 4 lines
Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
PATCH 17/39 misc: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/misc/mei/pci-me.c | 2 +- drivers/misc/mic/host/mic_main.c | 2 +- drivers/misc/vmw_vmci/vmci_guest.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/misc/mei/pci-me.c +1 -1
@@ -44,7 +44,7 @@#include "client.h" /* mei_pci_tbl - PCI Device ID Table */ -static DEFINE_PCI_DEVICE_TABLE (mei_me_pci_tbl) = { +static const struct pci_device_id mei_me_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,MEI_DEV_ID_82946GZ )}, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,MEI_DEV_ID_82G35 )}, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,MEI_DEV_ID_82Q965 )},
drivers/misc/mic/host/mic_main.c +1 -1
@@ -38,7 +38,7 @@static const char mic_driver_name[] ="mic" ; -static DEFINE_PCI_DEVICE_TABLE (mic_pci_tbl) = { +static const struct pci_device_id mic_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,MIC_X100_PCI_DEVICE_2250 )}, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,MIC_X100_PCI_DEVICE_2251 )}, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,MIC_X100_PCI_DEVICE_2252 )},
drivers/misc/vmw_vmci/vmci_guest.c +1 -1
@@ -745,7 +745,7 @@ static void vmci_guest_remove_device(struct pci_dev *pdev)/* The rest are managed resources and will be freed by PCI core */ } -static DEFINE_PCI_DEVICE_TABLE (vmci_ids) = { +static const struct pci_device_id vmci_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_VMWARE ,PCI_DEVICE_ID_VMWARE_VMCI ), }, {0 }, };
Signature · 1 line
1.7.10.4
PATCH 18/39 mmc: dw_mmc-pci: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/mmc/host/dw_mmc-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/dw_mmc-pci.c +1 -1
@@ -102,7 +102,7 @@ static int dw_mci_pci_resume(struct device *dev) static SIMPLE_DEV_PM_OPS(dw_mci_pci_pmops, dw_mci_pci_suspend, dw_mci_pci_resume); -static DEFINE_PCI_DEVICE_TABLE (dw_mci_pci_id) = { +static const struct pci_device_id dw_mci_pci_id[] = { {PCI_DEVICE (SYNOPSYS_DW_MCI_VENDOR_ID ,SYNOPSYS_DW_MCI_DEVICE_ID ) }, {} };
Signature · 1 line
1.7.10.4
PATCH 19/39 mtd: denali: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/mtd/nand/denali_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mtd/nand/denali_pci.c +1 -1
@@ -21,7 +21,7 @@#define DENALI_NAND_NAME "denali-nand-pci"/* List of platforms this NAND controller has be integrated into */ -static DEFINE_PCI_DEVICE_TABLE (denali_pci_ids) = { +static const struct pci_device_id denali_pci_ids[] = { {PCI_VDEVICE (INTEL ,0x0701 ),INTEL_CE4100 }, {PCI_VDEVICE (INTEL ,0x0809 ),INTEL_MRST }, {/* end: all zeroes */ }
Signature · 1 line
1.7.10.4
Brian Norris
AppliedRe: [PATCH 19/39] mtd: denali: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 4 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>
Pushed to l2-mtd.git.
Brian
PATCH 20/39 net: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/net/arcnet/com20020-pci.c | 2 +- drivers/net/can/c_can/c_can_pci.c | 2 +- drivers/net/can/pch_can.c | 2 +- drivers/net/can/sja1000/ems_pci.c | 2 +- drivers/net/can/sja1000/kvaser_pci.c | 2 +- drivers/net/can/sja1000/peak_pci.c | 2 +- drivers/net/can/sja1000/plx_pci.c | 2 +- drivers/net/ethernet/3com/3c59x.c | 2 +- drivers/net/ethernet/3com/typhoon.c | 2 +- drivers/net/ethernet/8390/ne2k-pci.c | 2 +- drivers/net/ethernet/adaptec/starfire.c | 2 +- drivers/net/ethernet/alteon/acenic.c | 2 +- drivers/net/ethernet/amd/amd8111e.c | 2 +- drivers/net/ethernet/amd/pcnet32.c | 2 +- drivers/net/ethernet/atheros/alx/main.c | 2 +- drivers/net/ethernet/atheros/atl1c/atl1c_main.c | 2 +- drivers/net/ethernet/atheros/atl1e/atl1e_main.c | 2 +- drivers/net/ethernet/atheros/atlx/atl1.c | 2 +- drivers/net/ethernet/atheros/atlx/atl2.c | 2 +- drivers/net/ethernet/broadcom/b44.c | 2 +- drivers/net/ethernet/broadcom/bnx2.c | 2 +- drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c | 2 +- drivers/net/ethernet/broadcom/tg3.c | 6 +++--- drivers/net/ethernet/brocade/bna/bnad.c | 2 +- drivers/net/ethernet/chelsio/cxgb/subr.c | 2 +- drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c | 2 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 2 +- drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c | 2 +- drivers/net/ethernet/cisco/enic/enic_main.c | 2 +- drivers/net/ethernet/dec/tulip/de2104x.c | 2 +- drivers/net/ethernet/dec/tulip/de4x5.c | 2 +- drivers/net/ethernet/dec/tulip/dmfe.c | 2 +- drivers/net/ethernet/dec/tulip/tulip_core.c | 4 ++-- drivers/net/ethernet/dec/tulip/uli526x.c | 2 +- drivers/net/ethernet/dec/tulip/winbond-840.c | 2 +- drivers/net/ethernet/dec/tulip/xircom_cb.c | 2 +- drivers/net/ethernet/dlink/dl2k.h | 2 +- drivers/net/ethernet/dlink/sundance.c | 2 +- drivers/net/ethernet/emulex/benet/be_main.c | 2 +- drivers/net/ethernet/fealnx.c | 2 +- drivers/net/ethernet/hp/hp100.c | 2 +- drivers/net/ethernet/icplus/ipg.c | 2 +- drivers/net/ethernet/intel/e100.c | 2 +- drivers/net/ethernet/intel/e1000/e1000_main.c | 2 +- drivers/net/ethernet/intel/e1000e/netdev.c | 2 +- drivers/net/ethernet/intel/i40e/i40e_main.c | 2 +- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- drivers/net/ethernet/intel/igbvf/netdev.c | 2 +- drivers/net/ethernet/intel/ixgb/ixgb_main.c | 2 +- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +- drivers/net/ethernet/jme.c | 2 +- drivers/net/ethernet/marvell/skge.c | 2 +- drivers/net/ethernet/marvell/sky2.c | 2 +- drivers/net/ethernet/mellanox/mlx4/main.c | 2 +- drivers/net/ethernet/micrel/ksz884x.c | 2 +- drivers/net/ethernet/myricom/myri10ge/myri10ge.c | 2 +- drivers/net/ethernet/natsemi/natsemi.c | 2 +- drivers/net/ethernet/natsemi/ns83820.c | 2 +- drivers/net/ethernet/neterion/s2io.c | 2 +- drivers/net/ethernet/neterion/vxge/vxge-main.c | 2 +- drivers/net/ethernet/nvidia/forcedeth.c | 2 +- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c | 2 +- drivers/net/ethernet/packetengines/hamachi.c | 2 +- drivers/net/ethernet/packetengines/yellowfin.c | 2 +- drivers/net/ethernet/pasemi/pasemi_mac.c | 2 +- drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c | 2 +- drivers/net/ethernet/qlogic/qla3xxx.c | 2 +- drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 2 +- drivers/net/ethernet/qlogic/qlge/qlge_main.c | 2 +- drivers/net/ethernet/rdc/r6040.c | 2 +- drivers/net/ethernet/realtek/8139cp.c | 2 +- drivers/net/ethernet/realtek/8139too.c | 2 +- drivers/net/ethernet/realtek/r8169.c | 2 +- drivers/net/ethernet/sfc/efx.c | 2 +- drivers/net/ethernet/sgi/ioc3-eth.c | 2 +- drivers/net/ethernet/silan/sc92031.c | 2 +- drivers/net/ethernet/sis/sis190.c | 2 +- drivers/net/ethernet/sis/sis900.c | 2 +- drivers/net/ethernet/smsc/epic100.c | 2 +- drivers/net/ethernet/smsc/smsc9420.c | 2 +- drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 2 +- drivers/net/ethernet/sun/cassini.c | 2 +- drivers/net/ethernet/sun/niu.c | 2 +- drivers/net/ethernet/sun/sungem.c | 2 +- drivers/net/ethernet/sun/sunhme.c | 2 +- drivers/net/ethernet/tehuti/tehuti.c | 2 +- drivers/net/ethernet/ti/tlan.c | 2 +- drivers/net/ethernet/toshiba/spider_net.c | 2 +- drivers/net/ethernet/toshiba/tc35815.c | 2 +- drivers/net/ethernet/via/via-rhine.c | 2 +- drivers/net/ethernet/via/via-velocity.c | 2 +- drivers/net/fddi/defxx.c | 2 +- drivers/net/fddi/skfp/skfddi.c | 2 +- drivers/net/hippi/rrunner.c | 2 +- drivers/net/irda/donauboe.c | 2 +- drivers/net/irda/via-ircc.c | 2 +- drivers/net/irda/vlsi_ir.c | 2 +- drivers/net/vmxnet3/vmxnet3_drv.c | 2 +- drivers/net/wan/dscc4.c | 2 +- drivers/net/wan/farsync.c | 2 +- drivers/net/wan/lmc/lmc_main.c | 2 +- drivers/net/wan/pc300too.c | 2 +- drivers/net/wan/pci200syn.c | 2 +- drivers/net/wan/wanxl.c | 2 +- drivers/net/wireless/adm8211.c | 2 +- drivers/net/wireless/airo.c | 2 +- drivers/net/wireless/ath/ath10k/pci.c | 2 +- drivers/net/wireless/ath/ath5k/led.c | 2 +- drivers/net/wireless/ath/ath5k/pci.c | 2 +- drivers/net/wireless/ath/ath9k/pci.c | 2 +- drivers/net/wireless/ath/wil6210/pcie_bus.c | 2 +- drivers/net/wireless/atmel_pci.c | 2 +- drivers/net/wireless/hostap/hostap_pci.c | 2 +- drivers/net/wireless/hostap/hostap_plx.c | 2 +- drivers/net/wireless/ipw2x00/ipw2100.c | 2 +- drivers/net/wireless/ipw2x00/ipw2200.c | 2 +- drivers/net/wireless/iwlegacy/3945.c | 2 +- drivers/net/wireless/iwlegacy/4965-mac.c | 2 +- drivers/net/wireless/iwlwifi/pcie/drv.c | 2 +- drivers/net/wireless/mwifiex/pcie.c | 2 +- drivers/net/wireless/mwl8k.c | 2 +- drivers/net/wireless/orinoco/orinoco_nortel.c | 2 +- drivers/net/wireless/orinoco/orinoco_pci.c | 2 +- drivers/net/wireless/orinoco/orinoco_plx.c | 2 +- drivers/net/wireless/orinoco/orinoco_tmd.c | 2 +- drivers/net/wireless/p54/p54pci.c | 2 +- drivers/net/wireless/prism54/islpci_hotplug.c | 2 +- drivers/net/wireless/rt2x00/rt2400pci.c | 2 +- drivers/net/wireless/rt2x00/rt2500pci.c | 2 +- drivers/net/wireless/rt2x00/rt2800pci.c | 2 +- drivers/net/wireless/rt2x00/rt61pci.c | 2 +- drivers/net/wireless/rtl818x/rtl8180/dev.c | 2 +- drivers/net/wireless/rtlwifi/rtl8188ee/sw.c | 2 +- drivers/net/wireless/rtlwifi/rtl8192ce/sw.c | 2 +- 135 files changed, 138 insertions(+), 138 deletions(-)
drivers/net/arcnet/com20020-pci.c +1 -1
@@ -144,7 +144,7 @@ static void com20020pci_remove(struct pci_dev *pdev)free_netdev (dev); } -static DEFINE_PCI_DEVICE_TABLE (com20020pci_id_table) = { +static const struct pci_device_id com20020pci_id_table[] = { {0x1571 ,0xa001 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 }, {0x1571 ,0xa002 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 }, {0x1571 ,0xa003 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 },
drivers/net/can/c_can/c_can_pci.c +1 -1
@@ -199,7 +199,7 @@ static struct c_can_pci_data c_can_sta2x11= { PCI_DEVICE(_vend, _dev), \ .driver_data = (unsigned long)&_driverdata, \ } -static DEFINE_PCI_DEVICE_TABLE (c_can_pci_tbl) = { +static const struct pci_device_id c_can_pci_tbl[] = {C_CAN_ID (PCI_VENDOR_ID_STMICRO ,PCI_DEVICE_ID_STMICRO_CAN , c_can_sta2x11), {},
drivers/net/can/pch_can.c +1 -1
@@ -196,7 +196,7 @@ static const struct can_bittiming_const pch_can_bittiming_const = { .brp_inc = 1, }; -static DEFINE_PCI_DEVICE_TABLE (pch_pci_tbl) = { +static const struct pci_device_id pch_pci_tbl[] = { {PCI_VENDOR_ID_INTEL ,0x8818 ,PCI_ANY_ID ,PCI_ANY_ID ,}, {0 ,} };
drivers/net/can/sja1000/ems_pci.c +1 -1
@@ -102,7 +102,7 @@ struct ems_pci_card {#define EMS_PCI_BASE_SIZE 4096/* size of controller area */ -static DEFINE_PCI_DEVICE_TABLE (ems_pci_tbl) = { +static const struct pci_device_id ems_pci_tbl[] = {/* CPC-PCI v1 */ {PCI_VENDOR_ID_SIEMENS ,0x2104 ,PCI_ANY_ID ,PCI_ANY_ID ,},/* CPC-PCI v2 */
drivers/net/can/sja1000/kvaser_pci.c +1 -1
@@ -108,7 +108,7 @@ struct kvaser_pci {#define KVASER_PCI_VENDOR_ID2 0x1a07/* the PCI device and vendor IDs */ #define KVASER_PCI_DEVICE_ID2 0x0008 -static DEFINE_PCI_DEVICE_TABLE (kvaser_pci_tbl) = { +static const struct pci_device_id kvaser_pci_tbl[] = { {KVASER_PCI_VENDOR_ID1 ,KVASER_PCI_DEVICE_ID1 ,PCI_ANY_ID ,PCI_ANY_ID ,}, {KVASER_PCI_VENDOR_ID2 ,KVASER_PCI_DEVICE_ID2 ,PCI_ANY_ID ,PCI_ANY_ID ,}, {0 ,}
drivers/net/can/sja1000/peak_pci.c +1 -1
@@ -77,7 +77,7 @@ static const u16 peak_pci_icr_masks[PEAK_PCI_CHAN_MAX] = {0x02 ,0x01 ,0x40 ,0x80 }; -static DEFINE_PCI_DEVICE_TABLE (peak_pci_tbl) = { +static const struct pci_device_id peak_pci_tbl[] = { {PEAK_PCI_VENDOR_ID ,PEAK_PCI_DEVICE_ID ,PCI_ANY_ID ,PCI_ANY_ID ,}, {PEAK_PCI_VENDOR_ID ,PEAK_PCIE_DEVICE_ID ,PCI_ANY_ID ,PCI_ANY_ID ,}, {PEAK_PCI_VENDOR_ID, PEAK_MPCI_DEVICE_ID, PCI_ANY_ID, PCI_ANY_ID,},
drivers/net/can/sja1000/plx_pci.c +1 -1
@@ -234,7 +234,7 @@ static struct plx_pci_card_info plx_pci_card_info_cti = {/* based on PLX9030 */ }; -static DEFINE_PCI_DEVICE_TABLE (plx_pci_tbl) = { +static const struct pci_device_id plx_pci_tbl[] = { {/* Adlink PCI-7841/cPCI-7841 */ ADLINK_PCI_VENDOR_ID ,ADLINK_PCI_DEVICE_ID ,
drivers/net/ethernet/3com/3c59x.c +1 -1
@@ -375,7 +375,7 @@ static struct vortex_chip_info { }; -static DEFINE_PCI_DEVICE_TABLE (vortex_pci_tbl) = { +static const struct pci_device_id vortex_pci_tbl[] = { {0x10B7 ,0x5900 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,CH_3C590 }, {0x10B7 ,0x5920 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,CH_3C592 }, {0x10B7 ,0x5970 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,CH_3C597 },
drivers/net/ethernet/3com/typhoon.c +1 -1
@@ -203,7 +203,7 @@ static struct typhoon_card_info typhoon_card_info[] = {* bit 8 indicates if this is a (0) copper or (1) fiber card * bits 12-16 indicate card type: (0) client and (1) server */ -static DEFINE_PCI_DEVICE_TABLE (typhoon_pci_tbl) = { +static const struct pci_device_id typhoon_pci_tbl[] = { {PCI_VENDOR_ID_3COM ,PCI_DEVICE_ID_3COM_3CR990 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,TYPHOON_TX }, {PCI_VENDOR_ID_3COM ,PCI_DEVICE_ID_3COM_3CR990_TX_95 ,
drivers/net/ethernet/8390/ne2k-pci.c +1 -1
@@ -135,7 +135,7 @@ static struct { }; -static DEFINE_PCI_DEVICE_TABLE (ne2k_pci_tbl) = { +static const struct pci_device_id ne2k_pci_tbl[] = { {0x10ec ,0x8029 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 , CH_RealTek_RTL_8029 }, {0x1050 ,0x0940 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 , CH_Winbond_89C940 }, {0x11f6 ,0x1401 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 , CH_Compex_RL2000 },
drivers/net/ethernet/adaptec/starfire.c +1 -1
@@ -285,7 +285,7 @@ enum chipset { CH_6915 = 0, }; -static DEFINE_PCI_DEVICE_TABLE (starfire_pci_tbl) = { +static const struct pci_device_id starfire_pci_tbl[] = { {PCI_VDEVICE (ADAPTEC ,0x6915 ),CH_6915 }, {0 , } };
drivers/net/ethernet/alteon/acenic.c +1 -1
@@ -132,7 +132,7 @@#define PCI_DEVICE_ID_SGI_ACENIC 0x0009#endif -static DEFINE_PCI_DEVICE_TABLE (acenic_pci_tbl) = { +static const struct pci_device_id acenic_pci_tbl[] = { {PCI_VENDOR_ID_ALTEON ,PCI_DEVICE_ID_ALTEON_ACENIC_FIBRE ,PCI_ANY_ID ,PCI_ANY_ID ,PCI_CLASS_NETWORK_ETHERNET <<8 ,0xffff00 , }, {PCI_VENDOR_ID_ALTEON ,PCI_DEVICE_ID_ALTEON_ACENIC_COPPER ,
drivers/net/ethernet/amd/amd8111e.c +1 -1
@@ -112,7 +112,7 @@ MODULE_PARM_DESC(coalesce, "Enable or Disable interrupt coalescing, 1: Enable, 0module_param_array (dynamic_ipg, bool,NULL ,0 );MODULE_PARM_DESC (dynamic_ipg,"Enable or Disable dynamic IPG, 1: Enable, 0: Disable" ); -static DEFINE_PCI_DEVICE_TABLE (amd8111e_pci_tbl) = { +static const struct pci_device_id amd8111e_pci_tbl[] = { {PCI_VENDOR_ID_AMD ,PCI_DEVICE_ID_AMD8111E_7462 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0UL },
drivers/net/ethernet/amd/pcnet32.c +1 -1
@@ -61,7 +61,7 @@ static const char *const version =/* * PCI device identifiers for "new style" Linux PCI Device Drivers */ -static DEFINE_PCI_DEVICE_TABLE (pcnet32_pci_tbl) = { +static const struct pci_device_id pcnet32_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_AMD ,PCI_DEVICE_ID_AMD_LANCE_HOME ), }, {PCI_DEVICE (PCI_VENDOR_ID_AMD ,PCI_DEVICE_ID_AMD_LANCE ), },
drivers/net/ethernet/atheros/alx/main.c +1 -1
@@ -1482,7 +1482,7 @@ static const struct pci_error_handlers alx_err_handlers = { .resume = alx_pci_error_resume, }; -static DEFINE_PCI_DEVICE_TABLE (alx_pci_tbl) = { +static const struct pci_device_id alx_pci_tbl[] = { {PCI_VDEVICE (ATTANSIC ,ALX_DEV_ID_AR8161 ), .driver_data =ALX_DEV_QUIRK_MSI_INTX_DISABLE_BUG }, {PCI_VDEVICE (ATTANSIC ,ALX_DEV_ID_E2200 ),
drivers/net/ethernet/atheros/atl1c/atl1c_main.c +1 -1
@@ -34,7 +34,7 @@ char atl1c_driver_version[] = ATL1C_DRV_VERSION;* { Vendor ID, Device ID, SubVendor ID, SubDevice ID, * Class, Class Mask, private data (not used) } */ -static DEFINE_PCI_DEVICE_TABLE (atl1c_pci_tbl) = { +static const struct pci_device_id atl1c_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_ATTANSIC ,PCI_DEVICE_ID_ATTANSIC_L1C )}, {PCI_DEVICE (PCI_VENDOR_ID_ATTANSIC ,PCI_DEVICE_ID_ATTANSIC_L2C )}, {PCI_DEVICE (PCI_VENDOR_ID_ATTANSIC ,PCI_DEVICE_ID_ATHEROS_L2C_B )},
drivers/net/ethernet/atheros/atl1e/atl1e_main.c +1 -1
@@ -35,7 +35,7 @@ char atl1e_driver_version[] = DRV_VERSION;* { Vendor ID, Device ID, SubVendor ID, SubDevice ID, * Class, Class Mask, private data (not used) } */ -static DEFINE_PCI_DEVICE_TABLE (atl1e_pci_tbl) = { +static const struct pci_device_id atl1e_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_ATTANSIC ,PCI_DEVICE_ID_ATTANSIC_L1E )}, {PCI_DEVICE (PCI_VENDOR_ID_ATTANSIC ,0x1066 )},/* required last entry */
drivers/net/ethernet/atheros/atlx/atl1.c +1 -1
@@ -235,7 +235,7 @@ static void atl1_check_options(struct atl1_adapter *adapter)/* * atl1_pci_tbl - PCI Device ID Table */ -static DEFINE_PCI_DEVICE_TABLE (atl1_pci_tbl) = { +static const struct pci_device_id atl1_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_ATTANSIC ,PCI_DEVICE_ID_ATTANSIC_L1 )},/* required last entry */ {0 ,}
drivers/net/ethernet/atheros/atlx/atl2.c +1 -1
@@ -64,7 +64,7 @@ MODULE_VERSION(ATL2_DRV_VERSION);/* * atl2_pci_tbl - PCI Device ID Table */ -static DEFINE_PCI_DEVICE_TABLE (atl2_pci_tbl) = { +static const struct pci_device_id atl2_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_ATTANSIC ,PCI_DEVICE_ID_ATTANSIC_L2 )},/* required last entry */ {0 ,}
drivers/net/ethernet/broadcom/b44.c +1 -1
@@ -103,7 +103,7 @@ MODULE_PARM_DESC(b44_debug, "B44 bitmapped debugging message enable value");#ifdef CONFIG_B44_PCI -static DEFINE_PCI_DEVICE_TABLE (b44_pci_tbl) = { +static const struct pci_device_id b44_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_BROADCOM ,PCI_DEVICE_ID_BCM4401 ) }, {PCI_DEVICE (PCI_VENDOR_ID_BROADCOM ,PCI_DEVICE_ID_BCM4401B0 ) }, { PCI_DEVICE(PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_BCM4401B1) },
drivers/net/ethernet/broadcom/bnx2.c +1 -1
@@ -120,7 +120,7 @@ static struct { { "Broadcom NetXtreme II BCM5716 1000Base-SX" }, }; -static DEFINE_PCI_DEVICE_TABLE(bnx2_pci_tbl) = { +static const struct pci_device_id bnx2_pci_tbl[] = { { PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_NX2_5706, PCI_VENDOR_ID_HP, 0x3101, 0, 0, NC370T }, { PCI_VENDOR_ID_BROADCOM, PCI_DEVICE_ID_NX2_5706,
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c +1 -1
@@ -247,7 +247,7 @@ static struct {#define PCI_DEVICE_ID_NX2_57811_VF CHIP_NUM_57811_VF#endif -static DEFINE_PCI_DEVICE_TABLE (bnx2x_pci_tbl) = { +static const struct pci_device_id bnx2x_pci_tbl[] = { {PCI_VDEVICE (BROADCOM ,PCI_DEVICE_ID_NX2_57710 ),BCM57710 }, {PCI_VDEVICE (BROADCOM ,PCI_DEVICE_ID_NX2_57711 ),BCM57711 }, {PCI_VDEVICE (BROADCOM ,PCI_DEVICE_ID_NX2_57711E ),BCM57711E },
drivers/net/ethernet/broadcom/tg3.c +3 -3
@@ -234,7 +234,7 @@ MODULE_PARM_DESC(tg3_debug, "Tigon3 bitmapped debugging message enable value");#define TG3_DRV_DATA_FLAG_10_100_ONLY 0x0001#define TG3_DRV_DATA_FLAG_5705_10_100 0x0002 -static DEFINE_PCI_DEVICE_TABLE (tg3_pci_tbl) = { +static const struct pci_device_id tg3_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_BROADCOM ,PCI_DEVICE_ID_TIGON3_5700 )}, {PCI_DEVICE (PCI_VENDOR_ID_BROADCOM ,PCI_DEVICE_ID_TIGON3_5701 )}, {PCI_DEVICE (PCI_VENDOR_ID_BROADCOM ,PCI_DEVICE_ID_TIGON3_5702 )},
@@ -15732,7 +15732,7 @@ static inline u32 tg3_rx_ret_ring_size(struct tg3 *tp)return TG3_RX_RET_MAX_SIZE_5705 ; } -static DEFINE_PCI_DEVICE_TABLE (tg3_write_reorder_chipsets) = { +static const struct pci_device_id tg3_write_reorder_chipsets[] = { {PCI_DEVICE (PCI_VENDOR_ID_AMD ,PCI_DEVICE_ID_AMD_FE_GATE_700C ) }, {PCI_DEVICE (PCI_VENDOR_ID_AMD ,PCI_DEVICE_ID_AMD_8131_BRIDGE ) }, {PCI_DEVICE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_8385_0 ) },
@@ -16984,7 +16984,7 @@ static int tg3_do_test_dma(struct tg3 *tp, u32 *buf, dma_addr_t buf_dma,#define TEST_BUFFER_SIZE 0x2000 -static DEFINE_PCI_DEVICE_TABLE (tg3_dma_wait_state_chipsets) = { +static const struct pci_device_id tg3_dma_wait_state_chipsets[] = { {PCI_DEVICE (PCI_VENDOR_ID_APPLE ,PCI_DEVICE_ID_APPLE_UNI_N_PCI15 ) }, { }, };
drivers/net/ethernet/brocade/bna/bnad.c +1 -1
@@ -3566,7 +3566,7 @@ bnad_pci_remove(struct pci_dev *pdev)free_netdev (netdev); } -static DEFINE_PCI_DEVICE_TABLE (bnad_pci_id_table) = { +static const struct pci_device_id bnad_pci_id_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_BROCADE ,PCI_DEVICE_ID_BROCADE_CT ),
drivers/net/ethernet/chelsio/cxgb/subr.c +1 -1
@@ -523,7 +523,7 @@ static const struct board_info t1_board[] = { }; -DEFINE_PCI_DEVICE_TABLE (t1_pci_tbl) = { +const struct pci_device_id t1_pci_tbl[] = {CH_DEVICE (8 ,0 ,CH_BRD_T110_1CU ),CH_DEVICE (8 ,1 ,CH_BRD_T110_1CU ),CH_DEVICE (7 ,0 ,CH_BRD_N110_1F ),
drivers/net/ethernet/chelsio/cxgb3/cxgb3_main.c +1 -1
@@ -85,7 +85,7 @@ enum {#define CH_DEVICE (devid, idx) \ { PCI_VENDOR_ID_CHELSIO, devid, PCI_ANY_ID, PCI_ANY_ID, 0, 0, idx } -static DEFINE_PCI_DEVICE_TABLE (cxgb3_pci_tbl) = { +static const struct pci_device_id cxgb3_pci_tbl[] = {CH_DEVICE (0x20 ,0 ),/* PE9000 */ CH_DEVICE (0x21 ,1 ),/* T302E */ CH_DEVICE (0x22 ,2 ),/* T310E */
drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c +1 -1
@@ -211,7 +211,7 @@ struct filter_entry {#define CH_DEVICE (devid, data) { PCI_VDEVICE(CHELSIO, devid), (data) } -static DEFINE_PCI_DEVICE_TABLE (cxgb4_pci_tbl) = { +static const struct pci_device_id cxgb4_pci_tbl[] = {CH_DEVICE (0xa000 ,0 ),/* PE10K */ CH_DEVICE (0x4001 ,-1 ),CH_DEVICE (0x4002 ,-1 ),
drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c +1 -1
@@ -2905,7 +2905,7 @@ static void cxgb4vf_pci_shutdown(struct pci_dev *pdev)#define CH_DEVICE (devid, idx) \ { PCI_VENDOR_ID_CHELSIO, devid, PCI_ANY_ID, PCI_ANY_ID, 0, 0, idx } -static DEFINE_PCI_DEVICE_TABLE (cxgb4vf_pci_tbl) = { +static const struct pci_device_id cxgb4vf_pci_tbl[] = {CH_DEVICE (0xb000 ,0 ),/* PE10K FPGA */ CH_DEVICE (0x4800 ,0 ),/* T440-dbg */ CH_DEVICE (0x4801 ,0 ),/* T420-cr */
drivers/net/ethernet/cisco/enic/enic_main.c +1 -1
@@ -59,7 +59,7 @@#define PCI_DEVICE_ID_CISCO_VIC_ENET_VF 0x0071/* enet SRIOV VF */ /* Supported devices */ -static DEFINE_PCI_DEVICE_TABLE (enic_id_table) = { +static const struct pci_device_id enic_id_table[] = { {PCI_VDEVICE (CISCO ,PCI_DEVICE_ID_CISCO_VIC_ENET ) }, {PCI_VDEVICE (CISCO ,PCI_DEVICE_ID_CISCO_VIC_ENET_DYN ) }, {PCI_VDEVICE (CISCO ,PCI_DEVICE_ID_CISCO_VIC_ENET_VF ) },
drivers/net/ethernet/dec/tulip/de2104x.c +1 -1
@@ -340,7 +340,7 @@ static void de21041_media_timer (unsigned long data);static unsigned int de_ok_to_advertise (struct de_private *de,u32 new_media); -static DEFINE_PCI_DEVICE_TABLE (de_pci_tbl) = { +static const struct pci_device_id de_pci_tbl[] = { {PCI_VENDOR_ID_DEC ,PCI_DEVICE_ID_DEC_TULIP ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 }, {PCI_VENDOR_ID_DEC ,PCI_DEVICE_ID_DEC_TULIP_PLUS ,
drivers/net/ethernet/dec/tulip/de4x5.c +1 -1
@@ -2328,7 +2328,7 @@ static void de4x5_pci_remove(struct pci_dev *pdev)pci_disable_device (pdev); } -static DEFINE_PCI_DEVICE_TABLE (de4x5_pci_tbl) = { +static const struct pci_device_id de4x5_pci_tbl[] = { {PCI_VENDOR_ID_DEC ,PCI_DEVICE_ID_DEC_TULIP ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 }, {PCI_VENDOR_ID_DEC ,PCI_DEVICE_ID_DEC_TULIP_PLUS ,
drivers/net/ethernet/dec/tulip/dmfe.c +1 -1
@@ -2096,7 +2096,7 @@ static void dmfe_HPNA_remote_cmd_chk(struct dmfe_board_info * db) -static DEFINE_PCI_DEVICE_TABLE (dmfe_pci_tbl) = { +static const struct pci_device_id dmfe_pci_tbl[] = { {0x1282 ,0x9132 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,PCI_DM9132_ID }, {0x1282 ,0x9102 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,PCI_DM9102_ID }, {0x1282 ,0x9100 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,PCI_DM9100_ID },
drivers/net/ethernet/dec/tulip/tulip_core.c +2 -2
@@ -207,7 +207,7 @@ struct tulip_chip_table tulip_tbl[] = { }; -static DEFINE_PCI_DEVICE_TABLE (tulip_pci_tbl) = { +static const struct pci_device_id tulip_pci_tbl[] = { {0x1011 ,0x0009 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,DC21140 }, {0x1011 ,0x0019 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,DC21143 }, {0x11AD ,0x0002 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,LC82C168 },
@@ -1294,7 +1294,7 @@ static const struct net_device_ops tulip_netdev_ops = {#endif }; -DEFINE_PCI_DEVICE_TABLE (early_486_chipsets) = { +const struct pci_device_id early_486_chipsets[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_82424 ) }, {PCI_DEVICE (PCI_VENDOR_ID_SI ,PCI_DEVICE_ID_SI_496 ) }, { },
drivers/net/ethernet/dec/tulip/uli526x.c +1 -1
@@ -1774,7 +1774,7 @@ static u16 phy_read_1bit(struct uli526x_board_info *db) } -static DEFINE_PCI_DEVICE_TABLE (uli526x_pci_tbl) = { +static const struct pci_device_id uli526x_pci_tbl[] = { {0x10B9 ,0x5261 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,PCI_ULI5261_ID }, {0x10B9 ,0x5263 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,PCI_ULI5263_ID }, {0 , }
drivers/net/ethernet/dec/tulip/winbond-840.c +1 -1
@@ -219,7 +219,7 @@ enum chip_capability_flags { CanHaveMII=1, HasBrokenTx=2, AlwaysFDX=4, FDXOnNoMII=8, }; -static DEFINE_PCI_DEVICE_TABLE (w840_pci_tbl) = { +static const struct pci_device_id w840_pci_tbl[] = { {0x1050 ,0x0840 ,PCI_ANY_ID ,0x8153 ,0 ,0 ,0 }, {0x1050 ,0x0840 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,1 }, {0x11f6 ,0x2011 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,2 },
drivers/net/ethernet/dec/tulip/xircom_cb.c +1 -1
@@ -138,7 +138,7 @@ static int link_status(struct xircom_private *card); -static DEFINE_PCI_DEVICE_TABLE (xircom_pci_table) = { +static const struct pci_device_id xircom_pci_table[] = { {PCI_VDEVICE (XIRCOM ,0x0003 ), }, {0 ,}, };
drivers/net/ethernet/dlink/dl2k.h +1 -1
@@ -409,7 +409,7 @@ struct netdev_private {driver_data Data private to the driver. */ -static DEFINE_PCI_DEVICE_TABLE (rio_pci_tbl) = { +static const struct pci_device_id rio_pci_tbl[] = { {0x1186 ,0x4000 ,PCI_ANY_ID ,PCI_ANY_ID , }, {0x13f0 ,0x1021 ,PCI_ANY_ID ,PCI_ANY_ID , }, { }
drivers/net/ethernet/dlink/sundance.c +1 -1
@@ -199,7 +199,7 @@ IVc. Errata#define USE_IO_OPS 1#endif -static DEFINE_PCI_DEVICE_TABLE (sundance_pci_tbl) = { +static const struct pci_device_id sundance_pci_tbl[] = { {0x1186 ,0x1002 ,0x1186 ,0x1002 ,0 ,0 ,0 }, {0x1186 ,0x1002 ,0x1186 ,0x1003 ,0 ,0 ,1 }, {0x1186 ,0x1002 ,0x1186 ,0x1012 ,0 ,0 ,2 },
drivers/net/ethernet/emulex/benet/be_main.c +1 -1
@@ -38,7 +38,7 @@ static ushort rx_frag_size = 2048;module_param (rx_frag_size, ushort,S_IRUGO );MODULE_PARM_DESC (rx_frag_size,"Size of a fragment that holds rcvd data." ); -static DEFINE_PCI_DEVICE_TABLE (be_dev_ids) = { +static const struct pci_device_id be_dev_ids[] = { {PCI_DEVICE (BE_VENDOR_ID ,BE_DEVICE_ID1 ) }, {PCI_DEVICE (BE_VENDOR_ID ,BE_DEVICE_ID2 ) }, {PCI_DEVICE (BE_VENDOR_ID ,OC_DEVICE_ID1 ) },
drivers/net/ethernet/fealnx.c +1 -1
@@ -1936,7 +1936,7 @@ static int netdev_close(struct net_device *dev)return 0 ; } -static DEFINE_PCI_DEVICE_TABLE (fealnx_pci_tbl) = { +static const struct pci_device_id fealnx_pci_tbl[] = { {0x1516 ,0x0800 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 }, {0x1516 ,0x0803 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,1 }, {0x1516 ,0x0891 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,2 },
drivers/net/ethernet/hp/hp100.c +1 -1
@@ -208,7 +208,7 @@ MODULE_DEVICE_TABLE(eisa, hp100_eisa_tbl);#endif #ifdef CONFIG_PCI -static DEFINE_PCI_DEVICE_TABLE (hp100_pci_tbl) = { +static const struct pci_device_id hp100_pci_tbl[] = { {PCI_VENDOR_ID_HP ,PCI_DEVICE_ID_HP_J2585A ,PCI_ANY_ID ,PCI_ANY_ID ,}, {PCI_VENDOR_ID_HP ,PCI_DEVICE_ID_HP_J2585B ,PCI_ANY_ID ,PCI_ANY_ID ,}, {PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_J2970A, PCI_ANY_ID, PCI_ANY_ID,},
drivers/net/ethernet/icplus/ipg.c +1 -1
@@ -95,7 +95,7 @@ static const char * const ipg_brand_name[] = {"D-Link NIC IP1000A" }; -static DEFINE_PCI_DEVICE_TABLE (ipg_pci_tbl) = { +static const struct pci_device_id ipg_pci_tbl[] = { {PCI_VDEVICE (SUNDANCE ,0x1023 ),0 }, {PCI_VDEVICE (SUNDANCE ,0x2021 ),1 }, {PCI_VDEVICE (DLINK ,0x9021 ),2 },
drivers/net/ethernet/intel/e100.c +1 -1
@@ -208,7 +208,7 @@ MODULE_PARM_DESC(use_io, "Force use of i/o access mode");#define INTEL_8255X_ETHERNET_DEVICE (device_id, ich) {\ PCI_VENDOR_ID_INTEL, device_id, PCI_ANY_ID, PCI_ANY_ID, \ PCI_CLASS_NETWORK_ETHERNET << 8, 0xFFFF00, ich } -static DEFINE_PCI_DEVICE_TABLE (e100_id_table) = { +static const struct pci_device_id e100_id_table[] = {INTEL_8255X_ETHERNET_DEVICE (0x1029 ,0 ),INTEL_8255X_ETHERNET_DEVICE (0x1030 ,0 ),INTEL_8255X_ETHERNET_DEVICE (0x1031 ,3 ),
drivers/net/ethernet/intel/e1000/e1000_main.c +1 -1
@@ -46,7 +46,7 @@ static const char e1000_copyright[] = "Copyright (c) 1999-2006 Intel Corporation* Macro expands to... * {PCI_DEVICE(PCI_VENDOR_ID_INTEL, device_id)} */ -static DEFINE_PCI_DEVICE_TABLE (e1000_pci_tbl) = { +static const struct pci_device_id e1000_pci_tbl[] = {INTEL_E1000_ETHERNET_DEVICE (0x1000 ),INTEL_E1000_ETHERNET_DEVICE (0x1001 ),INTEL_E1000_ETHERNET_DEVICE (0x1004 ),
drivers/net/ethernet/intel/e1000e/netdev.c +1 -1
@@ -6933,7 +6933,7 @@ static const struct pci_error_handlers e1000_err_handler = { .resume = e1000_io_resume, }; -static DEFINE_PCI_DEVICE_TABLE (e1000_pci_tbl) = { +static const struct pci_device_id e1000_pci_tbl[] = { {PCI_VDEVICE (INTEL ,E1000_DEV_ID_82571EB_COPPER ), board_82571 }, {PCI_VDEVICE (INTEL ,E1000_DEV_ID_82571EB_FIBER ), board_82571 }, {PCI_VDEVICE (INTEL ,E1000_DEV_ID_82571EB_QUAD_COPPER ), board_82571 },
drivers/net/ethernet/intel/i40e/i40e_main.c +1 -1
@@ -60,7 +60,7 @@ static int i40e_setup_pf_filter_control(struct i40e_pf *pf);* { Vendor ID, Device ID, SubVendor ID, SubDevice ID, * Class, Class Mask, private data (not used) } */ -static DEFINE_PCI_DEVICE_TABLE (i40e_pci_tbl) = { +static const struct pci_device_id i40e_pci_tbl[] = { {PCI_VDEVICE (INTEL ,I40E_SFP_XL710_DEVICE_ID ),0 }, {PCI_VDEVICE (INTEL ,I40E_SFP_X710_DEVICE_ID ),0 }, {PCI_VDEVICE (INTEL ,I40E_QEMU_DEVICE_ID ),0 },
drivers/net/ethernet/intel/igb/igb_main.c +1 -1
@@ -76,7 +76,7 @@ static const struct e1000_info *igb_info_tbl[] = { [board_82575] = &e1000_82575_info, }; -static DEFINE_PCI_DEVICE_TABLE (igb_pci_tbl) = { +static const struct pci_device_id igb_pci_tbl[] = { {PCI_VDEVICE (INTEL ,E1000_DEV_ID_I354_BACKPLANE_1GBPS ) }, {PCI_VDEVICE (INTEL ,E1000_DEV_ID_I354_SGMII ) }, {PCI_VDEVICE (INTEL ,E1000_DEV_ID_I354_BACKPLANE_2_5GBPS ) },
drivers/net/ethernet/intel/igbvf/netdev.c +1 -1
@@ -2855,7 +2855,7 @@ static const struct pci_error_handlers igbvf_err_handler = { .resume = igbvf_io_resume, }; -static DEFINE_PCI_DEVICE_TABLE (igbvf_pci_tbl) = { +static const struct pci_device_id igbvf_pci_tbl[] = { {PCI_VDEVICE (INTEL ,E1000_DEV_ID_82576_VF ), board_vf }, {PCI_VDEVICE (INTEL ,E1000_DEV_ID_I350_VF ), board_i350_vf }, { }/* terminate list */
drivers/net/ethernet/intel/ixgb/ixgb_main.c +1 -1
@@ -53,7 +53,7 @@ MODULE_PARM_DESC(copybreak,* { Vendor ID, Device ID, SubVendor ID, SubDevice ID, * Class, Class Mask, private data (not used) } */ -static DEFINE_PCI_DEVICE_TABLE (ixgb_pci_tbl) = { +static const struct pci_device_id ixgb_pci_tbl[] = { {PCI_VENDOR_ID_INTEL ,IXGB_DEVICE_ID_82597EX ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 }, {PCI_VENDOR_ID_INTEL ,IXGB_DEVICE_ID_82597EX_CX4 ,
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +1 -1
@@ -83,7 +83,7 @@ static const struct ixgbe_info *ixgbe_info_tbl[] = {* { Vendor ID, Device ID, SubVendor ID, SubDevice ID, * Class, Class Mask, private data (not used) } */ -static DEFINE_PCI_DEVICE_TABLE (ixgbe_pci_tbl) = { +static const struct pci_device_id ixgbe_pci_tbl[] = { {PCI_VDEVICE (INTEL ,IXGBE_DEV_ID_82598 ), board_82598 }, {PCI_VDEVICE (INTEL ,IXGBE_DEV_ID_82598AF_DUAL_PORT ), board_82598 }, {PCI_VDEVICE (INTEL ,IXGBE_DEV_ID_82598AF_SINGLE_PORT ), board_82598 },
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +1 -1
@@ -76,7 +76,7 @@ static const struct ixgbevf_info *ixgbevf_info_tbl[] = {* { Vendor ID, Device ID, SubVendor ID, SubDevice ID, * Class, Class Mask, private data (not used) } */ -static DEFINE_PCI_DEVICE_TABLE (ixgbevf_pci_tbl) = { +static const struct pci_device_id ixgbevf_pci_tbl[] = { {PCI_VDEVICE (INTEL ,IXGBE_DEV_ID_82599_VF ), board_82599_vf }, {PCI_VDEVICE (INTEL ,IXGBE_DEV_ID_X540_VF ), board_X540_vf },/* required last entry */
drivers/net/ethernet/jme.c +1 -1
@@ -3305,7 +3305,7 @@ static SIMPLE_DEV_PM_OPS(jme_pm_ops, jme_suspend, jme_resume);#define JME_PM_OPS NULL#endif -static DEFINE_PCI_DEVICE_TABLE (jme_pci_tbl) = { +static const struct pci_device_id jme_pci_tbl[] = { {PCI_VDEVICE (JMICRON ,PCI_DEVICE_ID_JMICRON_JMC250 ) }, {PCI_VDEVICE (JMICRON ,PCI_DEVICE_ID_JMICRON_JMC260 ) }, { }
drivers/net/ethernet/marvell/skge.c +1 -1
@@ -82,7 +82,7 @@ static int debug = -1; /* defaults above */module_param (debug, int,0 );MODULE_PARM_DESC (debug,"Debug level (0=none,...,16=all)" ); -static DEFINE_PCI_DEVICE_TABLE (skge_id_table) = { +static const struct pci_device_id skge_id_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_3COM ,0x1700 ) },/* 3Com 3C940 */ {PCI_DEVICE (PCI_VENDOR_ID_3COM ,0x80EB ) },/* 3Com 3C940B */ #ifdef CONFIG_SKGE_GENESIS
drivers/net/ethernet/marvell/sky2.c +1 -1
@@ -99,7 +99,7 @@ static int legacy_pme = 0;module_param (legacy_pme, int,0 );MODULE_PARM_DESC (legacy_pme,"Legacy power management" ); -static DEFINE_PCI_DEVICE_TABLE (sky2_id_table) = { +static const struct pci_device_id sky2_id_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_SYSKONNECT ,0x9000 ) },/* SK-9Sxx */ {PCI_DEVICE (PCI_VENDOR_ID_SYSKONNECT ,0x9E00 ) },/* SK-9Exx */ {PCI_DEVICE (PCI_VENDOR_ID_SYSKONNECT ,0x9E01 ) },/* SK-9E21M */
drivers/net/ethernet/mellanox/mlx4/main.c +1 -1
@@ -2508,7 +2508,7 @@ int mlx4_restart_one(struct pci_dev *pdev)return __mlx4_init_one (pdev, pci_dev_data); } -static DEFINE_PCI_DEVICE_TABLE (mlx4_pci_table) = { +static const struct pci_device_id mlx4_pci_table[] = {/* MT25408 "Hermon" SDR */ {PCI_VDEVICE (MELLANOX ,0x6340 ),MLX4_PCI_DEV_FORCE_SENSE_PORT },/* MT25408 "Hermon" DDR */
drivers/net/ethernet/micrel/ksz884x.c +1 -1
@@ -7225,7 +7225,7 @@ static int pcidev_suspend(struct pci_dev *pdev, pm_message_t state)static char pcidev_name[] ="ksz884xp" ; -static DEFINE_PCI_DEVICE_TABLE (pcidev_table) = { +static const struct pci_device_id pcidev_table[] = { {PCI_VENDOR_ID_MICREL_KS ,0x8841 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 }, {PCI_VENDOR_ID_MICREL_KS ,0x8842 ,
drivers/net/ethernet/myricom/myri10ge/myri10ge.c +1 -1
@@ -4213,7 +4213,7 @@ static void myri10ge_remove(struct pci_dev *pdev)#define PCI_DEVICE_ID_MYRICOM_MYRI10GE_Z8E 0x0008#define PCI_DEVICE_ID_MYRICOM_MYRI10GE_Z8E_9 0x0009 -static DEFINE_PCI_DEVICE_TABLE (myri10ge_pci_tbl) = { +static const struct pci_device_id myri10ge_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_MYRICOM ,PCI_DEVICE_ID_MYRICOM_MYRI10GE_Z8E )}, {PCI_DEVICE (PCI_VENDOR_ID_MYRICOM ,PCI_DEVICE_ID_MYRICOM_MYRI10GE_Z8E_9 )},
drivers/net/ethernet/natsemi/natsemi.c +1 -1
@@ -247,7 +247,7 @@ static struct { { "NatSemi DP8381[56]", 0, 24 }, }; -static DEFINE_PCI_DEVICE_TABLE (natsemi_pci_tbl) = { +static const struct pci_device_id natsemi_pci_tbl[] = { {PCI_VENDOR_ID_NS ,0x0020 ,0x12d9 ,0x000c ,0 ,0 ,0 }, {PCI_VENDOR_ID_NS ,0x0020 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,1 }, { } /* terminate list */
drivers/net/ethernet/natsemi/ns83820.c +1 -1
@@ -2263,7 +2263,7 @@ static void ns83820_remove_one(struct pci_dev *pci_dev)pci_set_drvdata (pci_dev,NULL ); } -static DEFINE_PCI_DEVICE_TABLE (ns83820_pci_tbl) = { +static const struct pci_device_id ns83820_pci_tbl[] = { {0x100b ,0x0022 ,PCI_ANY_ID ,PCI_ANY_ID ,0 , .driver_data =0 , }, {0 , }, };
drivers/net/ethernet/neterion/s2io.c +1 -1
@@ -471,7 +471,7 @@ module_param_array(rts_frm_len, uint, NULL, 0);* S2IO device table. * This table lists all the devices that this driver supports. */ -static DEFINE_PCI_DEVICE_TABLE (s2io_tbl) = { +static const struct pci_device_id s2io_tbl[] = { {PCI_VENDOR_ID_S2IO ,PCI_DEVICE_ID_S2IO_WIN ,PCI_ANY_ID ,PCI_ANY_ID }, {PCI_VENDOR_ID_S2IO ,PCI_DEVICE_ID_S2IO_UNI ,
drivers/net/ethernet/neterion/vxge/vxge-main.c +1 -1
@@ -63,7 +63,7 @@ MODULE_LICENSE("Dual BSD/GPL");MODULE_DESCRIPTION ("Neterion's X3100 Series 10GbE PCIe I/O" "Virtualized Server Adapter" ); -static DEFINE_PCI_DEVICE_TABLE (vxge_id_table) = { +static const struct pci_device_id vxge_id_table[] = { {PCI_VENDOR_ID_S2IO ,PCI_DEVICE_ID_TITAN_WIN ,PCI_ANY_ID ,PCI_ANY_ID }, {PCI_VENDOR_ID_S2IO ,PCI_DEVICE_ID_TITAN_UNI ,PCI_ANY_ID ,
drivers/net/ethernet/nvidia/forcedeth.c +1 -1
@@ -6178,7 +6178,7 @@ static void nv_shutdown(struct pci_dev *pdev)#define nv_shutdown NULL#endif /* CONFIG_PM */ -static DEFINE_PCI_DEVICE_TABLE (pci_tbl) = { +static const struct pci_device_id pci_tbl[] = { {/* nForce Ethernet Controller */ PCI_DEVICE (0x10DE ,0x01C3 ), .driver_data =DEV_NEED_TIMERIRQ |DEV_NEED_LINKTIMER ,
drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c +1 -1
@@ -2753,7 +2753,7 @@ static struct pch_gbe_privdata pch_gbe_minnow_privdata = { .platform_init = pch_gbe_minnow_platform_init, }; -static DEFINE_PCI_DEVICE_TABLE (pch_gbe_pcidev_id) = { +static const struct pci_device_id pch_gbe_pcidev_id[] = { {.vendor =PCI_VENDOR_ID_INTEL , .device =PCI_DEVICE_ID_INTEL_IOH1_GBE , .subvendor =PCI_VENDOR_ID_CIRCUITCO ,
drivers/net/ethernet/packetengines/hamachi.c +1 -1
@@ -1913,7 +1913,7 @@ static void hamachi_remove_one(struct pci_dev *pdev) } } -static DEFINE_PCI_DEVICE_TABLE (hamachi_pci_tbl) = { +static const struct pci_device_id hamachi_pci_tbl[] = { {0x1318 ,0x0911 ,PCI_ANY_ID ,PCI_ANY_ID , }, {0 , } };
drivers/net/ethernet/packetengines/yellowfin.c +1 -1
@@ -236,7 +236,7 @@ static const struct pci_id_info pci_id_tbl[] = { { } }; -static DEFINE_PCI_DEVICE_TABLE (yellowfin_pci_tbl) = { +static const struct pci_device_id yellowfin_pci_tbl[] = { {0x1000 ,0x0702 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 }, {0x1000 ,0x0701 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,1 }, { }
drivers/net/ethernet/pasemi/pasemi_mac.c +1 -1
@@ -1873,7 +1873,7 @@ static void pasemi_mac_remove(struct pci_dev *pdev)free_netdev (netdev); } -static DEFINE_PCI_DEVICE_TABLE (pasemi_mac_pci_tbl) = { +static const struct pci_device_id pasemi_mac_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_PASEMI ,0xa005 ) }, {PCI_DEVICE (PCI_VENDOR_ID_PASEMI ,0xa006 ) }, { },
drivers/net/ethernet/qlogic/netxen/netxen_nic_main.c +1 -1
@@ -101,7 +101,7 @@ static int netxen_nic_set_mac(struct net_device *netdev, void *p); {PCI_DEVICE(PCI_VENDOR_ID_NETXEN, (device)), \ .class = PCI_CLASS_NETWORK_ETHERNET << 8, .class_mask = ~0} -static DEFINE_PCI_DEVICE_TABLE (netxen_pci_tbl) = { +static const struct pci_device_id netxen_pci_tbl[] = {ENTRY (PCI_DEVICE_ID_NX2031_10GXSR ),ENTRY (PCI_DEVICE_ID_NX2031_10GCX4 ),ENTRY (PCI_DEVICE_ID_NX2031_4GCU ),
drivers/net/ethernet/qlogic/qla3xxx.c +1 -1
@@ -66,7 +66,7 @@ static int msi;module_param (msi, int,0 );MODULE_PARM_DESC (msi,"Turn on Message Signaled Interrupts." ); -static DEFINE_PCI_DEVICE_TABLE (ql3xxx_pci_tbl) = { +static const struct pci_device_id ql3xxx_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_QLOGIC ,QL3022_DEVICE_ID )}, {PCI_DEVICE (PCI_VENDOR_ID_QLOGIC ,QL3032_DEVICE_ID )},/* required last entry */
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c +1 -1
@@ -96,7 +96,7 @@ static u32 qlcnic_vlan_tx_check(struct qlcnic_adapter *adapter) {PCI_DEVICE(PCI_VENDOR_ID_QLOGIC, (device)), \ .class = PCI_CLASS_NETWORK_ETHERNET << 8, .class_mask = ~0} -static DEFINE_PCI_DEVICE_TABLE (qlcnic_pci_tbl) = { +static const struct pci_device_id qlcnic_pci_tbl[] = {ENTRY (PCI_DEVICE_ID_QLOGIC_QLE824X ),ENTRY (PCI_DEVICE_ID_QLOGIC_QLE834X ),ENTRY (PCI_DEVICE_ID_QLOGIC_VF_QLE834X ),
drivers/net/ethernet/qlogic/qlge/qlge_main.c +1 -1
@@ -87,7 +87,7 @@ MODULE_PARM_DESC(qlge_force_coredump,"Option to allow force of firmware core dump. " "Default is OFF - Do not allow."); -static DEFINE_PCI_DEVICE_TABLE (qlge_pci_tbl) = { +static const struct pci_device_id qlge_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_QLOGIC ,QLGE_DEVICE_ID_8012 )}, {PCI_DEVICE (PCI_VENDOR_ID_QLOGIC ,QLGE_DEVICE_ID_8000 )},/* required last entry */
drivers/net/ethernet/rdc/r6040.c +1 -1
@@ -1259,7 +1259,7 @@ static void r6040_remove_one(struct pci_dev *pdev) } -static DEFINE_PCI_DEVICE_TABLE (r6040_pci_tbl) = { +static const struct pci_device_id r6040_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_RDC ,0x6040 ) }, {0 } };
drivers/net/ethernet/realtek/8139cp.c +1 -1
@@ -382,7 +382,7 @@ static int cp_get_eeprom(struct net_device *dev,static int cp_set_eeprom (struct net_device *dev,struct ethtool_eeprom *eeprom,u8 *data); -static DEFINE_PCI_DEVICE_TABLE (cp_pci_tbl) = { +static const struct pci_device_id cp_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_REALTEK ,PCI_DEVICE_ID_REALTEK_8139 ), }, {PCI_DEVICE (PCI_VENDOR_ID_TTTECH ,PCI_DEVICE_ID_TTTECH_MC322 ), }, { },
drivers/net/ethernet/realtek/8139too.c +1 -1
@@ -234,7 +234,7 @@ static const struct { }; -static DEFINE_PCI_DEVICE_TABLE (rtl8139_pci_tbl) = { +static const struct pci_device_id rtl8139_pci_tbl[] = { {0x10ec ,0x8139 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,RTL8139 }, {0x10ec ,0x8138 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,RTL8139 }, {0x1113 ,0x1211 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,RTL8139 },
drivers/net/ethernet/realtek/r8169.c +1 -1
@@ -290,7 +290,7 @@ enum cfg_version {RTL_CFG_2 }; -static DEFINE_PCI_DEVICE_TABLE (rtl8169_pci_tbl) = { +static const struct pci_device_id rtl8169_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_REALTEK ,0x8129 ),0 ,0 ,RTL_CFG_0 }, {PCI_DEVICE (PCI_VENDOR_ID_REALTEK ,0x8136 ),0 ,0 ,RTL_CFG_2 }, {PCI_DEVICE (PCI_VENDOR_ID_REALTEK ,0x8167 ),0 ,0 ,RTL_CFG_0 },
drivers/net/ethernet/sfc/efx.c +1 -1
@@ -2468,7 +2468,7 @@ void efx_schedule_reset(struct efx_nic *efx, enum reset_type type)**************************************************************************/ /* PCI device ID table */ -static DEFINE_PCI_DEVICE_TABLE (efx_pci_table) = { +static const struct pci_device_id efx_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_SOLARFLARE ,PCI_DEVICE_ID_SOLARFLARE_SFC4000A_0 ), .driver_data = (unsigned long ) &falcon_a1_nic_type},
drivers/net/ethernet/sgi/ioc3-eth.c +1 -1
@@ -1385,7 +1385,7 @@ static void ioc3_remove_one(struct pci_dev *pdev)*/ } -static DEFINE_PCI_DEVICE_TABLE (ioc3_pci_tbl) = { +static const struct pci_device_id ioc3_pci_tbl[] = { {PCI_VENDOR_ID_SGI ,PCI_DEVICE_ID_SGI_IOC3 ,PCI_ANY_ID ,PCI_ANY_ID }, {0 } };
drivers/net/ethernet/silan/sc92031.c +1 -1
@@ -1561,7 +1561,7 @@ out:return 0 ; } -static DEFINE_PCI_DEVICE_TABLE (sc92031_pci_device_id_table) = { +static const struct pci_device_id sc92031_pci_device_id_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_SILAN ,0x2031 ) }, {PCI_DEVICE (PCI_VENDOR_ID_SILAN ,0x8139 ) }, {PCI_DEVICE (0x1088 ,0x2031 ) },
drivers/net/ethernet/sis/sis190.c +1 -1
@@ -330,7 +330,7 @@ static const struct { { "SiS 191 PCI Gigabit Ethernet adapter" }, }; -static DEFINE_PCI_DEVICE_TABLE (sis190_pci_tbl) = { +static const struct pci_device_id sis190_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_SI ,0x0190 ),0 ,0 ,0 }, {PCI_DEVICE (PCI_VENDOR_ID_SI ,0x0191 ),0 ,0 ,1 }, { 0, },
drivers/net/ethernet/sis/sis900.c +1 -1
@@ -106,7 +106,7 @@ static const char * card_names[] = {"SiS 900 PCI Fast Ethernet" ,"SiS 7016 PCI Fast Ethernet" }; -static DEFINE_PCI_DEVICE_TABLE (sis900_pci_tbl) = { +static const struct pci_device_id sis900_pci_tbl[] = { {PCI_VENDOR_ID_SI ,PCI_DEVICE_ID_SI_900 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,SIS_900 }, {PCI_VENDOR_ID_SI ,PCI_DEVICE_ID_SI_7016 ,
drivers/net/ethernet/smsc/epic100.c +1 -1
@@ -173,7 +173,7 @@ static const struct epic_chip_info pci_id_tbl[] = { }; -static DEFINE_PCI_DEVICE_TABLE (epic_pci_tbl) = { +static const struct pci_device_id epic_pci_tbl[] = { {0x10B8 ,0x0005 ,0x1092 ,0x0AB4 ,0 ,0 ,SMSC_83C170_0 }, {0x10B8 ,0x0005 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,SMSC_83C170 }, {0x10B8 ,0x0006 ,PCI_ANY_ID ,PCI_ANY_ID ,
drivers/net/ethernet/smsc/smsc9420.c +1 -1
@@ -84,7 +84,7 @@ struct smsc9420_pdata {int last_carrier; }; -static DEFINE_PCI_DEVICE_TABLE (smsc9420_id_table) = { +static const struct pci_device_id smsc9420_id_table[] = { {PCI_VENDOR_ID_9420 ,PCI_DEVICE_ID_9420 ,PCI_ANY_ID ,PCI_ANY_ID , }, {0 , } };
drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c +1 -1
@@ -170,7 +170,7 @@ static int stmmac_pci_resume(struct pci_dev *pdev)#define STMMAC_VENDOR_ID 0x700#define STMMAC_DEVICE_ID 0x1108 -static DEFINE_PCI_DEVICE_TABLE (stmmac_id_table) = { +static const struct pci_device_id stmmac_id_table[] = { {PCI_DEVICE (STMMAC_VENDOR_ID ,STMMAC_DEVICE_ID )}, {PCI_DEVICE (PCI_VENDOR_ID_STMICRO ,PCI_DEVICE_ID_STMICRO_MAC )}, {}
drivers/net/ethernet/sun/cassini.c +1 -1
@@ -231,7 +231,7 @@ static u16 link_modes[] = {CAS_BMCR_SPEED1000 |BMCR_FULLDPLX /* 5 : 1000bt full duplex */ }; -static DEFINE_PCI_DEVICE_TABLE (cas_pci_tbl) = { +static const struct pci_device_id cas_pci_tbl[] = { {PCI_VENDOR_ID_SUN ,PCI_DEVICE_ID_SUN_CASSINI ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0UL }, {PCI_VENDOR_ID_NS ,PCI_DEVICE_ID_NS_SATURN ,
drivers/net/ethernet/sun/niu.c +1 -1
@@ -59,7 +59,7 @@ static void writeq(u64 val, void __iomem *reg) }#endif -static DEFINE_PCI_DEVICE_TABLE (niu_pci_tbl) = { +static const struct pci_device_id niu_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_SUN ,0xabcd )}, {} };
drivers/net/ethernet/sun/sungem.c +1 -1
@@ -86,7 +86,7 @@ MODULE_LICENSE("GPL");#define GEM_MODULE_NAME "gem" -static DEFINE_PCI_DEVICE_TABLE (gem_pci_tbl) = { +static const struct pci_device_id gem_pci_tbl[] = { {PCI_VENDOR_ID_SUN ,PCI_DEVICE_ID_SUN_GEM ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0UL },
drivers/net/ethernet/sun/sunhme.c +1 -1
@@ -3172,7 +3172,7 @@ static void happy_meal_pci_remove(struct pci_dev *pdev)free_netdev (net_dev); } -static DEFINE_PCI_DEVICE_TABLE (happymeal_pci_ids) = { +static const struct pci_device_id happymeal_pci_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_SUN ,PCI_DEVICE_ID_SUN_HAPPYMEAL ) }, { }/* Terminating entry */ };
drivers/net/ethernet/tehuti/tehuti.c +1 -1
@@ -66,7 +66,7 @@#include "tehuti.h" -static DEFINE_PCI_DEVICE_TABLE (bdx_pci_tbl) = { +static const struct pci_device_id bdx_pci_tbl[] = { {PCI_VDEVICE (TEHUTI ,0x3009 ), }, {PCI_VDEVICE (TEHUTI ,0x3010 ), }, {PCI_VDEVICE (TEHUTI ,0x3014 ), },
drivers/net/ethernet/ti/tlan.c +1 -1
@@ -118,7 +118,7 @@ static struct board { TLAN_ADAPTER_ACTIVITY_LED, 0x83 }, /* EISA card */ }; -static DEFINE_PCI_DEVICE_TABLE (tlan_pci_tbl) = { +static const struct pci_device_id tlan_pci_tbl[] = { {PCI_VENDOR_ID_COMPAQ ,PCI_DEVICE_ID_COMPAQ_NETEL10 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 }, {PCI_VENDOR_ID_COMPAQ ,PCI_DEVICE_ID_COMPAQ_NETEL100 ,
drivers/net/ethernet/toshiba/spider_net.c +1 -1
@@ -73,7 +73,7 @@ MODULE_PARM_DESC(tx_descriptors, "number of descriptors used " \char spider_net_driver_name[] ="spidernet" ; -static DEFINE_PCI_DEVICE_TABLE (spider_net_pci_tbl) = { +static const struct pci_device_id spider_net_pci_tbl[] = { {PCI_VENDOR_ID_TOSHIBA_2 ,PCI_DEVICE_ID_TOSHIBA_SPIDER_NET ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0UL }, {0 , }
drivers/net/ethernet/toshiba/tc35815.c +1 -1
@@ -66,7 +66,7 @@ static const struct { { "TOSHIBA TC35815/TX4939" }, }; -static DEFINE_PCI_DEVICE_TABLE (tc35815_pci_tbl) = { +static const struct pci_device_id tc35815_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_TOSHIBA_2 ,PCI_DEVICE_ID_TOSHIBA_TC35815CF ), .driver_data =TC35815CF }, {PCI_DEVICE (PCI_VENDOR_ID_TOSHIBA_2 ,PCI_DEVICE_ID_TOSHIBA_TC35815_NWU ), .driver_data =TC35815_NWU }, {PCI_DEVICE(PCI_VENDOR_ID_TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_TC35815_TX4939), .driver_data = TC35815_TX4939 },
drivers/net/ethernet/via/via-rhine.c +1 -1
@@ -270,7 +270,7 @@ enum rhine_quirks {/* Beware of PCI posted writes */ #define IOSYNC do { ioread8(ioaddr + StationAddr); } while (0) -static DEFINE_PCI_DEVICE_TABLE (rhine_pci_tbl) = { +static const struct pci_device_id rhine_pci_tbl[] = { {0x1106 ,0x3043 ,PCI_ANY_ID ,PCI_ANY_ID , },/* VT86C100A */ {0x1106 ,0x3065 ,PCI_ANY_ID ,PCI_ANY_ID , },/* VT6102 */ {0x1106 ,0x3106 ,PCI_ANY_ID ,PCI_ANY_ID , },/* 6105{,L,LOM} */
drivers/net/ethernet/via/via-velocity.c +1 -1
@@ -381,7 +381,7 @@ static struct velocity_info_tbl chip_info_table[] = {* device driver. Used for hotplug autoloading. */ -static DEFINE_PCI_DEVICE_TABLE (velocity_pci_id_table) = { +static const struct pci_device_id velocity_pci_id_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_612X ) }, { } };
drivers/net/fddi/defxx.c +1 -1
@@ -3622,7 +3622,7 @@ static int __maybe_unused dfx_dev_unregister(struct device *);static int dfx_pci_register (struct pci_dev *,const struct pci_device_id *);static void dfx_pci_unregister (struct pci_dev *); -static DEFINE_PCI_DEVICE_TABLE (dfx_pci_table) = { +static const struct pci_device_id dfx_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_DEC ,PCI_DEVICE_ID_DEC_FDDI ) }, { } };
drivers/net/fddi/skfp/skfddi.c +1 -1
@@ -149,7 +149,7 @@ extern void mac_drv_rx_mode(struct s_smc *smc, int mode);extern void mac_drv_clear_rx_queue (struct s_smc *smc);extern void enable_tx_irq (struct s_smc *smc,u_short queue); -static DEFINE_PCI_DEVICE_TABLE (skfddi_pci_tbl) = { +static const struct pci_device_id skfddi_pci_tbl[] = { {PCI_VENDOR_ID_SK ,PCI_DEVICE_ID_SK_FP ,PCI_ANY_ID ,PCI_ANY_ID , }, { }/* Terminating entry */ };
drivers/net/hippi/rrunner.c +1 -1
@@ -1672,7 +1672,7 @@ static int rr_ioctl(struct net_device *dev, struct ifreq *rq, int cmd) } } -static DEFINE_PCI_DEVICE_TABLE (rr_pci_tbl) = { +static const struct pci_device_id rr_pci_tbl[] = { {PCI_VENDOR_ID_ESSENTIAL ,PCI_DEVICE_ID_ESSENTIAL_ROADRUNNER ,PCI_ANY_ID ,PCI_ANY_ID , }, {0 ,}
drivers/net/irda/donauboe.c +1 -1
@@ -184,7 +184,7 @@#define CONFIG0H_DMA_ON_NORX CONFIG0H_DMA_OFF| OBOE_CONFIG0H_ENDMAC#define CONFIG0H_DMA_ON CONFIG0H_DMA_ON_NORX | OBOE_CONFIG0H_ENRX -static DEFINE_PCI_DEVICE_TABLE (toshoboe_pci_tbl) = { +static const struct pci_device_id toshoboe_pci_tbl[] = { {PCI_VENDOR_ID_TOSHIBA ,PCI_DEVICE_ID_FIR701 ,PCI_ANY_ID ,PCI_ANY_ID , }, {PCI_VENDOR_ID_TOSHIBA ,PCI_DEVICE_ID_FIRD01 ,PCI_ANY_ID ,PCI_ANY_ID , }, { }/* Terminating entry */
drivers/net/irda/via-ircc.c +1 -1
@@ -116,7 +116,7 @@ static void iodelay(int udelay) } } -static DEFINE_PCI_DEVICE_TABLE (via_pci_tbl) = { +static const struct pci_device_id via_pci_tbl[] = { {PCI_VENDOR_ID_VIA ,0x8231 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 }, {PCI_VENDOR_ID_VIA ,0x3109 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,1 }, {PCI_VENDOR_ID_VIA ,0x3074 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,2 },
drivers/net/irda/vlsi_ir.c +1 -1
@@ -60,7 +60,7 @@ MODULE_LICENSE("GPL");static /* const */ char drivername[] =DRIVER_NAME ; -static DEFINE_PCI_DEVICE_TABLE (vlsi_irda_table) = { +static const struct pci_device_id vlsi_irda_table[] = { { .class =PCI_CLASS_WIRELESS_IRDA <<8 , .class_mask =PCI_CLASS_SUBCLASS_MASK <<8 ,
drivers/net/vmxnet3/vmxnet3_drv.c +1 -1
@@ -36,7 +36,7 @@ char vmxnet3_driver_name[] = "vmxnet3";* PCI Device ID Table * Last entry must be all 0s */ -static DEFINE_PCI_DEVICE_TABLE (vmxnet3_pciid_table) = { +static const struct pci_device_id vmxnet3_pciid_table[] = { {PCI_VDEVICE (VMWARE ,PCI_DEVICE_ID_VMWARE_VMXNET3 )}, {0 } };
drivers/net/wan/dscc4.c +1 -1
@@ -2041,7 +2041,7 @@ static int __init dscc4_setup(char *str)__setup ("dscc4.setup=" , dscc4_setup);#endif -static DEFINE_PCI_DEVICE_TABLE (dscc4_pci_tbl) = { +static const struct pci_device_id dscc4_pci_tbl[] = { {PCI_VENDOR_ID_SIEMENS ,PCI_DEVICE_ID_SIEMENS_DSCC4 ,PCI_ANY_ID ,PCI_ANY_ID , }, {0 ,}
drivers/net/wan/farsync.c +1 -1
@@ -530,7 +530,7 @@ do { \/* * PCI ID lookup table */ -static DEFINE_PCI_DEVICE_TABLE (fst_pci_dev_id) = { +static const struct pci_device_id fst_pci_dev_id[] = { {PCI_VENDOR_ID_FARSITE ,PCI_DEVICE_ID_FARSITE_T2P ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,FST_TYPE_T2P },
drivers/net/wan/lmc/lmc_main.c +1 -1
@@ -77,7 +77,7 @@static int LMC_PKT_BUF_SZ =1542 ; -static DEFINE_PCI_DEVICE_TABLE (lmc_pci_tbl) = { +static const struct pci_device_id lmc_pci_tbl = { {PCI_VENDOR_ID_DEC ,PCI_DEVICE_ID_DEC_TULIP_FAST ,PCI_VENDOR_ID_LMC ,PCI_ANY_ID }, {PCI_VENDOR_ID_DEC ,PCI_DEVICE_ID_DEC_TULIP_FAST ,
drivers/net/wan/pc300too.c +1 -1
@@ -478,7 +478,7 @@ static int pc300_pci_init_one(struct pci_dev *pdev, -static DEFINE_PCI_DEVICE_TABLE (pc300_pci_tbl) = { +static const struct pci_device_id pc300_pci_tbl[] = { {PCI_VENDOR_ID_CYCLADES ,PCI_DEVICE_ID_PC300_RX_1 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 }, {PCI_VENDOR_ID_CYCLADES ,PCI_DEVICE_ID_PC300_RX_2 ,PCI_ANY_ID ,
drivers/net/wan/pci200syn.c +1 -1
@@ -415,7 +415,7 @@ static int pci200_pci_init_one(struct pci_dev *pdev, -static DEFINE_PCI_DEVICE_TABLE (pci200_pci_tbl) = { +static const struct pci_device_id pci200_pci_tbl[] = { {PCI_VENDOR_ID_PLX ,PCI_DEVICE_ID_PLX_9050 ,PCI_VENDOR_ID_PLX ,PCI_DEVICE_ID_PLX_PCI200SYN ,0 ,0 ,0 }, {0 , }
drivers/net/wan/wanxl.c +1 -1
@@ -808,7 +808,7 @@ static int wanxl_pci_init_one(struct pci_dev *pdev,return 0 ; } -static DEFINE_PCI_DEVICE_TABLE (wanxl_pci_tbl) = { +static const struct pci_device_id wanxl_pci_tbl[] = { {PCI_VENDOR_ID_SBE ,PCI_DEVICE_ID_SBE_WANXL100 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 }, {PCI_VENDOR_ID_SBE ,PCI_DEVICE_ID_SBE_WANXL200 ,PCI_ANY_ID ,
drivers/net/wireless/adm8211.c +1 -1
@@ -42,7 +42,7 @@ static unsigned int rx_ring_size __read_mostly = 16;module_param (tx_ring_size, uint,0 );module_param (rx_ring_size, uint,0 ); -static DEFINE_PCI_DEVICE_TABLE (adm8211_pci_id_table) = { +static const struct pci_device_id adm8211_pci_id_table[] = {/* ADMtek ADM8211 */ {PCI_DEVICE (0x10B7 ,0x6000 ) },/* 3Com 3CRSHPW796 */ {PCI_DEVICE (0x1200 ,0x8201 ) },/* ? */
drivers/net/wireless/airo.c +1 -1
@@ -57,7 +57,7 @@#define DRV_NAME "airo"#ifdef CONFIG_PCI -static DEFINE_PCI_DEVICE_TABLE (card_ids) = { +static const struct pci_device_id card_ids[] = { {0x14b9 ,1 ,PCI_ANY_ID ,PCI_ANY_ID , }, {0x14b9 ,0x4500 ,PCI_ANY_ID ,PCI_ANY_ID }, { 0x14b9, 0x4800, PCI_ANY_ID, PCI_ANY_ID, },
drivers/net/wireless/ath/ath10k/pci.c +1 -1
@@ -38,7 +38,7 @@ MODULE_PARM_DESC(ath10k_target_ps, "Enable ath10k Target (SoC) PS option");#define QCA988X_2_0_DEVICE_ID (0x003c) -static DEFINE_PCI_DEVICE_TABLE (ath10k_pci_id_table) = { +static const struct pci_device_id ath10k_pci_id_table[] = { {PCI_VDEVICE (ATHEROS ,QCA988X_2_0_DEVICE_ID ) },/* PCI-E QCA988X V2 */ {0 } };
drivers/net/wireless/ath/ath5k/led.c +1 -1
@@ -53,7 +53,7 @@#define ATH_POLARITY (data) ((data) & 0xff)/* Devices we match on for LED config info (typically laptops) */ -static DEFINE_PCI_DEVICE_TABLE (ath5k_led_devices) = { +static const struct pci_device_id ath5k_led_devices[] = {/* AR5211 */ {PCI_VDEVICE (ATHEROS ,PCI_DEVICE_ID_ATHEROS_AR5211 ),ATH_LED (0 ,0 ) },/* HP Compaq nc6xx, nc4000, nx6000 */
drivers/net/wireless/ath/ath5k/pci.c +1 -1
@@ -28,7 +28,7 @@#include "reg.h" /* Known PCI ids */ -static DEFINE_PCI_DEVICE_TABLE (ath5k_pci_id_table) = { +static const struct pci_device_id ath5k_pci_id_table[] = { {PCI_VDEVICE (ATHEROS ,0x0207 ) },/* 5210 early */ {PCI_VDEVICE (ATHEROS ,0x0007 ) },/* 5210 */ {PCI_VDEVICE (ATHEROS ,0x0011 ) },/* 5311 - this is on AHB bus !*/
drivers/net/wireless/ath/ath9k/pci.c +1 -1
@@ -23,7 +23,7 @@#include <linux/module.h> #include "ath9k.h" -static DEFINE_PCI_DEVICE_TABLE (ath_pci_id_table) = { +static const struct pci_device_id ath_pci_id_table[] = { {PCI_VDEVICE (ATHEROS ,0x0023 ) },/* PCI */ {PCI_VDEVICE (ATHEROS ,0x0024 ) },/* PCI-E */ {PCI_VDEVICE (ATHEROS ,0x0027 ) },/* PCI */
drivers/net/wireless/ath/wil6210/pcie_bus.c +1 -1
@@ -199,7 +199,7 @@ static void wil_pcie_remove(struct pci_dev *pdev)pci_disable_device (pdev); } -static DEFINE_PCI_DEVICE_TABLE (wil6210_pcie_ids) = { +static const struct pci_device_id wil6210_pcie_ids[] = { {PCI_DEVICE (0x1ae9 ,0x0301 ) }, {/* end: all zeroes */ }, };
drivers/net/wireless/atmel_pci.c +1 -1
@@ -31,7 +31,7 @@ MODULE_DESCRIPTION("Support for Atmel at76c50x 802.11 wireless ethernet cards.")MODULE_LICENSE ("GPL" );MODULE_SUPPORTED_DEVICE ("Atmel at76c506 PCI wireless cards" ); -static DEFINE_PCI_DEVICE_TABLE (card_ids) = { +static const struct pci_device_id card_ids[] = { {0x1114 ,0x0506 ,PCI_ANY_ID ,PCI_ANY_ID }, {0 , } };
drivers/net/wireless/hostap/hostap_pci.c +1 -1
@@ -40,7 +40,7 @@ struct hostap_pci_priv {/* FIX: do we need mb/wmb/rmb with memory operations? */ -static DEFINE_PCI_DEVICE_TABLE (prism2_pci_id_table) = { +static const struct pci_device_id prism2_pci_id_table[] = {/* Intersil Prism3 ISL3872 11Mb/s WLAN Controller */ {0x1260 ,0x3872 ,PCI_ANY_ID ,PCI_ANY_ID },/* Intersil Prism2.5 ISL3874 11Mb/s WLAN Controller */
drivers/net/wireless/hostap/hostap_plx.c +1 -1
@@ -61,7 +61,7 @@ struct hostap_plx_priv {#define PLXDEV (vendor,dev,str) { vendor, dev, PCI_ANY_ID, PCI_ANY_ID } -static DEFINE_PCI_DEVICE_TABLE (prism2_plx_id_table) = { +static const struct pci_device_id prism2_plx_id_table[] = {PLXDEV (0x10b7 ,0x7770 ,"3Com AirConnect PCI 777A" ),PLXDEV (0x111a ,0x1023 ,"Siemens SpeedStream SS1023" ),PLXDEV (0x126c ,0x8030 ,"Nortel emobility" ),
drivers/net/wireless/ipw2x00/ipw2100.c +1 -1
@@ -6512,7 +6512,7 @@ static void ipw2100_shutdown(struct pci_dev *pci_dev)#define IPW2100_DEV_ID (x) { PCI_VENDOR_ID_INTEL, 0x1043, 0x8086, x } -static DEFINE_PCI_DEVICE_TABLE (ipw2100_pci_id_table) = { +static const struct pci_device_id ipw2100_pci_id_table[] = {IPW2100_DEV_ID (0x2520 ),/* IN 2100A mPCI 3A */ IPW2100_DEV_ID (0x2521 ),/* IN 2100A mPCI 3B */ IPW2100_DEV_ID (0x2524 ),/* IN 2100A mPCI 3B */
drivers/net/wireless/ipw2x00/ipw2200.c +1 -1
@@ -11542,7 +11542,7 @@ out: }/* PCI driver stuff */ -static DEFINE_PCI_DEVICE_TABLE (card_ids) = { +static const struct pci_device_id card_ids[] = { {PCI_VENDOR_ID_INTEL ,0x1043 ,0x8086 ,0x2701 ,0 ,0 ,0 }, {PCI_VENDOR_ID_INTEL ,0x1043 ,0x8086 ,0x2702 ,0 ,0 ,0 }, {PCI_VENDOR_ID_INTEL ,0x1043 ,0x8086 ,0x2711 ,0 ,0 ,0 },
drivers/net/wireless/iwlegacy/3945.c +1 -1
@@ -2729,7 +2729,7 @@ static struct il_cfg il3945_abg_cfg = { }, }; -DEFINE_PCI_DEVICE_TABLE (il3945_hw_card_ids) = { +const struct pci_device_id il3945_hw_card_ids[] = { {IL_PCI_DEVICE (0x4222 ,0x1005 , il3945_bg_cfg)}, {IL_PCI_DEVICE (0x4222 ,0x1034 , il3945_bg_cfg)}, {IL_PCI_DEVICE (0x4222 ,0x1044 , il3945_bg_cfg)},
drivers/net/wireless/iwlegacy/4965-mac.c +1 -1
@@ -6811,7 +6811,7 @@ il4965_txq_set_sched(struct il_priv *il, u32 mask)*****************************************************************************/ /* Hardware specific file defines the PCI IDs table for that hardware module */ -static DEFINE_PCI_DEVICE_TABLE (il4965_hw_card_ids) = { +static const struct pci_device_id il4965_hw_card_ids[] = { {IL_PCI_DEVICE (0x4229 ,PCI_ANY_ID , il4965_cfg)}, {IL_PCI_DEVICE (0x4230 ,PCI_ANY_ID , il4965_cfg)}, {0 }
drivers/net/wireless/iwlwifi/pcie/drv.c +1 -1
@@ -77,7 +77,7 @@ .driver_data = (kernel_ulong_t)&(cfg) /* Hardware specific file defines the PCI IDs table for that hardware module */ -static DEFINE_PCI_DEVICE_TABLE(iwl_hw_card_ids) = { +static const struct pci_device_id iwl_hw_card_ids[] = {#if IS_ENABLED (CONFIG_IWLDVM ) {IWL_PCI_DEVICE(0x4232, 0x1201, iwl5100_agn_cfg)}, /* Mini Card */ {IWL_PCI_DEVICE(0x4232, 0x1301, iwl5100_agn_cfg)}, /* Half Mini Card */
drivers/net/wireless/mwifiex/pcie.c +1 -1
@@ -242,7 +242,7 @@ static void mwifiex_pcie_shutdown(struct pci_dev *pdev)return ; } -static DEFINE_PCI_DEVICE_TABLE (mwifiex_ids) = { +static const struct pci_device_id mwifiex_ids[] = { {PCIE_VENDOR_ID_MARVELL ,PCIE_DEVICE_ID_MARVELL_88W8766P ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,
drivers/net/wireless/mwl8k.c +1 -1
@@ -5497,7 +5497,7 @@ MODULE_FIRMWARE("mwl8k/helper_8366.fw");MODULE_FIRMWARE ("mwl8k/fmimage_8366.fw" );MODULE_FIRMWARE (MWL8K_8366_AP_FW (MWL8K_8366_AP_FW_API )); -static DEFINE_PCI_DEVICE_TABLE (mwl8k_pci_id_table) = { +static const struct pci_device_id mwl8k_pci_id_table[] = { {PCI_VDEVICE (MARVELL ,0x2a0a ), .driver_data =MWL8363 , }, {PCI_VDEVICE (MARVELL ,0x2a0c ), .driver_data =MWL8363 , }, {PCI_VDEVICE (MARVELL ,0x2a24 ), .driver_data =MWL8363 , },
drivers/net/wireless/orinoco/orinoco_nortel.c +1 -1
@@ -272,7 +272,7 @@ static void orinoco_nortel_remove_one(struct pci_dev *pdev)pci_disable_device (pdev); } -static DEFINE_PCI_DEVICE_TABLE (orinoco_nortel_id_table) = { +static const struct pci_device_id orinoco_nortel_id_table[] = {/* Nortel emobility PCI */ {0x126c ,0x8030 ,PCI_ANY_ID ,PCI_ANY_ID ,},/* Symbol LA-4123 PCI */
drivers/net/wireless/orinoco/orinoco_pci.c +1 -1
@@ -210,7 +210,7 @@ static void orinoco_pci_remove_one(struct pci_dev *pdev)pci_disable_device (pdev); } -static DEFINE_PCI_DEVICE_TABLE (orinoco_pci_id_table) = { +static const struct pci_device_id orinoco_pci_id_table[] = {/* Intersil Prism 3 */ {0x1260 ,0x3872 ,PCI_ANY_ID ,PCI_ANY_ID ,},/* Intersil Prism 2.5 */
drivers/net/wireless/orinoco/orinoco_plx.c +1 -1
@@ -308,7 +308,7 @@ static void orinoco_plx_remove_one(struct pci_dev *pdev)pci_disable_device (pdev); } -static DEFINE_PCI_DEVICE_TABLE (orinoco_plx_id_table) = { +static const struct pci_device_id orinoco_plx_id_table[] = { {0x111a ,0x1023 ,PCI_ANY_ID ,PCI_ANY_ID ,},/* Siemens SpeedStream SS1023 */ {0x1385 ,0x4100 ,PCI_ANY_ID ,PCI_ANY_ID ,},/* Netgear MA301 */ {0x15e8 ,0x0130 ,PCI_ANY_ID ,PCI_ANY_ID ,},/* Correga - does this work? */
drivers/net/wireless/orinoco/orinoco_tmd.c +1 -1
@@ -201,7 +201,7 @@ static void orinoco_tmd_remove_one(struct pci_dev *pdev)pci_disable_device (pdev); } -static DEFINE_PCI_DEVICE_TABLE (orinoco_tmd_id_table) = { +static const struct pci_device_id orinoco_tmd_id_table[] = { {0x15e8 ,0x0131 ,PCI_ANY_ID ,PCI_ANY_ID ,},/* NDC and OEMs, e.g. pheecom */ {0 ,}, };
drivers/net/wireless/p54/p54pci.c +1 -1
@@ -33,7 +33,7 @@ MODULE_LICENSE("GPL");MODULE_ALIAS ("prism54pci" );MODULE_FIRMWARE ("isl3886pci" ); -static DEFINE_PCI_DEVICE_TABLE (p54p_table) = { +static const struct pci_device_id p54p_table[] = {/* Intersil PRISM Duette/Prism GT Wireless LAN adapter */ {PCI_DEVICE (0x1260 ,0x3890 ) },/* 3COM 3CRWE154G72 Wireless LAN adapter */
drivers/net/wireless/prism54/islpci_hotplug.c +1 -1
@@ -40,7 +40,7 @@ module_param(init_pcitm, int, 0);* driver_data * If you have an update for this please contact [email protected] * The latest list can be found at http://wireless.kernel.org/en/users/Drivers/p54 */ -static DEFINE_PCI_DEVICE_TABLE (prism54_id_tbl) = { +static const struct pci_device_id prism54_id_tbl[] = {/* Intersil PRISM Duette/Prism GT Wireless LAN adapter */ {0x1260 ,0x3890 ,
drivers/net/wireless/rt2x00/rt2400pci.c +1 -1
@@ -1824,7 +1824,7 @@ static const struct rt2x00_ops rt2400pci_ops = {/* * RT2400pci module information. */ -static DEFINE_PCI_DEVICE_TABLE (rt2400pci_device_table) = { +static const struct pci_device_id rt2400pci_device_table[] = { {PCI_DEVICE (0x1814 ,0x0101 ) }, {0 , } };
drivers/net/wireless/rt2x00/rt2500pci.c +1 -1
@@ -2113,7 +2113,7 @@ static const struct rt2x00_ops rt2500pci_ops = {/* * RT2500pci module information. */ -static DEFINE_PCI_DEVICE_TABLE (rt2500pci_device_table) = { +static const struct pci_device_id rt2500pci_device_table[] = { {PCI_DEVICE (0x1814 ,0x0201 ) }, {0 , } };
drivers/net/wireless/rt2x00/rt2800pci.c +1 -1
@@ -402,7 +402,7 @@ static const struct rt2x00_ops rt2800pci_ops = {/* * RT2800pci module information. */ -static DEFINE_PCI_DEVICE_TABLE (rt2800pci_device_table) = { +static const struct pci_device_id rt2800pci_device_table[] = { {PCI_DEVICE (0x1814 ,0x0601 ) }, {PCI_DEVICE (0x1814 ,0x0681 ) }, {PCI_DEVICE (0x1814 ,0x0701 ) },
drivers/net/wireless/rt2x00/rt61pci.c +1 -1
@@ -3078,7 +3078,7 @@ static const struct rt2x00_ops rt61pci_ops = {/* * RT61pci module information. */ -static DEFINE_PCI_DEVICE_TABLE (rt61pci_device_table) = { +static const struct pci_device_id rt61pci_device_table[] = {/* RT2561s */ {PCI_DEVICE (0x1814 ,0x0301 ) },/* RT2561 v2 */
drivers/net/wireless/rtl818x/rtl8180/dev.c +1 -1
@@ -36,7 +36,7 @@ MODULE_AUTHOR("Andrea Merello <[email protected]>");MODULE_DESCRIPTION ("RTL8180 / RTL8185 PCI wireless driver" );MODULE_LICENSE ("GPL" ); -static DEFINE_PCI_DEVICE_TABLE (rtl8180_table) = { +static const struct pci_device_id rtl8180_table[] = {/* rtl8185 */ {PCI_DEVICE (PCI_VENDOR_ID_REALTEK ,0x8185 ) }, {PCI_DEVICE (PCI_VENDOR_ID_BELKIN ,0x700f ) },
drivers/net/wireless/rtlwifi/rtl8188ee/sw.c +1 -1
@@ -363,7 +363,7 @@ static struct rtl_hal_cfg rtl88ee_hal_cfg = { .maps[RTL_RC_HT_RATEMCS15] = DESC92C_RATEMCS15, }; -static DEFINE_PCI_DEVICE_TABLE (rtl88ee_pci_ids) = { +static const struct pci_device_id rtl88ee_pci_ids[] = { {RTL_PCI_DEVICE (PCI_VENDOR_ID_REALTEK ,0x8179 , rtl88ee_hal_cfg)}, {}, };
drivers/net/wireless/rtlwifi/rtl8192ce/sw.c +1 -1
@@ -345,7 +345,7 @@ static struct rtl_hal_cfg rtl92ce_hal_cfg = { .maps[RTL_RC_HT_RATEMCS15] = DESC92_RATEMCS15, }; -static DEFINE_PCI_DEVICE_TABLE (rtl92ce_pci_ids) = { +static const struct pci_device_id rtl92ce_pci_ids[] = { {RTL_PCI_DEVICE (PCI_VENDOR_ID_REALTEK ,0x8191 , rtl92ce_hal_cfg)}, {RTL_PCI_DEVICE (PCI_VENDOR_ID_REALTEK ,0x8178 , rtl92ce_hal_cfg)}, {RTL_PCI_DEVICE (PCI_VENDOR_ID_REALTEK ,0x8177 , rtl92ce_hal_cfg)},
Signature · 1 line
1.7.10.4
Re: [PATCH 20/39] net: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 4 lines · On Tue, 03 Dec 2013 08:19:25 +0900 Jingoo Han <[email protected]> wrote:
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>
Perhaps a little more explanation why it is not preferred. Not everyone tracks LKML or the PCI list.
Re: [PATCH 20/39] net: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 10 lines · Stephen Hemminger
Quoted 4 lines · On Tue, 03 Dec 2013 08:19:25 +0900 Jingoo Han <[email protected]> wrote:
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>Perhaps a little more explanation why it is not preferred. Not everyone tracks LKML or the PCI list.
(+cc Joe Perches, Jonas Bonn)
It is simple.
There is no special reason to use DEFINE_PCI_DEVICE_TABLE macro.
According to the Greg Kroah-Hartman,
"Yeah, and it's a horrid macro that deserves to be removed, please don't use it in more places."
Currently, there is no other bus that has something like this macro for their device ids. Thus, DEFINE_PCI_DEVICE_TABLE macro should be removed.
Jonas Bonn (author of DEFINE_PCI_DEVICE_TABLE macro) also agreed to remove this macro. According to Jonas Bonn, "Actually, I think I submitted an even uglier macro called DECLARE_PCI_DEVICE_TABLE... might have been the first kernel Patch I ever sent? In any case, it should certainly have been kindly rejected."
After Joe Perches's patch[1] is merged, I will send these patches to each subsystem maintainer.
[1][PATCH] pci/checkpatch: Deprecate DEFINE_PCI_DEVICE_TABLE
(http://lkml.org/lkml/2013/12/2/400)
In this patch, Joe Perches fixed 'Documentation/PCI/pci.txt', and 'scripts/checkpatch.pl', in order to guide to use 'struct pci_device_id' instead of 'DEFINE_PCI_DEVICE_TABLE' macro.
Thank you.
Best regards,
Jingoo Han
PATCH 21/39 NTB: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/ntb/ntb_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ntb/ntb_hw.c +1 -1
@@ -91,7 +91,7 @@ static struct dentry *debugfs_dir;/* Translate memory window 0,1 to BAR 2,4 */ #define MW_TO_BAR (mw) (mw * NTB_MAX_NUM_MW + 2) -static DEFINE_PCI_DEVICE_TABLE (ntb_pci_tbl) = { +static const struct pci_device_id ntb_pci_tbl[] = { {PCI_VDEVICE (INTEL ,PCI_DEVICE_ID_INTEL_NTB_B2B_BWD )}, {PCI_VDEVICE (INTEL ,PCI_DEVICE_ID_INTEL_NTB_B2B_JSF )}, {PCI_VDEVICE (INTEL ,PCI_DEVICE_ID_INTEL_NTB_B2B_SNB )},
Signature · 1 line
1.7.10.4
PATCH 22/39 pcmcia: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/pcmcia/bcm63xx_pcmcia.c | 2 +- drivers/pcmcia/i82092.c | 2 +- drivers/pcmcia/pd6729.c | 2 +- drivers/pcmcia/vrc4173_cardu.c | 2 +- drivers/pcmcia/yenta_socket.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
drivers/pcmcia/bcm63xx_pcmcia.c +1 -1
@@ -475,7 +475,7 @@ static void bcm63xx_cb_exit(struct pci_dev *dev) bcm63xx_cb_dev =NULL ; } -static DEFINE_PCI_DEVICE_TABLE (bcm63xx_cb_table) = { +static const struct pci_device_id bcm63xx_cb_table[] = { { .vendor =PCI_VENDOR_ID_BROADCOM , .device =BCM6348_CPU_ID ,
drivers/pcmcia/i82092.c +1 -1
@@ -25,7 +25,7 @@MODULE_LICENSE ("GPL" );/* PCI core routines */ -static DEFINE_PCI_DEVICE_TABLE (i82092aa_pci_ids) = { +static const struct pci_device_id i82092aa_pci_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_82092AA_0 ) }, { } };
drivers/pcmcia/pd6729.c +1 -1
@@ -764,7 +764,7 @@ static void pd6729_pci_remove(struct pci_dev *dev)kfree (socket); } -static DEFINE_PCI_DEVICE_TABLE (pd6729_pci_ids) = { +static const struct pci_device_id pd6729_pci_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_CIRRUS ,PCI_DEVICE_ID_CIRRUS_6729 ) }, { } };
drivers/pcmcia/vrc4173_cardu.c +1 -1
@@ -563,7 +563,7 @@ static int vrc4173_cardu_setup(char *options)__setup ("vrc4173_cardu=" , vrc4173_cardu_setup); -static DEFINE_PCI_DEVICE_TABLE (vrc4173_cardu_id_table) = { +static const struct pci_device_id vrc4173_cardu_id_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_NEC ,PCI_DEVICE_ID_NEC_NAPCCARD ) }, {0 , } };
drivers/pcmcia/yenta_socket.c +1 -1
@@ -1352,7 +1352,7 @@ static const struct dev_pm_ops yenta_pm_ops = { .driver_data = CARDBUS_TYPE_##type, \ } -static DEFINE_PCI_DEVICE_TABLE (yenta_table) = { +static const struct pci_device_id yenta_table[] = {CB_ID (PCI_VENDOR_ID_TI ,PCI_DEVICE_ID_TI_1031 ,TI ),/*
Signature · 1 line
1.7.10.4
PATCH 23/39] platform: x86: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/platform/x86/intel_ips.c | 2 +- drivers/platform/x86/intel_scu_ipc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/platform/x86/intel_ips.c +1 -1
@@ -1478,7 +1478,7 @@ ips_link_to_i915_driver(void) }EXPORT_SYMBOL_GPL (ips_link_to_i915_driver); -static DEFINE_PCI_DEVICE_TABLE (ips_id_table) = { +static const struct pci_device_id ips_id_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_THERMAL_SENSOR ), }, {0 , }
drivers/platform/x86/intel_scu_ipc.c +1 -1
@@ -649,7 +649,7 @@ static void ipc_remove(struct pci_dev *pdev)intel_scu_devices_destroy (); } -static DEFINE_PCI_DEVICE_TABLE (pci_ids) = { +static const struct pci_device_id pci_ids[] = { {PCI_VDEVICE (INTEL ,0x082a ),SCU_IPC_LINCROFT }, {PCI_VDEVICE (INTEL ,0x080e ),SCU_IPC_PENWELL }, {PCI_VDEVICE (INTEL ,0x08ea ),SCU_IPC_CLOVERVIEW },
Signature · 1 line
1.7.10.4
PATCH 24/39 ptp: ptp_pch: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/ptp/ptp_pch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ptp/ptp_pch.c +1 -1
@@ -690,7 +690,7 @@ err_pci_en:return ret; } -static DEFINE_PCI_DEVICE_TABLE (pch_ieee1588_pcidev_id) = { +static const struct pci_device_id pch_ieee1588_pcidev_id[] = { { .vendor =PCI_VENDOR_ID_INTEL , .device =PCI_DEVICE_ID_PCH_1588
Signature · 1 line
1.7.10.4
PATCH 25/39 rapidio: tsi721: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/rapidio/devices/tsi721.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/rapidio/devices/tsi721.c +1 -1
@@ -2497,7 +2497,7 @@ err_exit:return err; } -static DEFINE_PCI_DEVICE_TABLE (tsi721_pci_tbl) = { +static const struct pci_device_id tsi721_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_IDT ,PCI_DEVICE_ID_TSI721 ) }, {0 , }/* terminate list */ };
Signature · 1 line
1.7.10.4
PATCH 26/39 scsi: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/scsi/BusLogic.c | 2 +- drivers/scsi/be2iscsi/be_main.c | 2 +- drivers/scsi/csiostor/csio_init.c | 2 +- drivers/scsi/isci/init.c | 2 +- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 2 +- drivers/scsi/mvumi.c | 2 +- drivers/scsi/ufs/ufshcd-pci.c | 2 +- 7 files changed, 7 insertions(+), 7 deletions(-)
drivers/scsi/BusLogic.c +1 -1
@@ -3893,7 +3893,7 @@ __setup("BusLogic=", blogic_setup);PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0}, { } };*/ -static DEFINE_PCI_DEVICE_TABLE (blogic_pci_tbl) = { +static const struct pci_device_id blogic_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_BUSLOGIC ,PCI_DEVICE_ID_BUSLOGIC_MULTIMASTER )}, {PCI_DEVICE (PCI_VENDOR_ID_BUSLOGIC ,PCI_DEVICE_ID_BUSLOGIC_MULTIMASTER_NC )}, {PCI_DEVICE (PCI_VENDOR_ID_BUSLOGIC ,PCI_DEVICE_ID_BUSLOGIC_FLASHPOINT )},
drivers/scsi/be2iscsi/be_main.c +1 -1
@@ -534,7 +534,7 @@ static umode_t beiscsi_eth_get_attr_visibility(void *data, int type) }/*------------------- PCI Driver operations and data ----------------- */ -static DEFINE_PCI_DEVICE_TABLE (beiscsi_pci_id_table) = { +static const struct pci_device_id beiscsi_pci_id_table[] = { {PCI_DEVICE (BE_VENDOR_ID ,BE_DEVICE_ID1 ) }, {PCI_DEVICE (BE_VENDOR_ID ,BE_DEVICE_ID2 ) }, {PCI_DEVICE (BE_VENDOR_ID ,OC_DEVICE_ID1 ) },
drivers/scsi/csiostor/csio_init.c +1 -1
@@ -1167,7 +1167,7 @@ static struct pci_error_handlers csio_err_handler = { .resume = csio_pci_resume, }; -static DEFINE_PCI_DEVICE_TABLE (csio_pci_tbl) = { +static const struct pci_device_id csio_pci_tbl[] = {CSIO_DEVICE (CSIO_DEVID_T440DBG_FCOE ,0 ),/* T4 DEBUG FCOE */ CSIO_DEVICE (CSIO_DEVID_T420CR_FCOE ,0 ),/* T420CR FCOE */ CSIO_DEVICE (CSIO_DEVID_T422CR_FCOE ,0 ),/* T422CR FCOE */
drivers/scsi/isci/init.c +1 -1
@@ -75,7 +75,7 @@ MODULE_VERSION(DRV_VERSION);static struct scsi_transport_template *isci_transport_template; -static DEFINE_PCI_DEVICE_TABLE (isci_id_table) = { +static const struct pci_device_id isci_id_table[] = { {PCI_VDEVICE (INTEL ,0x1D61 ),}, {PCI_VDEVICE (INTEL ,0x1D63 ),}, {PCI_VDEVICE (INTEL ,0x1D65 ),},
drivers/scsi/mpt3sas/mpt3sas_scsih.c +1 -1
@@ -247,7 +247,7 @@ struct _scsi_io_transfer {/* * The pci device ids are defined in mpi/mpi2_cnfg.h. */ -static DEFINE_PCI_DEVICE_TABLE (scsih_pci_table) = { +static const struct pci_device_id scsih_pci_table[] = {/* Fury ~ 3004 and 3008 */ {MPI2_MFGPAGE_VENDORID_LSI ,MPI25_MFGPAGE_DEVID_SAS3004 ,PCI_ANY_ID ,PCI_ANY_ID },
drivers/scsi/mvumi.c +1 -1
@@ -48,7 +48,7 @@ MODULE_LICENSE("GPL");MODULE_AUTHOR ("[email protected]" );MODULE_DESCRIPTION ("Marvell UMI Driver" ); -static DEFINE_PCI_DEVICE_TABLE (mvumi_pci_table) = { +static const struct pci_device_id mvumi_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_MARVELL_EXT ,PCI_DEVICE_ID_MARVELL_MV9143 ) }, {PCI_DEVICE (PCI_VENDOR_ID_MARVELL_EXT ,PCI_DEVICE_ID_MARVELL_MV9580 ) }, {0 }
drivers/scsi/ufs/ufshcd-pci.c +1 -1
@@ -211,7 +211,7 @@ static const struct dev_pm_ops ufshcd_pci_pm_ops = { .runtime_idle = ufshcd_pci_runtime_idle, }; -static DEFINE_PCI_DEVICE_TABLE (ufshcd_pci_tbl) = { +static const struct pci_device_id ufshcd_pci_tbl[] = { {PCI_VENDOR_ID_SAMSUNG ,0xC00C ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 }, { }/* terminate list */ };
Signature · 1 line
1.7.10.4
PATCH 27/39 spi: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/spi/spi-dw-pci.c | 2 +- drivers/spi/spi-pxa2xx-pci.c | 2 +- drivers/spi/spi-topcliff-pch.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/spi/spi-dw-pci.c +1 -1
@@ -148,7 +148,7 @@ static int spi_resume(struct pci_dev *pdev)#define spi_resume NULL#endif -static DEFINE_PCI_DEVICE_TABLE (pci_ids) = { +static const struct pci_device_id pci_ids[] = {/* Intel MID platform SPI controller 0 */ {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,0x0800 ) }, {},
drivers/spi/spi-pxa2xx-pci.c +1 -1
@@ -62,7 +62,7 @@ static void ce4100_spi_remove(struct pci_dev *dev)platform_device_unregister (pdev); } -static DEFINE_PCI_DEVICE_TABLE (ce4100_spi_devices) = { +static const struct pci_device_id ce4100_spi_devices[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,0x2e6a ) }, { }, };
drivers/spi/spi-topcliff-pch.c +1 -1
@@ -217,7 +217,7 @@ struct pch_pd_dev_save {struct pch_spi_board_data *board_dat; }; -static DEFINE_PCI_DEVICE_TABLE (pch_spi_pcidev_id) = { +static const struct pci_device_id pch_spi_pcidev_id[] = { {PCI_VDEVICE (INTEL ,PCI_DEVICE_ID_GE_SPI ),1 , }, {PCI_VDEVICE (ROHM ,PCI_DEVICE_ID_ML7213_SPI ),2 , }, {PCI_VDEVICE (ROHM ,PCI_DEVICE_ID_ML7223_SPI ),1 , },
Signature · 1 line
1.7.10.4
Re: [PATCH 27/39] spi: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 2 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.
Applied, thanks. It's on a topic branch by itself so I can easily drop it if we decide to do something else.
PATCH 28/39 staging: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/staging/comedi/drivers/8255_pci.c | 2 +- drivers/staging/comedi/drivers/addi_apci_035.c | 2 +- drivers/staging/comedi/drivers/addi_apci_1032.c | 2 +- drivers/staging/comedi/drivers/addi_apci_1500.c | 2 +- drivers/staging/comedi/drivers/addi_apci_1516.c | 2 +- drivers/staging/comedi/drivers/addi_apci_1564.c | 2 +- drivers/staging/comedi/drivers/addi_apci_16xx.c | 2 +- drivers/staging/comedi/drivers/addi_apci_2032.c | 2 +- drivers/staging/comedi/drivers/addi_apci_2200.c | 2 +- drivers/staging/comedi/drivers/addi_apci_3120.c | 2 +- drivers/staging/comedi/drivers/addi_apci_3200.c | 2 +- drivers/staging/comedi/drivers/addi_apci_3501.c | 2 +- drivers/staging/comedi/drivers/addi_apci_3xxx.c | 2 +- drivers/staging/comedi/drivers/adl_pci6208.c | 2 +- drivers/staging/comedi/drivers/adl_pci7x3x.c | 2 +- drivers/staging/comedi/drivers/adl_pci8164.c | 2 +- drivers/staging/comedi/drivers/adl_pci9111.c | 2 +- drivers/staging/comedi/drivers/adl_pci9118.c | 2 +- drivers/staging/comedi/drivers/adv_pci1710.c | 2 +- drivers/staging/comedi/drivers/adv_pci1723.c | 2 +- drivers/staging/comedi/drivers/adv_pci1724.c | 2 +- drivers/staging/comedi/drivers/adv_pci_dio.c | 2 +- drivers/staging/comedi/drivers/amplc_dio200_pci.c | 2 +- drivers/staging/comedi/drivers/amplc_pc236.c | 2 +- drivers/staging/comedi/drivers/amplc_pci224.c | 2 +- drivers/staging/comedi/drivers/amplc_pci230.c | 2 +- drivers/staging/comedi/drivers/amplc_pci263.c | 2 +- drivers/staging/comedi/drivers/cb_pcidas.c | 2 +- drivers/staging/comedi/drivers/cb_pcidas64.c | 2 +- drivers/staging/comedi/drivers/cb_pcidda.c | 2 +- drivers/staging/comedi/drivers/cb_pcimdas.c | 2 +- drivers/staging/comedi/drivers/cb_pcimdda.c | 2 +- drivers/staging/comedi/drivers/contec_pci_dio.c | 2 +- drivers/staging/comedi/drivers/daqboard2000.c | 2 +- drivers/staging/comedi/drivers/das08_pci.c | 2 +- drivers/staging/comedi/drivers/dt3000.c | 2 +- drivers/staging/comedi/drivers/dyna_pci10xx.c | 2 +- drivers/staging/comedi/drivers/gsc_hpdi.c | 2 +- drivers/staging/comedi/drivers/icp_multi.c | 2 +- drivers/staging/comedi/drivers/jr3_pci.c | 2 +- drivers/staging/comedi/drivers/ke_counter.c | 2 +- drivers/staging/comedi/drivers/me4000.c | 2 +- drivers/staging/comedi/drivers/me_daq.c | 2 +- drivers/staging/comedi/drivers/ni_6527.c | 2 +- drivers/staging/comedi/drivers/ni_65xx.c | 2 +- drivers/staging/comedi/drivers/ni_660x.c | 2 +- drivers/staging/comedi/drivers/ni_670x.c | 2 +- drivers/staging/comedi/drivers/ni_labpc_pci.c | 2 +- drivers/staging/comedi/drivers/ni_pcidio.c | 2 +- drivers/staging/comedi/drivers/ni_pcimio.c | 2 +- drivers/staging/comedi/drivers/rtd520.c | 2 +- drivers/staging/comedi/drivers/s626.c | 2 +- drivers/staging/comedi/drivers/skel.c | 2 +- drivers/staging/crystalhd/crystalhd_lnx.c | 2 +- drivers/staging/dwc2/pci.c | 2 +- drivers/staging/et131x/et131x.c | 2 +- drivers/staging/media/dt3155v4l/dt3155v4l.c | 2 +- drivers/staging/media/solo6x10/solo6x10-core.c | 2 +- drivers/staging/phison/phison.c | 2 +- drivers/staging/sep/sep_main.c | 2 +- drivers/staging/slicoss/slicoss.c | 2 +- drivers/staging/sm7xxfb/sm7xxfb.c | 2 +- drivers/staging/vt6655/device_main.c | 2 +- drivers/staging/xgifb/XGI_main.h | 2 +- drivers/staging/xillybus/xillybus_pcie.c | 2 +- 65 files changed, 65 insertions(+), 65 deletions(-)
drivers/staging/comedi/drivers/8255_pci.c +1 -1
@@ -257,7 +257,7 @@ static int pci_8255_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &pci_8255_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (pci_8255_pci_table) = { +static const struct pci_device_id pci_8255_pci_table[] = { {PCI_VDEVICE (ADLINK ,0x7224 ),BOARD_ADLINK_PCI7224 }, {PCI_VDEVICE (ADLINK ,0x7248 ),BOARD_ADLINK_PCI7248 }, {PCI_VDEVICE (ADLINK ,0x7296 ),BOARD_ADLINK_PCI7296 },
drivers/staging/comedi/drivers/addi_apci_035.c +1 -1
@@ -58,7 +58,7 @@ static int apci035_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &apci035_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (apci035_pci_table) = { +static const struct pci_device_id apci035_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_ADDIDATA ,0x0300 ) }, {0 } };
drivers/staging/comedi/drivers/addi_apci_1032.c +1 -1
@@ -364,7 +364,7 @@ static int apci1032_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &apci1032_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (apci1032_pci_table) = { +static const struct pci_device_id apci1032_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_ADDIDATA ,0x1003 ) }, {0 } };
drivers/staging/comedi/drivers/addi_apci_1500.c +1 -1
@@ -57,7 +57,7 @@ static int apci1500_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &apci1500_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (apci1500_pci_table) = { +static const struct pci_device_id apci1500_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_AMCC ,0x80fc ) }, {0 } };
drivers/staging/comedi/drivers/addi_apci_1516.c +1 -1
@@ -206,7 +206,7 @@ static int apci1516_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &apci1516_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (apci1516_pci_table) = { +static const struct pci_device_id apci1516_pci_table[] = { {PCI_VDEVICE (ADDIDATA ,0x1000 ),BOARD_APCI1016 }, {PCI_VDEVICE (ADDIDATA ,0x1001 ),BOARD_APCI1516 }, {PCI_VDEVICE (ADDIDATA ,0x1002 ),BOARD_APCI2016 },
drivers/staging/comedi/drivers/addi_apci_1564.c +1 -1
@@ -55,7 +55,7 @@ static int apci1564_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &apci1564_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (apci1564_pci_table) = { +static const struct pci_device_id apci1564_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_ADDIDATA ,0x1006 ) }, {0 } };
drivers/staging/comedi/drivers/addi_apci_16xx.c +1 -1
@@ -168,7 +168,7 @@ static int apci16xx_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &apci16xx_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (apci16xx_pci_table) = { +static const struct pci_device_id apci16xx_pci_table[] = { {PCI_VDEVICE (ADDIDATA ,0x1009 ),BOARD_APCI1648 }, {PCI_VDEVICE (ADDIDATA ,0x100a ),BOARD_APCI1696 }, {0 }
drivers/staging/comedi/drivers/addi_apci_2032.c +1 -1
@@ -359,7 +359,7 @@ static int apci2032_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &apci2032_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (apci2032_pci_table) = { +static const struct pci_device_id apci2032_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_ADDIDATA ,0x1004 ) }, {0 } };
drivers/staging/comedi/drivers/addi_apci_2200.c +1 -1
@@ -134,7 +134,7 @@ static int apci2200_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &apci2200_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (apci2200_pci_table) = { +static const struct pci_device_id apci2200_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_ADDIDATA ,0x1005 ) }, {0 } };
drivers/staging/comedi/drivers/addi_apci_3120.c +1 -1
@@ -230,7 +230,7 @@ static int apci3120_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &apci3120_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (apci3120_pci_table) = { +static const struct pci_device_id apci3120_pci_table[] = { {PCI_VDEVICE (AMCC ,0x818d ),BOARD_APCI3120 }, {PCI_VDEVICE (AMCC ,0x828d ),BOARD_APCI3001 }, {0 }
drivers/staging/comedi/drivers/addi_apci_3200.c +1 -1
@@ -109,7 +109,7 @@ static int apci3200_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &apci3200_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (apci3200_pci_table) = { +static const struct pci_device_id apci3200_pci_table[] = { {PCI_VDEVICE (ADDIDATA ,0x3000 ),BOARD_APCI3200 }, {PCI_VDEVICE (ADDIDATA ,0x3007 ),BOARD_APCI3300 }, {0 }
drivers/staging/comedi/drivers/addi_apci_3501.c +1 -1
@@ -428,7 +428,7 @@ static int apci3501_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &apci3501_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (apci3501_pci_table) = { +static const struct pci_device_id apci3501_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_ADDIDATA ,0x3001 ) }, {0 } };
drivers/staging/comedi/drivers/addi_apci_3xxx.c +1 -1
@@ -915,7 +915,7 @@ static int apci3xxx_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &apci3xxx_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (apci3xxx_pci_table) = { +static const struct pci_device_id apci3xxx_pci_table[] = { {PCI_VDEVICE (ADDIDATA ,0x3010 ),BOARD_APCI3000_16 }, {PCI_VDEVICE (ADDIDATA ,0x300f ),BOARD_APCI3000_8 }, {PCI_VDEVICE (ADDIDATA ,0x300e ),BOARD_APCI3000_4 },
drivers/staging/comedi/drivers/adl_pci6208.c +1 -1
@@ -242,7 +242,7 @@ static int adl_pci6208_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (adl_pci6208_pci_table) = { +static const struct pci_device_id adl_pci6208_pci_table[] = { {PCI_VDEVICE (ADLINK ,0x6208 ),BOARD_PCI6208 }, {PCI_VDEVICE (ADLINK ,0x6216 ),BOARD_PCI6216 }, {0 }
drivers/staging/comedi/drivers/adl_pci7x3x.c +1 -1
@@ -259,7 +259,7 @@ static int adl_pci7x3x_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (adl_pci7x3x_pci_table) = { +static const struct pci_device_id adl_pci7x3x_pci_table[] = { {PCI_VDEVICE (ADLINK ,0x7230 ),BOARD_PCI7230 }, {PCI_VDEVICE (ADLINK ,0x7233 ),BOARD_PCI7233 }, {PCI_VDEVICE (ADLINK ,0x7234 ),BOARD_PCI7234 },
drivers/staging/comedi/drivers/adl_pci8164.c +1 -1
@@ -145,7 +145,7 @@ static int adl_pci8164_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (adl_pci8164_pci_table) = { +static const struct pci_device_id adl_pci8164_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_ADLINK ,0x8164 ) }, {0 } };
drivers/staging/comedi/drivers/adl_pci9111.c +1 -1
@@ -938,7 +938,7 @@ static int pci9111_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (pci9111_pci_table) = { +static const struct pci_device_id pci9111_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_ADLINK ,PCI9111_HR_DEVICE_ID ) },/* { PCI_DEVICE(PCI_VENDOR_ID_ADLINK, PCI9111_HG_DEVICE_ID) }, */ {0 }
drivers/staging/comedi/drivers/adl_pci9118.c +1 -1
@@ -2217,7 +2217,7 @@ static int adl_pci9118_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (adl_pci9118_pci_table) = { +static const struct pci_device_id adl_pci9118_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_AMCC ,0x80d9 ) }, {0 } };
drivers/staging/comedi/drivers/adv_pci1710.c +1 -1
@@ -1374,7 +1374,7 @@ static int adv_pci1710_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (adv_pci1710_pci_table) = { +static const struct pci_device_id adv_pci1710_pci_table[] = { {PCI_DEVICE_SUB (PCI_VENDOR_ID_ADVANTECH ,0x1710 ,PCI_VENDOR_ID_PLX ,PCI_DEVICE_ID_PLX_9050 ),
drivers/staging/comedi/drivers/adv_pci1723.c +1 -1
@@ -306,7 +306,7 @@ static int adv_pci1723_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (adv_pci1723_pci_table) = { +static const struct pci_device_id adv_pci1723_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_ADVANTECH ,0x1723 ) }, {0 } };
drivers/staging/comedi/drivers/adv_pci1724.c +1 -1
@@ -381,7 +381,7 @@ static int adv_pci1724_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (adv_pci1724_pci_table) = { +static const struct pci_device_id adv_pci1724_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_ADVANTECH ,0x1724 ) }, {0 } };
drivers/staging/comedi/drivers/adv_pci_dio.c +1 -1
@@ -1188,7 +1188,7 @@ static int adv_pci_dio_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &adv_pci_dio_driver, cardtype); } -static DEFINE_PCI_DEVICE_TABLE (adv_pci_dio_pci_table) = { +static const struct pci_device_id adv_pci_dio_pci_table[] = { {PCI_VDEVICE (ADVANTECH ,0x1730 ),TYPE_PCI1730 }, {PCI_VDEVICE (ADVANTECH ,0x1733 ),TYPE_PCI1733 }, {PCI_VDEVICE (ADVANTECH ,0x1734 ),TYPE_PCI1734 },
drivers/staging/comedi/drivers/amplc_dio200_pci.c +1 -1
@@ -439,7 +439,7 @@ static struct comedi_driver dio200_pci_comedi_driver = { .detach = dio200_pci_detach, }; -static DEFINE_PCI_DEVICE_TABLE (dio200_pci_table) = { +static const struct pci_device_id dio200_pci_table[] = { {PCI_VDEVICE (AMPLICON ,PCI_DEVICE_ID_AMPLICON_PCI215 ), pci215_model
drivers/staging/comedi/drivers/amplc_pc236.c +1 -1
@@ -567,7 +567,7 @@ static struct comedi_driver amplc_pc236_driver = { };#if DO_PCI -static DEFINE_PCI_DEVICE_TABLE (pc236_pci_table) = { +static const struct pci_device_id pc236_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_AMPLICON ,PCI_DEVICE_ID_AMPLICON_PCI236 ) }, {0 } };
drivers/staging/comedi/drivers/amplc_pci224.c +1 -1
@@ -1498,7 +1498,7 @@ static int amplc_pci224_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (amplc_pci224_pci_table) = { +static const struct pci_device_id amplc_pci224_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_AMPLICON ,PCI_DEVICE_ID_AMPLICON_PCI224 ) }, {PCI_DEVICE (PCI_VENDOR_ID_AMPLICON ,PCI_DEVICE_ID_AMPLICON_PCI234 ) }, {0 }
drivers/staging/comedi/drivers/amplc_pci230.c +1 -1
@@ -2856,7 +2856,7 @@ static int amplc_pci230_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (amplc_pci230_pci_table) = { +static const struct pci_device_id amplc_pci230_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_AMPLICON ,PCI_DEVICE_ID_PCI230 ) }, {PCI_DEVICE (PCI_VENDOR_ID_AMPLICON ,PCI_DEVICE_ID_PCI260 ) }, {0 }
drivers/staging/comedi/drivers/amplc_pci263.c +1 -1
@@ -96,7 +96,7 @@ static struct comedi_driver amplc_pci263_driver = { .detach = comedi_pci_disable, }; -static DEFINE_PCI_DEVICE_TABLE (pci263_pci_table) = { +static const struct pci_device_id pci263_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_AMPLICON ,PCI_DEVICE_ID_AMPLICON_PCI263 ) }, {0 } };
drivers/staging/comedi/drivers/cb_pcidas.c +1 -1
@@ -1614,7 +1614,7 @@ static int cb_pcidas_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (cb_pcidas_pci_table) = { +static const struct pci_device_id cb_pcidas_pci_table[] = { {PCI_VDEVICE (CB ,0x0001 ),BOARD_PCIDAS1602_16 }, {PCI_VDEVICE (CB ,0x000f ),BOARD_PCIDAS1200 }, {PCI_VDEVICE (CB ,0x0010 ),BOARD_PCIDAS1602_12 },
drivers/staging/comedi/drivers/cb_pcidas64.c +1 -1
@@ -4161,7 +4161,7 @@ static int cb_pcidas64_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (cb_pcidas64_pci_table) = { +static const struct pci_device_id cb_pcidas64_pci_table[] = { {PCI_VDEVICE (CB ,0x001d ),BOARD_PCIDAS6402_16 }, {PCI_VDEVICE (CB ,0x001e ),BOARD_PCIDAS6402_12 }, {PCI_VDEVICE (CB ,0x0035 ),BOARD_PCIDAS64_M1_16 },
drivers/staging/comedi/drivers/cb_pcidda.c +1 -1
@@ -407,7 +407,7 @@ static int cb_pcidda_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (cb_pcidda_pci_table) = { +static const struct pci_device_id cb_pcidda_pci_table[] = { {PCI_VDEVICE (CB ,0x0020 ),BOARD_DDA02_12 }, {PCI_VDEVICE (CB ,0x0021 ),BOARD_DDA04_12 }, {PCI_VDEVICE (CB ,0x0022 ),BOARD_DDA08_12 },
drivers/staging/comedi/drivers/cb_pcimdas.c +1 -1
@@ -288,7 +288,7 @@ static int cb_pcimdas_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (cb_pcimdas_pci_table) = { +static const struct pci_device_id cb_pcimdas_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_CB ,0x0056 ) }, {0 } };
drivers/staging/comedi/drivers/cb_pcimdda.c +1 -1
@@ -206,7 +206,7 @@ static int cb_pcimdda_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (cb_pcimdda_pci_table) = { +static const struct pci_device_id cb_pcimdda_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_CB ,PCI_ID_PCIM_DDA06_16 ) }, {0 } };
drivers/staging/comedi/drivers/contec_pci_dio.c +1 -1
@@ -111,7 +111,7 @@ static int contec_pci_dio_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (contec_pci_dio_pci_table) = { +static const struct pci_device_id contec_pci_dio_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_CONTEC ,PCI_DEVICE_ID_PIO1616L ) }, {0 } };
drivers/staging/comedi/drivers/daqboard2000.c +1 -1
@@ -772,7 +772,7 @@ static int daqboard2000_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (daqboard2000_pci_table) = { +static const struct pci_device_id daqboard2000_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_IOTECH ,0x0409 ) }, {0 } };
drivers/staging/comedi/drivers/das08_pci.c +1 -1
@@ -89,7 +89,7 @@ static int das08_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (das08_pci_table) = { +static const struct pci_device_id das08_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_CB ,PCI_DEVICE_ID_PCIDAS08 ) }, {0 } };
drivers/staging/comedi/drivers/dt3000.c +1 -1
@@ -818,7 +818,7 @@ static int dt3000_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &dt3000_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (dt3000_pci_table) = { +static const struct pci_device_id dt3000_pci_table[] = { {PCI_VDEVICE (DT ,0x0022 ),BOARD_DT3001 }, {PCI_VDEVICE (DT ,0x0023 ),BOARD_DT3002 }, {PCI_VDEVICE (DT ,0x0024 ),BOARD_DT3003 },
drivers/staging/comedi/drivers/dyna_pci10xx.c +1 -1
@@ -260,7 +260,7 @@ static int dyna_pci10xx_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (dyna_pci10xx_pci_table) = { +static const struct pci_device_id dyna_pci10xx_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_PLX ,0x1050 ) }, {0 } };
drivers/staging/comedi/drivers/gsc_hpdi.c +1 -1
@@ -914,7 +914,7 @@ static int gsc_hpdi_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &gsc_hpdi_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (gsc_hpdi_pci_table) = { +static const struct pci_device_id gsc_hpdi_pci_table[] = { {PCI_VENDOR_ID_PLX ,PCI_DEVICE_ID_PLX_9080 ,PCI_VENDOR_ID_PLX ,0x2400 ,0 ,0 ,0 }, {0 }
drivers/staging/comedi/drivers/icp_multi.c +1 -1
@@ -597,7 +597,7 @@ static int icp_multi_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &icp_multi_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (icp_multi_pci_table) = { +static const struct pci_device_id icp_multi_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_ICP ,PCI_DEVICE_ID_ICP_MULTI ) }, {0 } };
drivers/staging/comedi/drivers/jr3_pci.c +1 -1
@@ -807,7 +807,7 @@ static int jr3_pci_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &jr3_pci_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (jr3_pci_pci_table) = { +static const struct pci_device_id jr3_pci_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_JR3 ,PCI_DEVICE_ID_JR3_1_CHANNEL ) }, {PCI_DEVICE (PCI_VENDOR_ID_JR3 ,PCI_DEVICE_ID_JR3_1_CHANNEL_NEW ) }, {PCI_DEVICE (PCI_VENDOR_ID_JR3 ,PCI_DEVICE_ID_JR3_2_CHANNEL ) },
drivers/staging/comedi/drivers/ke_counter.c +1 -1
@@ -139,7 +139,7 @@ static int ke_counter_pci_probe(struct pci_dev *dev, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (ke_counter_pci_table) = { +static const struct pci_device_id ke_counter_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_KOLTER ,CNT_CARD_DEVICE_ID ) }, {0 } };
drivers/staging/comedi/drivers/me4000.c +1 -1
@@ -1635,7 +1635,7 @@ static int me4000_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &me4000_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (me4000_pci_table) = { +static const struct pci_device_id me4000_pci_table[] = { {PCI_VDEVICE (MEILHAUS ,0x4650 ),BOARD_ME4650 }, {PCI_VDEVICE (MEILHAUS ,0x4660 ),BOARD_ME4660 }, {PCI_VDEVICE (MEILHAUS ,0x4661 ),BOARD_ME4660I },
drivers/staging/comedi/drivers/me_daq.c +1 -1
@@ -576,7 +576,7 @@ static int me_daq_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &me_daq_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (me_daq_pci_table) = { +static const struct pci_device_id me_daq_pci_table[] = { {PCI_VDEVICE (MEILHAUS ,0x2600 ),BOARD_ME2600 }, {PCI_VDEVICE (MEILHAUS ,0x2000 ),BOARD_ME2000 }, {0 }
drivers/staging/comedi/drivers/ni_6527.c +1 -1
@@ -455,7 +455,7 @@ static int ni6527_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &ni6527_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (ni6527_pci_table) = { +static const struct pci_device_id ni6527_pci_table[] = { {PCI_VDEVICE (NI ,0x2b10 ),BOARD_PXI6527 }, {PCI_VDEVICE (NI ,0x2b20 ),BOARD_PCI6527 }, {0 }
drivers/staging/comedi/drivers/ni_65xx.c +1 -1
@@ -741,7 +741,7 @@ static int ni_65xx_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &ni_65xx_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (ni_65xx_pci_table) = { +static const struct pci_device_id ni_65xx_pci_table[] = { {PCI_VDEVICE (NI ,0x1710 ),BOARD_PXI6509 }, {PCI_VDEVICE (NI ,0x7085 ),BOARD_PCI6509 }, {PCI_VDEVICE (NI ,0x7086 ),BOARD_PXI6528 },
drivers/staging/comedi/drivers/ni_660x.c +1 -1
@@ -1320,7 +1320,7 @@ static int ni_660x_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &ni_660x_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (ni_660x_pci_table) = { +static const struct pci_device_id ni_660x_pci_table[] = { {PCI_VDEVICE (NI ,0x1310 ),BOARD_PCI6602 }, {PCI_VDEVICE (NI ,0x1360 ),BOARD_PXI6602 }, {PCI_VDEVICE (NI ,0x2c60 ),BOARD_PCI6601 },
drivers/staging/comedi/drivers/ni_670x.c +1 -1
@@ -282,7 +282,7 @@ static int ni_670x_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &ni_670x_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (ni_670x_pci_table) = { +static const struct pci_device_id ni_670x_pci_table[] = { {PCI_VDEVICE (NI ,0x1290 ),BOARD_PCI6704 }, {PCI_VDEVICE (NI ,0x1920 ),BOARD_PXI6704 }, {PCI_VDEVICE (NI ,0x2c90 ),BOARD_PCI6703 },
drivers/staging/comedi/drivers/ni_labpc_pci.c +1 -1
@@ -107,7 +107,7 @@ static struct comedi_driver labpc_pci_comedi_driver = { .detach = labpc_pci_detach, }; -static DEFINE_PCI_DEVICE_TABLE (labpc_pci_table) = { +static const struct pci_device_id labpc_pci_table[] = { {PCI_VDEVICE (NI ,0x161 ),BOARD_NI_PCI1200 }, {0 } };
drivers/staging/comedi/drivers/ni_pcidio.c +1 -1
@@ -1200,7 +1200,7 @@ static int ni_pcidio_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &ni_pcidio_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (ni_pcidio_pci_table) = { +static const struct pci_device_id ni_pcidio_pci_table[] = { {PCI_VDEVICE (NI ,0x1150 ),BOARD_PCIDIO_32HS }, {PCI_VDEVICE (NI ,0x12b0 ),BOARD_PCI6534 }, {PCI_VDEVICE (NI ,0x1320 ),BOARD_PXI6533 },
drivers/staging/comedi/drivers/ni_pcimio.c +1 -1
@@ -1639,7 +1639,7 @@ static int ni_pcimio_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &ni_pcimio_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (ni_pcimio_pci_table) = { +static const struct pci_device_id ni_pcimio_pci_table[] = { {PCI_VDEVICE (NI ,0x0162 ),BOARD_PCIMIO_16XE_50 },/* 0x1620? */ {PCI_VDEVICE (NI ,0x1170 ),BOARD_PCIMIO_16XE_10 }, {PCI_VDEVICE (NI ,0x1180 ),BOARD_PCIMIO_16E_1 },
drivers/staging/comedi/drivers/rtd520.c +1 -1
@@ -1427,7 +1427,7 @@ static int rtd520_pci_probe(struct pci_dev *dev,return comedi_pci_auto_config (dev, &rtd520_driver, id->driver_data); } -static DEFINE_PCI_DEVICE_TABLE (rtd520_pci_table) = { +static const struct pci_device_id rtd520_pci_table[] = { {PCI_VDEVICE (RTD ,0x7520 ),BOARD_DM7520 }, {PCI_VDEVICE (RTD ,0x4520 ),BOARD_PCI4520 }, {0 }
drivers/staging/comedi/drivers/s626.c +1 -1
@@ -2965,7 +2965,7 @@ static int s626_pci_probe(struct pci_dev *dev,* also subvendor:subdevice ids, because otherwise it will conflict with * Philips SAA7146 media/dvb based cards. */ -static DEFINE_PCI_DEVICE_TABLE (s626_pci_table) = { +static const struct pci_device_id s626_pci_table[] = { {PCI_DEVICE_SUB (PCI_VENDOR_ID_PHILIPS ,PCI_DEVICE_ID_PHILIPS_SAA7146 ,0x6000 ,0x0272 ) }, {0 }
drivers/staging/comedi/drivers/skel.c +1 -1
@@ -698,7 +698,7 @@ static int skel_pci_probe(struct pci_dev *dev,* This is used by modprobe to translate PCI IDs to drivers. * Should only be used for PCI and ISA-PnP devices */ -static DEFINE_PCI_DEVICE_TABLE (skel_pci_table) = { +static const struct pci_device_id skel_pci_table[] = { {PCI_VDEVICE (SKEL ,0x0100 ),BOARD_SKEL100 }, {PCI_VDEVICE (SKEL ,0x0200 ),BOARD_SKEL200 }, {0 }
drivers/staging/crystalhd/crystalhd_lnx.c +1 -1
@@ -703,7 +703,7 @@ static int chd_dec_pci_resume(struct pci_dev *pdev) }#endif -static DEFINE_PCI_DEVICE_TABLE (chd_dec_pci_id_table) = { +static const struct pci_device_id chd_dec_pci_id_table[] = { {PCI_VDEVICE (BROADCOM ,0x1612 ),8 }, {0 , }, };
drivers/staging/dwc2/pci.c +1 -1
@@ -152,7 +152,7 @@ static int dwc2_driver_probe(struct pci_dev *dev,return retval; } -static DEFINE_PCI_DEVICE_TABLE (dwc2_pci_ids) = { +static const struct pci_device_id dwc2_pci_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_SYNOPSYS ,PCI_PRODUCT_ID_HAPS_HSOTG ), },
drivers/staging/et131x/et131x.c +1 -1
@@ -4930,7 +4930,7 @@ err_disable: goto out; } -static DEFINE_PCI_DEVICE_TABLE (et131x_pci_table) = { +static const struct pci_device_id et131x_pci_table[] = { {PCI_VDEVICE (ATT ,ET131X_PCI_DEVICE_ID_GIG ),0UL }, {PCI_VDEVICE (ATT ,ET131X_PCI_DEVICE_ID_FAST ),0UL }, {0 ,}
drivers/staging/media/dt3155v4l/dt3155v4l.c +1 -1
@@ -974,7 +974,7 @@ dt3155_remove(struct pci_dev *pdev)kfree (pd); } -static DEFINE_PCI_DEVICE_TABLE (pci_ids) = { +static const struct pci_device_id pci_ids[] = { {PCI_DEVICE (DT3155_VENDOR_ID ,DT3155_DEVICE_ID ) }, {0 ,/* zero marks the end */ }, };
drivers/staging/media/solo6x10/solo6x10-core.c +1 -1
@@ -669,7 +669,7 @@ static void solo_pci_remove(struct pci_dev *pdev)free_solo_dev (solo_dev); } -static DEFINE_PCI_DEVICE_TABLE (solo_id_table) = { +static const struct pci_device_id solo_id_table[] = {/* 6010 based cards */ {PCI_DEVICE (PCI_VENDOR_ID_SOFTLOGIC ,PCI_DEVICE_ID_SOLO6010 ), .driver_data =SOLO_DEV_6010 },
drivers/staging/phison/phison.c +1 -1
@@ -69,7 +69,7 @@ static int phison_init_one(struct pci_dev *pdev, const struct pci_device_id *id)return ret; } -static DEFINE_PCI_DEVICE_TABLE (phison_pci_tbl) = { +static const struct pci_device_id phison_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_PHISON ,PCI_DEVICE_ID_PS5000 ),PCI_CLASS_STORAGE_IDE <<8 ,0xffff00 ,0 }, {0 , },
drivers/staging/sep/sep_main.c +1 -1
@@ -4292,7 +4292,7 @@ static void sep_remove(struct pci_dev *pdev) }/* Initialize struct pci_device_id for our driver */ -static DEFINE_PCI_DEVICE_TABLE (sep_pci_id_tbl) = { +static const struct pci_device_id sep_pci_id_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,0x0826 )}, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,0x08e9 )}, {0 }
drivers/staging/slicoss/slicoss.c +1 -1
@@ -136,7 +136,7 @@ MODULE_PARM_DESC(dynamic_intagg, "Dynamic Interrupt Aggregation Setting");module_param (intagg_delay, int,0 );MODULE_PARM_DESC (intagg_delay,"uSec Interrupt Aggregation Delay" ); -static DEFINE_PCI_DEVICE_TABLE (slic_pci_tbl) = { +static const struct pci_device_id slic_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_ALACRITECH ,SLIC_1GB_DEVICE_ID ) }, {PCI_DEVICE (PCI_VENDOR_ID_ALACRITECH ,SLIC_2GB_DEVICE_ID ) }, {0 }
drivers/staging/sm7xxfb/sm7xxfb.c +1 -1
@@ -920,7 +920,7 @@ failed_free:* 0x712 (LynxEM+) * 0x720 (Lynx3DM, Lynx3DM+) */ -static DEFINE_PCI_DEVICE_TABLE (smtcfb_pci_table) = { +static const struct pci_device_id smtcfb_pci_table[] = { {PCI_DEVICE (0x126f ,0x710 ), }, {PCI_DEVICE (0x126f ,0x712 ), }, {PCI_DEVICE (0x126f ,0x720 ), },
drivers/staging/vt6655/device_main.c +1 -1
@@ -267,7 +267,7 @@ static CHIP_INFO chip_info_table[] = { {0, NULL} }; -DEFINE_PCI_DEVICE_TABLE (vt6655_pci_id_table) = { +const struct pci_device_id vt6655_pci_id_table[] = { {PCI_VDEVICE (VIA ,0x3253 ), (kernel_ulong_t )chip_info_table}, {0 , } };
drivers/staging/xgifb/XGI_main.h +1 -1
@@ -11,7 +11,7 @@#define PCI_DEVICE_ID_XGI_27 0x027#endif -static DEFINE_PCI_DEVICE_TABLE (xgifb_pci_table) = { +static const struct pci_device_id xgifb_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_XGI ,PCI_DEVICE_ID_XGI_20 )}, {PCI_DEVICE (PCI_VENDOR_ID_XGI ,PCI_DEVICE_ID_XGI_27 )}, {PCI_DEVICE (PCI_VENDOR_ID_XGI ,PCI_DEVICE_ID_XGI_40 )},
drivers/staging/xillybus/xillybus_pcie.c +1 -1
@@ -30,7 +30,7 @@ MODULE_LICENSE("GPL v2");static const char xillyname[] ="xillybus_pcie" ; -static DEFINE_PCI_DEVICE_TABLE (xillyids) = { +static const struct pci_device_id xillyids[] = { {PCI_DEVICE (PCI_VENDOR_ID_XILINX ,PCI_DEVICE_ID_XILLYBUS )}, {PCI_DEVICE (PCI_VENDOR_ID_ALTERA ,PCI_DEVICE_ID_XILLYBUS )}, {PCI_DEVICE (PCI_VENDOR_ID_ACTEL ,PCI_DEVICE_ID_XILLYBUS )},
Signature · 1 line
1.7.10.4
Re: [PATCH 28/39] staging: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 5 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>
I think you misunderstood the checkpatch.pl warning, it tells you what to do, not what not to do.
WARNING: Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id
This means use DEFINE_PCI_DEVICE_TABLE to replace struct pci_device_id, not reverse.
Greg Kroah-Hartman
maintainerRe: [PATCH 28/39] staging: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 7 lines · ZHAO Gang
Quoted 5 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>
Quoted 7 lines
I think you misunderstood the checkpatch.pl warning, it tells you what to do, not what not to do.
WARNING: Use
DEFINE_PCI_DEVICE_TABLEfor structpci_device_idThis means use
DEFINE_PCI_DEVICE_TABLEto replace structpci_device_id, not reverse.
No, checkpatch is wrong, and is being fixed, this patch is correct.
Re: [PATCH 28/39] staging: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 11 lines · Greg Kroah-Hartman
Quoted 10 lines · ZHAO Gang
Quoted 5 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>I think you misunderstood the checkpatch.pl warning, it tells you what to do, not what not to do.
Quoted 6 lines
Quoted 4 lines
WARNING: Use
DEFINE_PCI_DEVICE_TABLEfor structpci_device_idThis means use
DEFINE_PCI_DEVICE_TABLEto replace structpci_device_id, not reverse.No, checkpatch is wrong, and is being fixed, this patch is correct.
Oh, I didn't notice the recent checkpatch update, sorry for the noise.
PATCH 29/39 tty: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/tty/rocket.c | 2 +- drivers/tty/serial/pch_uart.c | 2 +- drivers/tty/serial/rp2.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/tty/rocket.c +1 -1
@@ -1744,7 +1744,7 @@ static void rp_flush_buffer(struct tty_struct *tty)#ifdef CONFIG_PCI -static DEFINE_PCI_DEVICE_TABLE (rocket_pci_ids) = { +static const struct pci_device_id rocket_pci_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_RP ,PCI_DEVICE_ID_RP4QUAD ) }, {PCI_DEVICE (PCI_VENDOR_ID_RP ,PCI_DEVICE_ID_RP8OCTA ) }, { PCI_DEVICE(PCI_VENDOR_ID_RP, PCI_DEVICE_ID_URP8OCTA) },
drivers/tty/serial/pch_uart.c +1 -1
@@ -1907,7 +1907,7 @@ static int pch_uart_pci_resume(struct pci_dev *pdev)#define pch_uart_pci_resume NULL#endif -static DEFINE_PCI_DEVICE_TABLE (pch_uart_pci_id) = { +static const struct pci_device_id pch_uart_pci_id[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,0x8811 ), .driver_data = pch_et20t_uart0}, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,0x8812 ),
drivers/tty/serial/rp2.c +1 -1
@@ -810,7 +810,7 @@ static void rp2_remove(struct pci_dev *pdev)rp2_remove_ports (card); } -static DEFINE_PCI_DEVICE_TABLE (rp2_pci_tbl) = { +static const struct pci_device_id rp2_pci_tbl[] = {/* RocketPort INFINITY cards */
Signature · 1 line
1.7.10.4
PATCH 30/39 uio: uio_mf624: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/uio/uio_mf624.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/uio/uio_mf624.c +1 -1
@@ -228,7 +228,7 @@ static void mf624_pci_remove(struct pci_dev *dev)kfree (info); } -static DEFINE_PCI_DEVICE_TABLE (mf624_pci_id) = { +static const struct pci_device_id mf624_pci_id[] = { {PCI_DEVICE (PCI_VENDOR_ID_HUMUSOFT ,PCI_DEVICE_ID_MF624 ) }, {0 , } };
Signature · 1 line
1.7.10.4
PATCH 31/39 USB: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/usb/chipidea/ci_hdrc_pci.c | 2 +- drivers/usb/dwc3/dwc3-pci.c | 2 +- drivers/usb/gadget/amd5536udc.c | 2 +- drivers/usb/gadget/pch_udc.c | 2 +- drivers/usb/host/uhci-pci.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-)
drivers/usb/chipidea/ci_hdrc_pci.c +1 -1
@@ -112,7 +112,7 @@ static void ci_hdrc_pci_remove(struct pci_dev *pdev)* * Check "pci.h" for details */ -static DEFINE_PCI_DEVICE_TABLE (ci_hdrc_pci_id_table) = { +static const struct pci_device_id ci_hdrc_pci_id_table[] = { {PCI_DEVICE (0x153F ,0x1004 ), .driver_data = (kernel_ulong_t)&pci_platdata,
drivers/usb/dwc3/dwc3-pci.c +1 -1
@@ -182,7 +182,7 @@ static void dwc3_pci_remove(struct pci_dev *pci)pci_disable_device (pci); } -static DEFINE_PCI_DEVICE_TABLE (dwc3_pci_id_table) = { +static const struct pci_device_id dwc3_pci_id_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_SYNOPSYS ,PCI_DEVICE_ID_SYNOPSYS_HAPSUSB3 ),
drivers/usb/gadget/amd5536udc.c +1 -1
@@ -3338,7 +3338,7 @@ static int udc_remote_wakeup(struct udc *dev) }/* PCI device parameters */ -static DEFINE_PCI_DEVICE_TABLE (pci_id) = { +static const struct pci_device_id pci_id[] = { {PCI_DEVICE (PCI_VENDOR_ID_AMD ,0x2096 ), .class = (PCI_CLASS_SERIAL_USB <<8 ) |0xfe ,
drivers/usb/gadget/pch_udc.c +1 -1
@@ -3210,7 +3210,7 @@ finished:return retval; } -static DEFINE_PCI_DEVICE_TABLE (pch_udc_pcidev_id) = { +static const struct pci_device_id pch_udc_pcidev_id[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_EG20T_UDC ), .class = (PCI_CLASS_SERIAL_USB <<8 ) |0xfe ,
drivers/usb/host/uhci-pci.c +1 -1
@@ -279,7 +279,7 @@ static const struct hc_driver uhci_driver = { .hub_control = uhci_hub_control, }; -static DEFINE_PCI_DEVICE_TABLE (uhci_pci_ids) = { { +static const struct pci_device_id uhci_pci_ids[] = { {/* handle any USB UHCI controller */ PCI_DEVICE_CLASS (PCI_CLASS_SERIAL_USB_UHCI , ~0 ), .driver_data = (unsigned long ) &uhci_driver,
Signature · 1 line
1.7.10.4
Re: [PATCH 31/39] USB: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 4 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>
I wonder why I wasn't Cc:ed to this email considering it touches three drivers I care about.
Greg, I have the original ones in my tree and I would really like to avoid rebasing my 'next' branch. Do we keep it there or do you want to avoid merging those commits ?
Jingoo, please keep maintainers in Cc next time, it's very tough to filter emails you care about otherwise.
cheers
Signature · 1 line
balbi
'Greg Kroah-Hartman'
maintainerRe: [PATCH 31/39] USB: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 4 lines · Felipe Balbi
Quoted 3 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.
Quoted 8 lines
Quoted 1 line
Signed-off-by Jingoo Han <[email protected]>I wonder why I wasn't Cc:ed to this email considering it touches three drivers I care about.
Greg, I have the original ones in my tree and I would really like to avoid rebasing my 'next' branch. Do we keep it there or do you want to avoid merging those commits ?
Just keep it there and we can handle the merge, it shouldn't be a big deal, right?
thanks,
greg k-h
Re: [PATCH 31/39] USB: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 10 lines · Greg Kroah-Hartman
Quoted 9 lines · Felipe Balbi
Quoted 4 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>I wonder why I wasn't Cc:ed to this email considering it touches three drivers I care about.
Quoted 6 lines
Quoted 3 lines
Greg, I have the original ones in my tree and I would really like to avoid rebasing my 'next' branch. Do we keep it there or do you want to avoid merging those commits ?
Just keep it there and we can handle the merge, it shouldn't be a big deal, right?
Should not. Thanks Greg.
Signature · 1 line
balbi
PATCH 32/39 video: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/video/hyperv_fb.c | 2 +- drivers/video/i740fb.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
drivers/video/hyperv_fb.c +1 -1
@@ -800,7 +800,7 @@ static int hvfb_remove(struct hv_device *hdev) } -static DEFINE_PCI_DEVICE_TABLE (pci_stub_id_table) = { +static const struct pci_device_id pci_stub_id_table[] = { { .vendor =PCI_VENDOR_ID_MICROSOFT , .device =PCI_DEVICE_ID_HYPERV_VIDEO ,
drivers/video/i740fb.c +1 -1
@@ -1260,7 +1260,7 @@ fail:#define I740_ID_PCI 0x00d1#define I740_ID_AGP 0x7800 -static DEFINE_PCI_DEVICE_TABLE (i740fb_id_table) = { +static const struct pci_device_id i740fb_id_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,I740_ID_PCI ) }, {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,I740_ID_AGP ) }, {0 }
Signature · 1 line
1.7.10.4
PATCH 33/39 virtio: pci: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/virtio/virtio_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/virtio/virtio_pci.c +1 -1
@@ -91,7 +91,7 @@ struct virtio_pci_vq_info };/* Qumranet donated their vendor ID for devices 0x1000 thru 0x10FF. */ -static DEFINE_PCI_DEVICE_TABLE (virtio_pci_id_table) = { +static const struct pci_device_id virtio_pci_id_table[] = { {PCI_DEVICE (0x1af4 ,PCI_ANY_ID ) }, {0 } };
Signature · 1 line
1.7.10.4
PATCH 34/39 vme: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/vme/boards/vme_vmivme7805.c | 2 +- drivers/vme/bridges/vme_ca91cx42.c | 2 +- drivers/vme/bridges/vme_tsi148.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)
drivers/vme/boards/vme_vmivme7805.c +1 -1
@@ -27,7 +27,7 @@ static void __iomem *vmic_base;static const char driver_name[] ="vmivme_7805" ; -static DEFINE_PCI_DEVICE_TABLE (vmic_ids) = { +static const struct pci_device_id vmic_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_VMIC ,PCI_DEVICE_ID_VTIMR ) }, { }, };
drivers/vme/bridges/vme_ca91cx42.c +1 -1
@@ -42,7 +42,7 @@ static int geoid;static const char driver_name[] ="vme_ca91cx42" ; -static DEFINE_PCI_DEVICE_TABLE (ca91cx42_ids) = { +static const struct pci_device_id ca91cx42_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_TUNDRA ,PCI_DEVICE_ID_TUNDRA_CA91C142 ) }, { }, };
drivers/vme/bridges/vme_tsi148.c +1 -1
@@ -45,7 +45,7 @@ static int geoid;static const char driver_name[] ="vme_tsi148" ; -static DEFINE_PCI_DEVICE_TABLE (tsi148_ids) = { +static const struct pci_device_id tsi148_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_TUNDRA ,PCI_DEVICE_ID_TUNDRA_TSI148 ) }, { }, };
Signature · 1 line
1.7.10.4
Re: [PATCH 34/39] vme: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 5 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>---
Greg, this patch should be reverted. It do the opposite things.
Quoted 52 lines
drivers/vme/boards/vme_vmivme7805.c | 2 +- drivers/vme/bridges/vme_ca91cx42.c | 2 +- drivers/vme/bridges/vme_tsi148.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-)drivers/vme/boards/vme_vmivme7805.c +1
-1@@ -27,7 +27,7 @@ static void __iomem *vmic_base;static const char driver_name[] ="vmivme_7805" ; -static DEFINE_PCI_DEVICE_TABLE (vmic_ids) = { +static const struct pci_device_id vmic_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_VMIC ,PCI_DEVICE_ID_VTIMR ) }, { }, };drivers/vme/bridges/vme_ca91cx42.c +1
-1@@ -42,7 +42,7 @@ static int geoid;static const char driver_name[] ="vme_ca91cx42" ; -static DEFINE_PCI_DEVICE_TABLE (ca91cx42_ids) = { +static const struct pci_device_id ca91cx42_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_TUNDRA ,PCI_DEVICE_ID_TUNDRA_CA91C142 ) }, { }, };drivers/vme/bridges/vme_tsi148.c +1
-2@@ -45,7 +45,7 @@ static int geoid;static const char driver_name[] ="vme_tsi148" ; -static DEFINE_PCI_DEVICE_TABLE (tsi148_ids) = { +static const struct pci_device_id tsi148_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_TUNDRA ,PCI_DEVICE_ID_TUNDRA_TSI148 ) }, { }, }; --1.7.10.4
_______________________________________________
devel mailing list
[email protected]
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Greg Kroah-Hartman
maintainerRe: [PATCH 34/39] vme: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 8 lines · ZHAO Gang
Quoted 5 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>---
Greg, this patch should be reverted. It do the opposite things.
Not at all, it is correct.
PATCH 35/39 watchdog: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/watchdog/alim1535_wdt.c | 2 +- drivers/watchdog/alim7101_wdt.c | 2 +- drivers/watchdog/hpwdt.c | 2 +- drivers/watchdog/i6300esb.c | 2 +- drivers/watchdog/nv_tco.c | 2 +- drivers/watchdog/pcwd_pci.c | 2 +- drivers/watchdog/sp5100_tco.c | 2 +- drivers/watchdog/via_wdt.c | 2 +- drivers/watchdog/wdt_pci.c | 2 +- 9 files changed, 9 insertions(+), 9 deletions(-)
drivers/watchdog/alim1535_wdt.c +1 -1
@@ -301,7 +301,7 @@ static int ali_notify_sys(struct notifier_block *this,* want to register another driver on the same PCI id. */ -static DEFINE_PCI_DEVICE_TABLE (ali_pci_tbl)__used = { +static const struct pci_device_id ali_pci_tbl[]__used = { {PCI_VENDOR_ID_AL ,0x1533 ,PCI_ANY_ID ,PCI_ANY_ID ,}, {PCI_VENDOR_ID_AL ,0x1535 ,PCI_ANY_ID ,PCI_ANY_ID ,}, {0 , },
drivers/watchdog/alim7101_wdt.c +1 -1
@@ -414,7 +414,7 @@ err_out:module_init (alim7101_wdt_init);module_exit (alim7101_wdt_unload); -static DEFINE_PCI_DEVICE_TABLE (alim7101_pci_tbl)__used = { +static const struct pci_device_id alim7101_pci_tbl[]__used = { {PCI_DEVICE (PCI_VENDOR_ID_AL ,PCI_DEVICE_ID_AL_M1533 ) }, {PCI_DEVICE (PCI_VENDOR_ID_AL ,PCI_DEVICE_ID_AL_M7101 ) }, { }
drivers/watchdog/hpwdt.c +1 -1
@@ -55,7 +55,7 @@ static void __iomem *pci_mem_addr; /* the PCI-memory address */static unsigned long __iomem *hpwdt_timer_reg;static unsigned long __iomem *hpwdt_timer_con; -static DEFINE_PCI_DEVICE_TABLE (hpwdt_devices) = { +static const struct pci_device_id hpwdt_devices[] = { {PCI_DEVICE (PCI_VENDOR_ID_COMPAQ ,0xB203 ) },/* iLO2 */ {PCI_DEVICE (PCI_VENDOR_ID_HP ,0x3306 ) },/* iLO3 */ {0 },/* terminate list */
drivers/watchdog/i6300esb.c +1 -1
@@ -334,7 +334,7 @@ static struct miscdevice esb_miscdev = {/* * Data for PCI driver interface */ -static DEFINE_PCI_DEVICE_TABLE (esb_pci_tbl) = { +static const struct pci_device_id esb_pci_tbl[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_ESB_9 ), }, {0 , },/* End of list */ };
drivers/watchdog/nv_tco.c +1 -1
@@ -289,7 +289,7 @@ static struct miscdevice nv_tco_miscdev = {* register a pci_driver, because someone else might one day * want to register another driver on the same PCI id. */ -static DEFINE_PCI_DEVICE_TABLE (tco_pci_tbl) = { +static const struct pci_device_id tco_pci_tbl[] = { {PCI_VENDOR_ID_NVIDIA ,PCI_DEVICE_ID_NVIDIA_NFORCE_MCP51_SMBUS ,PCI_ANY_ID ,PCI_ANY_ID , }, {PCI_VENDOR_ID_NVIDIA ,PCI_DEVICE_ID_NVIDIA_NFORCE_MCP55_SMBUS ,
drivers/watchdog/pcwd_pci.c +1 -1
@@ -801,7 +801,7 @@ static void pcipcwd_card_exit(struct pci_dev *pdev) cards_found--; } -static DEFINE_PCI_DEVICE_TABLE (pcipcwd_pci_tbl) = { +static const struct pci_device_id pcipcwd_pci_tbl[] = { {PCI_VENDOR_ID_QUICKLOGIC ,PCI_DEVICE_ID_WATCHDOG_PCIPCWD ,PCI_ANY_ID ,PCI_ANY_ID , }, {0 },/* End of list */
drivers/watchdog/sp5100_tco.c +1 -1
@@ -303,7 +303,7 @@ static struct miscdevice sp5100_tco_miscdev = {* register a pci_driver, because someone else might * want to register another driver on the same PCI id. */ -static DEFINE_PCI_DEVICE_TABLE (sp5100_tco_pci_tbl) = { +static const struct pci_device_id sp5100_tco_pci_tbl[] = { {PCI_VENDOR_ID_ATI ,PCI_DEVICE_ID_ATI_SBX00_SMBUS ,PCI_ANY_ID ,PCI_ANY_ID , }, {0 , },/* End of list */
drivers/watchdog/via_wdt.c +1 -1
@@ -239,7 +239,7 @@ static void wdt_remove(struct pci_dev *pdev)pci_disable_device (pdev); } -static DEFINE_PCI_DEVICE_TABLE (wdt_pci_table) = { +static const struct pci_device_id wdt_pci_table[] = { {PCI_DEVICE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_CX700 ) }, {PCI_DEVICE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_VX800 ) }, {PCI_DEVICE (PCI_VENDOR_ID_VIA ,PCI_DEVICE_ID_VIA_VX855 ) },
drivers/watchdog/wdt_pci.c +1 -1
@@ -720,7 +720,7 @@ static void wdtpci_remove_one(struct pci_dev *pdev) } -static DEFINE_PCI_DEVICE_TABLE (wdtpci_pci_tbl) = { +static const struct pci_device_id wdtpci_pci_tbl[] = { { .vendor =PCI_VENDOR_ID_ACCESSIO , .device =PCI_DEVICE_ID_ACCESSIO_WDG_CSM ,
Signature · 1 line
1.7.10.4
Re: [PATCH 35/39] watchdog: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 4 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred.Signed-off-by Jingoo Han <[email protected]>
PATCH 36/39 xen: pciback: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/xen/xen-pciback/pci_stub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/xen/xen-pciback/pci_stub.c +1 -1
@@ -564,7 +564,7 @@ static void pcistub_remove(struct pci_dev *dev) } } -static DEFINE_PCI_DEVICE_TABLE (pcistub_ids) = { +static const struct pci_device_id pcistub_ids[] = { { .vendor =PCI_ANY_ID , .device =PCI_ANY_ID ,
Signature · 1 line
1.7.10.4
PATCH 36/39 xen: pciback: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- drivers/xen/xen-pciback/pci_stub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/xen/xen-pciback/pci_stub.c +1 -1
@@ -564,7 +564,7 @@ static void pcistub_remove(struct pci_dev *dev) } } -static DEFINE_PCI_DEVICE_TABLE (pcistub_ids) = { +static const struct pci_device_id pcistub_ids[] = { { .vendor =PCI_ANY_ID , .device =PCI_ANY_ID ,
Signature · 1 line
1.7.10.4
PATCH 37/39 sound: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred.
--- sound/oss/kahlua.c | 2 +- sound/pci/ad1889.c | 2 +- sound/pci/ali5451/ali5451.c | 2 +- sound/pci/als300.c | 2 +- sound/pci/als4000.c | 2 +- sound/pci/asihpi/asihpi.c | 2 +- sound/pci/atiixp.c | 2 +- sound/pci/atiixp_modem.c | 2 +- sound/pci/au88x0/au8810.c | 2 +- sound/pci/au88x0/au8820.c | 2 +- sound/pci/au88x0/au8830.c | 2 +- sound/pci/aw2/aw2-alsa.c | 2 +- sound/pci/azt3328.c | 2 +- sound/pci/bt87x.c | 4 ++-- sound/pci/ca0106/ca0106_main.c | 2 +- sound/pci/cmipci.c | 4 ++-- sound/pci/cs4281.c | 2 +- sound/pci/cs46xx/cs46xx.c | 2 +- sound/pci/cs5530.c | 2 +- sound/pci/cs5535audio/cs5535audio.c | 2 +- sound/pci/ctxfi/xfi.c | 2 +- sound/pci/echoaudio/darla20.c | 2 +- sound/pci/echoaudio/darla24.c | 2 +- sound/pci/echoaudio/echo3g.c | 2 +- sound/pci/echoaudio/gina20.c | 2 +- sound/pci/echoaudio/gina24.c | 2 +- sound/pci/echoaudio/indigo.c | 2 +- sound/pci/echoaudio/indigodj.c | 2 +- sound/pci/echoaudio/indigodjx.c | 2 +- sound/pci/echoaudio/indigoio.c | 2 +- sound/pci/echoaudio/indigoiox.c | 2 +- sound/pci/echoaudio/layla20.c | 2 +- sound/pci/echoaudio/layla24.c | 2 +- sound/pci/echoaudio/mia.c | 2 +- sound/pci/echoaudio/mona.c | 2 +- sound/pci/emu10k1/emu10k1.c | 2 +- sound/pci/emu10k1/emu10k1x.c | 2 +- sound/pci/ens1370.c | 2 +- sound/pci/es1938.c | 2 +- sound/pci/es1968.c | 2 +- sound/pci/fm801.c | 2 +- sound/pci/hda/hda_intel.c | 2 +- sound/pci/ice1712/ice1712.c | 2 +- sound/pci/ice1712/ice1724.c | 2 +- sound/pci/intel8x0.c | 2 +- sound/pci/intel8x0m.c | 2 +- sound/pci/korg1212/korg1212.c | 2 +- sound/pci/lola/lola.c | 2 +- sound/pci/lx6464es/lx6464es.c | 2 +- sound/pci/maestro3.c | 2 +- sound/pci/mixart/mixart.c | 2 +- sound/pci/nm256/nm256.c | 2 +- sound/pci/oxygen/oxygen.c | 2 +- sound/pci/oxygen/virtuoso.c | 2 +- sound/pci/pcxhr/pcxhr.c | 2 +- sound/pci/riptide/riptide.c | 4 ++-- sound/pci/rme32.c | 2 +- sound/pci/rme96.c | 2 +- sound/pci/rme9652/hdsp.c | 2 +- sound/pci/rme9652/hdspm.c | 2 +- sound/pci/rme9652/rme9652.c | 2 +- sound/pci/sis7019.c | 2 +- sound/pci/sonicvibes.c | 2 +- sound/pci/trident/trident.c | 2 +- sound/pci/via82xx.c | 2 +- sound/pci/via82xx_modem.c | 2 +- sound/pci/vx222/vx222.c | 2 +- sound/pci/ymfpci/ymfpci.c | 2 +- 68 files changed, 71 insertions(+), 71 deletions(-)
sound/oss/kahlua.c +1 -1
@@ -197,7 +197,7 @@ MODULE_LICENSE("GPL");* 5530 only. The 5510/5520 decode is different. */ -static DEFINE_PCI_DEVICE_TABLE (id_tbl) = { +static const struct pci_device_id id_tbl[] = { {PCI_VDEVICE (CYRIX ,PCI_DEVICE_ID_CYRIX_5530_AUDIO ),0 }, { } };
sound/pci/ad1889.c +1 -1
@@ -1048,7 +1048,7 @@ snd_ad1889_remove(struct pci_dev *pci)snd_card_free (pci_get_drvdata (pci)); } -static DEFINE_PCI_DEVICE_TABLE (snd_ad1889_ids) = { +static const struct pci_device_id snd_ad1889_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_ANALOG_DEVICES ,PCI_DEVICE_ID_AD1889JS ) }, {0 , }, };
sound/pci/ali5451/ali5451.c +1 -1
@@ -275,7 +275,7 @@ struct snd_ali {#endif }; -static DEFINE_PCI_DEVICE_TABLE (snd_ali_ids) = { +static const struct pci_device_id snd_ali_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_AL ,PCI_DEVICE_ID_AL_M5451 ),0 ,0 ,0 }, {0 , } };
sound/pci/als300.c +1 -1
@@ -152,7 +152,7 @@ struct snd_als300_substream_data {int block_counter_register; }; -static DEFINE_PCI_DEVICE_TABLE (snd_als300_ids) = { +static const struct pci_device_id snd_als300_ids[] = { {0x4005 ,0x0300 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,DEVICE_ALS300 }, {0x4005 ,0x0308 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,DEVICE_ALS300_PLUS }, {0 , }
sound/pci/als4000.c +1 -1
@@ -116,7 +116,7 @@ struct snd_card_als4000 {#endif }; -static DEFINE_PCI_DEVICE_TABLE (snd_als4000_ids) = { +static const struct pci_device_id snd_als4000_ids[] = { {0x4005 ,0x4000 ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 , },/* ALS4000 */ {0 , } };
sound/pci/asihpi/asihpi.c +1 -1
@@ -2960,7 +2960,7 @@ static void snd_asihpi_remove(struct pci_dev *pci_dev)asihpi_adapter_remove (pci_dev); } -static DEFINE_PCI_DEVICE_TABLE (asihpi_pci_tbl) = { +static const struct pci_device_id asihpi_pci_tbl[] = { {HPI_PCI_VENDOR_ID_TI ,HPI_PCI_DEV_ID_DSP6205 ,HPI_PCI_VENDOR_ID_AUDIOSCIENCE ,PCI_ANY_ID ,0 ,0 , (kernel_ulong_t )HPI_6205 },
sound/pci/atiixp.c +1 -1
@@ -286,7 +286,7 @@ struct atiixp {/* */ -static DEFINE_PCI_DEVICE_TABLE (snd_atiixp_ids) = { +static const struct pci_device_id snd_atiixp_ids[] = { {PCI_VDEVICE (ATI ,0x4341 ),0 },/* SB200 */ {PCI_VDEVICE (ATI ,0x4361 ),0 },/* SB300 */ {PCI_VDEVICE (ATI ,0x4370 ),0 },/* SB400 */
sound/pci/atiixp_modem.c +1 -1
@@ -261,7 +261,7 @@ struct atiixp_modem {/* */ -static DEFINE_PCI_DEVICE_TABLE (snd_atiixp_ids) = { +static const struct pci_device_id snd_atiixp_ids[] = { {PCI_VDEVICE (ATI ,0x434d ),0 },/* SB200 */ {PCI_VDEVICE (ATI ,0x4378 ),0 },/* SB400 */ {0 , }
sound/pci/au88x0/au8810.c +1 -1
@@ -1,6 +1,6 @@#include "au8810.h" #include "au88x0.h" -static DEFINE_PCI_DEVICE_TABLE (snd_vortex_ids) = { +static const struct pci_device_id snd_vortex_ids[] = { {PCI_VDEVICE (AUREAL ,PCI_DEVICE_ID_AUREAL_ADVANTAGE ),1 ,}, {0 ,} };
sound/pci/au88x0/au8820.c +1 -1
@@ -1,6 +1,6 @@#include "au8820.h" #include "au88x0.h" -static DEFINE_PCI_DEVICE_TABLE (snd_vortex_ids) = { +static const struct pci_device_id snd_vortex_ids[] = { {PCI_VDEVICE (AUREAL ,PCI_DEVICE_ID_AUREAL_VORTEX_1 ),0 ,}, {0 ,} };
sound/pci/au88x0/au8830.c +1 -1
@@ -1,6 +1,6 @@#include "au8830.h" #include "au88x0.h" -static DEFINE_PCI_DEVICE_TABLE (snd_vortex_ids) = { +static const struct pci_device_id snd_vortex_ids[] = { {PCI_VDEVICE (AUREAL ,PCI_DEVICE_ID_AUREAL_VORTEX_2 ),0 ,}, {0 ,} };
sound/pci/aw2/aw2-alsa.c +1 -1
@@ -160,7 +160,7 @@ MODULE_PARM_DESC(id, "ID string for the Audiowerk2 soundcard.");module_param_array (enable, bool,NULL ,0444 );MODULE_PARM_DESC (enable,"Enable Audiowerk2 soundcard." ); -static DEFINE_PCI_DEVICE_TABLE (snd_aw2_ids) = { +static const struct pci_device_id snd_aw2_ids[] = { {PCI_VENDOR_ID_PHILIPS ,PCI_DEVICE_ID_PHILIPS_SAA7146 ,0 ,0 ,0 ,0 ,0 }, {0 }
sound/pci/azt3328.c +1 -1
@@ -376,7 +376,7 @@ struct snd_azf3328 {#endif }; -static DEFINE_PCI_DEVICE_TABLE (snd_azf3328_ids) = { +static const struct pci_device_id snd_azf3328_ids[] = { {0x122D ,0x50DC ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 },/* PCI168/3328 */ {0x122D ,0x80DA ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 ,0 },/* 3328 */ {0 , }
sound/pci/bt87x.c +2 -2
@@ -789,7 +789,7 @@ fail: .driver_data = SND_BT87X_BOARD_ ## id }/* driver_data is the card id for that device */ -static DEFINE_PCI_DEVICE_TABLE (snd_bt87x_ids) = { +static const struct pci_device_id snd_bt87x_ids[] = {/* Hauppauge WinTV series */ BT_DEVICE (PCI_DEVICE_ID_BROOKTREE_878 ,0x0070 ,0x13eb ,GENERIC ),/* Hauppauge WinTV series */
@@ -957,7 +957,7 @@ static void snd_bt87x_remove(struct pci_dev *pci)/* default entries for all Bt87x cards - it's not exported */ /* driver_data is set to 0 to call detection */ -static DEFINE_PCI_DEVICE_TABLE (snd_bt87x_default_ids) = { +static const struct pci_device_id snd_bt87x_default_ids[] = {BT_DEVICE (PCI_DEVICE_ID_BROOKTREE_878 ,PCI_ANY_ID ,PCI_ANY_ID ,UNKNOWN ),BT_DEVICE (PCI_DEVICE_ID_BROOKTREE_879 ,PCI_ANY_ID ,PCI_ANY_ID ,UNKNOWN ), { }
sound/pci/ca0106/ca0106_main.c +1 -1
@@ -1959,7 +1959,7 @@ static SIMPLE_DEV_PM_OPS(snd_ca0106_pm, snd_ca0106_suspend, snd_ca0106_resume);#endif // PCI IDs -static DEFINE_PCI_DEVICE_TABLE (snd_ca0106_ids) = { +static const struct pci_device_id snd_ca0106_ids[] = { {PCI_VDEVICE (CREATIVE ,0x0007 ),0 },/* Audigy LS or Live 24bit */ {0 , } };
sound/pci/cmipci.c +2 -2
@@ -2803,7 +2803,7 @@ static inline void snd_cmipci_proc_init(struct cmipci *cm) {}#endif -static DEFINE_PCI_DEVICE_TABLE (snd_cmipci_ids) = { +static const struct pci_device_id snd_cmipci_ids[] = { {PCI_VDEVICE (CMEDIA ,PCI_DEVICE_ID_CMEDIA_CM8338A ),0 }, {PCI_VDEVICE (CMEDIA ,PCI_DEVICE_ID_CMEDIA_CM8338B ),0 }, {PCI_VDEVICE (CMEDIA ,PCI_DEVICE_ID_CMEDIA_CM8738 ),0 },
@@ -3025,7 +3025,7 @@ static int snd_cmipci_create(struct snd_card *card, struct pci_dev *pci,int integrated_midi =0 ;char modelstr[16 ];int pcm_index, pcm_spdif_index; -static DEFINE_PCI_DEVICE_TABLE (intel_82437vx) = { +static const struct pci_device_id intel_82437vx[] = { {PCI_DEVICE (PCI_VENDOR_ID_INTEL ,PCI_DEVICE_ID_INTEL_82437VX ) }, { }, };
sound/pci/cs4281.c +1 -1
@@ -494,7 +494,7 @@ struct cs4281 {static irqreturn_t snd_cs4281_interrupt (int irq,void *dev_id); -static DEFINE_PCI_DEVICE_TABLE (snd_cs4281_ids) = { +static const struct pci_device_id snd_cs4281_ids[] = { {PCI_VDEVICE (CIRRUS ,0x6005 ),0 , },/* CS4281 */ {0 , } };
sound/pci/cs46xx/cs46xx.c +1 -1
@@ -64,7 +64,7 @@ MODULE_PARM_DESC(thinkpad, "Force to enable Thinkpad's CLKRUN control.");module_param_array (mmap_valid, bool,NULL ,0444 );MODULE_PARM_DESC (mmap_valid,"Support OSS mmap." ); -static DEFINE_PCI_DEVICE_TABLE (snd_cs46xx_ids) = { +static const struct pci_device_id snd_cs46xx_ids[] = { {PCI_VDEVICE (CIRRUS ,0x6001 ),0 , },/* CS4280 */ {PCI_VDEVICE (CIRRUS ,0x6003 ),0 , },/* CS4612 */ {PCI_VDEVICE (CIRRUS ,0x6004 ),0 , },/* CS4615 */
sound/pci/cs5530.c +1 -1
@@ -66,7 +66,7 @@ struct snd_cs5530 {unsigned long pci_base; }; -static DEFINE_PCI_DEVICE_TABLE (snd_cs5530_ids) = { +static const struct pci_device_id snd_cs5530_ids[] = { {PCI_VENDOR_ID_CYRIX ,PCI_DEVICE_ID_CYRIX_5530_AUDIO ,PCI_ANY_ID ,PCI_ANY_ID ,0 ,0 }, {0 ,}
sound/pci/cs5535audio/cs5535audio.c +1 -1
@@ -66,7 +66,7 @@ MODULE_PARM_DESC(id, "ID string for " DRIVER_NAME);module_param_array (enable, bool,NULL ,0444 );MODULE_PARM_DESC (enable,"Enable " DRIVER_NAME ); -static DEFINE_PCI_DEVICE_TABLE (snd_cs5535audio_ids) = { +static const struct pci_device_id snd_cs5535audio_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_NS ,PCI_DEVICE_ID_NS_CS5535_AUDIO ) }, {PCI_DEVICE (PCI_VENDOR_ID_AMD ,PCI_DEVICE_ID_AMD_CS5536_AUDIO ) }, {}
sound/pci/ctxfi/xfi.c +1 -1
@@ -44,7 +44,7 @@ MODULE_PARM_DESC(enable, "Enable Creative X-Fi driver");module_param_array (subsystem, int,NULL ,0444 );MODULE_PARM_DESC (subsystem,"Override subsystem ID for Creative X-Fi driver" ); -static DEFINE_PCI_DEVICE_TABLE (ct_pci_dev_ids) = { +static const struct pci_device_id ct_pci_dev_ids[] = {/* only X-Fi is supported, so... */ {PCI_DEVICE (PCI_VENDOR_ID_CREATIVE ,PCI_DEVICE_ID_CREATIVE_20K1 ), .driver_data =ATC20K1 ,
sound/pci/echoaudio/darla20.c +1 -1
@@ -63,7 +63,7 @@ static const struct firmware card_fw[] = { {0, "darla20_dsp.fw"} }; -static DEFINE_PCI_DEVICE_TABLE (snd_echo_ids) = { +static const struct pci_device_id snd_echo_ids[] = { {0x1057 ,0x1801 ,0xECC0 ,0x0010 ,0 ,0 ,0 },/* DSP 56301 Darla20 rev.0 */ {0 ,} };
sound/pci/echoaudio/darla24.c +1 -1
@@ -67,7 +67,7 @@ static const struct firmware card_fw[] = { {0, "darla24_dsp.fw"} }; -static DEFINE_PCI_DEVICE_TABLE (snd_echo_ids) = { +static const struct pci_device_id snd_echo_ids[] = { {0x1057 ,0x1801 ,0xECC0 ,0x0040 ,0 ,0 ,0 },/* DSP 56301 Darla24 rev.0 */ {0x1057 ,0x1801 ,0xECC0 ,0x0041 ,0 ,0 ,0 },/* DSP 56301 Darla24 rev.1 */ {0 ,}
sound/pci/echoaudio/echo3g.c +1 -1
@@ -81,7 +81,7 @@ static const struct firmware card_fw[] = { {0, "3g_asic.fw"} }; -static DEFINE_PCI_DEVICE_TABLE (snd_echo_ids) = { +static const struct pci_device_id snd_echo_ids[] = { {0x1057 ,0x3410 ,0xECC0 ,0x0100 ,0 ,0 ,0 },/* Echo 3G */ {0 ,} };
sound/pci/echoaudio/gina20.c +1 -1
@@ -67,7 +67,7 @@ static const struct firmware card_fw[] = { {0, "gina20_dsp.fw"} }; -static DEFINE_PCI_DEVICE_TABLE (snd_echo_ids) = { +static const struct pci_device_id snd_echo_ids[] = { {0x1057 ,0x1801 ,0xECC0 ,0x0020 ,0 ,0 ,0 },/* DSP 56301 Gina20 rev.0 */ {0 ,} };
sound/pci/echoaudio/gina24.c +1 -1
@@ -85,7 +85,7 @@ static const struct firmware card_fw[] = { {0, "gina24_361_asic.fw"} }; -static DEFINE_PCI_DEVICE_TABLE (snd_echo_ids) = { +static const struct pci_device_id snd_echo_ids[] = { {0x1057 ,0x1801 ,0xECC0 ,0x0050 ,0 ,0 ,0 },/* DSP 56301 Gina24 rev.0 */ {0x1057 ,0x1801 ,0xECC0 ,0x0051 ,0 ,0 ,0 },/* DSP 56301 Gina24 rev.1 */ {0x1057 ,0x3410 ,0xECC0 ,0x0050 ,0 ,0 ,0 },/* DSP 56361 Gina24 rev.0 */
sound/pci/echoaudio/indigo.c +1 -1
@@ -68,7 +68,7 @@ static const struct firmware card_fw[] = { {0, "indigo_dsp.fw"} }; -static DEFINE_PCI_DEVICE_TABLE (snd_echo_ids) = { +static const struct pci_device_id snd_echo_ids[] = { {0x1057 ,0x3410 ,0xECC0 ,0x0090 ,0 ,0 ,0 },/* Indigo */ {0 ,} };
sound/pci/echoaudio/indigodj.c +1 -1
@@ -68,7 +68,7 @@ static const struct firmware card_fw[] = { {0, "indigo_dj_dsp.fw"} }; -static DEFINE_PCI_DEVICE_TABLE (snd_echo_ids) = { +static const struct pci_device_id snd_echo_ids[] = { {0x1057 ,0x3410 ,0xECC0 ,0x00B0 ,0 ,0 ,0 },/* Indigo DJ*/ {0 ,} };
sound/pci/echoaudio/indigodjx.c +1 -1
@@ -68,7 +68,7 @@ static const struct firmware card_fw[] = { {0, "indigo_djx_dsp.fw"} }; -static DEFINE_PCI_DEVICE_TABLE (snd_echo_ids) = { +static const struct pci_device_id snd_echo_ids[] = { {0x1057 ,0x3410 ,0xECC0 ,0x00E0 ,0 ,0 ,0 },/* Indigo DJx*/ {0 ,} };
sound/pci/echoaudio/indigoio.c +1 -1
@@ -69,7 +69,7 @@ static const struct firmware card_fw[] = { {0, "indigo_io_dsp.fw"} }; -static DEFINE_PCI_DEVICE_TABLE (snd_echo_ids) = { +static const struct pci_device_id snd_echo_ids[] = { {0x1057 ,0x3410 ,0xECC0 ,0x00A0 ,0 ,0 ,0 },/* Indigo IO*/ {0 ,} };
sound/pci/echoaudio/indigoiox.c +1 -1
@@ -69,7 +69,7 @@ static const struct firmware card_fw[] = { {0, "indigo_iox_dsp.fw"} }; -static DEFINE_PCI_DEVICE_TABLE (snd_echo_ids) = { +static const struct pci_device_id snd_echo_ids[] = { {0x1057 ,0x3410 ,0xECC0 ,0x00D0 ,0 ,0 ,0 },/* Indigo IOx */ {0 ,} };
sound/pci/echoaudio/layla20.c +1 -1
@@ -76,7 +76,7 @@ static const struct firmware card_fw[] = { {0, "layla20_asic.fw"} }; -static DEFINE_PCI_DEVICE_TABLE (snd_echo_ids) = { +static const struct pci_device_id snd_echo_ids[] = { {0x1057 ,0x1801 ,0xECC0 ,0x0030 ,0 ,0 ,0 },/* DSP 56301 Layla20 rev.0 */ {0x1057 ,0x1801 ,0xECC0 ,0x0031 ,0 ,0 ,0 },/* DSP 56301 Layla20 rev.1 */ {0 ,}
sound/pci/echoaudio/layla24.c +1 -1
@@ -87,7 +87,7 @@ static const struct firmware card_fw[] = { {0, "layla24_2S_asic.fw"} }; -static DEFINE_PCI_DEVICE_TABLE (snd_echo_ids) = { +static const struct pci_device_id snd_echo_ids[] = { {0x1057 ,0x3410 ,0xECC0 ,0x0060 ,0 ,0 ,0 },/* DSP 56361 Layla24 rev.0 */ {0 ,} };
sound/pci/echoaudio/mia.c +1 -1
@@ -77,7 +77,7 @@ static const struct firmware card_fw[] = { {0, "mia_dsp.fw"} }; -static DEFINE_PCI_DEVICE_TABLE (snd_echo_ids) = { +static const struct pci_device_id snd_echo_ids[] = { {0x1057 ,0x3410 ,0xECC0 ,0x0080 ,0 ,0 ,0 },/* DSP 56361 Mia rev.0 */ {0x1057 ,0x3410 ,0xECC0 ,0x0081 ,0 ,0 ,0 },/* DSP 56361 Mia rev.1 */ {0 ,}
sound/pci/echoaudio/mona.c +1 -1
@@ -92,7 +92,7 @@ static const struct firmware card_fw[] = { {0, "mona_2_asic.fw"} }; -static DEFINE_PCI_DEVICE_TABLE (snd_echo_ids) = { +static const struct pci_device_id snd_echo_ids[] = { {0x1057 ,0x1801 ,0xECC0 ,0x0070 ,0 ,0 ,0 },/* DSP 56301 Mona rev.0 */ {0x1057 ,0x1801 ,0xECC0 ,0x0071 ,0 ,0 ,0 },/* DSP 56301 Mona rev.1 */ {0x1057 ,0x1801 ,0xECC0 ,0x0072 ,0 ,0 ,0 },/* DSP 56301 Mona rev.2 */
sound/pci/emu10k1/emu10k1.c +1 -1
@@ -79,7 +79,7 @@ MODULE_PARM_DESC(delay_pcm_irq, "Delay PCM interrupt by specified number of samp/* * Class 0401: 1102:0008 (rev 00) Subsystem: 1102:1001 -> Audigy2 Value Model:SB0400 */ -static DEFINE_PCI_DEVICE_TABLE (snd_emu10k1_ids) = { +static const struct pci_device_id snd_emu10k1_ids[] = { {PCI_VDEVICE (CREATIVE ,0x0002 ),0 },/* EMU10K1 */ {PCI_VDEVICE (CREATIVE ,0x0004 ),1 },/* Audigy */ {PCI_VDEVICE (CREATIVE ,0x0008 ),1 },/* Audigy 2 Value SB0400 */
sound/pci/emu10k1/emu10k1x.c +1 -1
@@ -1626,7 +1626,7 @@ static void snd_emu10k1x_remove(struct pci_dev *pci) }// PCI IDs -static DEFINE_PCI_DEVICE_TABLE (snd_emu10k1x_ids) = { +static const struct pci_device_id snd_emu10k1x_ids[] = { {PCI_VDEVICE (CREATIVE ,0x0006 ),0 },/* Dell OEM version (EMU10K1) */ {0 , } };
sound/pci/ens1370.c +1 -1
@@ -446,7 +446,7 @@ struct ensoniq {static irqreturn_t snd_audiopci_interrupt (int irq,void *dev_id); -static DEFINE_PCI_DEVICE_TABLE(snd_audiopci_ids) = { +static const struct pci_device_id snd_audiopci_ids[] = { #ifdef CHIP1370 {PCI_VDEVICE (ENSONIQ ,0x5000 ),0 , },/* ES1370 */ #endif
sound/pci/es1938.c +1 -1
@@ -243,7 +243,7 @@ struct es1938 {static irqreturn_t snd_es1938_interrupt (int irq,void *dev_id); -static DEFINE_PCI_DEVICE_TABLE (snd_es1938_ids) = { +static const struct pci_device_id snd_es1938_ids[] = { {PCI_VDEVICE (ESS ,0x1969 ),0 , },/* Solo-1 */ {0 , } };
sound/pci/es1968.c +1 -1
@@ -570,7 +570,7 @@ struct es1968 {static irqreturn_t snd_es1968_interrupt (int irq,void *dev_id); -static DEFINE_PCI_DEVICE_TABLE (snd_es1968_ids) = { +static const struct pci_device_id snd_es1968_ids[] = {/* Maestro 1 */ {0x1285 ,0x0100 ,PCI_ANY_ID ,PCI_ANY_ID ,PCI_CLASS_MULTIMEDIA_AUDIO <<8 ,0xffff00 ,TYPE_MAESTRO },/* Maestro 2 */
sound/pci/fm801.c +1 -1
@@ -210,7 +210,7 @@ struct fm801 {#endif }; -static DEFINE_PCI_DEVICE_TABLE (snd_fm801_ids) = { +static const struct pci_device_id snd_fm801_ids[] = { {0x1319 ,0x0801 ,PCI_ANY_ID ,PCI_ANY_ID ,PCI_CLASS_MULTIMEDIA_AUDIO <<8 ,0xffff00 ,0 , },/* FM801 */ {0x5213 ,0x0510 ,PCI_ANY_ID ,PCI_ANY_ID ,PCI_CLASS_MULTIMEDIA_AUDIO <<8 ,0xffff00 ,0 , },/* Gallant Odyssey Sound 4 */ {0 , }
sound/pci/hda/hda_intel.c +1 -1
@@ -3969,7 +3969,7 @@ static void azx_remove(struct pci_dev *pci) }/* PCI IDs */ -static DEFINE_PCI_DEVICE_TABLE (azx_ids) = { +static const struct pci_device_id azx_ids[] = {/* CPT */ {PCI_DEVICE (0x8086 ,0x1c20 ), .driver_data =AZX_DRIVER_PCH |AZX_DCAPS_INTEL_PCH_NOPM },
sound/pci/ice1712/ice1712.c +1 -1
@@ -105,7 +105,7 @@ module_param_array(dxr_enable, int, NULL, 0444);MODULE_PARM_DESC (dxr_enable,"Enable DXR support for Terratec DMX6FIRE." ); -static DEFINE_PCI_DEVICE_TABLE (snd_ice1712_ids) = { +static const struct pci_device_id snd_ice1712_ids[] = { {PCI_VDEVICE (ICE ,PCI_DEVICE_ID_ICE_1712 ),0 },/* ICE1712 */ {0 , } };
sound/pci/ice1712/ice1724.c +1 -1
@@ -94,7 +94,7 @@ MODULE_PARM_DESC(model, "Use the given board model.");/* Both VT1720 and VT1724 have the same PCI IDs */ -static DEFINE_PCI_DEVICE_TABLE (snd_vt1724_ids) = { +static const struct pci_device_id snd_vt1724_ids[] = { {PCI_VDEVICE (ICE ,PCI_DEVICE_ID_VT1724 ),0 }, {0 , } };
sound/pci/intel8x0.c +1 -1
@@ -430,7 +430,7 @@ struct intel8x0 {u32 int_sta_mask;/* interrupt status mask */ }; -static DEFINE_PCI_DEVICE_TABLE (snd_intel8x0_ids) = { +static const struct pci_device_id snd_intel8x0_ids[] = { {PCI_VDEVICE (INTEL ,0x2415 ),DEVICE_INTEL },/* 82801AA */ {PCI_VDEVICE (INTEL ,0x2425 ),DEVICE_INTEL },/* 82901AB */ {PCI_VDEVICE (INTEL ,0x2445 ),DEVICE_INTEL },/* 82801BA */
sound/pci/intel8x0m.c +1 -1
@@ -219,7 +219,7 @@ struct intel8x0m {unsigned int pcm_pos_shift; }; -static DEFINE_PCI_DEVICE_TABLE (snd_intel8x0m_ids) = { +static const struct pci_device_id snd_intel8x0m_ids[] = { {PCI_VDEVICE (INTEL ,0x2416 ),DEVICE_INTEL },/* 82801AA */ {PCI_VDEVICE (INTEL ,0x2426 ),DEVICE_INTEL },/* 82901AB */ {PCI_VDEVICE (INTEL ,0x2446 ),DEVICE_INTEL },/* 82801BA */
sound/pci/korg1212/korg1212.c +1 -1
@@ -418,7 +418,7 @@ module_param_array(enable, bool, NULL, 0444);MODULE_PARM_DESC (enable,"Enable Korg 1212 soundcard." );MODULE_AUTHOR ("Haroldo Gamal <[email protected]>" ); -static DEFINE_PCI_DEVICE_TABLE (snd_korg1212_ids) = { +static const struct pci_device_id snd_korg1212_ids[] = { { .vendor =0x10b5 , .device =0x906d ,
sound/pci/lola/lola.c +1 -1
@@ -762,7 +762,7 @@ static void lola_remove(struct pci_dev *pci) }/* PCI IDs */ -static DEFINE_PCI_DEVICE_TABLE (lola_ids) = { +static const struct pci_device_id lola_ids[] = { {PCI_VDEVICE (DIGIGRAM ,0x0001 ) }, {0 , } };
sound/pci/lx6464es/lx6464es.c +1 -1
@@ -56,7 +56,7 @@ static const char card_name[] = "LX6464ES";#define PCI_DEVICE_ID_PLX_LX6464ES PCI_DEVICE_ID_PLX_9056 -static DEFINE_PCI_DEVICE_TABLE (snd_lx6464es_ids) = { +static const struct pci_device_id snd_lx6464es_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_PLX ,PCI_DEVICE_ID_PLX_LX6464ES ), .subvendor =PCI_VENDOR_ID_DIGIGRAM , .subdevice =PCI_SUBDEVICE_ID_DIGIGRAM_LX6464ES_SERIAL_SUBSYSTEM
sound/pci/maestro3.c +1 -1
@@ -800,7 +800,7 @@ struct snd_m3 {/* * pci ids */ -static DEFINE_PCI_DEVICE_TABLE (snd_m3_ids) = { +static const struct pci_device_id snd_m3_ids[] = { {PCI_VENDOR_ID_ESS ,PCI_DEVICE_ID_ESS_ALLEGRO_1 ,PCI_ANY_ID ,PCI_ANY_ID ,PCI_CLASS_MULTIMEDIA_AUDIO <<8 ,0xffff00 ,0 }, {PCI_VENDOR_ID_ESS ,PCI_DEVICE_ID_ESS_ALLEGRO ,PCI_ANY_ID ,PCI_ANY_ID ,
sound/pci/mixart/mixart.c +1 -1
@@ -61,7 +61,7 @@ MODULE_PARM_DESC(enable, "Enable Digigram " CARD_NAME " soundcard.");/* */ -static DEFINE_PCI_DEVICE_TABLE (snd_mixart_ids) = { +static const struct pci_device_id snd_mixart_ids[] = { {PCI_VDEVICE (MOTOROLA ,0x0003 ),0 , },/* MC8240 */ {0 , } };
sound/pci/nm256/nm256.c +1 -1
@@ -262,7 +262,7 @@ struct nm256 {/* * PCI ids */ -static DEFINE_PCI_DEVICE_TABLE (snd_nm256_ids) = { +static const struct pci_device_id snd_nm256_ids[] = { {PCI_VDEVICE (NEOMAGIC ,PCI_DEVICE_ID_NEOMAGIC_NM256AV_AUDIO ),0 }, {PCI_VDEVICE (NEOMAGIC ,PCI_DEVICE_ID_NEOMAGIC_NM256ZX_AUDIO ),0 }, {PCI_VDEVICE (NEOMAGIC ,PCI_DEVICE_ID_NEOMAGIC_NM256XL_PLUS_AUDIO ),0 },
sound/pci/oxygen/oxygen.c +1 -1
@@ -97,7 +97,7 @@ enum { MODEL_XONAR_DGX, }; -static DEFINE_PCI_DEVICE_TABLE (oxygen_ids) = { +static const struct pci_device_id oxygen_ids[] = {/* C-Media's reference design */ {OXYGEN_PCI_SUBID (0x10b0 ,0x0216 ), .driver_data =MODEL_CMEDIA_REF }, {OXYGEN_PCI_SUBID (0x10b0 ,0x0217 ), .driver_data =MODEL_CMEDIA_REF },
sound/pci/oxygen/virtuoso.c +1 -1
@@ -41,7 +41,7 @@ MODULE_PARM_DESC(id, "ID string");module_param_array (enable, bool,NULL ,0444 );MODULE_PARM_DESC (enable,"enable card" ); -static DEFINE_PCI_DEVICE_TABLE (xonar_ids) = { +static const struct pci_device_id xonar_ids[] = { {OXYGEN_PCI_SUBID (0x1043 ,0x8269 ) }, {OXYGEN_PCI_SUBID (0x1043 ,0x8275 ) }, {OXYGEN_PCI_SUBID (0x1043 ,0x82b7 ) },
sound/pci/pcxhr/pcxhr.c +1 -1
@@ -102,7 +102,7 @@ enum {PCI_ID_LAST }; -static DEFINE_PCI_DEVICE_TABLE (pcxhr_ids) = { +static const struct pci_device_id pcxhr_ids[] = { {0x10b5 ,0x9656 ,0x1369 ,0xb001 ,0 ,0 ,PCI_ID_VX882HR , }, {0x10b5 ,0x9656 ,0x1369 ,0xb101 ,0 ,0 ,PCI_ID_PCX882HR , }, {0x10b5 ,0x9656 ,0x1369 ,0xb201 ,0 ,0 ,PCI_ID_VX881HR , },
sound/pci/riptide/riptide.c +2 -2
@@ -508,7 +508,7 @@ static int riptide_reset(struct cmdif *cif, struct snd_riptide *chip);/* */ -static DEFINE_PCI_DEVICE_TABLE (snd_riptide_ids) = { +static const struct pci_device_id snd_riptide_ids[] = { {PCI_DEVICE (0x127a ,0x4310 ) }, {PCI_DEVICE (0x127a ,0x4320 ) }, {PCI_DEVICE (0x127a ,0x4330 ) },
@@ -517,7 +517,7 @@ static DEFINE_PCI_DEVICE_TABLE(snd_riptide_ids) = { };#ifdef SUPPORT_JOYSTICK -static DEFINE_PCI_DEVICE_TABLE (snd_riptide_joystick_ids) = { +static const struct pci_device_id snd_riptide_joystick_ids[] = { {PCI_DEVICE (0x127a ,0x4312 ) }, {PCI_DEVICE (0x127a ,0x4322 ) }, { PCI_DEVICE(0x127a, 0x4332) },
sound/pci/rme32.c +1 -1
@@ -226,7 +226,7 @@ struct rme32 {struct snd_kcontrol *spdif_ctl; }; -static DEFINE_PCI_DEVICE_TABLE (snd_rme32_ids) = { +static const struct pci_device_id snd_rme32_ids[] = { {PCI_VDEVICE (XILINX_RME ,PCI_DEVICE_ID_RME_DIGI32 ),0 ,}, {PCI_VDEVICE (XILINX_RME ,PCI_DEVICE_ID_RME_DIGI32_8 ),0 ,}, {PCI_VDEVICE (XILINX_RME ,PCI_DEVICE_ID_RME_DIGI32_PRO ),0 ,},
sound/pci/rme96.c +1 -1
@@ -263,7 +263,7 @@ struct rme96 {struct snd_kcontrol *spdif_ctl; }; -static DEFINE_PCI_DEVICE_TABLE (snd_rme96_ids) = { +static const struct pci_device_id snd_rme96_ids[] = { {PCI_VDEVICE (XILINX ,PCI_DEVICE_ID_RME_DIGI96 ),0 , }, {PCI_VDEVICE (XILINX ,PCI_DEVICE_ID_RME_DIGI96_8 ),0 , }, {PCI_VDEVICE (XILINX ,PCI_DEVICE_ID_RME_DIGI96_8_PRO ),0 , },
sound/pci/rme9652/hdsp.c +1 -1
@@ -603,7 +603,7 @@ static void snd_hammerfall_free_buffer(struct snd_dma_buffer *dmab, struct pci_d } -static DEFINE_PCI_DEVICE_TABLE (snd_hdsp_ids) = { +static const struct pci_device_id snd_hdsp_ids[] = { { .vendor =PCI_VENDOR_ID_XILINX , .device =PCI_DEVICE_ID_XILINX_HAMMERFALL_DSP ,
sound/pci/rme9652/hdspm.c +1 -1
@@ -1077,7 +1077,7 @@ struct hdspm { }; -static DEFINE_PCI_DEVICE_TABLE (snd_hdspm_ids) = { +static const struct pci_device_id snd_hdspm_ids[] = { { .vendor =PCI_VENDOR_ID_XILINX , .device =PCI_DEVICE_ID_XILINX_HAMMERFALL_DSP_MADI ,
sound/pci/rme9652/rme9652.c +1 -1
@@ -313,7 +313,7 @@ static void snd_hammerfall_free_buffer(struct snd_dma_buffer *dmab, struct pci_d } -static DEFINE_PCI_DEVICE_TABLE (snd_rme9652_ids) = { +static const struct pci_device_id snd_rme9652_ids[] = { { .vendor =0x10ee , .device =0x3fc4 ,
sound/pci/sis7019.c +1 -1
@@ -52,7 +52,7 @@ MODULE_PARM_DESC(enable, "Enable SiS7019 Audio Accelerator.");module_param (codecs, int,0444 );MODULE_PARM_DESC (codecs,"Set bit to indicate that codec number is expected to be present (default 1)" ); -static DEFINE_PCI_DEVICE_TABLE (snd_sis7019_ids) = { +static const struct pci_device_id snd_sis7019_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_SI ,0x7019 ) }, {0 , } };
sound/pci/sonicvibes.c +1 -1
@@ -242,7 +242,7 @@ struct sonicvibes {#endif }; -static DEFINE_PCI_DEVICE_TABLE (snd_sonic_ids) = { +static const struct pci_device_id snd_sonic_ids[] = { {PCI_VDEVICE (S3 ,0xca00 ),0 , }, {0 , } };
sound/pci/trident/trident.c +1 -1
@@ -62,7 +62,7 @@ MODULE_PARM_DESC(pcm_channels, "Number of hardware channels assigned for PCM.");module_param_array (wavetable_size, int,NULL ,0444 );MODULE_PARM_DESC (wavetable_size,"Maximum memory size in kB for wavetable synth." ); -static DEFINE_PCI_DEVICE_TABLE (snd_trident_ids) = { +static const struct pci_device_id snd_trident_ids[] = { {PCI_DEVICE (PCI_VENDOR_ID_TRIDENT ,PCI_DEVICE_ID_TRIDENT_4DWAVE_DX ),PCI_CLASS_MULTIMEDIA_AUDIO <<8 ,0xffff00 ,0 }, {PCI_DEVICE (PCI_VENDOR_ID_TRIDENT ,PCI_DEVICE_ID_TRIDENT_4DWAVE_NX ),
sound/pci/via82xx.c +1 -1
@@ -404,7 +404,7 @@ struct via82xx {#endif }; -static DEFINE_PCI_DEVICE_TABLE (snd_via82xx_ids) = { +static const struct pci_device_id snd_via82xx_ids[] = {/* 0x1106, 0x3058 */ {PCI_VDEVICE (VIA ,PCI_DEVICE_ID_VIA_82C686_5 ),TYPE_CARD_VIA686 , },/* 686A */ /* 0x1106, 0x3059 */
sound/pci/via82xx_modem.c +1 -1
@@ -260,7 +260,7 @@ struct via82xx_modem {struct snd_info_entry *proc_entry; }; -static DEFINE_PCI_DEVICE_TABLE (snd_via82xx_modem_ids) = { +static const struct pci_device_id snd_via82xx_modem_ids[] = { {PCI_VDEVICE (VIA ,0x3068 ),TYPE_CARD_VIA82XX_MODEM , }, {0 , } };
sound/pci/vx222/vx222.c +1 -1
@@ -60,7 +60,7 @@ enum {VX_PCI_VX222_NEW }; -static DEFINE_PCI_DEVICE_TABLE (snd_vx222_ids) = { +static const struct pci_device_id snd_vx222_ids[] = { {0x10b5 ,0x9050 ,0x1369 ,PCI_ANY_ID ,0 ,0 ,VX_PCI_VX222_OLD , },/* PLX */ {0x10b5 ,0x9030 ,0x1369 ,PCI_ANY_ID ,0 ,0 ,VX_PCI_VX222_NEW , },/* PLX */ {0 , }
sound/pci/ymfpci/ymfpci.c +1 -1
@@ -66,7 +66,7 @@ MODULE_PARM_DESC(joystick_port, "Joystick port address");module_param_array (rear_switch, bool,NULL ,0444 );MODULE_PARM_DESC (rear_switch,"Enable shared rear/line-in switch" ); -static DEFINE_PCI_DEVICE_TABLE (snd_ymfpci_ids) = { +static const struct pci_device_id snd_ymfpci_ids[] = { {PCI_VDEVICE (YAMAHA ,0x0004 ),0 , },/* YMF724 */ {PCI_VDEVICE (YAMAHA ,0x000d ),0 , },/* YMF724F */ {PCI_VDEVICE (YAMAHA ,0x000a ),0 , },/* YMF740 */
Signature · 1 line
1.7.10.4
PATCH 38/39 PCI: remove DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveDon't use DEFINE_PCI_DEVICE_TABLE macro, because this macro is not preferred. Also, the definition of DEFINE_PCI_DEVICE_TABLE macro is removed.
--- Documentation/PCI/pci.txt | 3 +-- drivers/pci/ioapic.c | 2 +- include/linux/pci.h | 10 ---------- 3 files changed, 2 insertions(+), 13 deletions(-)
Documentation/PCI/pci.txt +1 -2
@@ -123,8 +123,7 @@ initialization with a pointer to a structure describing the driver The ID table is an array of struct pci_device_id entries ending with an -all-zero entry; use of the macro DEFINE_PCI_DEVICE_TABLE is the preferred -method of declaring the table. Each entry consists of: +all-zero entry; Each entry consists of: vendor,device Vendor and device ID to match (or PCI_ANY_ID)
drivers/pci/ioapic.c +1 -1
@@ -99,7 +99,7 @@ static void ioapic_remove(struct pci_dev *dev) } -static DEFINE_PCI_DEVICE_TABLE (ioapic_devices) = { +static const struct pci_device_id ioapic_devices[] = { {PCI_DEVICE_CLASS (PCI_CLASS_SYSTEM_PIC_IOAPIC , ~0 ) }, {PCI_DEVICE_CLASS (PCI_CLASS_SYSTEM_PIC_IOXAPIC , ~0 ) }, { }
include/linux/pci.h +0 -10
@@ -631,16 +631,6 @@ struct pci_driver {#define to_pci_driver (drv) container_of(drv, struct pci_driver, driver)/** -* DEFINE_PCI_DEVICE_TABLE - macro used to describe a pci device table -* @_table: device table name -* -* This macro is used to create a struct pci_device_id array (a device table) -* in a generic manner. -*/ -#define DEFINE_PCI_DEVICE_TABLE (_table) \ - const struct pci_device_id _table[] - -/** * PCI_DEVICE - macro used to describe a specific pci device * @vend: the 16 bit PCI Vendor ID * @dev: the 16 bit PCI Device ID
Signature · 1 line
1.7.10.4
Joe Perches
maintainerRe: [PATCH 38/39] PCI: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 3 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred. Also, the definition ofDEFINE_PCI_DEVICE_TABLEmacro is removed.
These sorts of treewide conversions are almost never applied wholesale.
This patch is not appropriate until there are no more uses of DEFINE_PCI_DEVICE_TABLE in Linus' tree.
Just marking the function as deprecated in the
documentation and the pci.h file is probably good
enough for now.
Re: [PATCH 38/39] PCI: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 8 lines · Joe Perches
Quoted 3 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred. Also, the definition ofDEFINE_PCI_DEVICE_TABLEmacro is removed.These sorts of treewide conversions are almost never applied wholesale.
Quoted 8 lines
This patch is not appropriate until there are no more uses of
DEFINE_PCI_DEVICE_TABLEin Linus' tree.Just marking the function as deprecated in the
documentation and thepci.hfile is probably good
enough for now.
Actually, I want to remove all DEFINE_PCI_DEVICE_TABLEs from the next 3.14-rc1 kernel, by merging all patches through Greg's tree.
Greg,
How about you?
Best regards,
Jingoo Han
'Greg Kroah-Hartman'
maintainerRe: [PATCH 38/39] PCI: remove DEFINE_PCI_DEVICE_TABLE macro
Quoted 16 lines · Jingoo Han
Quoted 15 lines · Joe Perches
Quoted 3 lines · Jingoo Han
Don't use
DEFINE_PCI_DEVICE_TABLEmacro, because this macro is not preferred. Also, the definition ofDEFINE_PCI_DEVICE_TABLEmacro is removed.These sorts of treewide conversions are almost never applied wholesale.
This patch is not appropriate until there are no more uses of
DEFINE_PCI_DEVICE_TABLEin Linus' tree.Just marking the function as deprecated in the
documentation and thepci.hfile is probably good
enough for now.
Quoted 7 lines
Quoted 1 line
Actually, I want to remove all
DEFINE_PCI_DEVICE_TABLEsfrom the next 3.14-rc1 kernel, by merging all patches through Greg's tree.Greg,
How about you?
No, take them through their individual driver trees please.
thanks,
greg k-h
PATCH 39/39 checkpatch: remove check for DEFINE_PCI_DEVICE_TABLE macro
In reply to a message not in the archiveRemove check for DEFINE_PCI_DEVICE_TABLE macro, because DEFINE_PCI_DEVICE_TABLE macro is not used anymore.
--- scripts/checkpatch.pl | 6 ------ 1 file changed, 6 deletions(-)
scripts/checkpatch.pl +0 -6
@@ -2634,12 +2634,6 @@ sub process { $herecurr); } -# check for declarations of struct pci_device_id - if ($line =~ /\bstruct\s+pci_device_id\s+\w+\s*\[\s*\]\s*\=\s*\{/) { - WARN("DEFINE_PCI_DEVICE_TABLE", - "Use DEFINE_PCI_DEVICE_TABLE for struct pci_device_id\n" . $herecurr); - } - # check for new typedefs, only function parameters and sparse annotations # make sense. if ($line =~ /\btypedef\s/ &&
Signature · 1 line
1.7.10.4