hpsa: increase the probability of a reported success after a device reset

PATCH New Tomas Henzl 1 participant 1 message Dec 3, 2013

Subsystems (2)

SCSI Hewlett-packard smart array RAID driver (hpsa)

lore

Share & tools

lore

Tomas Henzl

author

2013-12-03 16:46 UTC #0 lore raw

PATCH 1/1 hpsa: increase the probability of a reported success after a device reset

rc is set in the loop, and it isn't set back to zero anywhere this patch fixes it

Signed-off-by Tomas Henzl <[email protected]>

---
 drivers/scsi/hpsa.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

drivers/scsi/hpsa.c +2 -1

index fb5a898..e46b609 100644
@@ -2379,7 +2379,7 @@ static int hpsa_register_scsi(struct ctlr_info *h)
 static int wait_for_device_to_become_ready(struct ctlr_info *h,
 	unsigned char lunaddr[])
 {
-	int rc = 0;
+	int rc;
 	int count = 0;
 	int waittime = 1; /* seconds */
 	struct CommandList *c;

@@ -2399,6 +2399,7 @@ static int wait_for_device_to_become_ready(struct ctlr_info *h,
 		 */
 		msleep(1000 * waittime);
 		count++;
+		rc = 0; /* device ready. */
 
 		/* Increase wait time with each try, up to a point. */
 		if (waittime < HPSA_MAX_WAIT_INTERVAL_SECS)

Signature · 1 line

1.8.3.1