mx6sabresd: Allow probing HYNC, VSYNC and DISP_CLK signals
PATCH 1/2 mx6sabresd: Allow probing HYNC, VSYNC and DISP_CLK signals
HSYNC, VSYNC and DISP_CLK are very useful display signals for debugging.
Configure them as active pins.
--- board/freescale/mx6sabresd/mx6sabresd.c | 8 ++++++++ 1 file changed, 8 insertions(+)
board/freescale/mx6sabresd/mx6sabresd.c +8 -0
@@ -120,6 +120,12 @@ iomux_v3_cfg_t const usdhc4_pads[] = { MX6_PAD_SD4_DAT7__SD4_DATA7 | MUX_PAD_CTRL(USDHC_PAD_CTRL), }; +iomux_v3_cfg_t const di0_pads[] = { +MX6_PAD_DI0_DISP_CLK__IPU1_DI0_DISP_CLK ,/* DISP0_CLK */ +MX6_PAD_DI0_PIN2__IPU1_DI0_PIN02 ,/* DISP0_HSYNC */ +MX6_PAD_DI0_PIN3__IPU1_DI0_PIN03 ,/* DISP0_VSYNC */ +}; +static void setup_iomux_uart (void ) {imx_iomux_v3_setup_multiple_pads (uart1_pads,ARRAY_SIZE (uart1_pads));
@@ -371,6 +377,8 @@ static void setup_display(void)struct iomuxc *iomux = (struct iomuxc *)IOMUXC_BASE_ADDR ;int reg; +imx_iomux_v3_setup_multiple_pads (di0_pads,ARRAY_SIZE (di0_pads)); +enable_ipu_clock ();imx_setup_hdmi ();
Signature · 1 line
1.8.1.2
PATCH 2/2 mx6sabresd: Fix LVDS width and color format
mx6sabresd boards have a 18-bit LVDS data width and the correct color format is RGB666.
--- board/freescale/mx6sabresd/mx6sabresd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
board/freescale/mx6sabresd/mx6sabresd.c +3 -3
@@ -279,15 +279,15 @@ static void enable_lvds(struct display_info_t const *dev)struct iomuxc *iomux = (struct iomuxc *)IOMUXC_BASE_ADDR ;u32 reg =readl (&iomux->gpr[2 ]); - reg |=IOMUXC_GPR2_DATA_WIDTH_CH0_24BIT | -IOMUXC_GPR2_DATA_WIDTH_CH1_24BIT ; + reg |=IOMUXC_GPR2_DATA_WIDTH_CH0_18BIT | +IOMUXC_GPR2_DATA_WIDTH_CH1_18BIT ;writel (reg, &iomux->gpr[2 ]); }static struct display_info_t const displays[] = {{ .bus =-1 , .addr =0 , - .pixfmt =IPU_PIX_FMT_LVDS666 , + .pixfmt =IPU_PIX_FMT_RGB666 , .detect =NULL , .enable = enable_lvds, .mode = {
Signature · 1 line
1.8.1.2
PATCH 1/2 mx6sabresd: Allow probing HYNC, VSYNC and DISP_CLK signals
In reply to Fabio EstevamQuoted 5 lines · Fabio Estevam
HSYNC, VSYNC and
DISP_CLKare very useful display signals for debugging.Configure them as active pins.
Signed-off-by Fabio Estevam <[email protected]>
...
Quoted 1 line
+
imx_iomux_v3_setup_multiple_pads(di0_pads, ARRAY_SIZE(di0_pads));
A single line comment here making it clear it is here for convenience would be good.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
PATCH 1/2 mx6sabresd: Allow probing HYNC, VSYNC and DISP_CLK signals
In reply to Fabio EstevamQuoted 9 lines · Fabio Estevam
HSYNC, VSYNC and
DISP_CLKare very useful display signals for debugging.Configure them as active pins.
Signed-off-by Fabio Estevam <[email protected]>--- board/freescale/mx6sabresd/mx6sabresd.c | 8 ++++++++ 1 file changed, 8 insertions(+)
Please fix the typo 'HYNC' in the commit head. It should be 'HSYNC'.
Regard,
Liu Ying