Skip to contentSkip to conversation

PowerPC: mpc83xx: Do not use absolute paths for obj-y

PATCH New Masahiro Yamada 2 participants 3 messages Dec 3, 2013 – Dec 4, 2013 PowerPC

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 PowerPC: mpc83xx: Do not use absolute paths for obj-y

---

Please make sure relative paths always should be used when $(obj-y) points to objects under a different directory.

The absolute path like follows:
obj-$(CONFIG_MPC8349) += $(SRCTREE)/drivers/ddr/fsl/mpc85xx_ddr_gen2.o
creates an object file under a strange path for out-of-tree build.

  $ rm -rf build/
  $ make O=build MPC8349EMDS_config
  Configuring for MPC8349EMDS board...
  $ make O=build CROSS_COMPILE=powerpc-linux-
  <<snip>>
  $ find . -name mpc85xx_ddr_gen2.o
  ./build/arch/powerpc/cpu/mpc83xx/home/yamada/workspace/u-boot/drivers/ddr/fsl/mpc85xx_ddr_gen2.o
 arch/powerpc/cpu/mpc83xx/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/cpu/mpc83xx/Makefile +1 -1
index c345dd6..d184c04 100644
@@ -39,7 +39,7 @@ obj-$(CONFIG_OF_LIBFDT) += fdt.o
 obj-y += cache.o
 
 ifdef CONFIG_SYS_FSL_DDR2
-obj-$(CONFIG_MPC8349) += $(SRCTREE)/drivers/ddr/fsl/mpc85xx_ddr_gen2.o
+obj-$(CONFIG_MPC8349) += ../../../../drivers/ddr/fsl/mpc85xx_ddr_gen2.o
 else
 obj-y += spd_sdram.o
 endif
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 PowerPC: mpc83xx: Do not use absolute paths for obj-y

Hi.

Quoted 10 lines

---

Please make sure relative paths always should be used when $(obj-y) points to objects under a different directory.

The absolute path like follows:
obj-$(CONFIG_MPC8349) += $(SRCTREE)/drivers/ddr/fsl/mpc85xx_ddr_gen2.o
creates an object file under a strange path for out-of-tree build.

Quoted 7 lines
  $ rm -rf build/
  $ make O=build MPC8349EMDS_config
  Configuring for MPC8349EMDS board...
  $ make O=build CROSS_COMPILE=powerpc-linux-
  <<snip>>
  $ find . -name mpc85xx_ddr_gen2.o
  ./build/arch/powerpc/cpu/mpc83xx/home/yamada/workspace/u-boot/drivers/ddr/fsl/mpc85xx_ddr_gen2.o

Please change the status of this patch to Superseded or Rejected.

This patch was replaced with York Sun's patch:
http://patchwork.ozlabs.org/patch/296307/

Best Regards
Masahiro Yamada

#2 lore raw

PATCH 1/1 PowerPC: mpc83xx: Do not use absolute paths for obj-y

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Quoted 21 lines · Masahiro Yamada

Hi.

Quoted 10 lines

---

Please make sure relative paths always should be used when $(obj-y) points to objects under a different directory.

The absolute path like follows:
obj-$(CONFIG_MPC8349) += $(SRCTREE)/drivers/ddr/fsl/mpc85xx_ddr_gen2.o
creates an object file under a strange path for out-of-tree build.

Quoted 7 lines
  $ rm -rf build/
  $ make O=build MPC8349EMDS_config
  Configuring for MPC8349EMDS board...
  $ make O=build CROSS_COMPILE=powerpc-linux-
  <<snip>>
  $ find . -name mpc85xx_ddr_gen2.o
  ./build/arch/powerpc/cpu/mpc83xx/home/yamada/workspace/u-boot/drivers/ddr/fsl/mpc85xx_ddr_gen2.o
Quoted 4 lines

Please change the status of this patch to Superseded or Rejected.

This patch was replaced with York Sun's patch:
http://patchwork.ozlabs.org/patch/296307/

Done, thanks.

- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSnyX5AAoJENk4IS6UOR1WSygP/3cw1pWU25rcIr3SnjHr2UEA FTX213Gw+FJSl3IZUnylvL6zFmOOxn7D6Shf8/Nz7LbO2rZs/6jg5Ev/0XSvR/p3 SZmFsH/8ymEgjsiE5V0wMtexdWM0qXVbs9XKhM9VIEBeYnxS30f+u8ppw2Pq9qPF 6dhOaYDytVPbxb1cWWdroEFyJgu4lcwN/Rwbi+cgKX0m2m5nMOhdUUr/QvQYrOjy PSv+pfv3GauEBus66SS3NZWzqpt48njtetfy5LeDNkCi1TwcAuKq1EPGP5Qy8qxZ sEJR65iJfza3RjIahEYdhAd8mqtapm1zZ3ZAk8R0vca+/sW1eeA1xLYruJ4TPF5u 0bbW9DkVuhgwWwzRj1cQrV1MqdHU0562ysRST6iMUh5NqyawZ+PgQ2jW55Ti54gf Nh+og5YRRSlDZtqqeF9QxjJgua8ziH8Daes3WkvNUaWgoU90Y4yZTKri+1q1UHCF PH8wZbW4CEgXdrGW6o0W7DVE3PgoOalJzWxL8mbh40Mm2eQIG4XvS73IBkxnClGn Hv/rPJNpKk1TSvEAZdk/g0aT2BzP3ISyXAJs4OiQrvbAc7D0MPRQ+936OSZsjwZ1 E124RMYebi8tUxHvIZ41IvxdgvjKIbmKqq3be8U1RQZSm3qyOwMKrhCNSxITYFoG oDNlHCA2hN+lKdjCa4/+
=BuiJ
-----END PGP SIGNATURE-----