Skip to contentSkip to conversation

flac: update to version 1.3.0

PATCH New Sven Neumann 2 participants 4 messages Dec 3, 2013 – Dec 4, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 flac: update to version 1.3.0

Remove flac-no-altivec.patch as it appears to have been merged upstream.

---
 package/flac/flac-no-altivec.patch | 28 ----------------------------
 package/flac/flac.mk               |  5 +++--
 2 files changed, 3 insertions(+), 30 deletions(-)
 delete mode 100644 package/flac/flac-no-altivec.patch
package/flac/flac-no-altivec.patch deleted +0 -28
deleted file mode 100644
index c6a535b..0000000
@@ -1,28 +0,0 @@
-FLAC assumes every powerpc around has altivec ABI which is wrong.
-
-Signed-off-by: Gustavo Zacarias <[email protected]>
-
-diff -Nura flac-1.2.1/src/libFLAC/Makefile.am flac-1.2.1-noaltivec/src/libFLAC/Makefile.am
---- flac-1.2.1/src/libFLAC/Makefile.am	2007-09-14 18:06:17.000000000 -0300
-+++ flac-1.2.1-noaltivec/src/libFLAC/Makefile.am	2011-01-06 15:14:36.384242614 -0300
-@@ -41,7 +41,7 @@
- else
- # Linux-gcc for PPC does not have -force_cpusubtype_ALL, it is Darwin-specific
- #@@@ PPC optimizations temporarily disabled
--CPUCFLAGS = -maltivec -mabi=altivec -DFLAC__NO_ASM
-+CPUCFLAGS = -DFLAC__NO_ASM
- endif
- endif
- 
-diff -Nura flac-1.2.1/src/libFLAC/Makefile.in flac-1.2.1-noaltivec/src/libFLAC/Makefile.in
---- flac-1.2.1/src/libFLAC/Makefile.in	2007-09-16 17:05:12.000000000 -0300
-+++ flac-1.2.1-noaltivec/src/libFLAC/Makefile.in	2011-01-06 15:14:50.997545602 -0300
-@@ -240,7 +240,7 @@
- @FLaC__CPU_PPC_TRUE@@FLaC__SYS_DARWIN_TRUE at CPUCFLAGS = -faltivec -force_cpusubtype_ALL -DFLAC__NO_ASM
- # Linux-gcc for PPC does not have -force_cpusubtype_ALL, it is Darwin-specific
- #@@@ PPC optimizations temporarily disabled
-- at FLaC__CPU_PPC_TRUE@@FLaC__SYS_DARWIN_FALSE at CPUCFLAGS = -maltivec -mabi=altivec -DFLAC__NO_ASM
-+ at FLaC__CPU_PPC_TRUE@@FLaC__SYS_DARWIN_FALSE at CPUCFLAGS = -DFLAC__NO_ASM
- 
- AM_CFLAGS = $(DEBUGCFLAGS) $(CPUCFLAGS) @OGG_CFLAGS@
- @FLaC__CPU_PPC_TRUE@@FLaC__NO_ASM_FALSE at ARCH_SUBDIRS = ppc
package/flac/flac.mk +3 -2
index 95cd5a1..177e1ce 100644
@@ -4,8 +4,9 @@
 #
 ################################################################################
 
-FLAC_VERSION = 1.2.1
-FLAC_SITE = http://downloads.sourceforge.net/project/flac/flac-src/flac-$(FLAC_VERSION)-src
+FLAC_VERSION = 1.3.0
+FLAC_SITE = http://downloads.xiph.org/releases/flac/
+FLAC_SOURCE = flac-$(FLAC_VERSION).tar.xz
 FLAC_INSTALL_STAGING = YES
 
 FLAC_CONF_OPT = \
Signature · 1 line
1.8.4.2
#1 lore raw

PATCH 1/1 flac: update to version 1.3.0

Quoted 4 lines · Sven Neumann

Remove flac-no-altivec.patch as it appears to have been merged upstream.

Hold off this one a bit, IIRC it failed miserably to run on MIPS and/or PPC. Let me retry and see before comitting it.
Regards.

#2 lore raw

PATCH 1/1 flac: update to version 1.3.0

Hi,

Quoted 10 lines · Gustavo Zacarias
Quoted 4 lines · Sven Neumann

Remove flac-no-altivec.patch as it appears to have been merged upstream.

Hold off this one a bit, IIRC it failed miserably to run on MIPS and/or PPC. Let me retry and see before comitting it.
Regards.

Fine with me. I have only tested builds on two ARM platforms (XScale and Cortex-A8).

Regards,
Sven

Signature · 14 lines
Sven Neumann
Senior System Architect

Lautsprecher Teufel GmbH
Gewerbehof B?lowbogen - Aufgang D1
B?lowstr. 66 - 10783 Berlin - Germany

Registernummer HRB 20271 beim Amtsgericht Berlin-Charlottenburg
Gesch?ftsf?hrer: Edgar van Velzen

Tel. +49 (0)30 - 300 930 - 0, Direkt -153
neumann at teufel.de  

www.teufel.de  www.teufelaudio.com  http://blog.teufel.de
#3 lore raw

PATCH 1/1 flac: update to version 1.3.0

Quoted 7 lines · Sven Neumann
Quoted 3 lines · Gustavo Zacarias

Hold off this one a bit, IIRC it failed miserably to run on MIPS and/or PPC. Let me retry and see before comitting it.
Regards.

Fine with me. I have only tested builds on two ARM platforms (XScale and Cortex-A8).

On qemu-mips-malta i get a floating point exception when encoding a simple wav file (might be qemu at fault).
For powerpc altivec is still leaking inside leading to build failures (or probably bad code) since it seems there are no powerpc processors without altivec? 8-O
I'll concoct a patch for the altivec failure and test it, though i'd need someone to test mips on real hardware.
Regards.