SMDK5420: Add S2MPS11 pmic support to SMDK5420
v3 cover SMDK5420: Add S2MPS11 pmic support to SMDK5420
This patchset adds support for S2MPS11 pmic on SMDK5420
This patchset has dependency on Rajeshwari's base patchset:
[PATCH 00/10 V6] EXYNOS5420: Add SMDK5420 board support
http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/172653
Also, for testing we need Naveen's i2c patchset as well:
i2c: improve s3c24x0 with High-speed and new SYS_I2C framework support
http://www.mail-archive.com/u-boot at lists.denx.de/msg122679.html
Changes since V2:
- Rebased on V6 version patchset sent by Rajeshwari http://comments.gmane.org/gmane.comp.boot-loaders.u-boot/172653
Changes since V1:
- In patch "exynos: Use common pmic_reg_update() definition" moved pmic_reg_update() from drivers/power/power_i2c.c to power_core.c suggested by Lukasz Majewski <[email protected]>
- Changed the License details to GPL 2.0+ license for below pathces
SMDK5420: S2MPS11: Adds the register settings for S2MPS11
exynos: Add a common DT based PMIC driver initialization
- corrected the typo error in "config: SMDK5420: Enable S2MPS11 pmic" patch header
Leela Krishna Amudala (6):
exynos: Use common pmic_reg_update() definition
power: Explicitly select pmic device's bus
FDT: Exynos5420: Add compatible srings for PMIC
SMDK5420: S2MPS11: Adds the register settings for S2MPS11
exynos: Add a common DT based PMIC driver initialization
config: SMDK5420: Enable S2MPS11 pmic
board/samsung/common/board.c | 39 ++++++----- drivers/power/pmic/Makefile | 1 + drivers/power/pmic/pmic_common.c | 97 ++++++++++++++++++++++++++ drivers/power/power_core.c | 33 +++++++++ drivers/power/power_i2c.c | 62 +++++++++++++++-- include/configs/smdk5420.h | 4 ++ include/fdtdec.h | 1 + include/power/pmic.h | 35 ++++++++++ include/power/s2mps11_pmic.h | 141 ++++++++++++++++++++++++++++++++++++++ lib/fdtdec.c | 1 + 10 files changed, 391 insertions(+), 23 deletions(-) create mode 100644 drivers/power/pmic/pmic_common.c create mode 100644 include/power/s2mps11_pmic.h
Signature · 1 line
1.7.10.4
PATCH v3 1/6 exynos: Use common pmic_reg_update() definition
This function is used by different Exynos platforms, put it in the common file.
--- board/samsung/common/board.c | 19 ------------------- drivers/power/power_core.c | 19 +++++++++++++++++++ include/power/pmic.h | 1 + 3 files changed, 20 insertions(+), 19 deletions(-)
board/samsung/common/board.c +0 -19
@@ -156,25 +156,6 @@ static int board_init_cros_ec_devices(const void *blob) #if defined(CONFIG_POWER) #ifdef CONFIG_POWER_MAX77686 -static int pmic_reg_update(struct pmic *p, int reg, uint regval) -{ - u32 val; - int ret = 0; - - ret = pmic_reg_read(p, reg, &val); - if (ret) { - debug("%s: PMIC %d register read failed\n", __func__, reg); - return -1; - } - val |= regval; - ret = pmic_reg_write(p, reg, val); - if (ret) { - debug("%s: PMIC %d register write failed\n", __func__, reg); - return -1; - } - return 0; -} - static int max77686_init(void) { struct pmic *p;
drivers/power/power_core.c +19 -0
@@ -208,6 +208,25 @@ int do_pmic(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])return CMD_RET_SUCCESS ; } +int pmic_reg_update (struct pmic *p,int reg,uint regval) +{ +u32 val; +int ret =0 ; + + ret =pmic_reg_read (p, reg, &val); +if (ret) { +debug ("%s: PMIC %d register read failed\n" , __func__, reg); +return -1 ; + } + val |= regval; + ret =pmic_reg_write (p, reg, val); +if (ret) { +debug ("%s: PMIC %d register write failed\n" , __func__, reg); +return -1 ; + } +return 0 ; +} + U_BOOT_CMD( pmic, CONFIG_SYS_MAXARGS, 1, do_pmic, "PMIC",
include/power/pmic.h +1 -0
@@ -83,6 +83,7 @@ int pmic_probe(struct pmic *p);int pmic_reg_read (struct pmic *p,u32 reg,u32 *val);int pmic_reg_write (struct pmic *p,u32 reg,u32 val);int pmic_set_output (struct pmic *p,u32 reg,int ldo,int on); +int pmic_reg_update (struct pmic *p,int reg,uint regval);#define pmic_i2c_addr (p->hw.i2c.addr)#define pmic_i2c_tx_num (p->hw.i2c.tx_num)
Signature · 1 line
1.7.10.4
PATCH v3 1/6 exynos: Use common pmic_reg_update() definition
Dear Leela Krishna Amudala,
Quoted 49 lines · Leela Krishna Amudala
This function is used by different Exynos platforms, put it in the common file.
Signed-off-by Vadim Bendebury <[email protected]>Signed-off-by Leela Krishna Amudala <[email protected]>Reviewed-by Doug Anderson <[email protected]>Reviewed-by Lukasz Majewski <[email protected]>Acked-by Simon Glass <[email protected]>--- board/samsung/common/board.c | 19 ------------------- drivers/power/power_core.c | 19 +++++++++++++++++++ include/power/pmic.h | 1 + 3 files changed, 20 insertions(+), 19 deletions(-)board/samsung/common/board.c +0
-19@@ -156,25 +156,6 @@ static int board_init_cros_ec_devices(const void *blob) #if defined(CONFIG_POWER) #ifdef CONFIG_POWER_MAX77686 -static int pmic_reg_update(struct pmic *p, int reg, uint regval) -{ - u32 val; - int ret = 0; - - ret = pmic_reg_read(p, reg, &val); - if (ret) { - debug("%s: PMIC %d register read failed\n", __func__, reg); - return -1; - } - val |= regval; - ret = pmic_reg_write(p, reg, val); - if (ret) { - debug("%s: PMIC %d register write failed\n", __func__, reg); - return -1; - } - return 0; -} - static int max77686_init(void) { struct pmic *p;drivers/power/power_core.c +0
-0
drivers/power/power_core.c int do_pmic(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) · line 214
Quoted 7 lines
drivers/power/power_core.c +4
-0@@ -208,6 +208,25 @@ int do_pmic(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])return CMD_RET_SUCCESS ; } +int pmic_reg_update (struct pmic *p,int reg,uint regval) +{ +u32 val; +int ret =0 ;
= 0 is unnecessary.
drivers/power/power_core.c int do_pmic(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) · line 220
Quoted 6 lines
drivers/power/power_core.c +6
-0+ + ret =pmic_reg_read (p, reg, &val); +if (ret) { +debug ("%s: PMIC %d register read failed\n" , __func__, reg); +return -1 ; + }
please add blank line.
Quoted 17 lines
drivers/power/power_core.c +9
-0+ val |= regval; + ret =pmic_reg_write (p, reg, val); +if (ret) { +debug ("%s: PMIC %d register write failed\n" , __func__, reg); +return -1 ; + } +return 0 ; +} + U_BOOT_CMD( pmic, CONFIG_SYS_MAXARGS, 1, do_pmic, "PMIC",include/power/pmic.h +0
-0
include/power/pmic.h int pmic_probe(struct pmic *p); · line 86
Quoted 4 lines
include/power/pmic.h +1
-0@@ -83,6 +83,7 @@ int pmic_probe(struct pmic *p);int pmic_reg_read (struct pmic *p,u32 reg,u32 *val);int pmic_reg_write (struct pmic *p,u32 reg,u32 val);int pmic_set_output (struct pmic *p,u32 reg,int ldo,int on); +int pmic_reg_update (struct pmic *p,int reg,uint regval);
uint regval -> u32 val, for keep naming convention with other functions.
include/power/pmic.h int pmic_probe(struct pmic *p);
Quoted 4 lines
include/power/pmic.h +0
-0#define pmic_i2c_addr (p->hw.i2c.addr)#define pmic_i2c_tx_num (p->hw.i2c.tx_num)
Thanks,
Minkyu Kang.
PATCH v3 1/6 exynos: Use common pmic_reg_update() definition
Hi Minkyu Kang,
Sorry for late response.
Please find my comments below.
Quoted 55 lines · Minkyu Kang
Dear Leela Krishna Amudala,
Quoted 52 lines · Leela Krishna Amudala
This function is used by different Exynos platforms, put it in the common file.
Signed-off-by Vadim Bendebury <[email protected]>Signed-off-by Leela Krishna Amudala <[email protected]>Reviewed-by Doug Anderson <[email protected]>Reviewed-by Lukasz Majewski <[email protected]>Acked-by Simon Glass <[email protected]>--- board/samsung/common/board.c | 19 ------------------- drivers/power/power_core.c | 19 +++++++++++++++++++ include/power/pmic.h | 1 + 3 files changed, 20 insertions(+), 19 deletions(-)board/samsung/common/board.c +0
-19@@ -156,25 +156,6 @@ static int board_init_cros_ec_devices(const void *blob) #if defined(CONFIG_POWER) #ifdef CONFIG_POWER_MAX77686 -static int pmic_reg_update(struct pmic *p, int reg, uint regval) -{ - u32 val; - int ret = 0; - - ret = pmic_reg_read(p, reg, &val); - if (ret) { - debug("%s: PMIC %d register read failed\n", __func__, reg); - return -1; - } - val |= regval; - ret = pmic_reg_write(p, reg, val); - if (ret) { - debug("%s: PMIC %d register write failed\n", __func__, reg); - return -1; - } - return 0; -} - static int max77686_init(void) { struct pmic *p;drivers/power/power_core.c +0
-0@@ -208,6 +208,25 @@ int do_pmic(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])return CMD_RET_SUCCESS ; }
Quoted 7 lines
drivers/power/power_core.c int do_pmic(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) · line 214
Quoted 4 lines
drivers/power/power_core.c +4
-0+int pmic_reg_update (struct pmic *p,int reg,uint regval) +{ +u32 val; +int ret =0 ;= 0 is unnecessary.
Okay, will remove it.
Quoted 9 lines
drivers/power/power_core.c int do_pmic(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) · line 220
Quoted 6 lines
drivers/power/power_core.c +6
-0+ + ret =pmic_reg_read (p, reg, &val); +if (ret) { +debug ("%s: PMIC %d register read failed\n" , __func__, reg); +return -1 ; + }please add blank line.
Okay, will add it.
Quoted 15 lines
Quoted 15 lines
drivers/power/power_core.c +9
-0+ val |= regval; + ret =pmic_reg_write (p, reg, val); +if (ret) { +debug ("%s: PMIC %d register write failed\n" , __func__, reg); +return -1 ; + } +return 0 ; +} + U_BOOT_CMD( pmic, CONFIG_SYS_MAXARGS, 1, do_pmic, "PMIC",include/power/pmic.h +0
-1--- a/include/power/pmic.h
Quoted 9 lines
include/power/pmic.h int pmic_probe(struct pmic *p); · line 86
Quoted 6 lines
+++
b/include/power/pmic.hinclude/power/pmic.h +1
-0@@ -83,6 +83,7 @@ int pmic_probe(struct pmic *p);int pmic_reg_read (struct pmic *p,u32 reg,u32 *val);int pmic_reg_write (struct pmic *p,u32 reg,u32 val);int pmic_set_output (struct pmic *p,u32 reg,int ldo,int on); +int pmic_reg_update (struct pmic *p,int reg,uint regval);uint regval -> u32 val, for keep naming convention with other functions.
Okay, will change it.
Best Wishes,
Leela Krishna.
Quoted 11 lines
include/power/pmic.h int pmic_probe(struct pmic *p);
Quoted 4 lines
include/power/pmic.h +0
-0#define pmic_i2c_addr (p->hw.i2c.addr)#define pmic_i2c_tx_num (p->hw.i2c.tx_num)Thanks,
Minkyu Kang.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
PATCH v3 2/6 power: Explicitly select pmic device's bus
In reply to Leela Krishna AmudalaThe current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There is nothing ensuring that to be true. Therefore, select the proper bus before performing a transaction.
--- drivers/power/power_i2c.c | 62 +++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 57 insertions(+), 5 deletions(-)
drivers/power/power_i2c.c +57 -5
@@ -16,9 +16,45 @@#include <i2c.h> #include <compiler.h> +static int pmic_select (struct pmic *p) +{ +int ret, old_bus; + + old_bus =i2c_get_bus_num (); +if (old_bus != p->bus) { +debug ("%s: Select bus %d\n" , __func__, p->bus); + ret =i2c_set_bus_num (p->bus); +if (ret) { +debug ("%s: Cannot select pmic %s, err %d\n" , + __func__, p->name, ret); +return -1 ; + } + } + +return old_bus; +} + +static int pmic_deselect (int old_bus) +{ +int ret; + +if (old_bus !=i2c_get_bus_num ()) { + ret =i2c_set_bus_num (old_bus); +debug ("%s: Select bus %d\n" , __func__, old_bus); +if (ret) { +debug ("%s: Cannot restore i2c bus, err %d\n" , + __func__, ret); +return -1 ; + } + } + +return 0 ; +} +int pmic_reg_write (struct pmic *p,u32 reg,u32 val) {unsigned char buf[4 ] = {0 }; +int ret, old_bus;if (check_reg (p, reg))return -1 ;
@@ -52,23 +88,33 @@ int pmic_reg_write(struct pmic *p, u32 reg, u32 val)return -1 ; } -if (i2c_write (pmic_i2c_addr, reg,1 , buf, pmic_i2c_tx_num)) + old_bus =pmic_select (p); +if (old_bus <0 )return -1 ; -return 0 ; + ret =i2c_write (pmic_i2c_addr, reg,1 , buf, pmic_i2c_tx_num); +pmic_deselect (old_bus); +return ret; }int pmic_reg_read (struct pmic *p,u32 reg,u32 *val) {unsigned char buf[4 ] = {0 };u32 ret_val =0 ; +int ret, old_bus;if (check_reg (p, reg))return -1 ; -if (i2c_read (pmic_i2c_addr, reg,1 , buf, pmic_i2c_tx_num)) + old_bus =pmic_select (p); +if (old_bus <0 )return -1 ; + ret =i2c_read (pmic_i2c_addr, reg,1 , buf, pmic_i2c_tx_num); +pmic_deselect (old_bus); +if (ret) +return ret; +switch (pmic_i2c_tx_num) {case 3 :if (p->sensor_byte_order ==PMIC_SENSOR_BYTE_ORDER_BIG )
@@ -98,9 +144,15 @@ int pmic_reg_read(struct pmic *p, u32 reg, u32 *val)int pmic_probe (struct pmic *p) { -i2c_set_bus_num (p->bus); +int ret, old_bus; + + old_bus =pmic_select (p); +if (old_bus <0 ) +return -1 ;debug ("Bus: %d PMIC:%s probed!\n" , p->bus, p->name); -if (i2c_probe (pmic_i2c_addr)) { + ret =i2c_probe (pmic_i2c_addr); +pmic_deselect (old_bus); +if (ret) {printf ("Can't find PMIC:%s\n" , p->name);return -1 ; }
Signature · 1 line
1.7.10.4
PATCH v3 2/6 power: Explicitly select pmic device's bus
Dear Leela Krishna Amudala,
Quoted 19 lines · Leela Krishna Amudala
The current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There is nothing ensuring that to be true. Therefore, select the proper bus before performing a transaction.
Signed-off-by Aaron Durbin <[email protected]>Signed-off-by Simon Glass <[email protected]>Signed-off-by Leela Krishna Amudala <[email protected]>Reviewed-by Doug Anderson <[email protected]>Acked-by Simon Glass <[email protected]>--- drivers/power/power_i2c.c | 62 +++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 57 insertions(+), 5 deletions(-)drivers/power/power_i2c.c +0
-0
drivers/power/power_i2c.c line 21
Quoted 6 lines
drivers/power/power_i2c.c +3
-0@@ -16,9 +16,45 @@#include <i2c.h> #include <compiler.h> +static int pmic_select (struct pmic *p) +{ +int ret, old_bus;
I think, old prefix is meaningless.
please fix it globally.
drivers/power/power_i2c.c line 24
Quoted 3 lines
drivers/power/power_i2c.c +3
-0+ + old_bus =i2c_get_bus_num (); +if (old_bus != p->bus) {
How about return immediately if get a bus.
if (old_bus == p->bus)
return old_bus;
drivers/power/power_i2c.c line 37
Quoted 13 lines
drivers/power/power_i2c.c +13
-0+debug ("%s: Select bus %d\n" , __func__, p->bus); + ret =i2c_set_bus_num (p->bus); +if (ret) { +debug ("%s: Cannot select pmic %s, err %d\n" , + __func__, p->name, ret); +return -1 ; + } + } + +return old_bus; +} + +static int pmic_deselect (int old_bus)
in your patch, you never check a return value.
then is it void function or wrong usage?
And I think pmic_deselect function is almost same with pmic_select. If you change the parameter for pmic_select to "int bus" then, What is different with pmic_select?
for example.
bus = pmic_select(p->bus);
/* do something */pmic_deselect(bus);
is same with.
bus = pmic_select(p->bus);
/* do something */pmic_select(bus);
How do you think?
Quoted 25 lines
drivers/power/power_i2c.c +17
-0+{ +int ret; + +if (old_bus !=i2c_get_bus_num ()) { + ret =i2c_set_bus_num (old_bus); +debug ("%s: Select bus %d\n" , __func__, old_bus); +if (ret) { +debug ("%s: Cannot restore i2c bus, err %d\n" , + __func__, ret); +return -1 ; + } + } + +return 0 ; +} +int pmic_reg_write (struct pmic *p,u32 reg,u32 val) {unsigned char buf[4 ] = {0 }; +int ret, old_bus;if (check_reg (p, reg))return -1 ;@@ -52,23 +88,33 @@ int pmic_reg_write(struct pmic *p, u32 reg, u32 val)return -1 ;
drivers/power/power_i2c.c int pmic_reg_write(struct pmic *p, u32 reg, u32 val) · line 96
Quoted 10 lines
drivers/power/power_i2c.c +4
-2} -if (i2c_write (pmic_i2c_addr, reg,1 , buf, pmic_i2c_tx_num)) + old_bus =pmic_select (p); +if (old_bus <0 )return -1 ; -return 0 ; + ret =i2c_write (pmic_i2c_addr, reg,1 , buf, pmic_i2c_tx_num); +pmic_deselect (old_bus);
please add blank line.
Quoted 26 lines
drivers/power/power_i2c.c +9
-1+return ret; }int pmic_reg_read (struct pmic *p,u32 reg,u32 *val) {unsigned char buf[4 ] = {0 };u32 ret_val =0 ; +int ret, old_bus;if (check_reg (p, reg))return -1 ; -if (i2c_read (pmic_i2c_addr, reg,1 , buf, pmic_i2c_tx_num)) + old_bus =pmic_select (p); +if (old_bus <0 )return -1 ; + ret =i2c_read (pmic_i2c_addr, reg,1 , buf, pmic_i2c_tx_num); +pmic_deselect (old_bus); +if (ret) +return ret; +switch (pmic_i2c_tx_num) {case 3 :if (p->sensor_byte_order ==PMIC_SENSOR_BYTE_ORDER_BIG )
drivers/power/power_i2c.c int pmic_reg_read(struct pmic *p, u32 reg, u32 *val) · line 151
Quoted 9 lines
drivers/power/power_i2c.c +5
-1@@ -98,9 +144,15 @@ int pmic_reg_read(struct pmic *p, u32 reg, u32 *val)int pmic_probe (struct pmic *p) { -i2c_set_bus_num (p->bus); +int ret, old_bus; + + old_bus =pmic_select (p); +if (old_bus <0 ) +return -1 ;
please add blank line.
drivers/power/power_i2c.c int pmic_reg_read(struct pmic *p, u32 reg, u32 *val) · line 158
Quoted 9 lines
drivers/power/power_i2c.c +3
-1debug ("Bus: %d PMIC:%s probed!\n" , p->bus, p->name); -if (i2c_probe (pmic_i2c_addr)) { + ret =i2c_probe (pmic_i2c_addr); +pmic_deselect (old_bus); +if (ret) {printf ("Can't find PMIC:%s\n" , p->name);return -1 ; }
Thanks,
Minkyu Kang.
PATCH v3 2/6 power: Explicitly select pmic device's bus
Hi Minkyu Kang,
Quoted 25 lines · Minkyu Kang
Dear Leela Krishna Amudala,
Quoted 22 lines · Leela Krishna Amudala
The current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There is nothing ensuring that to be true. Therefore, select the proper bus before performing a transaction.
Signed-off-by Aaron Durbin <[email protected]>Signed-off-by Simon Glass <[email protected]>Signed-off-by Leela Krishna Amudala <[email protected]>Reviewed-by Doug Anderson <[email protected]>Acked-by Simon Glass <[email protected]>--- drivers/power/power_i2c.c | 62 +++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 57 insertions(+), 5 deletions(-)drivers/power/power_i2c.c +0
-0@@ -16,9 +16,45 @@#include <i2c.h> #include <compiler.h>
Quoted 7 lines
drivers/power/power_i2c.c line 21
Quoted 3 lines
drivers/power/power_i2c.c +3
-0+static int pmic_select (struct pmic *p) +{ +int ret, old_bus;I think, old prefix is meaningless.
please fix it globally.
I think, it is necessary to differentiate with the current bus. Please see my below commets for clear picture.
Quoted 9 lines
drivers/power/power_i2c.c line 24
Quoted 3 lines
drivers/power/power_i2c.c +3
-0+ + old_bus =i2c_get_bus_num (); +if (old_bus != p->bus) {How about return immediately if get a bus.
if (
old_bus==p->bus)return old_bus;
The current code is also doing the same but in other way. If old_bus != p->bus then set the new bus otherwise no code to execute and return old_bus.
This is same as what you suggested.
Quoted 8 lines
Quoted 8 lines
drivers/power/power_i2c.c +8
-0+debug ("%s: Select bus %d\n" , __func__, p->bus); + ret =i2c_set_bus_num (p->bus); +if (ret) { +debug ("%s: Cannot select pmic %s, err %d\n" , + __func__, p->name, ret); +return -1 ; + } + }
Quoted 9 lines
drivers/power/power_i2c.c line 37
Quoted 5 lines
drivers/power/power_i2c.c +5
-0+ +return old_bus; +} + +static int pmic_deselect (int old_bus)in your patch, you never check a return value.
then is it void function or wrong usage?
Okay, I'll change the function return type.
Quoted 10 lines
And I think
pmic_deselectfunction is almost same withpmic_select. If you change the parameter forpmic_selectto "int bus" then, What is different withpmic_select?for example.
bus =
pmic_select(p->bus);
/* do something */pmic_deselect(bus);
Quoted 8 lines
is same with.
bus =
pmic_select(p->bus);
/* do something */pmic_select(bus);How do you think?
Yes, pmic_deselect is almost same as pmic_select but there is a minor difference.
pmic_select() is used to set new bus and this function returns the old bus number. we will hold this old_bus number and once we are done with our work we have to restore the old_bus so we are passing old_bus to pmic_deselect()
Now, pmic_deselect() takes old_bus as argument and trying to set it. This function won't return any bus number.
Hope this explanation helps.
Quoted 32 lines
Quoted 32 lines
drivers/power/power_i2c.c +19
-1+{ +int ret; + +if (old_bus !=i2c_get_bus_num ()) { + ret =i2c_set_bus_num (old_bus); +debug ("%s: Select bus %d\n" , __func__, old_bus); +if (ret) { +debug ("%s: Cannot restore i2c bus, err %d\n" , + __func__, ret); +return -1 ; + } + } + +return 0 ; +} +int pmic_reg_write (struct pmic *p,u32 reg,u32 val) {unsigned char buf[4 ] = {0 }; +int ret, old_bus;if (check_reg (p, reg))return -1 ;@@ -52,23 +88,33 @@ int pmic_reg_write(struct pmic *p, u32 reg, u32 val)return -1 ; } -if (i2c_write (pmic_i2c_addr, reg,1 , buf, pmic_i2c_tx_num)) + old_bus =pmic_select (p); +if (old_bus <0 )return -1 ;
Quoted 6 lines
drivers/power/power_i2c.c int pmic_reg_write(struct pmic *p, u32 reg, u32 val) · line 96
Quoted 3 lines
drivers/power/power_i2c.c +2
-1-return 0 ; + ret =i2c_write (pmic_i2c_addr, reg,1 , buf, pmic_i2c_tx_num); +pmic_deselect (old_bus);please add blank line.
Okay, will do it.
Quoted 27 lines
Quoted 27 lines
drivers/power/power_i2c.c +9
-1+return ret; }int pmic_reg_read (struct pmic *p,u32 reg,u32 *val) {unsigned char buf[4 ] = {0 };u32 ret_val =0 ; +int ret, old_bus;if (check_reg (p, reg))return -1 ; -if (i2c_read (pmic_i2c_addr, reg,1 , buf, pmic_i2c_tx_num)) + old_bus =pmic_select (p); +if (old_bus <0 )return -1 ; + ret =i2c_read (pmic_i2c_addr, reg,1 , buf, pmic_i2c_tx_num); +pmic_deselect (old_bus); +if (ret) +return ret; +switch (pmic_i2c_tx_num) {case 3 :if (p->sensor_byte_order ==PMIC_SENSOR_BYTE_ORDER_BIG )@@ -98,9 +144,15 @@ int pmic_reg_read(struct pmic *p, u32 reg, u32 *val)
Quoted 11 lines
drivers/power/power_i2c.c int pmic_reg_read(struct pmic *p, u32 reg, u32 *val) · line 151
Quoted 8 lines
drivers/power/power_i2c.c +5
-1int pmic_probe (struct pmic *p) { -i2c_set_bus_num (p->bus); +int ret, old_bus; + + old_bus =pmic_select (p); +if (old_bus <0 ) +return -1 ;please add blank line.
Okay, will do it.
Best Wishes,
Leela Krishna.
Quoted 16 lines
drivers/power/power_i2c.c int pmic_reg_read(struct pmic *p, u32 reg, u32 *val) · line 158
Quoted 9 lines
drivers/power/power_i2c.c +3
-1debug ("Bus: %d PMIC:%s probed!\n" , p->bus, p->name); -if (i2c_probe (pmic_i2c_addr)) { + ret =i2c_probe (pmic_i2c_addr); +pmic_deselect (old_bus); +if (ret) {printf ("Can't find PMIC:%s\n" , p->name);return -1 ; }Thanks,
Minkyu Kang.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
PATCH v3 2/6 power: Explicitly select pmic device's bus
Quoted 36 lines · Leela Krishna Amudala
Hi Minkyu Kang,
Quoted 25 lines · Minkyu Kang
Dear Leela Krishna Amudala,
Quoted 22 lines · Leela Krishna Amudala
The current pmic i2c code assumes the current i2c bus is the same as the pmic device's bus. There is nothing ensuring that to be true. Therefore, select the proper bus before performing a transaction.
Signed-off-by Aaron Durbin <[email protected]>Signed-off-by Simon Glass <[email protected]>Signed-off-by Leela Krishna Amudala <[email protected]>Reviewed-by Doug Anderson <[email protected]>Acked-by Simon Glass <[email protected]>--- drivers/power/power_i2c.c | 62 +++++++++++++++++++++++++++++++++++++++++---- 1 file changed, 57 insertions(+), 5 deletions(-)drivers/power/power_i2c.c +0
-0@@ -16,9 +16,45 @@#include <i2c.h> #include <compiler.h> Quoted 7 lines
drivers/power/power_i2c.c line 21
Quoted 3 lines
drivers/power/power_i2c.c +3
-0+static int pmic_select (struct pmic *p) +{ +int ret, old_bus;I think, old prefix is meaningless.
please fix it globally.
Quoted 2 lines
I think, it is necessary to differentiate with the current bus. Please see my below commets for clear picture.
there's no current bus variable.
also, we knew that p->bus is current bus.
Quoted 7 lines
Quoted 7 lines
drivers/power/power_i2c.c line 24
Quoted 4 lines
drivers/power/power_i2c.c +3
-0+ + old_bus =i2c_get_bus_num (); +if (old_bus != p->bus) {How about return immediately if get a bus.
Quoted 8 lines
Quoted 3 lines
if (
old_bus==p->bus)return old_bus;The current code is also doing the same but in other way. If
old_bus!=p->busthen set the new bus otherwise no code to execute and returnold_bus.
This is same as what you suggested.
I know.
I'm talking about code quality.
please think, which one is better.
Quoted 48 lines
Quoted 18 lines
Quoted 4 lines
drivers/power/power_i2c.c +3
-0+debug ("%s: Select bus %d\n" , __func__, p->bus); + ret =i2c_set_bus_num (p->bus); +if (ret) {drivers/power/power_i2c.c line 37
Quoted 10 lines
drivers/power/power_i2c.c +10
-0+debug ("%s: Cannot select pmic %s, err %d\n" , + __func__, p->name, ret); +return -1 ; + } + } + +return old_bus; +} + +static int pmic_deselect (int old_bus)in your patch, you never check a return value.
then is it void function or wrong usage?Okay, I'll change the function return type.
Quoted 10 lines
And I think
pmic_deselectfunction is almost same withpmic_select. If you change the parameter forpmic_selectto "int bus" then, What is different withpmic_select?for example.
bus =
pmic_select(p->bus);
/* do something */pmic_deselect(bus);Quoted 8 lines
is same with.
bus =
pmic_select(p->bus);
/* do something */pmic_select(bus);How do you think?
Yes,
pmic_deselectis almost same aspmic_selectbut there is a minor difference.
pmic_select()is used to set new bus and this function returns the old bus number. we will hold thisold_busnumber and once we are done with our work we have to restore theold_busso we are passingold_bustopmic_deselect()
Quoted 4 lines
Now,
pmic_deselect()takesold_busas argument and trying to set it. This function won't return any bus number.Hope this explanation helps.
I know.
the focus is that almost codes were duplicated.
My suggestion is one of example for reducing code duplication. Please think about it.
Quoted 81 lines
Quoted 33 lines
Quoted 33 lines
drivers/power/power_i2c.c +19
-1+{ +int ret; + +if (old_bus !=i2c_get_bus_num ()) { + ret =i2c_set_bus_num (old_bus); +debug ("%s: Select bus %d\n" , __func__, old_bus); +if (ret) { +debug ("%s: Cannot restore i2c bus, err %d\n" , + __func__, ret); +return -1 ; + } + } + +return 0 ; +} +int pmic_reg_write (struct pmic *p,u32 reg,u32 val) {unsigned char buf[4 ] = {0 }; +int ret, old_bus;if (check_reg (p, reg))return -1 ;@@ -52,23 +88,33 @@ int pmic_reg_write(struct pmic *p, u32 reg, u32 val)return -1 ; } -if (i2c_write (pmic_i2c_addr, reg,1 , buf, pmic_i2c_tx_num)) + old_bus =pmic_select (p); +if (old_bus <0 )return -1 ;Quoted 6 lines
drivers/power/power_i2c.c int pmic_reg_write(struct pmic *p, u32 reg, u32 val) · line 96
Quoted 3 lines
drivers/power/power_i2c.c +2
-1-return 0 ; + ret =i2c_write (pmic_i2c_addr, reg,1 , buf, pmic_i2c_tx_num); +pmic_deselect (old_bus);please add blank line.
Okay, will do it.
Quoted 27 lines
Quoted 27 lines
drivers/power/power_i2c.c +9
-1+return ret; }int pmic_reg_read (struct pmic *p,u32 reg,u32 *val) {unsigned char buf[4 ] = {0 };u32 ret_val =0 ; +int ret, old_bus;if (check_reg (p, reg))return -1 ; -if (i2c_read (pmic_i2c_addr, reg,1 , buf, pmic_i2c_tx_num)) + old_bus =pmic_select (p); +if (old_bus <0 )return -1 ; + ret =i2c_read (pmic_i2c_addr, reg,1 , buf, pmic_i2c_tx_num); +pmic_deselect (old_bus); +if (ret) +return ret; +switch (pmic_i2c_tx_num) {case 3 :if (p->sensor_byte_order ==PMIC_SENSOR_BYTE_ORDER_BIG )@@ -98,9 +144,15 @@ int pmic_reg_read(struct pmic *p, u32 reg, u32 *val)Quoted 11 lines
drivers/power/power_i2c.c int pmic_reg_read(struct pmic *p, u32 reg, u32 *val) · line 151
Quoted 8 lines
drivers/power/power_i2c.c +5
-1int pmic_probe (struct pmic *p) { -i2c_set_bus_num (p->bus); +int ret, old_bus; + + old_bus =pmic_select (p); +if (old_bus <0 ) +return -1 ;please add blank line.
Quoted 22 lines
Okay, will do it.
Best Wishes,
Leela Krishna.Quoted 16 lines
drivers/power/power_i2c.c int pmic_reg_read(struct pmic *p, u32 reg, u32 *val) · line 158
Quoted 9 lines
drivers/power/power_i2c.c +3
-1debug ("Bus: %d PMIC:%s probed!\n" , p->bus, p->name); -if (i2c_probe (pmic_i2c_addr)) { + ret =i2c_probe (pmic_i2c_addr); +pmic_deselect (old_bus); +if (ret) {printf ("Can't find PMIC:%s\n" , p->name);return -1 ; }Thanks,
Minkyu Kang.
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Thanks,
Minkyu Kang.
PATCH v3 3/6 FDT: Exynos5420: Add compatible srings for PMIC
In reply to Leela Krishna AmudalaAdd required compatible strings for PMIC S2MPS11
--- include/fdtdec.h | 1 + lib/fdtdec.c | 1 + 2 files changed, 2 insertions(+)
include/fdtdec.h +1 -0
@@ -85,6 +85,7 @@ enum fdt_compat_id {COMPAT_INFINEON_SLB9635_TPM ,/* Infineon SLB9635 TPM */ COMPAT_INFINEON_SLB9645_TPM ,/* Infineon SLB9645 TPM */ COMPAT_SAMSUNG_EXYNOS5_I2C ,/* Exynos5 High Speed I2C Controller */ +COMPAT_SAMSUNG_S2MPS11_PMIC ,/* S2MPS11 PMIC */ COMPAT_COUNT, };
lib/fdtdec.c +1 -0
@@ -58,6 +58,7 @@ static const char * const compat_names[COMPAT_COUNT] = {COMPAT (INFINEON_SLB9635_TPM ,"infineon,slb9635-tpm" ),COMPAT (INFINEON_SLB9645_TPM ,"infineon,slb9645-tpm" ),COMPAT (SAMSUNG_EXYNOS5_I2C ,"samsung,exynos5-hsi2c" ), + COMPAT(SAMSUNG_S2MPS11_PMIC, "samsung,s2mps11-pmic"), };const char *fdtdec_get_compatible (enum fdt_compat_id id)
Signature · 1 line
1.7.10.4
PATCH v3 4/6 SMDK5420: S2MPS11: Adds the register settings for S2MPS11
In reply to Leela Krishna AmudalaAdds the register settings, addresses and voltages associated with S2MPS11
--- include/power/s2mps11_pmic.h | 141 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 141 insertions(+) create mode 100644 include/power/s2mps11_pmic.h
include/power/s2mps11_pmic.h new file +141 -0
@@ -0,0 +1,141 @@ +/* +* s2mps11_pmic.h +* +* Copyright (c) 2012 Samsung Electronics Co., Ltd +* http://www.samsung.com +* +* SPDX-License-Identifier: GPL-2.0+ +* +*/ +#ifndef __S2MPS11_H +#define __S2MPS11_H + +/* S2MPS11 registers */ +enum s2mps11_reg { +S2MPS11_REG_ID , +S2MPS11_REG_INT1 , +S2MPS11_REG_INT2 , +S2MPS11_REG_INT3 , +S2MPS11_REG_INT1M , +S2MPS11_REG_INT2M , +S2MPS11_REG_INT3M , +S2MPS11_REG_ST1 , +S2MPS11_REG_ST2 , +S2MPS11_REG_OFFSRC , +S2MPS11_REG_PWRONSRC , +S2MPS11_REG_RTC_CTRL , +S2MPS11_REG_CTRL1 , +S2MPS11_REG_ETC_TEST , +S2MPS11_REG_RSVD3 , +S2MPS11_REG_BU_CHG , +S2MPS11_REG_RAMP , +S2MPS11_REG_RAMP_BUCK , +S2MPS11_REG_LDO1_8 , +S2MPS11_REG_LDO9_16 , +S2MPS11_REG_LDO17_24 , +S2MPS11_REG_LDO25_32 , +S2MPS11_REG_LDO33_38 , +S2MPS11_REG_LDO1_8_1 , +S2MPS11_REG_LDO9_16_1 , +S2MPS11_REG_LDO17_24_1 , +S2MPS11_REG_LDO25_32_1 , +S2MPS11_REG_LDO33_38_1 , +S2MPS11_REG_OTP_ADRL , +S2MPS11_REG_OTP_ADRH , +S2MPS11_REG_OTP_DATA , +S2MPS11_REG_MON1SEL , +S2MPS11_REG_MON2SEL , +S2MPS11_REG_LEE , +S2MPS11_REG_RSVD_NO , +S2MPS11_REG_UVLO , +S2MPS11_REG_LEE_NO , +S2MPS11_REG_B1CTRL1 , +S2MPS11_REG_B1CTRL2 , +S2MPS11_REG_B2CTRL1 , +S2MPS11_REG_B2CTRL2 , +S2MPS11_REG_B3CTRL1 , +S2MPS11_REG_B3CTRL2 , +S2MPS11_REG_B4CTRL1 , +S2MPS11_REG_B4CTRL2 , +S2MPS11_REG_B5CTRL1 , +S2MPS11_REG_BUCK5_SW , +S2MPS11_REG_B5CTRL2 , +S2MPS11_REG_B5CTRL3 , +S2MPS11_REG_B5CTRL4 , +S2MPS11_REG_B5CTRL5 , +S2MPS11_REG_B6CTRL1 , +S2MPS11_REG_B6CTRL2 , +S2MPS11_REG_B7CTRL1 , +S2MPS11_REG_B7CTRL2 , +S2MPS11_REG_B8CTRL1 , +S2MPS11_REG_B8CTRL2 , +S2MPS11_REG_B9CTRL1 , +S2MPS11_REG_B9CTRL2 , +S2MPS11_REG_B10CTRL1 , +S2MPS11_REG_B10CTRL2 , +S2MPS11_REG_L1CTRL , +S2MPS11_REG_L2CTRL , +S2MPS11_REG_L3CTRL , +S2MPS11_REG_L4CTRL , +S2MPS11_REG_L5CTRL , +S2MPS11_REG_L6CTRL , +S2MPS11_REG_L7CTRL , +S2MPS11_REG_L8CTRL , +S2MPS11_REG_L9CTRL , +S2MPS11_REG_L10CTRL , +S2MPS11_REG_L11CTRL , +S2MPS11_REG_L12CTRL , +S2MPS11_REG_L13CTRL , +S2MPS11_REG_L14CTRL , +S2MPS11_REG_L15CTRL , +S2MPS11_REG_L16CTRL , +S2MPS11_REG_L17CTRL , +S2MPS11_REG_L18CTRL , +S2MPS11_REG_L19CTRL , +S2MPS11_REG_L20CTRL , +S2MPS11_REG_L21CTRL , +S2MPS11_REG_L22CTRL , +S2MPS11_REG_L23CTRL , +S2MPS11_REG_L24CTRL , +S2MPS11_REG_L25CTRL , +S2MPS11_REG_L26CTRL , +S2MPS11_REG_L27CTRL , +S2MPS11_REG_L28CTRL , +S2MPS11_REG_L29CTRL , +S2MPS11_REG_L30CTRL , +S2MPS11_REG_L31CTRL , +S2MPS11_REG_L32CTRL , +S2MPS11_REG_L33CTRL , +S2MPS11_REG_L34CTRL , +S2MPS11_REG_L35CTRL , +S2MPS11_REG_L36CTRL , +S2MPS11_REG_L37CTRL , +S2MPS11_REG_L38CTRL , + +S2MPS11_NUM_OF_REGS , +}; + +/* I2C device address for pmic S2MPS11 */ +#define S2MPS11_I2C_ADDR (0xCC >> 1) +#define S2MPS11_BUS_NUM 4 + +/* Value to set voltage as 1V */ +#define S2MPS11_BUCK_CTRL2_1V 0x40 +/* Value to set voltage as 1.2V */ +#define S2MPS11_BUCK_CTRL2_1_2V 0x60 +/* Value to set voltage as 1.2625V */ +#define S2MPS11_BUCK_CTRL2_1_2625V 0x6A + +/* Buck register addresses */ +#define S2MPS11_BUCK1_CTRL2 0x26 +#define S2MPS11_BUCK2_CTRL2 0x28 +#define S2MPS11_BUCK3_CTRL2 0x2a +#define S2MPS11_BUCK4_CTRL2 0x2c +#define S2MPS11_BUCK6_CTRL2 0x34 +#define S2MPS11_LDO22_CTRL 0x52 + +#define S2MPS11_DEVICE_NAME "S2MPS11_PMIC" + +#define S2MPS11_RTC_CTRL_32KHZ_CP_EN (1 << 1) +#define S2MPS11_RTC_CTRL_JIT (1 << 4) +#endif /* __LINUX_MFD_S2MPS11_H */
Signature · 1 line
1.7.10.4
PATCH v3 5/6 exynos: Add a common DT based PMIC driver initialization
In reply to Leela Krishna AmudalaMost of i2c PMIC drivers follow the same initialization sequence, let's generalize it in a common file.
The initialization function finds the PMIC in the device tree, and if found - registers it in the list of known PMICs and initializes it, iterating through the table of settings supplied by the caller.
--- board/samsung/common/board.c | 22 +++++++++ drivers/power/pmic/Makefile | 1 + drivers/power/pmic/pmic_common.c | 97 ++++++++++++++++++++++++++++++++++++++ drivers/power/power_core.c | 14 ++++++ include/power/pmic.h | 34 +++++++++++++ 5 files changed, 168 insertions(+) create mode 100644 drivers/power/pmic/pmic_common.c
board/samsung/common/board.c +22 -0
@@ -23,6 +23,7 @@#include <power/pmic.h> #include <asm/arch/sromc.h> #include <power/max77686_pmic.h> +#include <power/s2mps11_pmic.h> DECLARE_GLOBAL_DATA_PTR ;
@@ -154,6 +155,25 @@ static int board_init_cros_ec_devices(const void *blob) }#endif +#ifdef CONFIG_POWER_S2MPS11 +int board_init_s2mps11 (void ) +{ +const struct pmic_init_ops pmic_ops[] = { + {PMIC_REG_WRITE ,S2MPS11_BUCK1_CTRL2 ,S2MPS11_BUCK_CTRL2_1V }, + {PMIC_REG_WRITE ,S2MPS11_BUCK2_CTRL2 , +S2MPS11_BUCK_CTRL2_1_2625V }, + {PMIC_REG_WRITE ,S2MPS11_BUCK3_CTRL2 ,S2MPS11_BUCK_CTRL2_1V }, + {PMIC_REG_WRITE ,S2MPS11_BUCK4_CTRL2 ,S2MPS11_BUCK_CTRL2_1V }, + {PMIC_REG_WRITE ,S2MPS11_BUCK6_CTRL2 ,S2MPS11_BUCK_CTRL2_1V }, + {PMIC_REG_UPDATE ,S2MPS11_REG_RTC_CTRL , +S2MPS11_RTC_CTRL_32KHZ_CP_EN |S2MPS11_RTC_CTRL_JIT }, + {PMIC_REG_BAIL } + }; + +return pmic_common_init (COMPAT_SAMSUNG_S2MPS11_PMIC , pmic_ops); +} +#endif +#if defined(CONFIG_POWER )#ifdef CONFIG_POWER_MAX77686 static int max77686_init (void )
@@ -259,6 +279,8 @@ int power_init_board(void)#ifdef CONFIG_POWER_MAX77686 ret =max77686_init (); +#elif defined(CONFIG_POWER_S2MPS11 ) + ret =board_init_s2mps11 ();#endif return ret;
drivers/power/pmic/Makefile +1 -0
@@ -15,6 +15,7 @@ COBJS-$(CONFIG_POWER_MUIC_MAX8997) += muic_max8997.o COBJS-$(CONFIG_POWER_MAX77686) += pmic_max77686.o COBJS-$(CONFIG_POWER_TPS65217) += pmic_tps65217.o COBJS-$(CONFIG_POWER_TPS65910) += pmic_tps65910.o +COBJS-$(CONFIG_POWER) += pmic_common.o COBJS := $(COBJS-y) SRCS := $(COBJS:.o=.c)
drivers/power/pmic/pmic_common.c new file +97 -0
97 lines not on this page · raw message
drivers/power/power_core.c +14 -0
@@ -227,6 +227,20 @@ int pmic_reg_update(struct pmic *p, int reg, uint regval)return 0 ; } +struct pmic *pmic_get_by_id (enum fdt_compat_id pmic_compat) +{ +struct pmic *p; + +list_for_each_entry (p, &pmic_list, list) { +if (p->compat_id == pmic_compat) { +debug ("%s: pmic %s -> 0x%p\n" , __func__, p->name, p); +return p; + } + } + +return NULL ; +} + U_BOOT_CMD( pmic, CONFIG_SYS_MAXARGS, 1, do_pmic, "PMIC",
include/power/pmic.h +34 -0
@@ -12,6 +12,7 @@#include <linux/list.h> #include <i2c.h> #include <power/power_chrg.h> +#include <fdtdec.h> enum {PMIC_I2C ,PMIC_SPI ,PMIC_NONE };enum {I2C_PMIC ,I2C_NUM , };
@@ -72,6 +73,7 @@ struct pmic {struct pmic *parent;struct list_head list; +enum fdt_compat_id compat_id; };int pmic_init (unsigned char bus);
@@ -84,6 +86,38 @@ int pmic_reg_read(struct pmic *p, u32 reg, u32 *val);int pmic_reg_write (struct pmic *p,u32 reg,u32 val);int pmic_set_output (struct pmic *p,u32 reg,int ldo,int on);int pmic_reg_update (struct pmic *p,int reg,uint regval); +/* +* Find registered PMIC based on its compatibility ID. +* +* @param pmic_compat compatibility ID of the PMIC to search for. +* @return pointer to the relevant 'struct pmic' on success or NULL +*/ +struct pmic *pmic_get_by_id (enum fdt_compat_id pmic_compat); + +enum pmic_reg_op {PMIC_REG_BAIL ,PMIC_REG_WRITE ,PMIC_REG_UPDATE }; +struct pmic_init_ops { +enum pmic_reg_op reg_op; +u8 reg_addr; +u8 reg_value; +}; + +/** +* Common function used to intialize an i2c based PMIC. +* +* This function finds the PMIC in the device tree based on its compatibility +* ID. If found, the struct pmic is allocated, initialized and registered. +* +* Then the table of initialization settings is scanned and the PMIC registers +* are set as dictated by the table contents, +* +* @param pmic_compat compatibility ID f the PMIC to be initialized. +* @param pmic_ops a pointer to the table containing PMIC initialization +* settings. The last entry contains reg_op +* of PMIC_REG_BAIL. +* @return zero on success, nonzero on failure +*/ +int pmic_common_init (enum fdt_compat_id pmic_compat, +const struct pmic_init_ops *pmic_ops);#define pmic_i2c_addr (p->hw.i2c.addr)#define pmic_i2c_tx_num (p->hw.i2c.tx_num)
Signature · 1 line
1.7.10.4
PATCH v3 6/6 config: SMDK5420: Enable S2MPS11 pmic
In reply to Leela Krishna Amudalaconfigure S2MPS11 pmic on SMDK5420
--- include/configs/smdk5420.h | 4 ++++ 1 file changed, 4 insertions(+)
include/configs/smdk5420.h +4 -0
@@ -53,4 +53,8 @@#define CONFIG_MAX_I2C_NUM 11 +#define CONFIG_POWER +#define CONFIG_POWER_I2C +#define CONFIG_POWER_S2MPS11 +#endif /* __CONFIG_5420_H */
Signature · 1 line
1.7.10.4