Skip to contentSkip to conversation

ARM: shmobile: Genmai SPI over GPIO support

PATCH New Magnus Damm 3 participants 3 messages Dec 4, 2013 – Dec 5, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ARM: shmobile: Genmai SPI over GPIO support

From: Magnus Damm <[email protected]>

Hook up the serial flash memory to bit bang SPI on the Genmai board.

---

Written on to of renesas git tag renesas-devel-v3.13-rc2-20131202 and [PATCH 00/04] ARM: shmobile: r7s72100 and Genmai GPIO / PINCTRL support

 arch/arm/boot/dts/r7s72100-genmai-reference.dts |   15 +++++++++++++++
 1 file changed, 15 insertions(+)
arch/arm/boot/dts/r7s72100-genmai-reference.dts +15 -0
@@ -56,5 +56,20 @@
 			reg = <0x50>;
 		};
 	};
+	spi0 {
+		compatible = "spi-gpio";
+		gpio-sck = <&port9 2 0>;
+		gpio-mosi = <&port9 4 0>;
+		gpio-miso = <&port9 5 0>;
+		cs-gpios = <&port9 3 0>;
+		num-chipselects = <1>;
+		#address-cells = <1>;
+		#size-cells = <0>;
 
+		s25fl512s: s25fl512s0 {
+			compatible = "s25fl512s";
+			reg = <0>;
+			spi-max-frequency = <104000000>;
+                };
+        };
 };
#1 lore raw

PATCH 1/1 ARM: shmobile: Genmai SPI over GPIO support

Hi Magnus,

Thank you for the patch.

Quoted 16 lines · On Thursday 05 December 2013 06:29:15 Magnus Damm wrote:

From: Magnus Damm <[email protected]>

Hook up the serial flash memory to bit bang SPI on the Genmai board.

---

Written on to of renesas git tag renesas-devel-v3.13-rc2-20131202 and [PATCH 00/04] ARM: shmobile: r7s72100 and Genmai GPIO / PINCTRL support

 arch/arm/boot/dts/r7s72100-genmai-reference.dts |   15 +++++++++++++++
 1 file changed, 15 insertions(+)
arch/arm/boot/dts/r7s72100-genmai-reference.dts +0 -0

06:23:57.000000000 +0900 @@ -56,5 +56,20 @@

arch/arm/boot/dts/r7s72100-genmai-reference.dts line 64

Quoted 9 lines
arch/arm/boot/dts/r7s72100-genmai-reference.dts +6 -0
 			reg = <0x50>;
 		};
 	};
+	spi0 {
+		compatible = "spi-gpio";
+		gpio-sck = <&port9 2 0>;
+		gpio-mosi = <&port9 4 0>;
+		gpio-miso = <&port9 5 0>;
+		cs-gpios = <&port9 3 0>;

What about replacing those 0 with GPIO_ACTIVE_HIGH ?

arch/arm/boot/dts/r7s72100-genmai-reference.dts line 69

Quoted 5 lines
arch/arm/boot/dts/r7s72100-genmai-reference.dts +4 -0
+		num-chipselects = <1>;
+		#address-cells = <1>;
+		#size-cells = <0>;
 
+		s25fl512s: s25fl512s0 {

The node should be called flash at 0.

arch/arm/boot/dts/r7s72100-genmai-reference.dts line 74

Quoted 5 lines
arch/arm/boot/dts/r7s72100-genmai-reference.dts +5 -0
+			compatible = "s25fl512s";
+			reg = <0>;
+			spi-max-frequency = <104000000>;
+                };
+        };

Please use tabs for indentation here.

The rest looks fine to me, but I obviously can't review most of the information as I don't have access to the board schematics. I'll trust you that you have tested the patch :-)

Quoted 1 line

};

Signature · 3 lines
Regards,

Laurent Pinchart
#2 lore raw

PATCH 1/1 ARM: shmobile: Genmai SPI over GPIO support

In reply to Magnus Damm

Hello.

Quoted 16 lines · Magnus Damm

From: Magnus Damm <[email protected]>

Hook up the serial flash memory to bit bang SPI on the Genmai board.

---

Written on to of renesas git tag renesas-devel-v3.13-rc2-20131202 and [PATCH 00/04] ARM: shmobile: r7s72100 and Genmai GPIO / PINCTRL support

  arch/arm/boot/dts/r7s72100-genmai-reference.dts |   15 +++++++++++++++
  1 file changed, 15 insertions(+)

arch/arm/boot/dts/r7s72100-genmai-reference.dts line 59

Quoted 4 lines
arch/arm/boot/dts/r7s72100-genmai-reference.dts +1 -0
@@ -56,5 +56,20 @@
  			reg = <0x50>;
  		};
  	};
+	spi0 {

Maybe just "spi"?

arch/arm/boot/dts/r7s72100-genmai-reference.dts line 69

Quoted 10 lines
arch/arm/boot/dts/r7s72100-genmai-reference.dts +9 -0
+		compatible = "spi-gpio";
+		gpio-sck = <&port9 2 0>;
+		gpio-mosi = <&port9 4 0>;
+		gpio-miso = <&port9 5 0>;
+		cs-gpios = <&port9 3 0>;
+		num-chipselects = <1>;
+		#address-cells = <1>;
+		#size-cells = <0>;
 
+		s25fl512s: s25fl512s0 {

The node should probably be named "flash", according to ePAPR spec. And
why you didn't specify "@0"?

arch/arm/boot/dts/r7s72100-genmai-reference.dts line 75

Quoted 6 lines
arch/arm/boot/dts/r7s72100-genmai-reference.dts +5 -0
+			compatible = "s25fl512s";
+			reg = <0>;
+			spi-max-frequency = <104000000>;
+                };
+        };
  };

WBR, Sergei