Skip to contentSkip to conversation

Usb: atm: usbatm: fixed a pointer variable format issue

PATCH In review learc83 2 participants 3 messages Dec 6, 2013 1 message not in the archive

Subsystems (3)
lore
Share & tools
lore

learc83

author
#0 lore raw

PATCH 1/1 Usb: atm: usbatm: fixed a pointer variable format issue

Fixed a pointer variable format issue.

---
 drivers/usb/atm/usbatm.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/usb/atm/usbatm.c +4 -4
index 25a7bfc..dada014 100644
@@ -170,9 +170,9 @@ struct usbatm_control {
 static void usbatm_atm_dev_close(struct atm_dev *atm_dev);
 static int usbatm_atm_open(struct atm_vcc *vcc);
 static void usbatm_atm_close(struct atm_vcc *vcc);
-static int usbatm_atm_ioctl(struct atm_dev *atm_dev, unsigned int cmd, void __user * arg);
+static int usbatm_atm_ioctl(struct atm_dev *atm_dev, unsigned int cmd, void __user *arg);
 static int usbatm_atm_send(struct atm_vcc *vcc, struct sk_buff *skb);
-static int usbatm_atm_proc_read(struct atm_dev *atm_dev, loff_t * pos, char *page);
+static int usbatm_atm_proc_read(struct atm_dev *atm_dev, loff_t *pos, char *page);
 
 static struct atmdev_ops usbatm_atm_devops = {
 	.dev_close	= usbatm_atm_dev_close,
@@ -739,7 +739,7 @@ static void usbatm_atm_dev_close(struct atm_dev *atm_dev)
 	usbatm_put_instance(instance);	/* taken in usbatm_atm_init */
 }
 
-static int usbatm_atm_proc_read(struct atm_dev *atm_dev, loff_t * pos, char *page)
+static int usbatm_atm_proc_read(struct atm_dev *atm_dev, loff_t *pos, char *page)
 {
 	struct usbatm_data *instance = atm_dev->dev_data;
 	int left = *pos;
@@ -895,7 +895,7 @@ static void usbatm_atm_close(struct atm_vcc *vcc)
 }
 
 static int usbatm_atm_ioctl(struct atm_dev *atm_dev, unsigned int cmd,
-			  void __user * arg)
+			  void __user *arg)
 {
 	struct usbatm_data *instance = atm_dev->dev_data;
 
Signature · 1 line
1.7.10.4
#1 lore raw
Quoted 1 line · On 06/12/13 04:59, learc83 wrote:

Fixed a pointer variable format issue.

This is obviously OK.

Ciao, Duncan.

Quoted 41 lines
---
  drivers/usb/atm/usbatm.c |    8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)
drivers/usb/atm/usbatm.c +4 -4
index 25a7bfc..dada014 100644
@@ -170,9 +170,9 @@ struct usbatm_control {
  static void usbatm_atm_dev_close(struct atm_dev *atm_dev);
  static int usbatm_atm_open(struct atm_vcc *vcc);
  static void usbatm_atm_close(struct atm_vcc *vcc);
-static int usbatm_atm_ioctl(struct atm_dev *atm_dev, unsigned int cmd, void __user * arg);
+static int usbatm_atm_ioctl(struct atm_dev *atm_dev, unsigned int cmd, void __user *arg);
  static int usbatm_atm_send(struct atm_vcc *vcc, struct sk_buff *skb);
-static int usbatm_atm_proc_read(struct atm_dev *atm_dev, loff_t * pos, char *page);
+static int usbatm_atm_proc_read(struct atm_dev *atm_dev, loff_t *pos, char *page);
 
  static struct atmdev_ops usbatm_atm_devops = {
  	.dev_close	= usbatm_atm_dev_close,
@@ -739,7 +739,7 @@ static void usbatm_atm_dev_close(struct atm_dev *atm_dev)
  	usbatm_put_instance(instance);	/* taken in usbatm_atm_init */
  }
 
-static int usbatm_atm_proc_read(struct atm_dev *atm_dev, loff_t * pos, char *page)
+static int usbatm_atm_proc_read(struct atm_dev *atm_dev, loff_t *pos, char *page)
  {
  	struct usbatm_data *instance = atm_dev->dev_data;
  	int left = *pos;
@@ -895,7 +895,7 @@ static void usbatm_atm_close(struct atm_vcc *vcc)
  }
 
  static int usbatm_atm_ioctl(struct atm_dev *atm_dev, unsigned int cmd,
-			  void __user * arg)
+			  void __user *arg)
  {
  	struct usbatm_data *instance = atm_dev->dev_data;
 

A message that is not in the archive (sent off-list or not yet received): CAFcs13FWknRxhT_ZUnirRk+O0ZeDq1TVFtgMD9hkp=aVKUnHLA@mail.gmail.com

#3 lore raw

Hi Seth,

Quoted 2 lines · Seth Archer

Sorry, but do you mean the patch is OK, or the original is OK and no patch necessary?

I meant that the patch is obviously OK.

Ciao, Duncan.

Quoted 13 lines

-Seth

On Fri, Dec 6, 2013 at 3:24 AM, Duncan Sands <[email protected] <mailto:[email protected]>> wrote:

On 06/12/13 04:59, learc83 wrote:

Fixed a pointer variable format issue.

This is obviously OK.