use light-gray as default color in normal.mod for consistency
PATCH 1/1 use light-gray as default color in normal.mod for consistency
As we are in clean up stage ... annoyed me for quite some time.
Defalut font color on PC console seems to be light-gray; this is what user also gets in rescue prompt and what is defined as GRUB_TERM_DEFAULT_NORMAL_COLOR. But normal.mod defaults to white. This makes unpleasant visual effect as colors are changed after kernel is booted.
Use the same color eveywhere for consistency and default to light-gray as this is also what at least Linux kernel is using by default.
--- grub-core/normal/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
grub-core/normal/main.c +2 -2
@@ -572,8 +572,8 @@ GRUB_MOD_INIT(normal)grub_env_export ("color_highlight" );/* Set default color names. */ -grub_env_set ("color_normal" ,"white/black" ); -grub_env_set ("color_highlight" ,"black/white" ); +grub_env_set ("color_normal" ,"light-gray/black" ); +grub_env_set ("color_highlight" ,"black/light-gray" );for (i =0 ; i <ARRAY_SIZE (features); i++) {
Signature · 1 line
tg: (69ca97c..) u/default-color (depends on: master)
Go ahead
Quoted 31 lines · Andrey Borzenkov
As we are in clean up stage ... annoyed me for quite some time.
Defalut font color on PC console seems to be light-gray; this is what user also gets in rescue prompt and what is defined as
GRUB_TERM_DEFAULT_NORMAL_COLOR. But normal.mod defaults to white. This makes unpleasant visual effect as colors are changed after kernel is booted.Use the same color eveywhere for consistency and default to light-gray as this is also what at least Linux kernel is using by default.
--- grub-core/normal/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)grub-core/normal/main.c +2
-2@@ -572,8 +572,8 @@ GRUB_MOD_INIT(normal)grub_env_export ("color_highlight" );/* Set default color names. */ -grub_env_set ("color_normal" ,"white/black" ); -grub_env_set ("color_highlight" ,"black/white" ); +grub_env_set ("color_normal" ,"light-gray/black" ); +grub_env_set ("color_highlight" ,"black/light-gray" );for (i =0 ; i <ARRAY_SIZE (features); i++) {