Skip to contentSkip to conversation

ARM: imx: use __initconst for const init definition

PATCH New Shawn Guo 2 participants 2 messages Dec 9, 2013

Subsystems (4)
lore
Share & tools
lore

Shawn Guo

author
#0 lore raw

PATCH 1/1 ARM: imx: use __initconst for const init definition

0-DAY kernel build testing backend reports the following.

scripts/checkpatch.pl 0001-ARM-imx-add-support-code-for-IMX50-based-machines.patch

 # many are suggestions rather than must-fix

ERROR: Use of const init definition must use __initconst #80: arch/arm/mach-imx/mach-imx50.c:26:
+static const char *imx50_dt_board_compat[] __initdata = {

While at it, fix the error globally for IMX platform.

---
 arch/arm/mach-imx/imx31-dt.c    |    2 +-
 arch/arm/mach-imx/imx51-dt.c    |    2 +-
 arch/arm/mach-imx/mach-imx50.c  |    2 +-
 arch/arm/mach-imx/mach-imx53.c  |    2 +-
 arch/arm/mach-imx/mach-imx6q.c  |    2 +-
 arch/arm/mach-imx/mach-imx6sl.c |    2 +-
 arch/arm/mach-imx/mach-vf610.c  |    2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)
arch/arm/mach-imx/imx31-dt.c +1 -1
index 818a1cc..e1e70ef 100644
@@ -25,7 +25,7 @@ static void __init imx31_dt_init(void)
 	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
 }
 
-static const char *imx31_dt_board_compat[] __initdata = {
+static const char *imx31_dt_board_compat[] __initconst = {
 	"fsl,imx31",
 	NULL
 };
arch/arm/mach-imx/imx51-dt.c +1 -1
index bece8a6..0230d78 100644
@@ -29,7 +29,7 @@ static void __init imx51_dt_init(void)
 	platform_device_register_full(&devinfo);
 }
 
-static const char *imx51_dt_board_compat[] __initdata = {
+static const char *imx51_dt_board_compat[] __initconst = {
 	"fsl,imx51",
 	NULL
 };
arch/arm/mach-imx/mach-imx50.c +1 -1
index 2f74fad..77b77a9 100644
@@ -23,7 +23,7 @@ static void __init imx50_dt_init(void)
 	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
 }
 
-static const char *imx50_dt_board_compat[] __initdata = {
+static const char *imx50_dt_board_compat[] __initconst = {
 	"fsl,imx50",
 	NULL
 };
arch/arm/mach-imx/mach-imx53.c +1 -1
index c9c4d8d..6585090 100644
@@ -31,7 +31,7 @@ static void __init imx53_dt_init(void)
 	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
 }
 
-static const char *imx53_dt_board_compat[] __initdata = {
+static const char *imx53_dt_board_compat[] __initconst = {
 	"fsl,imx53",
 	NULL
 };
arch/arm/mach-imx/mach-imx6q.c +1 -1
index 7e5ec34..d2ea6e6 100644
@@ -273,7 +273,7 @@ static void __init imx6q_init_irq(void)
 	irqchip_init();
 }
 
-static const char *imx6q_dt_compat[] __initdata = {
+static const char *imx6q_dt_compat[] __initconst = {
 	"fsl,imx6dl",
 	"fsl,imx6q",
 	NULL,
arch/arm/mach-imx/mach-imx6sl.c +1 -1
index 2f952e3..cca183a 100644
@@ -61,7 +61,7 @@ static void __init imx6sl_init_irq(void)
 	irqchip_init();
 }
 
-static const char *imx6sl_dt_compat[] __initdata = {
+static const char *imx6sl_dt_compat[] __initconst = {
 	"fsl,imx6sl",
 	NULL,
 };
arch/arm/mach-imx/mach-vf610.c +1 -1
index af0cb8a..2d8aef5 100644
@@ -26,7 +26,7 @@ static void __init vf610_init_irq(void)
 	irqchip_init();
 }
 
-static const char *vf610_dt_compat[] __initdata = {
+static const char *vf610_dt_compat[] __initconst = {
 	"fsl,vf610",
 	NULL,
 };
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 ARM: imx: use __initconst for const init definition

Quoted 5 lines · Shawn Guo

0-DAY kernel build testing backend reports the following.

scripts/checkpatch.pl 0001-ARM-imx-add-support-code-for-IMX50-based-machines.patch

  # many are suggestions rather than must-fix
Quoted 8 lines

ERROR: Use of const init definition must use __initconst #80: arch/arm/mach-imx/mach-imx50.c:26:
+static const char *imx50_dt_board_compat[] __initdata = {

While at it, fix the error globally for IMX platform.

For what its worth:

Quoted 102 lines
---
  arch/arm/mach-imx/imx31-dt.c    |    2 +-
  arch/arm/mach-imx/imx51-dt.c    |    2 +-
  arch/arm/mach-imx/mach-imx50.c  |    2 +-
  arch/arm/mach-imx/mach-imx53.c  |    2 +-
  arch/arm/mach-imx/mach-imx6q.c  |    2 +-
  arch/arm/mach-imx/mach-imx6sl.c |    2 +-
  arch/arm/mach-imx/mach-vf610.c  |    2 +-
  7 files changed, 7 insertions(+), 7 deletions(-)
arch/arm/mach-imx/imx31-dt.c +1 -1
index 818a1cc..e1e70ef 100644
@@ -25,7 +25,7 @@ static void __init imx31_dt_init(void)
  	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
  }
 
-static const char *imx31_dt_board_compat[] __initdata = {
+static const char *imx31_dt_board_compat[] __initconst = {
  	"fsl,imx31",
  	NULL
  };
arch/arm/mach-imx/imx51-dt.c +1 -1
index bece8a6..0230d78 100644
@@ -29,7 +29,7 @@ static void __init imx51_dt_init(void)
  	platform_device_register_full(&devinfo);
  }
 
-static const char *imx51_dt_board_compat[] __initdata = {
+static const char *imx51_dt_board_compat[] __initconst = {
  	"fsl,imx51",
  	NULL
  };
arch/arm/mach-imx/mach-imx50.c +1 -1
index 2f74fad..77b77a9 100644
@@ -23,7 +23,7 @@ static void __init imx50_dt_init(void)
  	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
  }
 
-static const char *imx50_dt_board_compat[] __initdata = {
+static const char *imx50_dt_board_compat[] __initconst = {
  	"fsl,imx50",
  	NULL
  };
arch/arm/mach-imx/mach-imx53.c +1 -1
index c9c4d8d..6585090 100644
@@ -31,7 +31,7 @@ static void __init imx53_dt_init(void)
  	of_platform_populate(NULL, of_default_bus_match_table, NULL, NULL);
  }
 
-static const char *imx53_dt_board_compat[] __initdata = {
+static const char *imx53_dt_board_compat[] __initconst = {
  	"fsl,imx53",
  	NULL
  };
arch/arm/mach-imx/mach-imx6q.c +1 -1
index 7e5ec34..d2ea6e6 100644
@@ -273,7 +273,7 @@ static void __init imx6q_init_irq(void)
  	irqchip_init();
  }
 
-static const char *imx6q_dt_compat[] __initdata = {
+static const char *imx6q_dt_compat[] __initconst = {
  	"fsl,imx6dl",
  	"fsl,imx6q",
  	NULL,
arch/arm/mach-imx/mach-imx6sl.c +1 -1
index 2f952e3..cca183a 100644
@@ -61,7 +61,7 @@ static void __init imx6sl_init_irq(void)
  	irqchip_init();
  }
 
-static const char *imx6sl_dt_compat[] __initdata = {
+static const char *imx6sl_dt_compat[] __initconst = {
  	"fsl,imx6sl",
  	NULL,
  };
arch/arm/mach-imx/mach-vf610.c +1 -1
index af0cb8a..2d8aef5 100644
@@ -26,7 +26,7 @@ static void __init vf610_init_irq(void)
  	irqchip_init();
  }
 
-static const char *vf610_dt_compat[] __initdata = {
+static const char *vf610_dt_compat[] __initconst = {
  	"fsl,vf610",
  	NULL,
  };