Skip to contentSkip to conversation

i915: NULL pointer dereference in i915_update_dri1_breadcrumb() during shutdown

DISCUSSION Eugene Shatokhin 2 participants 3 messages Dec 10, 2013

lore
Share & tools
lore
#0 lore raw

Hi,

I have recently observed a NULL pointer dereference in i915 driver on my Eee PC running ROSA Linux with kernel 3.10.21.

The crash occurs during shutdown but quite rarely, not each time.

The system log is lost but here is what I extracted from the info displayed on the screen.

NULL pointer dereference at 0x4
EIP is at i915_update_dri1_breadcrumb+0x25/0x70
comm: systemd-journal

i915_update_dri1_breadcrumb+0x25:

	mov    0x4(%eax),%ebx // %eax contains 0, the list of register values 

confirms that.

That is the reading of 'master_priv->sarea_priv':

void i915_update_dri1_breadcrumb(struct drm_device *dev)

{
	drm_i915_private_t *dev_priv = dev->dev_private;
	struct drm_i915_master_private *master_priv;

	if (dev->primary->master) {
		master_priv = dev->primary->master->driver_priv;
		if (master_priv->sarea_priv) // <<< crashes here
			master_priv->sarea_priv->last_dispatch =
				READ_BREADCRUMB(dev_priv);
	}
}

addr2line points to the same line too.

So, i915_update_dri1_breadcrumb() was called somehow when dev->primary->master->driver_priv was NULL already. A race with i915_master_destroy() or something else?

Hardware info, from the output of lspci -vnn:
------------------------------
00:02.0 VGA compatible controller [0300]: Intel Corporation Atom Processor D4xx/D5xx/N4xx/N5xx Integrated Graphics Controller [8086:a011] (prog-if 00 [VGA controller])

	Subsystem: ASUSTeK Computer Inc. Device [1043:83ac]
	Flags: bus master, fast devsel, latency 0, IRQ 44
	Memory at f7e00000 (32-bit, non-prefetchable) [size=512K]
	I/O ports at dc00 [size=8]
	Memory at d0000000 (32-bit, prefetchable) [size=256M]
	Memory at f7d00000 (32-bit, non-prefetchable) [size=1M]
	Expansion ROM at <unassigned> [disabled]
	Capabilities: [90] MSI: Enable+ Count=1/1 Maskable- 64bit-
	Capabilities: [d0] Power Management version 2
	Kernel driver in use: i915

------------------------------

Regards,
Eugene

Signature · 2 lines
Eugene Shatokhin, ROSA Laboratory.
www.rosalab.com
#1 lore raw
Quoted 21 lines · Eugene Shatokhin

Hi,

I have recently observed a NULL pointer dereference in i915 driver on my Eee PC running ROSA Linux with kernel 3.10.21.

The crash occurs during shutdown but quite rarely, not each time.

The system log is lost but here is what I extracted from the info displayed on the screen.

NULL pointer dereference at 0x4
EIP is at i915_update_dri1_breadcrumb+0x25/0x70
comm: systemd-journal

i915_update_dri1_breadcrumb+0x25:

	mov    0x4(%eax),%ebx // %eax contains 0, the list of register

values confirms that.

That is the reading of 'master_priv->sarea_priv':

void i915_update_dri1_breadcrumb(struct drm_device *dev)

Quoted 11 lines
{
	drm_i915_private_t *dev_priv = dev->dev_private;
	struct drm_i915_master_private *master_priv;

	if (dev->primary->master) {
		master_priv = dev->primary->master->driver_priv;
		if (master_priv->sarea_priv) // <<< crashes here
			master_priv->sarea_priv->last_dispatch =
				READ_BREADCRUMB(dev_priv);
	}
}

Indeed, that's fairly hapzardous. But also only needed for legacy ums support. I'll send out a patch to block this in kms mode quickly. Please test it.

Thanks, Daniel

Quoted 30 lines

addr2line points to the same line too.

So, i915_update_dri1_breadcrumb() was called somehow when dev->primary->master->driver_priv was NULL already. A race with i915_master_destroy() or something else?

Hardware info, from the output of lspci -vnn:
------------------------------
00:02.0 VGA compatible controller [0300]: Intel Corporation Atom Processor D4xx/D5xx/N4xx/N5xx Integrated Graphics Controller [8086:a011] (prog-if 00 [VGA controller])

	Subsystem: ASUSTeK Computer Inc. Device [1043:83ac]
	Flags: bus master, fast devsel, latency 0, IRQ 44
	Memory at f7e00000 (32-bit, non-prefetchable) [size=512K]
	I/O ports at dc00 [size=8]
	Memory at d0000000 (32-bit, prefetchable) [size=256M]
	Memory at f7d00000 (32-bit, non-prefetchable) [size=1M]
	Expansion ROM at <unassigned> [disabled]
	Capabilities: [90] MSI: Enable+ Count=1/1 Maskable- 64bit-
	Capabilities: [d0] Power Management version 2
	Kernel driver in use: i915

------------------------------

Regards,
Eugene

Signature · 2 lines
Eugene Shatokhin, ROSA Laboratory.
www.rosalab.com
Signature · 3 lines
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
#2 lore raw
Quoted 34 lines · Daniel Vetter
Quoted 21 lines · Eugene Shatokhin

Hi,

I have recently observed a NULL pointer dereference in i915 driver on my Eee PC running ROSA Linux with kernel 3.10.21.

The crash occurs during shutdown but quite rarely, not each time.

The system log is lost but here is what I extracted from the info displayed on the screen.

NULL pointer dereference at 0x4
EIP is at i915_update_dri1_breadcrumb+0x25/0x70
comm: systemd-journal

i915_update_dri1_breadcrumb+0x25:

	mov    0x4(%eax),%ebx // %eax contains 0, the list of register

values confirms that.

That is the reading of 'master_priv->sarea_priv':

void i915_update_dri1_breadcrumb(struct drm_device *dev)

Quoted 11 lines
{
	drm_i915_private_t *dev_priv = dev->dev_private;
	struct drm_i915_master_private *master_priv;

	if (dev->primary->master) {
		master_priv = dev->primary->master->driver_priv;
		if (master_priv->sarea_priv) // <<< crashes here
			master_priv->sarea_priv->last_dispatch =
				READ_BREADCRUMB(dev_priv);
	}
}
Quoted 5 lines

Indeed, that's fairly hapzardous. But also only needed for legacy ums support. I'll send out a patch to block this in kms mode quickly. Please test it.

Thanks, Daniel

Thanks a lot!

I am building kernel 3.10.23 now with this patch applied and will let you know if something goes wrong.

Regards,
Eugene

Signature · 2 lines
Eugene Shatokhin, ROSA Laboratory.
www.rosalab.com