Skip to contentSkip to conversation

logfs: Check for the return value after calling find_or_create_page()

PATCH New Younger Liu 1 participant 1 message Dec 11, 2013 VFS

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 logfs: Check for the return value after calling find_or_create_page()

From: Younger Liu <[email protected]>

In get_mapping_page(), after calling find_or_create_page(),
the return value should be checked.

This patch has been provided:
http://www.spinics.net/lists/linux-fsdevel/msg66948.html
but not been applied now.

---
 fs/logfs/segment.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
fs/logfs/segment.c +0 -0
index d448a77..7f9b096 100644
@@ -62,7 +62,8 @@ static struct page *get_mapping_page(struct

super_block *sb, pgoff_t index,
page = read_cache_page(mapping, index, filler, sb);
else {
page = find_or_create_page(mapping, index, GFP_NOFS);
- unlock_page(page);
+ if (page)
+ unlock_page(page);
}
return page;
}

Signature · 1 line
1.7.9.5