gpiolib, sfi: introduce SFI GPIO helpers
v6 cover gpiolib, sfi: introduce SFI GPIO helpers
Here is a sixth [1] version of the SFI GPIO helpers. This series contains SFI GPIO helpers along with the update of GPIO library to lookup for SFI resources.
It has been tested on Medfield device on top of recent linux-next-20131210 + Mika's ACPI gpio patches [2].
Changes since v6:
- remove FSF address
- require dev to be NULL when looking up for GPIO line
[1] https://lkml.org/lkml/2013/6/5/316
[2] http://www.spinics.net/lists/linux-acpi/msg47572.html
Andy Shevchenko (2):
SFI: store GPIO table and export lookup function
gpiolib: append SFI helpers for GPIO API
drivers/gpio/Kconfig | 4 ++ drivers/gpio/Makefile | 1 + drivers/gpio/gpiolib-sfi.c | 27 +++++++++++ drivers/gpio/gpiolib.c | 3 ++ drivers/gpio/gpiolib.h | 13 +++++ drivers/sfi/Makefile | 2 +- drivers/sfi/sfi_core.c | 6 +++ drivers/sfi/sfi_core.h | 3 ++ drivers/sfi/sfi_gpio.c | 115 +++++++++++++++++++++++++++++++++++++++++++++ include/linux/sfi.h | 10 ++++ 10 files changed, 183 insertions(+), 1 deletion(-) create mode 100644 drivers/gpio/gpiolib-sfi.c create mode 100644 drivers/sfi/sfi_gpio.c
Signature · 1 line
1.8.4.4
PATCH v6 1/2 SFI: store GPIO table and export lookup function
We have to provide a mechanism to retrive GPIO information from SFI. For this we store SFI GPIO table and provide the lookup function sfi_gpio_get_entry_by_name() that will be used later in GPIO framework.
--- drivers/sfi/Makefile | 2 +- drivers/sfi/sfi_core.c | 6 +++ drivers/sfi/sfi_core.h | 3 ++ drivers/sfi/sfi_gpio.c | 115 +++++++++++++++++++++++++++++++++++++++++++++++++ include/linux/sfi.h | 10 +++++ 5 files changed, 135 insertions(+), 1 deletion(-) create mode 100644 drivers/sfi/sfi_gpio.c
drivers/sfi/Makefile +1 -1
@@ -1,3 +1,3 @@ obj-y += sfi_acpi.o obj-y += sfi_core.o - +obj-y += sfi_gpio.o
drivers/sfi/sfi_core.c +6 -0
@@ -512,6 +512,12 @@ void __init sfi_init_late(void) syst_va =sfi_map_memory (syst_pa, length);sfi_acpi_init (); + +/* +* Parsing GPIO table first, since the DEVS table will need this table +* to map the pin name to the actual pin. +*/ +sfi_gpio_init (); }/*
drivers/sfi/sfi_core.h +3 -0
@@ -79,3 +79,6 @@ struct sfi_table_header *sfi_get_table(struct sfi_table_key *key);extern void sfi_put_table (struct sfi_table_header *table);extern struct sfi_table_attr __init *sfi_sysfs_install_table (u64 pa);extern void __init sfi_acpi_sysfs_init (void ); + +/* sfi_gpio.c */ +int sfi_gpio_init (void );
drivers/sfi/sfi_gpio.c new file +115 -0
115 lines not on this page · raw message
include/linux/sfi.h +10 -0
@@ -61,6 +61,8 @@#include <linux/init.h> #include <linux/types.h> +#include <linux/errno.h> +#include <linux/err.h> /* Table signatures reserved by the SFI specification */ #define SFI_SIG_SYST "SYST"
@@ -185,6 +187,8 @@ static inline void disable_sfi(void) sfi_disabled = 1; } +struct sfi_gpio_table_entry *sfi_gpio_get_entry_by_name (const char *name); +#else /* !CONFIG_SFI */ static inline void sfi_init (void )
@@ -204,6 +208,12 @@ static inline int sfi_table_parse(char *signature, char *oem_id,return -1 ; } +static inline +struct sfi_gpio_table_entry *sfi_gpio_get_entry_by_name (const char *name) +{ +return ERR_PTR (-ENODEV ); +} +#endif /* !CONFIG_SFI */ #endif /*_LINUX_SFI_H*/
Signature · 1 line
1.8.4.4
PATCH v6 2/2 gpiolib: append SFI helpers for GPIO API
In reply to Andy ShevchenkoTo support some (legacy) firmwares and platforms let's make life easier for their customers.
This patch provides a function which converts sfi_gpio_table_entry to gpio_desc. The use of it is integrated into GPIO library to enable generic access to the SFI GPIO resources.
--- drivers/gpio/Kconfig | 4 ++++ drivers/gpio/Makefile | 1 + drivers/gpio/gpiolib-sfi.c | 27 +++++++++++++++++++++++++++ drivers/gpio/gpiolib.c | 3 +++ drivers/gpio/gpiolib.h | 13 +++++++++++++ 5 files changed, 48 insertions(+) create mode 100644 drivers/gpio/gpiolib-sfi.c
drivers/gpio/Kconfig +4 -0
@@ -51,6 +51,10 @@ config OF_GPIO def_bool y depends on OF +config GPIO_SFI + def_bool y + depends on SFI + config GPIO_ACPI def_bool y depends on ACPI
drivers/gpio/Makefile +1 -0
@@ -5,6 +5,7 @@ ccflags-$(CONFIG_DEBUG_GPIO) += -DDEBUG obj-$(CONFIG_GPIO_DEVRES) += devres.o obj-$(CONFIG_GPIOLIB) += gpiolib.o obj-$(CONFIG_OF_GPIO) += gpiolib-of.o +obj-$(CONFIG_GPIO_SFI) += gpiolib-sfi.o obj-$(CONFIG_GPIO_ACPI) += gpiolib-acpi.o # Device drivers. Generally keep list sorted alphabetically
drivers/gpio/gpiolib-sfi.c new file +27 -0
@@ -0,0 +1,27 @@ +/* +* Simple Firmware Interface (SFI) helpers for GPIO API +* +* Copyright (C) 2013, Intel Corporation +* Author: Andy Shevchenko <[email protected]> +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License version 2 as +* published by the Free Software Foundation. +*/ + +#include <linux/gpio/consumer.h> +#include <linux/sfi.h> +#include <linux/err.h> + +#include "gpiolib.h" + +struct gpio_desc *sfi_get_gpiod_by_name (const char *name) +{ +struct sfi_gpio_table_entry *pentry; + + pentry =sfi_gpio_get_entry_by_name (name); +if (IS_ERR (pentry)) +return ERR_CAST (pentry); + +return gpio_to_desc (pentry->pin_no); +}
drivers/gpio/gpiolib.c +3 -0
@@ -2452,6 +2452,9 @@ struct gpio_desc *__must_check gpiod_get_index(struct device *dev, }else if (IS_ENABLED (CONFIG_ACPI ) && dev &&ACPI_HANDLE (dev)) {dev_dbg (dev,"using ACPI for GPIO lookup\n" ); desc =acpi_find_gpio (dev, con_id, idx, &flags); + }else if (IS_ENABLED (CONFIG_SFI ) && !dev) { +dev_dbg (dev,"using SFI for GPIO lookup\n" ); + desc =sfi_get_gpiod_by_name (con_id); }/*
drivers/gpio/gpiolib.h +13 -0
@@ -43,4 +43,17 @@ acpi_get_gpiod_by_index(struct device *dev, int index, }#endif +#ifdef CONFIG_GPIO_SFI + +struct gpio_desc *sfi_get_gpiod_by_name (const char *name); + +#else /* !CONFIG_GPIO_SFI */ + +static inline struct gpio_desc *sfi_get_gpiod_by_name (const char *name) +{ +return ERR_PTR (-ENODEV ); +} + +#endif /* !CONFIG_GPIO_SFI */ +#endif /* GPIOLIB_H */
Signature · 1 line
1.8.4.4
Quoted 9 lines · Andy Shevchenko
Here is a sixth [1] version of the SFI GPIO helpers. This series contains SFI GPIO helpers along with the update of GPIO library to lookup for SFI resources.
It has been tested on Medfield device on top of recent linux-next-20131210 + Mika's ACPI gpio patches [2].
Changes since v6:
- remove FSF address
- require dev to be NULL when looking up for GPIO line
Since my concerns about lookup by non-platform code have been lifted:
Quoted 5 lines · Andy Shevchenko
Here is a sixth [1] version of the SFI GPIO helpers. This series contains SFI GPIO helpers along with the update of GPIO library to lookup for SFI resources.
It has been tested on Medfield device on top of recent linux-next-20131210 + Mika's ACPI gpio patches [2].
This is still stalled due to no response from the SFI maintainer, Len can you please look at this series, if you ACK them I'm happy to take the whole series through the GPIO tree.
Yours,
Linus Walleij
Quoted 6 lines · Linus Walleij
Quoted 3 lines · Andy Shevchenko
Here is a sixth [1] version of the SFI GPIO helpers. This series contains SFI GPIO helpers along with the update of GPIO library to lookup for SFI resources.
Quoted 6 lines
Quoted 2 lines
It has been tested on Medfield device on top of recent linux-next-20131210 + Mika's ACPI gpio patches [2].
This is still stalled due to no response from the SFI maintainer, Len can you please look at this series, if you ACK them I'm happy to take the whole series through the GPIO tree.
Ping on this.
Yours,
Linus Walleij