Skip to contentSkip to conversation

netbsd:fix documentation typo.

PATCH New Kees Jongenburger 4 participants 4 messages Dec 9, 2013 – Dec 12, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 netbsd:fix documentation typo.

From: Kees Jongenburger <[email protected]>

The documentation suggested the arguments where passed over r3-r6 while the code bellow simply does that over r0-r3.

Cc Kumar Gala <[email protected]>
---
 common/cmd_bootm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
common/cmd_bootm.c +4 -4
index ba73f57..084c0e9 100644
@@ -1531,10 +1531,10 @@ static int do_bootm_netbsd(int flag, int argc, char * const argv[],
 
 	/*
 	 * NetBSD Stage-2 Loader Parameters:
-	 *   r3: ptr to board info data
-	 *   r4: image address
-	 *   r5: console device
-	 *   r6: boot args string
+	 *   r0: ptr to board info data
+	 *   r1: image address
+	 *   r3: console device
+	 *   r3: boot args string
 	 */
 	(*loader)(gd->bd, os_hdr, consdev, cmdline);
 
Signature · 1 line
1.8.3.2
#1 lore raw

PATCH 1/1 netbsd:fix documentation typo.

Quoted 8 lines

-----Original Message-----
From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Kees Jongenburger
Sent: 09 December 2013 10:28
To: u-boot at lists.denx.de
Cc: Kees Jongenburger; Kumar Gala
Subject: [U-Boot] [PATCH] netbsd:fix documentation typo.

Quoted 4 lines

From: Kees Jongenburger <[email protected]>

The documentation suggested the arguments where passed over r3-r6 while the code bellow simply does that over r0-r3.

s/bellow/below/

Quoted 12 lines
Cc Kumar Gala <[email protected]>
---
 common/cmd_bootm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
common/cmd_bootm.c index renamed from common/cmd_bootm.c +0 -0

ba73f57..084c0e9 100644

common/cmd_bootm.c +0 -0
@@ -1531,10 +1531,10 @@ static int do_bootm_netbsd(int flag, int argc, char *
 const argv[],

common/cmd_bootm.c static int do_bootm_netbsd(int flag, int argc, char * · line 1537

Quoted 10 lines
common/cmd_bootm.c +3 -4
 
 	/*
 	 * NetBSD Stage-2 Loader Parameters:
-	 *   r3: ptr to board info data
-	 *   r4: image address
-	 *   r5: console device
-	 *   r6: boot args string
+	 *   r0: ptr to board info data
+	 *   r1: image address
+	 *   r3: console device

You mean r2 here I believe.

Qais

Quoted 11 lines
common/cmd_bootm.c +1 -1
+	 *   r3: boot args string
 	 */
 	(*loader)(gd->bd, os_hdr, consdev, cmdline);
 
--

1.8.3.2

_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

#2 lore raw

PATCH 1/1 netbsd:fix documentation typo.

In reply to Kees Jongenburger

hi Kees,

Quoted 16 lines · Kees Jongenburger

From: Kees Jongenburger <[email protected]>

The documentation suggested the arguments where passed over r3-r6 while the code bellow simply does that over r0-r3.

Cc Kumar Gala <[email protected]>
---
 common/cmd_bootm.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
common/cmd_bootm.c +0 -0
index ba73f57..084c0e9 100644
@@ -1531,10 +1531,10 @@ static int do_bootm_netbsd(int flag, int argc, char * const argv[],
 

common/cmd_bootm.c static int do_bootm_netbsd(int flag, int argc, char * const argv[], · line 1537

Quoted 10 lines
common/cmd_bootm.c +4 -4
 	/*
 	 * NetBSD Stage-2 Loader Parameters:
-	 *   r3: ptr to board info data
-	 *   r4: image address
-	 *   r5: console device
-	 *   r6: boot args string
+	 *   r0: ptr to board info data
+	 *   r1: image address
+	 *   r3: console device
+	 *   r3: boot args string

Umm, is this not supposed to be processor agnostic -- different architectures would use different registers to pass these arguments. I would suggest changing it to something like arg[0-3] instead.

-sughosh

#3 lore raw

PATCH 1/1 netbsd:fix documentation typo.

Hi,

Quoted 11 lines · Sughosh Ganu

hi Kees,

* NetBSD Stage-2 Loader Parameters:

common/cmd_bootm.c +4 -4
-	 *   r3: ptr to board info data
-	 *   r4: image address
-	 *   r5: console device
-	 *   r6: boot args string
+	 *   r0: ptr to board info data
+	 *   r1: image address
+	 *   r3: console device
+	 *   r3: boot args string
Quoted 3 lines

Umm, is this not supposed to be processor agnostic -- different architectures would use different registers to pass these arguments. I would suggest changing it to something like arg[0-3] instead.

Thanks for the feedback. I will wait a little more and update the patch.

Greetings