gst-fsl-plugin: Fix that enables mfw_isink work by default.
PATCH 1/1 gst-fsl-plugin: Fix that enables mfw_isink work by default.
vssconfig by default has fb_num configured to 1, but the value must be set to 2 for isink to work properly.
Note, that VSALPHA still must be set manually.
--- ...ault-framebuffer-number-to-2-in-vssconfig.patch | 25 ++++++++++++++++++++++ .../gstreamer/gst-fsl-plugin_3.0.9.bb | 3 ++- 2 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 recipes-multimedia/gstreamer/gst-fsl-plugin/change-default-framebuffer-number-to-2-in-vssconfig.patch
recipes-multimedia/gstreamer/gst-fsl-plugin/change-default-framebuffer-number-to-2-in-vssconfig.patch new file +25 -0
@@ -0,0 +1,25 @@ +From a8c79cad10bc405f261fc23cb51eafa5e8a3e4e2 Mon Sep 17 00:00:00 2001 +From: =?UTF-8?q?J=C4=81nis=20=C4=8Coders?= <[email protected]> +Date: Mon, 25 Nov 2013 10:41:27 +0200 +Subject: [PATCH] change default framebuffer number to 2 in vssconfig + +- This change is needed so that mfw_isink would work by default. +--- + libs/vss/vssconfig | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/libs/vss/vssconfig b/libs/vss/vssconfig +index 0bd2a3d..0ff7fd0 100755 +--- a/libs/vss/vssconfig ++++ b/libs/vss/vssconfig +@@ -5,6 +5,6 @@ + [master] + type = framebuffer + format = RGBP +-fb_num = 1 ++fb_num = 2 + main_fb_num = 0 + +-- +1.8.4.4 +
recipes-multimedia/gstreamer/gst-fsl-plugin_3.0.9.bb +2 -1
@@ -6,7 +6,8 @@ require gst-fsl-plugin.inc # FIXME: Inspecting the source code the content is in fact 3.0.9 SRC_URI = "${FSL_MIRROR}/gst-fsl-plugins-3.10.9-1.0.0.tar.gz \ file://remove-GST_INFO-in-mfw_gst_utils.h.patch \ - file://configure.ac-Fix-checking-for-include-headers-in-mul.patch" + file://configure.ac-Fix-checking-for-include-headers-in-mul.patch \ + file://change-default-framebuffer-number-to-2-in-vssconfig.patch" SRC_URI[md5sum] = "a338a5c25225c765ae5f44af82fe7413" SRC_URI[sha256sum] = "e809daa0cd60381f05a79f34a53305a5ee53bfed22192a1cda6d998acc84a6fd"
Signature · 1 line
1.8.4.4
Hello Janis,
Thanks for sending the patch.
Quoted 6 lines · Jānis Čoders
vssconfig by default has
fb_numconfigured to 1, but the value must be set to 2 for isink to work properly.Note, that VSALPHA still must be set manually.
Signed-off-by Jānis Čoders <[email protected]>
Lauren, please review this patch and ack/nack it. As I am not a multimedia guy I don't feel confortable in acking it as I don't know the implications for users of this change. Please let me know your thoughts.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Quoted 8 lines · Otavio Salvador
Hello Janis,
Thanks for sending the patch.
Quoted 3 lines · Jānis Čoders
vssconfig by default has
fb_numconfigured to 1, but the value must be set to 2 for isink to work properly.
Quoted 9 lines
Quoted 3 lines
Note, that VSALPHA still must be set manually.
Signed-off-by Jānis Čoders <[email protected]>Lauren, please review this patch and ack/nack it. As I am not a multimedia guy I don't feel confortable in acking it as I don't know the implications for users of this change. Please let me know your thoughts.
Janis, what target did you use for testing the patch?
Signature · 1 line
Daiane
I used board based on QSB - imx53.
Quoted 29 lines · Daiane Angolini
Quoted 12 lines · Otavio Salvador
Hello Janis,
Thanks for sending the patch.
Quoted 5 lines · Jānis Čoders
vssconfig by default has
fb_numconfigured to 1, but the value must be set to 2 for isink to work properly.Note, that VSALPHA still must be set manually.
Quoted 9 lines
Quoted 2 lines
Signed-off-by Jānis Čoders <[email protected]>Lauren, please review this patch and ack/nack it. As I am not a multimedia guy I don't feel confortable in acking it as I don't know the implications for users of this change. Please let me know your thoughts.
Janis, what target did you use for testing the patch?
--
Daiane
Signature · 2 lines
Ar cieņu, Jānis Čoders
Quoted 1 line · Jānis Čoders
I used board based on QSB - imx53.
I think your patch breaks imx6. Are you available to test it on any imx6 board?
Otherwise, I will try to test it next week, before we merge the patch
Daiane
Quoted 41 lines
On 13 December 2013 13:37, Daiane Angolini <[email protected] <mailto:[email protected]>> wrote:
On 25-11-2013 09:22, Otavio Salvador wrote:
Hello Janis,
Thanks for sending the patch.
On Mon, Nov 25, 2013 at 8:42 AM, Jānis Čoders <[email protected] <mailto:[email protected]>> wrote:
vssconfig by default has
fb_numconfigured to 1, but the value must be set to 2 for isink to work properly.Note, that VSALPHA still must be set manually.
Signed-off-by Jānis Čoders <[email protected]<mailto:[email protected]>>
Lauren, please review this patch and ack/nack it. As I am not a multimedia guy I don't feel confortable in acking it as I don't know the implications for users of this change. Please let me know your thoughts.
Janis, what target did you use for testing the patch?
--
Daiane--
Ar cieņu,
Jānis Čoders
Signature · 1 line
Daiane
No, unfortunately I don't have imx6 based board. And yeah, I hoped someone could test this on imx6.
Quoted 64 lines · Daiane Angolini
Quoted 2 lines · Jānis Čoders
I used board based on QSB - imx53.
I think your patch breaks imx6. Are you available to test it on any imx6 board?
Otherwise, I will try to test it next week, before we merge the patch
Daiane
Quoted 41 lines
On 13 December 2013 13:37, Daiane Angolini <[email protected] <mailto:[email protected]>>
wrote:
On 25-11-2013 09:22, Otavio Salvador wrote:
Hello Janis,
Thanks for sending the patch.
On Mon, Nov 25, 2013 at 8:42 AM, Jānis Čoders <[email protected] <mailto:[email protected]>> wrote:
vssconfig by default has
fb_numconfigured to 1, but the value must be set to 2 for isink to work properly.Note, that VSALPHA still must be set manually.
Signed-off-by Jānis Čoders <[email protected]<mailto:[email protected]>>
Lauren, please review this patch and ack/nack it. As I am not a multimedia guy I don't feel confortable in acking it as I don't
know
the implications for users of this change. Please let me know your thoughts.Janis, what target did you use for testing the patch?
--
DaianeQuoted 4 lines
--
Ar cieņu,
Jānis Čoders--
Daiane
Signature · 2 lines
Ar cieņu, Jānis Čoders
Quoted 11 lines
-----Original Message-----
From: [email protected] [mailto:meta-freescale- [email protected]] On Behalf Of Daiane Angolini
Sent: Friday, December 13, 2013 2:49 PM
To: Jānis Čoders
Cc: [email protected]; Otavio Salvador
Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH] gst-fsl-plugin: Fix that enablesmfw_isinkwork by default.
Quoted 7 lines
Quoted 1 line · Jānis Čoders
I used board based on QSB - imx53.
I think your patch breaks imx6. Are you available to test it on any imx6 board?
Otherwise, I will try to test it next week, before we merge the patch
I just tested this patch and it hurts imx6 (please, see error attached)
I propose to open a BUG in bugzilla and apply the patch only for mx5 boards, with a #FIXME tag pointing to BUG number.
The error must be fixed properly for 'all boards', however we do have a workaround Today that may help people.
What do you think?
Daiane
Quoted 49 lines
Daiane
Quoted 8 lines
On 13 December 2013 13:37, Daiane Angolini <[email protected] <mailto:[email protected]>> wrote:
On 25-11-2013 09:22, Otavio Salvador wrote:
Quoted 8 lines
Hello Janis,
Thanks for sending the patch.
On Mon, Nov 25, 2013 at 8:42 AM, Jānis Čoders <[email protected] <mailto:[email protected]>> wrote:
vssconfig by default has
fb_numconfigured to 1, but thevalue
Quoted 10 lines
must be set to 2 for isink to work properly.
Note, that VSALPHA still must be set manually.
Signed-off-by Jānis Čoders <[email protected]<mailto:[email protected]>>
Lauren, please review this patch and ack/nack it. As I am not a multimedia guy I don't feel confortable in acking it as I don't
know
Quoted 1 line
the implications for users of this change. Please let me know
your
Quoted 11 lines
thoughts.
Janis, what target did you use for testing the patch?
--
DaianeQuoted 3 lines
--
Ar cieņu,
Jānis Čoders
Quoted 7 lines
--
Daiane_______________________________________________
meta-freescale mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-freescale
eps1_4.451mbps_30fps_720_L3B2_cut.avi ! decodebin ! mfw_isinkedia/sda1/StarWars_ MAX resolution 1024x768
set color keyMFW_GST_ISINK_PLUGIN 3.0.9 build on Jan 7 2014 11:52:33.
Setting pipeline to PAUSED ...
Pipeline is PREROLLING ...
Aiur: 3.0.9
Core: AVI_PARSER_03.05.07 build on Aug 28 2013 10:17:26
mime: video/x-msvideo
file: /usr/lib/imx-mm/parser/lib_avi_parser_arm11_elinux.so.3.1
Content Info:
URI:
file:///media/sda1/StarWars_eps1_4.451mbps_30fps_720_L3B2_cut.avi
Idx File:
/home/root/.aiur/.media.sda1.StarWars_eps1_4.451mbps_30fps_720_L3B2_cut.avi.aidx
Seekable : Yes
Size(byte): 6394986Movie Info:
Seekable : Yes
Live : No
Duration : 0:00:16.683333000
ReadMode : Track
Track : 2Track 00 [video_000000] Enabled
Duration: 0:00:16.683333000
Language: und
Mime:
video/x-h264, parsed=(boolean)true, width=(int)720, height=(int)480, framerate=(
fraction)30000/1001
[INFO] Product Info: i.MX6Q/D/S
vpudec versions :)
plugin: 3.0.9
wrapper: 1.0.40(VPUWRAPPER_ARM_LINUX Build on Jan 7 2014 11:30:13)
vpulib: 5.4.18
firmware: 2.3.10.40778
Track 01 [audio_000000] Enabled
Duration: 0:00:16.650000000
Language: und
Mime:
audio/mpeg, mpegversion=(int)1, framed=(boolean)true, channels=(int)2, rate=(int
)48000, bitrate=(int)128000[INFO] bitstreamMode 1, chromaInterleave 1, mapType 0, tiled2LinearEnable 0
hwbuf allocator zone(520192) created
Beep: 3.0.9
Core: MP3 decoder Wrapper build on Aug 29 2013 13:37:52
mime: audio/mpeg, mpegversion = (int)1
file: /usr/lib/imx-mm/audio-codec/wrap/lib_mp3d_wrap_arm12_elinux.so.3
CODEC: BLN_MAD-MMCODECS_MP3D_ARM_02.13.00_CORTEX-A8 build on Dec 5 2012 09:45:19.
can not create threadmmxc_sdc_fb mxc_sdc_fb.1: Should use the overlay framebuffer to set the position of the overlay window fw_gst_isink_setcaps:1489
Pipeline is PREROLLED ...
Setting pipeline to PLAYING ...
VS0 created. in fmt[NV12] win(0,0-720,480:720x480) out win(0,0-mxc_sdc_fb mxc_sdc_fb.1: Should use the overlay framebuffer to set the position of the overlay window 1024,768:1024x768)
New clock: GstSystemClockvss/mfw_gst_vss_common.c:701 ioctl error, return -1vss/mfw_gst_vss_common.c:726 ioctl error, return -1vss/mfw_gst_vss_common.c:593 ioctl error, return -1
set deinterlace mode 0
Got EOS from element "pipeline0".
Execution ended after 16663865002 ns.
Setting pipeline to PAUSED ...
Setting pipeline to READY ...
Setting pipeline to NULL ...vss/mfw_gst_vss_common.c:760 ioctl error, return -1
VS0 destroyed, force=0!
hwbuf allocator zone(520192) destroied.
[--->FINALIZE aiurdemux
Freeing pipeline ...
[--->FINALIZE isink
Quoted 25 lines · On Mon, Jan 13, 2014 at 11:06 AM, [email protected] <…
Quoted 11 lines
-----Original Message-----
From: [email protected] [mailto:meta-freescale- [email protected]] On Behalf Of Daiane Angolini
Sent: Friday, December 13, 2013 2:49 PM
To: Jānis Čoders
Cc: [email protected]; Otavio Salvador
Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH] gst-fsl-plugin: Fix that enablesmfw_isinkwork by default.Quoted 7 lines
Quoted 1 line · Jānis Čoders
I used board based on QSB - imx53.
I think your patch breaks imx6. Are you available to test it on any imx6 board?
Otherwise, I will try to test it next week, before we merge the patch
I just tested this patch and it hurts imx6 (please, see error attached)
I propose to open a BUG in bugzilla and apply the patch only for mx5 boards,
with a #FIXME tag pointing to BUG number.
Quoted 6 lines
The error must be fixed properly for 'all boards', however we do have a workaround
Today that may help people.What do you think?
I agree.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Quoted 38 lines · Otavio Salvador
On Mon, Jan 13, 2014 at 11:06 AM, [email protected] <mailto:[email protected]> <[email protected] <mailto:[email protected]>> wrote:
> -----Original Message-----
> From: [email protected]
<mailto:[email protected]> [mailto:meta-freescale- <mailto:meta-freescale->
> [email protected] <mailto:[email protected]>] On
Behalf Of Daiane Angolini
> Sent: Friday, December 13, 2013 2:49 PM
> To: Jānis Čoders
> Cc: [email protected]
<mailto:[email protected]>; Otavio Salvador
> Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH]
gst-fsl-plugin: Fix
> that enablesmfw_isinkwork by default.
>
> On 13-12-2013 14:44, Jānis Čoders wrote:
> > I used board based on QSB - imx53.
>
> I think your patch breaks imx6. Are you available to test it on
any imx6
> board?
>
> Otherwise, I will try to test it next week, before we merge the patchI just tested this patch and it hurts imx6 (please, see error attached)
I propose to open a BUG in bugzilla and apply the patch only for mx5 boards,
with a #FIXME tag pointing to BUG number.
Quoted 8 lines
The error must be fixed properly for 'all boards', however we do have a workaround
Today that may help people.What do you think?
I agree.
Janis, do you think it's a good solution to you? Would you mind to create the BUG and re-send the patch?
Regards,
Daiane
Quoted 5 lines
--
Otavio SalvadorO.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Signature · 1 line
Daiane
Hello Janis,
Quoted 6 lines · Jānis Čoders
vssconfig by default has
fb_numconfigured to 1, but the value must be set to 2 for isink to work properly.Note, that VSALPHA still must be set manually.
Signed-off-by Jānis Čoders <[email protected]>
Did you create the bugzilla bug about this issue? I have this patch marked as pending in my side awaiting for the bug number.
In case you didn't, please add the link for the patchwork:
http://patchwork.openembedded.org/patch/62279/
I just marked it as Not Applicable.
Signature · 3 lines
Otavio Salvador O.S. Systems http://www.ossystems.com.br http://code.ossystems.com.br Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
Hi,
I am using Dora branch and when I changed fb_num as 2, I started getting lots of errors like below. I am using nitrogen6X. /usr/share/vssconfig
# vss device definition # Singel display
# master display [master] type = framebuffer format = RGBP fb_num = 2 main_fb_num = 0
saved, sync , reboot,
export VSALPHA=1
vss/mfw_gst_vss_common.c:521 ioctl error, return -1
createVideoSurface: error config! vss/mfw_gst_vss_common.c:521 ioctl error, return -1
createVideoSurface: error config!
..............
Please advise.
Thanks
Alok
Quoted 29 lines · Otavio Salvador
Hello Janis,
Quoted 6 lines · Jānis Čoders
vssconfig by default has
fb_numconfigured to 1, but the value must be set to 2 for isink to work properly.Note, that VSALPHA still must be set manually.
Signed-off-by Jānis Čoders <[email protected]>Did you create the bugzilla bug about this issue? I have this patch marked as pending in my side awaiting for the bug number.
In case you didn't, please add the link for the patchwork:
http://patchwork.openembedded.org/patch/62279/
I just marked it as Not Applicable.
--
Otavio SalvadorO.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9981-7854 Mobile: +1 (347) 903-9750
_______________________________________________
meta-freescale mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-freescale
Signature · 2 lines
Regards Alok Kumar
Re: vssconfig (was [meta-fsl-arm][PATCH] gst-fsl-plugin: Fix that enables mfw_isink work by default)
Hi Alok,
Quoted 10 lines · Alok Kumar
Hi,
I am using Dora branch and when I changed
fb_numas 2, I started getting lots of errors like below. I am using nitrogen6X./usr/share/vssconfig# vss device definition # Singel display
Quoted 6 lines
# master display [master] type = framebuffer format = RGBP fb_num = 2 main_fb_num = 0
What are you after here? I think fb_num=2 would point at a second display.
On i.MX5x, /dev/fb2 was a YUV overlay, but on i.MX6, this is /dev/fb1
Please advise,
Eric
Re: vssconfig (was [meta-fsl-arm][PATCH] gst-fsl-plugin: Fix that enables mfw_isink work by default)
ohh my bad, I thought for i.MX6 we should be using /dev/fb2 for better performance on mfw_isink. I am sorry I did not read through completely.
mfw_isink is working ok for /dev/fb1 for imx6 (nitrogen6x). video playback seems ok.
Quoted 33 lines · Eric Nelson
Hi Alok,
Quoted 10 lines · Alok Kumar
Hi,
I am using Dora branch and when I changed
fb_numas 2, I started getting lots of errors like below. I am using nitrogen6X./usr/share/vssconfig# vss device definition # Singel displayQuoted 7 lines
# master display [master] type = framebuffer format = RGBP
fb_num= 2main_fb_num= 0What are you after here? I think fb_num=2 would point at a second display.
On i.MX5x,
/dev/fb2was a YUV overlay, but on i.MX6, this is/dev/fb1Please advise,
Eric
Signature · 2 lines
Regards Alok Kumar