ARM: tegra: fix pinctrl misconfiguration on Venic2
Subsystems (2)
PATCH v2 1/1 ARM: tegra: fix pinctrl misconfiguration on Venic2
From: Stephen Warren <[email protected]>
Other boards use PULL_NONE for their debug UART pins, and without this change, the board doesn't accept any serial input.
Don't set the I2S port pins to tristate mode, or no audio signal will be sent out.
---
v2: Added fix for I2S port.
Laxman, can you please go through the whole pinctrl configuration for Venice2 and make sure it's correct. Perhaps the best approach would be to compare it against our downstream kernels for this board.
--- arch/arm/boot/dts/tegra124-venice2.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
arch/arm/boot/dts/tegra124-venice2.dts +2 -2
@@ -40,7 +40,7 @@ nvidia,function = "i2s1"; nvidia,enable-input = <TEGRA_PIN_ENABLE>; nvidia,pull = <TEGRA_PIN_PULL_NONE>; - nvidia,tristate = <TEGRA_PIN_ENABLE>; + nvidia,tristate = <TEGRA_PIN_DISABLE>; }; dvfs_pwm_px0 { nvidia,pins = "dvfs_pwm_px0";
@@ -250,7 +250,7 @@ "pu3"; nvidia,function = "uarta"; nvidia,enable-input = <TEGRA_PIN_ENABLE>; - nvidia,pull = <TEGRA_PIN_PULL_UP>; + nvidia,pull = <TEGRA_PIN_PULL_NONE>; nvidia,tristate = <TEGRA_PIN_DISABLE>; }; uart2_cts_n_pj5 {
Signature · 1 line
1.8.1.5
PATCH v2 1/1 ARM: tegra: fix pinctrl misconfiguration on Venic2
Quoted 8 lines · Stephen Warren
From: Stephen Warren <[email protected]>
Other boards use
PULL_NONEfor their debug UART pins, and without this change, the board doesn't accept any serial input.Don't set the I2S port pins to tristate mode, or no audio signal will be sent out.
Quoted 8 lines
Fixes 605ae5804385 ("ARM: tegra: add default pinctrl nodes for Venice2")Signed-off-by Stephen Warren <[email protected]>---
v2: Added fix for I2S port.Laxman, can you please go through the whole pinctrl configuration for Venice2 and make sure it's correct. Perhaps the best approach would be to compare it against our downstream kernels for this board.
The patch is generated based on downstream ref platforms setting, Let me again check with very similar board in dowsntream.
PATCH v2 1/1 ARM: tegra: fix pinctrl misconfiguration on Venic2
Quoted 14 lines · Laxman Dewangan
Quoted 13 lines · Stephen Warren
From: Stephen Warren <[email protected]>
Other boards use
PULL_NONEfor their debug UART pins, and without this change, the board doesn't accept any serial input.Don't set the I2S port pins to tristate mode, or no audio signal will be sent out.
Fixes 605ae5804385 ("ARM: tegra: add default pinctrl nodes for Venice2")Signed-off-by Stephen Warren <[email protected]>---
v2: Added fix for I2S port.
Quoted 6 lines
Quoted 3 lines
Laxman, can you please go through the whole pinctrl configuration for Venice2 and make sure it's correct. Perhaps the best approach would be to compare it against our downstream kernels for this board.
The patch is generated based on downstream ref platforms setting, Let me again check with very similar board in dowsntream.
Oh, you mean this isn't a pinctrl configuration for Venice2 then? As you know, we do have a separate downstream kernel with full Venice2 support; you should use that as a reference.
PATCH v2 1/1 ARM: tegra: fix pinctrl misconfiguration on Venic2
In reply to Stephen WarrenQuoted 1 line · Stephen Warren
From: Stephen Warren <[email protected]>
Just in case you ever wanted to rebase this: s/Venic2/Venice2/
Thierry
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20131213/05b261ad/attachment.sig>