pppoe: slight optimization of addr compare

PATCH In review Ding Tianhong 1 participant 1 message Dec 16, 2013

Subsystems (3)

Networking Network drivers PPP over Ethernet

lore

Share & tools

lore

Ding Tianhong

author

2013-12-16 08:24 UTC #0 lore raw

PATCH v2 5/6 pppoe: slight optimization of addr compare

Joe Perches add ether_addr_equal_unaligned to test if possibly unaligned to u16 Ethernet addresses are equal.

If CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS is set, this uses the slightly faster generic routine ether_addr_equal, otherwise this uses memcmp.

Signed-off-by Ding Tianhong <[email protected]>

---
 drivers/net/ppp/pppoe.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

drivers/net/ppp/pppoe.c +3 -2

index 82ee6ed..baed1ef 100644
@@ -131,12 +131,13 @@ static inline struct pppoe_net *pppoe_pernet(struct net *net)
 
 static inline int cmp_2_addr(struct pppoe_addr *a, struct pppoe_addr *b)
 {
-	return a->sid == b->sid && !memcmp(a->remote, b->remote, ETH_ALEN);
+	return a->sid == b->sid &&
+		ether_addr_equal_unaligned(a->remote, b->remote);
 }
 
 static inline int cmp_addr(struct pppoe_addr *a, __be16 sid, char *addr)
 {
-	return a->sid == sid && !memcmp(a->remote, addr, ETH_ALEN);
+	return a->sid == sid && ether_addr_equal_unaligned(a->remote, addr);
 }
 
 #if 8 % PPPOE_HASH_BITS

Signature · 1 line

1.8.0