plip: slight optimization of addr compare

PATCH In review Ding Tianhong 1 participant 1 message Dec 16, 2013

Subsystems (2)

Networking Network drivers

lore

Share & tools

lore

Ding Tianhong

author

2013-12-16 08:24 UTC #0 lore raw

PATCH v2 6/6 plip: slight optimization of addr compare

Joe Perches add ether_addr_equal_unaligned to test if possibly unaligned to u16 Ethernet addresses are equal.

If CONFIG_HAVE_EFFICIENT_UNALIGNED_ACCESS is set, this uses the slightly faster generic routine ether_addr_equal, otherwise this uses memcmp.

Signed-off-by Ding Tianhong <[email protected]>

---
 drivers/net/plip/plip.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/net/plip/plip.c +1 -1

index 7b4ff35..0c26fb9 100644
@@ -549,7 +549,7 @@ static __be16 plip_type_trans(struct sk_buff *skb, struct net_device *dev)
 
 	if(*eth->h_dest&1)
 	{
-		if(memcmp(eth->h_dest,dev->broadcast, ETH_ALEN)==0)
+		if(ether_addr_equal_unaligned(eth->h_dest,dev->broadcast))
 			skb->pkt_type=PACKET_BROADCAST;
 		else
 			skb->pkt_type=PACKET_MULTICAST;

Signature · 1 line

1.8.0