ARM: mxs: tools: Fix errno handling in strtoul() invocation
PATCH 1/1 ARM: mxs: tools: Fix errno handling in strtoul() invocation
According to NOTE in strtoul(3), the errno must be zeroed before strtoul() is called. Zero the errno. The NOTE reads as such:
Since strtoul() can legitimately return 0 or ULONG_MAX (ULLONG_MAX for strtoull()) on both success and failure, the calling program should set errno to 0 before the call, and then determine if an error occurred by checking whether errno has a nonzero value after the call.
This issue was detected on Fedora 19 with glibc 2.17 .
--- tools/mxsimage.c | 1 + 1 file changed, 1 insertion(+)
tools/mxsimage.c +1 -0
@@ -502,6 +502,7 @@ static int sb_token_to_long(char *tok, uint32_t *rid) tok +=2 ; + errno =0 ; id =strtoul (tok, &endptr,16 );if ((errno ==ERANGE && id ==ULONG_MAX ) || (errno !=0 && id ==0 )) {fprintf (stderr,"ERR: Value can't be decoded!\n" );
Signature · 1 line
1.8.4.2
PATCH 1/1 ARM: mxs: tools: Fix errno handling in strtoul() invocation
Quoted 8 lines · Marek Vasut
According to NOTE in strtoul(3), the errno must be zeroed before
strtoul()is called. Zero the errno. The NOTE reads as such:Since
strtoul()can legitimately return 0 orULONG_MAX(ULLONG_MAXforstrtoull()) on both success and failure, the calling program should set errno to 0 before the call, and then determine if an error occurred by checking whether errno has a nonzero value after the call.
Quoted 6 lines
This issue was detected on Fedora 19 with glibc 2.17 .
Signed-off-by Marek Vasut <[email protected]>Cc Stefano Babic <[email protected]>Cc Tom Rini <[email protected]>---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
Signature · 5 lines
===================================================================== DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de =====================================================================