Skip to contentSkip to conversation

regression bug: user loses DISPLAY & REMOTEHOST with 'su -p - username"

DISCUSSION Linda Walsh 2 participants 3 messages Dec 17, 2013 – Dec 18, 2013 Util-Linux package

lore
Share & tools
lore
#0 lore raw

"su --preserve_environment - username" no longer preserves your REMOTEHOST and DISPLAY values. They should be in the same class as 'TERM', as they are passed from the pre-login environment.

I don't know if there are other values that shouldn't be removed -- but it is bad to clear the environment just because one wants a shell called with '-<shell>'.

The preserve environment flag is NOT incompatible with login. It means don't clear the env, but do call login via -<shell>.

-p means don't clear the ENV -- but do call the user's shell with a '-' in front of it. That has always been the functionality of 'su'.

If you want to make 'su' fancier, maybe it needs a "/etc/suers.conf" file so specific values can be easily changed to reflect site policy rather than hard coding them.

maintainer
#1 lore raw

Hi Linda,

Quoted 9 lines · Linda Walsh

"su --preserve_environment - username" no longer preserves your REMOTEHOST and DISPLAY values. They should be in the same class as 'TERM', as they are passed from the pre-login environment.

I don't know if there are other values that shouldn't be removed -- but it is bad to clear the environment just because one wants a shell called with '-<shell>'.

Please, when you call a problem "regression" then it would be nice to know which version was correct... because util-linxu su(1) is code from coreutils and I see in the original code as well as in the current code:

if (simulate_login) {
... reset environment ...

 } else if (change_environment) {  
    ... modify HOME, SHELL, ...

}

it means that --login and --preserve-environment has been always mutually exclusive and the latest version prints wanning when the options are use together. It's also described in the man page.

Quoted 10 lines

The preserve environment flag is NOT incompatible with login. It means don't clear the env, but do call login via -<shell>.

-p means don't clear the ENV -- but do call the user's shell with a '-' in front of it. That has always been the functionality of 'su'.

If you want to make 'su' fancier, maybe it needs a "/etc/suers.conf" file so specific values can be easily changed to reflect site policy rather than hard coding them.

It would be probably better to use PAM for such things.

Karel

Signature · 2 lines
 Karel Zak  <[email protected]>
 http://karelzak.blogspot.com
#2 lore raw
Quoted 4 lines · Karel Zak

it means that --login and --preserve-environment has been always mutually exclusive and the latest version prints wanning when the options are use together. It's also described in the man page.

----
You are right. Compared back with to core utils 8.9 -- same.
Confused it with an open suse change to call pam_env /session instead of per_auth which has a similar effect of losing remote DISPLAY/REMOTEHOST vals.

Quoted 8 lines
Quoted 8 lines

The preserve environment flag is NOT incompatible with login. It means don't clear the env, but do call login via -<shell>.

-p means don't clear the ENV -- but do call the user's shell with a '-' in front of it. That has always been the functionality of 'su'.

Quoted 7 lines
Quoted 4 lines

If you want to make 'su' fancier, maybe it needs a "/etc/suers.conf" file so specific values can be easily changed to reflect site policy rather than hard coding them.

It would be probably better to use PAM for such things.

----

PAM doesn't maintain state. After the initial authorization that
grants you access to the machine -- the "where" you came from is lost.

Perhaps this is a deficiency in PAM, can't say, but DISPLAY is
like TERM. It tells you how to send output to the user. DISPLAY can be derived from REMOTEHOST only on initial authorization when the host is first entered. Since future "sessions" from a remote-entry all stem from the initial login, it would seem useful to preserve information about the origination. TERM is preserved because it describes the nature of the terminal functions to use at 'DISPLAY'. It seems a bit myopic to save TERM but not DISPLAY.

Other vars could easily fall into that category. But certainly,
losing DISPLAY information is at least, no less valuable than losing TERM.