Skip to contentSkip to conversation

misc fix for memory mapped support, dra config

PATCH New Sourav Poddar 2 participants 9 messages Nov 14, 2013 – Dec 19, 2013 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

cover misc fix for memory mapped support, dra config

Hi Jagan,
Here are the miscellaneous fix and config update for dra7 qspi flash.

Patch series adds:
Add BAR config in dra7 config file.
Set spi controller device control registers before doing a memory mapped read.

Patches available here:
git://gitorious.org/u-boot-shared/u-boot-qspi.git debug_dra_qspi

Tested on dra7 evm with qspi boot.

Sourav Poddar (2):
config: dra7_evm: Add Bank Address Register(BAR) config
driver: mtd: sf_ops: claim bus while doing memcpy

 drivers/mtd/spi/sf_ops.c     |    6 ++++++
 include/configs/dra7xx_evm.h |    1 +
 2 files changed, 7 insertions(+), 0 deletions(-)
#1 lore raw

PATCH 1/2 config: dra7_evm: Add Bank Address Register(BAR) config

Add config to support bank address register.

---
 include/configs/dra7xx_evm.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
include/configs/dra7xx_evm.h +1 -0
index 1600131..46cc6db 100644
@@ -54,6 +54,7 @@
 #define CONFIG_SPI_FLASH_SPANSION
 #define CONFIG_CMD_SF
 #define CONFIG_CMD_SPI
+#define CONFIG_SPI_FLASH_BAR
 #define CONFIG_TI_SPI_MMAP
 #define CONFIG_SF_DEFAULT_SPEED                48000000
 #define CONFIG_DEFAULT_SPI_MODE                SPI_MODE_3
Signature · 1 line
1.7.1
#2 lore raw

PATCH 2/2 driver: mtd: sf_ops: claim bus while doing memcpy

In reply to Sourav Poddar

claim spi bus while doing memory copy, this will set up the spi controller device control register before doing a memory read.

---
 drivers/mtd/spi/sf_ops.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
drivers/mtd/spi/sf_ops.c +6 -0
index 108665f..e316a69 100644
@@ -273,9 +273,15 @@ int spi_flash_cmd_read_ops(struct spi_flash *flash, u32 offset,
 
 	/* Handle memory-mapped SPI */
 	if (flash->memory_map) {
+		ret = spi_claim_bus(flash->spi);
+		if (ret) {
+			debug("SF: unable to claim SPI bus\n");
+			return ret;
+		}
 		spi_xfer(flash->spi, 0, NULL, NULL, SPI_XFER_MMAP);
 		memcpy(data, flash->memory_map + offset, len);
 		spi_xfer(flash->spi, 0, NULL, NULL, SPI_XFER_MMAP_END);
+		spi_release_bus(flash->spi);
 		return 0;
 	}
 
Signature · 1 line
1.7.1
#3 lore raw

cover misc fix for memory mapped support, dra config

In reply to Sourav Poddar

Hi Jagan,

Quoted 8 lines · Sourav Poddar

Hi Jagan,
Here are the miscellaneous fix and config update for dra7 qspi flash.

Patch series adds:
Add BAR config in dra7 config file.
Set spi controller device control registers before doing a memory mapped read.

Quoted 4 lines

Patches available here:
git://gitorious.org/u-boot-shared/u-boot-qspi.git debug_dra_qspi

Tested on dra7 evm with qspi boot.

Can these patches be picked?

Quoted 8 lines

Sourav Poddar (2):
config: dra7_evm: Add Bank Address Register(BAR) config
driver: mtd: sf_ops: claim bus while doing memcpy

  drivers/mtd/spi/sf_ops.c     |    6 ++++++
  include/configs/dra7xx_evm.h |    1 +
  2 files changed, 7 insertions(+), 0 deletions(-)
#4 lore raw

cover misc fix for memory mapped support, dra config

In reply to Sourav Poddar

Jagan,

Quoted 13 lines · Sourav Poddar

Hi Jagan,
Here are the miscellaneous fix and config update for dra7 qspi flash.

Patch series adds:
Add BAR config in dra7 config file.
Set spi controller device control registers before doing a memory mapped read.

Patches available here:
git://gitorious.org/u-boot-shared/u-boot-qspi.git debug_dra_qspi

Tested on dra7 evm with qspi boot.

Quoted 8 lines

Sourav Poddar (2):
config: dra7_evm: Add Bank Address Register(BAR) config
driver: mtd: sf_ops: claim bus while doing memcpy

  drivers/mtd/spi/sf_ops.c     |    6 ++++++
  include/configs/dra7xx_evm.h |    1 +
  2 files changed, 7 insertions(+), 0 deletions(-)

Ping on this.
This are miscellaneous fixes for dra7 qspi uboot.
Can you pick this up ?

#5 lore raw

cover misc fix for memory mapped support, dra config

Quoted 20 lines · Sourav Poddar

Jagan,

Quoted 18 lines · Sourav Poddar

Hi Jagan,
Here are the miscellaneous fix and config update for dra7 qspi flash.

Patch series adds:
Add BAR config in dra7 config file.
Set spi controller device control registers before doing a memory mapped read.

Patches available here:
git://gitorious.org/u-boot-shared/u-boot-qspi.git debug_dra_qspi

Tested on dra7 evm with qspi boot.

Sourav Poddar (2):
config: dra7_evm: Add Bank Address Register(BAR) config
driver: mtd: sf_ops: claim bus while doing memcpy

Quoted 7 lines
Quoted 4 lines
  drivers/mtd/spi/sf_ops.c     |    6 ++++++
  include/configs/dra7xx_evm.h |    1 +
  2 files changed, 7 insertions(+), 0 deletions(-)

Ping on this.
This are miscellaneous fixes for dra7 qspi uboot.
Can you pick this up ?

What is this series - I couldn't find it on patchwork. You sent a series with 0/5 and these two are part of that is it?

Signature · 2 lines
Thanks,
Jagan.
#6 lore raw

cover misc fix for memory mapped support, dra config

Quoted 24 lines · Jagan Teki
Quoted 23 lines · Sourav Poddar

Jagan,

Quoted 21 lines · Sourav Poddar

Hi Jagan,
Here are the miscellaneous fix and config update for dra7 qspi flash.

Patch series adds:
Add BAR config in dra7 config file.
Set spi controller device control registers before doing a memory mapped read.

Patches available here:
git://gitorious.org/u-boot-shared/u-boot-qspi.git debug_dra_qspi

Tested on dra7 evm with qspi boot.

Sourav Poddar (2):
config: dra7_evm: Add Bank Address Register(BAR) config
driver: mtd: sf_ops: claim bus while doing memcpy

   drivers/mtd/spi/sf_ops.c     |    6 ++++++
   include/configs/dra7xx_evm.h |    1 +
   2 files changed, 7 insertions(+), 0 deletions(-)
Quoted 6 lines
Quoted 3 lines

Ping on this.
This are miscellaneous fixes for dra7 qspi uboot.
Can you pick this up ?

What is this series - I couldn't find it on patchwork. You sent a series with 0/5 and these two are part of that is it?

This is a differnet series for dra7 soc, it has miscellaneous cleanup and fixes.

The other series (0/5) is for qspi on am43x soc

#7 lore raw

cover misc fix for memory mapped support, dra config

Quoted 33 lines · Sourav Poddar
Quoted 32 lines · Jagan Teki
Quoted 28 lines · Sourav Poddar

Jagan,

Quoted 14 lines · Sourav Poddar

Hi Jagan,
Here are the miscellaneous fix and config update for dra7 qspi flash.

Patch series adds:
Add BAR config in dra7 config file.
Set spi controller device control registers before doing a memory mapped read.

Patches available here:
git://gitorious.org/u-boot-shared/u-boot-qspi.git debug_dra_qspi

Tested on dra7 evm with qspi boot.

Quoted 8 lines

Sourav Poddar (2):
config: dra7_evm: Add Bank Address Register(BAR) config
driver: mtd: sf_ops: claim bus while doing memcpy

   drivers/mtd/spi/sf_ops.c     |    6 ++++++
   include/configs/dra7xx_evm.h |    1 +
   2 files changed, 7 insertions(+), 0 deletions(-)

Ping on this.
This are miscellaneous fixes for dra7 qspi uboot.
Can you pick this up ?

Quoted 7 lines
Quoted 3 lines

What is this series - I couldn't find it on patchwork. You sent a series with 0/5 and these two are part of that is it?

This is a differnet series for dra7 soc, it has miscellaneous cleanup and fixes.

The other series (0/5) is for qspi on am43x soc

Applied to u-boot-spi/master

Signature · 8 lines
Thanks,
Jagan.
--------
Jagannadha Sutradharudu Teki,
E: jagannadh.teki at gmail.com, P: +91-9676773388
Engineer - System Software Hacker
U-boot - SPI Custodian and Zynq APSOC
Ln: http://www.linkedin.com/in/jaganteki
#8 lore raw

cover misc fix for memory mapped support, dra config

Quoted 30 lines · Jagan Teki
Quoted 29 lines · Sourav Poddar
Quoted 28 lines · Jagan Teki
Quoted 26 lines · Sourav Poddar

Jagan,

Quoted 13 lines · Sourav Poddar

Hi Jagan,
Here are the miscellaneous fix and config update for dra7 qspi flash.

Patch series adds:
Add BAR config in dra7 config file.
Set spi controller device control registers before doing a memory mapped read.

Patches available here:
git://gitorious.org/u-boot-shared/u-boot-qspi.git debug_dra_qspi

Tested on dra7 evm with qspi boot.

Quoted 8 lines

Sourav Poddar (2):
config: dra7_evm: Add Bank Address Register(BAR) config
driver: mtd: sf_ops: claim bus while doing memcpy

drivers/mtd/spi/sf_ops.c | 6 ++++++
include/configs/dra7xx_evm.h | 1 +
2 files changed, 7 insertions(+), 0 deletions(-)

Ping on this.
This are miscellaneous fixes for dra7 qspi uboot.
Can you pick this up ?

Quoted 9 lines
Quoted 7 lines
Quoted 3 lines

What is this series - I couldn't find it on patchwork. You sent a series with 0/5 and these two are part of that is it?

This is a differnet series for dra7 soc, it has miscellaneous cleanup and fixes.

The other series (0/5) is for qspi on am43x soc

Applied to u-boot-spi/master

Thanks!