Skip to contentSkip to conversation

netfilter: ipvs: remove the unused variable

PATCH In review Wang Weidong 3 participants 4 messages Dec 19, 2013 – Dec 27, 2013

Subsystems (4)
Networking Network drivers netfilter IPVS
lore
Share & tools
lore

Wang Weidong

author
#0 lore raw

PATCH 1/1 netfilter: ipvs: remove the unused variable

when I built the netfilter, I got that:
net/netfilter/ipvs/ip_vs_sync.c: In function sync_thread_master’:
net/netfilter/ipvs/ip_vs_sync.c:1640: warning: unused variable ‘ret’

Signed-off-by Wang Weidong <[email protected]>
---
 net/netfilter/ipvs/ip_vs_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/netfilter/ipvs/ip_vs_sync.c +1 -1
index f63c238..d258125 100644
@@ -1637,7 +1637,7 @@ static int sync_thread_master(void *data)
 			continue;
 		}
 		while (ip_vs_send_sync_msg(tinfo->sock, sb->mesg) < 0) {
-			int ret = __wait_event_interruptible(*sk_sleep(sk),
+			__wait_event_interruptible(*sk_sleep(sk),
 						   sock_writeable(sk) ||
 						   kthread_should_stop());
 			if (unlikely(kthread_should_stop()))
Signature · 1 line
1.7.12
maintainer
#1 lore raw

Hello,

Quoted 3 lines · Wang Weidong

when I built the netfilter, I got that:
net/netfilter/ipvs/ip_vs_sync.c: In function sync_thread_master’:
net/netfilter/ipvs/ip_vs_sync.c:1640: warning: unused variable ‘ret’

There is another patch that we plan to apply but
due to possible merge conflict it was delayed:

http://marc.info/?t=138426695600002&r=1&w=2
http://marc.info/?t=138426469400008&r=1&w=2

May be it is time to apply it...

Quoted 20 lines
Signed-off-by Wang Weidong <[email protected]>
---
 net/netfilter/ipvs/ip_vs_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/netfilter/ipvs/ip_vs_sync.c +1 -1
index f63c238..d258125 100644
@@ -1637,7 +1637,7 @@ static int sync_thread_master(void *data)
 			continue;
 		}
 		while (ip_vs_send_sync_msg(tinfo->sock, sb->mesg) < 0) {
-			int ret = __wait_event_interruptible(*sk_sleep(sk),
+			__wait_event_interruptible(*sk_sleep(sk),
 						   sock_writeable(sk) ||
 						   kthread_should_stop());
 			if (unlikely(kthread_should_stop()))
Signature · 1 line
1.7.12

Regards

--
Julian Anastasov <[email protected]>

author
#2 lore raw
Quoted 9 lines · Julian Anastasov

Hello,

Quoted 3 lines · Wang Weidong

when I built the netfilter, I got that:
net/netfilter/ipvs/ip_vs_sync.c: In function sync_thread_master’:
net/netfilter/ipvs/ip_vs_sync.c:1640: warning: unused variable ‘ret’

Quoted 8 lines

There is another patch that we plan to apply but
due to possible merge conflict it was delayed:

http://marc.info/?t=138426695600002&r=1&w=2
http://marc.info/?t=138426469400008&r=1&w=2

May be it is time to apply it...

Ok, Got it.

Regards.
Wang

Quoted 26 lines
Quoted 20 lines
Signed-off-by Wang Weidong <[email protected]>
---
 net/netfilter/ipvs/ip_vs_sync.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
net/netfilter/ipvs/ip_vs_sync.c +1 -1
index f63c238..d258125 100644
@@ -1637,7 +1637,7 @@ static int sync_thread_master(void *data)
 			continue;
 		}
 		while (ip_vs_send_sync_msg(tinfo->sock, sb->mesg) < 0) {
-			int ret = __wait_event_interruptible(*sk_sleep(sk),
+			__wait_event_interruptible(*sk_sleep(sk),
 						   sock_writeable(sk) ||
 						   kthread_should_stop());
 			if (unlikely(kthread_should_stop()))
Signature · 1 line
1.7.12

Regards

--
Julian Anastasov <[email protected]>

maintainer
#3 lore raw
In reply to Julian Anastasov
Quoted 9 lines · Julian Anastasov

Hello,

Quoted 3 lines · Wang Weidong

when I built the netfilter, I got that:
net/netfilter/ipvs/ip_vs_sync.c: In function sync_thread_master’:
net/netfilter/ipvs/ip_vs_sync.c:1640: warning: unused variable ‘ret’

Quoted 7 lines

There is another patch that we plan to apply but
due to possible merge conflict it was delayed:

http://marc.info/?t=138426695600002&r=1&w=2
http://marc.info/?t=138426469400008&r=1&w=2

May be it is time to apply it...

Thanks, I have done so.