Skip to contentSkip to conversation

weston: for fbdev enabled distro feature, change WESTON_NATIVE_BACKEND

PATCH In review Valentin Popa 3 participants 4 messages Dec 19, 2013 – Dec 20, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 weston: for fbdev enabled distro feature, change WESTON_NATIVE_BACKEND

For builds with fbdev (no drm/kms), set WESTON_NATIVE_BACKEND to "fbdev-backend.so"; doing this, weston-launch will be able to know what backend to use.

---
 meta/recipes-graphics/wayland/weston_1.3.1.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/wayland/weston_1.3.1.bb +1 -1
index d97f6af..4ab2776 100644
@@ -45,7 +45,7 @@ PACKAGECONFIG[x11] = "--enable-x11-compositor,--disable-x11-compositor,virtual/l
 # Headless Weston
 PACKAGECONFIG[headless] = "--enable-headless-compositor,--disable-headless-compositor"
 # Weston on framebuffer
-PACKAGECONFIG[fbdev] = "--enable-fbdev-compositor,--disable-fbdev-compositor,udev mtdev"
+PACKAGECONFIG[fbdev] = "--enable-fbdev-compositor WESTON_NATIVE_BACKEND="fbdev-backend.so",--disable-fbdev-compositor,udev mtdev"
 # weston-launch
 PACKAGECONFIG[launch] = "--enable-weston-launch,--disable-weston-launch,libpam"
 # VA-API desktop recorder
Signature · 1 line
1.8.3.2
#1 lore raw
Quoted 14 lines · Valentin Popa

For builds with fbdev (no drm/kms), set WESTON_NATIVE_BACKEND to "fbdev-backend.so"; doing this, weston-launch will be able to know what backend to use.

---
  meta/recipes-graphics/wayland/weston_1.3.1.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/wayland/weston_1.3.1.bb +0 -0
index d97f6af..4ab2776 100644

meta/recipes-graphics/wayland/weston_1.3.1.bb PACKAGECONFIG[x11] = "--enable-x11-compositor,--disable-x11-compositor,virtual/l · line 48

Quoted 5 lines
meta/recipes-graphics/wayland/weston_1.3.1.bb +1 -1
@@ -45,7 +45,7 @@ PACKAGECONFIG[x11] = "--enable-x11-compositor,--disable-x11-compositor,virtual/l
  # Headless Weston
  PACKAGECONFIG[headless] = "--enable-headless-compositor,--disable-headless-compositor"
  # Weston on framebuffer
-PACKAGECONFIG[fbdev] = "--enable-fbdev-compositor,--disable-fbdev-compositor,udev mtdev"
+PACKAGECONFIG[fbdev] = "--enable-fbdev-compositor WESTON_NATIVE_BACKEND="fbdev-backend.so",--disable-fbdev-compositor,udev mtdev"

Is this a more general way to do this as suggested by Koen back in May?

+# Needed for weston-launch
+WESTONBACKEND ??= "fbdev-backend.so"
+
+export WESTON_NATIVE_BACKEND = "${WESTONBACKEND}"

See http://patches.openembedded.org/patch/50871/

Sau!

Quoted 4 lines
meta/recipes-graphics/wayland/weston_1.3.1.bb +0 -0
  # weston-launch
  PACKAGECONFIG[launch] = "--enable-weston-launch,--disable-weston-launch,libpam"
  # VA-API desktop recorder
#2 lore raw
Quoted 32 lines · Saul Wold
Quoted 15 lines · Valentin Popa

For builds with fbdev (no drm/kms), set WESTON_NATIVE_BACKEND to "fbdev-backend.so"; doing this, weston-launch will be able to know what backend to use.

---
  meta/recipes-graphics/wayland/weston_1.3.1.bb | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
meta/recipes-graphics/wayland/weston_1.3.1.bb +0 -0
index d97f6af..4ab2776 100644
@@ -45,7 +45,7 @@ PACKAGECONFIG[x11] = 

"--enable-x11-compositor,--disable-x11-compositor,virtual/l

Quoted 8 lines

# Headless Weston
PACKAGECONFIG[headless] =
"--enable-headless-compositor,--disable-headless-compositor"
# Weston on framebuffer
-PACKAGECONFIG[fbdev] = "--enable-fbdev-compositor,--disable-fbdev-compositor,udev mtdev" +PACKAGECONFIG[fbdev] = "--enable-fbdev-compositor WESTON_NATIVE_BACKEND="fbdev-backend.so",--disable-fbdev-compositor,udev mtdev"

Is this a more general way to do this as suggested by Koen back in May?

(quoted diff) +4 -0
+# Needed for weston-launch
+WESTONBACKEND ??= "fbdev-backend.so"
+
+export WESTON_NATIVE_BACKEND = "${WESTONBACKEND}"
Quoted 3 lines

See http://patches.openembedded.org/patch/50871/

Sau!

Not sure of the context of that patch, but with this patch we have fbdev backend -only- if the user builds with fbdev distro feature. I've tried to build with both kms and fbdev and failed at compile time (bug or feature).

Quoted 7 lines
Quoted 7 lines

  # weston-launch
  PACKAGECONFIG[launch] = 
"--enable-weston-launch,--disable-weston-launch,libpam"
  # VA-API desktop recorder
#3 lore raw
Quoted 2 lines · Valentin Popa

I've tried to build with both kms and fbdev and failed at compile time (bug or feature).

I'd expect bug as you can build with x11 and drm backends enabled. Please file a bug for this (and CC me using [email protected]).

Ross