mac8011: slight optimization of addr compare

PATCH Superseded Ding Tianhong 2 participants 2 messages Dec 23, 2013 – Jan 6, 2014

Subsystems (3)

Networking Network drivers mac80211

lore

Share & tools

lore

Ding Tianhong

author

2013-12-23 05:10 UTC #0 lore raw

PATCH 13/21 mac8011: slight optimization of addr compare

Use the recently added and possibly more efficient ether_addr_equal_unaligned to instead of memcmp.

Cc Johannes Berg <[email protected]>

Cc John W. Linville <[email protected]>

Cc David Miller <[email protected]>

Cc [email protected]

Signed-off-by Wang Weidong <[email protected]>

Signed-off-by Ding Tianhong <[email protected]>

---
 net/mac80211/iface.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

net/mac80211/iface.c +2 -4

index 7aa9f9d..1773e17 100644
@@ -1497,8 +1497,7 @@ static void ieee80211_assign_perm_addr(struct ieee80211_local *local,
 			bool used = false;
 
 			list_for_each_entry(sdata, &local->interfaces, list) {
-				if (memcmp(local->hw.wiphy->addresses[i].addr,
-					   sdata->vif.addr, ETH_ALEN) == 0) {
+				if (ether_addr_equal_unaligned(local->hw.wiphy->addresses[i].addr, sdata->vif.addr)) {
 					used = true;
 					break;
 				}

@@ -1558,8 +1557,7 @@ static void ieee80211_assign_perm_addr(struct ieee80211_local *local,
 			val += inc;
 
 			list_for_each_entry(sdata, &local->interfaces, list) {
-				if (memcmp(tmp_addr, sdata->vif.addr,
-							ETH_ALEN) == 0) {
+				if (ether_addr_equal_unaligned(tmp_addr, sdata->vif.addr)) {
 					used = true;
 					break;
 				}

Signature · 1 line

1.8.0

Johannes Berg

maintainer

2014-01-06 15:21 UTC #1 lore raw

net/mac80211/iface.c static void ieee80211_assign_perm_addr(struct ieee80211_local *local, · line 1500

Quoted 6 lines · Ding Tianhong

Use the recently added and possibly more efficient ether_addr_equal_unaligned to instead of memcmp.
net/mac80211/iface.c +1 -2
-				if (memcmp(local->hw.wiphy->addresses[i].addr,
-					   sdata->vif.addr, ETH_ALEN) == 0) {
+				if (ether_addr_equal_unaligned(local->hw.wiphy->addresses[i].addr, sdata->vif.addr)) {

This clearly should have some linebreaks.

This code also doesn't care all that much about efficiency, so not sure it's worth it at all.

johannes