zd1211rw: slight optimization of addr compare

PATCH Superseded Ding Tianhong 1 participant 1 message Dec 24, 2013

Subsystems (3)

Networking Network drivers Networking drivers (wireless)

lore

Share & tools

lore

Ding Tianhong

author

2013-12-24 11:28 UTC #0 lore raw

PATCH v2 8/20 zd1211rw: slight optimization of addr compare

Use possibly more efficient ether_addr_equal instead of memcmp.

Cc Daniel Drake <[email protected]>

Cc Ulrich Kunitz <[email protected]>

Cc "John W. Linville" <[email protected]>

Cc [email protected]

Signed-off-by Tan Xiaojun <[email protected]>

Signed-off-by Ding Tianhong <[email protected]>

---
 drivers/net/wireless/zd1211rw/zd_mac.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

drivers/net/wireless/zd1211rw/zd_mac.c +2 -3

index eff79a3..e7af261 100644
@@ -532,9 +532,8 @@ void zd_mac_tx_failed(struct urb *urb)
 		tx_hdr = (struct ieee80211_hdr *)skb->data;
 
 		/* we skip all frames not matching the reported destination */
-		if (unlikely(memcmp(tx_hdr->addr1, tx_status->mac, ETH_ALEN))) {
+		if (unlikely(!ether_addr_equal(tx_hdr->addr1, tx_status->mac)))
 			continue;
-		}
 
 		/* we skip all frames not matching the reported final rate */

@@ -997,7 +996,7 @@ static int filter_ack(struct ieee80211_hw *hw, struct ieee80211_hdr *rx_hdr,
 		    continue;
 
 		tx_hdr = (struct ieee80211_hdr *)skb->data;
-		if (likely(!memcmp(tx_hdr->addr2, rx_hdr->addr1, ETH_ALEN)))
+		if (likely(ether_addr_equal(tx_hdr->addr2, rx_hdr->addr1)))
 		{
 			found = 1;
 			break;

Signature · 1 line

1.8.0