Skip to contentSkip to conversation

board:trats2: fix default partitions and mmc env

PATCH Superseded Piotr Wilczek 3 participants 5 messages Dec 19, 2013 – Dec 31, 2013

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 board:trats2: fix default partitions and mmc env

This patch add uuid disk to defualt partions necessary to restore gpt partitions and fixes mmcdev environmental variable.

---
 include/configs/trats2.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/configs/trats2.h +2 -1
index 5d86a3d..4c0068b 100644
@@ -160,6 +160,7 @@
 #define PARTS_UMS		"ums"
 
 #define PARTS_DEFAULT \
+	"uuid_disk=${uuid_gpt_disk};" \
 	"name="PARTS_CSA",start=5MiB,size=8MiB,uuid=${uuid_gpt_"PARTS_CSA"};" \
 	"name="PARTS_BOOT",size=64MiB,uuid=${uuid_gpt_"PARTS_BOOT"};" \
 	"name="PARTS_MODEM",size=100MiB,uuid=${uuid_gpt_"PARTS_MODEM"};" \
@@ -201,7 +202,7 @@
 		"${kernelname}\0" \
 	"loaddtb=ext4load mmc ${mmcdev}:${mmcbootpart} ${fdtaddr} " \
 		"${fdtfile}\0" \
-	"mmcdev=CONFIG_MMC_DEFAULT_DEV\0" \
+	"mmcdev=0\0" \
 	"mmcbootpart=2\0" \
 	"mmcrootpart=5\0" \
 	"opts=always_resume=1\0" \
Signature · 1 line
1.7.9.5
#1 lore raw

PATCH 1/1 board:trats2: fix default partitions and mmc env

Hi, Piotr.

Quoted 22 lines · Piotr Wilczek

This patch add uuid disk to defualt partions necessary to restore gpt partitions and fixes mmcdev environmental variable.

---
 include/configs/trats2.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/configs/trats2.h +1 -0
index 5d86a3d..4c0068b 100644
@@ -160,6 +160,7 @@
 #define PARTS_UMS		"ums"
 
 #define PARTS_DEFAULT \
+	"uuid_disk=${uuid_gpt_disk};" \
 	"name="PARTS_CSA",start=5MiB,size=8MiB,uuid=${uuid_gpt_"PARTS_CSA"};" \
 	"name="PARTS_BOOT",size=64MiB,uuid=${uuid_gpt_"PARTS_BOOT"};" \
 	"name="PARTS_MODEM",size=100MiB,uuid=${uuid_gpt_"PARTS_MODEM"};" \

include/configs/trats2.h line 205

Quoted 5 lines
include/configs/trats2.h +1 -1
@@ -201,7 +202,7 @@
 		"${kernelname}\0" \
 	"loaddtb=ext4load mmc ${mmcdev}:${mmcbootpart} ${fdtaddr} " \
 		"${fdtfile}\0" \
-	"mmcdev=CONFIG_MMC_DEFAULT_DEV\0" \
+	"mmcdev=0\0" \

What difference is CONFIG_MMC_DEFAULT_DEV and 0? CONFIG_MMC_DEFAULT_DEV 0 is defined. Maybe, mmcdev is set to 0, isn't? (It recognized that CONFIG_MMC_DEFAULT_DEV isn't defined.)

Best Regards,
Jaehoon Chung

Quoted 4 lines
include/configs/trats2.h +0 -0
 	"mmcbootpart=2\0" \
 	"mmcrootpart=5\0" \
 	"opts=always_resume=1\0" \
#2 lore raw

PATCH 1/1 board:trats2: fix default partitions and mmc env

Dear Jaehoon Chung,

Quoted 36 lines

-----Original Message-----
From: Jaehoon Chung [mailto:jh80.chung at samsung.com]
Sent: Thursday, December 26, 2013 9:03 AM
To: Piotr Wilczek; u-boot at lists.denx.de
Cc: Kyungmin Park
Subject: Re: [U-Boot] [PATCH] board:trats2: fix default partitions and mmc env

Hi, Piotr.

include/configs/trats2.h

Quoted 10 lines · Piotr Wilczek

This patch add uuid disk to defualt partions necessary to restore gpt partitions and fixes mmcdev environmental variable.

---
 include/configs/trats2.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/configs/trats2.h +0 -0

index

include/configs/trats2.h line 164

Quoted 9 lines

5d86a3d..4c0068b 100644

include/configs/trats2.h +1 -0
@@ -160,6 +160,7 @@
 #define PARTS_UMS		"ums"
 
 #define PARTS_DEFAULT \
+	"uuid_disk=${uuid_gpt_disk};" \
 
	"name="PARTS_CSA",start=5MiB,size=8MiB,uuid=${uuid_gpt_"PARTS_CSA

"};" \

include/configs/trats2.h line 166

Quoted 2 lines
include/configs/trats2.h +0 -0
 	"name="PARTS_BOOT",size=64MiB,uuid=${uuid_gpt_"PARTS_BOOT"};" \
 	"name="PARTS_MODEM",size=100MiB,uuid=${uuid_gpt_"PARTS_MODEM"};"

\

Quoted 10 lines

include/configs/trats2.h line 205

Quoted 6 lines
include/configs/trats2.h +1 -1
@@ -201,7 +202,7 @@
 		"${kernelname}\0" \
 	"loaddtb=ext4load mmc ${mmcdev}:${mmcbootpart} ${fdtaddr} " \
 		"${fdtfile}\0" \
-	"mmcdev=CONFIG_MMC_DEFAULT_DEV\0" \
+	"mmcdev=0\0" \

What difference is CONFIG_MMC_DEFAULT_DEV and 0? CONFIG_MMC_DEFAULT_DEV 0 is defined. Maybe, mmcdev is set to 0, isn't? (It recognized that CONFIG_MMC_DEFAULT_DEV isn't defined.)

You are right, CONFIG_MMC_DEFAULT_DEV is set 0. I should have used __stringify function originally.
Please see V2:
http://patchwork.ozlabs.org/patch/305737/

Please also see the following patch:
http://patchwork.ozlabs.org/patch/302903/

Both are very important fixes for current release.

Quoted 6 lines

Best Regards,
Jaehoon Chung

Quoted 4 lines
include/configs/trats2.h +0 -0
 	"mmcbootpart=2\0" \
 	"mmcrootpart=5\0" \
 	"opts=always_resume=1\0" \

Best regards,
Piotr Wilczek

#3 lore raw

PATCH v2 1/1 board:trats2: fix default partitions and mmc env

In reply to Piotr Wilczek

This patch add uuid disk to defualt partions necessary to restore gpt partitions and fixes mmcdev environmental variable.

---
Changes for V2:
- use __stringify for CONFIG_MMC_DEFAULT_DEV stringification

 include/configs/trats2.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/configs/trats2.h +2 -1
index 5d86a3d..c9ce828 100644
@@ -160,6 +160,7 @@
 #define PARTS_UMS		"ums"
 
 #define PARTS_DEFAULT \
+	"uuid_disk=${uuid_gpt_disk};" \
 	"name="PARTS_CSA",start=5MiB,size=8MiB,uuid=${uuid_gpt_"PARTS_CSA"};" \
 	"name="PARTS_BOOT",size=64MiB,uuid=${uuid_gpt_"PARTS_BOOT"};" \
 	"name="PARTS_MODEM",size=100MiB,uuid=${uuid_gpt_"PARTS_MODEM"};" \
@@ -201,7 +202,7 @@
 		"${kernelname}\0" \
 	"loaddtb=ext4load mmc ${mmcdev}:${mmcbootpart} ${fdtaddr} " \
 		"${fdtfile}\0" \
-	"mmcdev=CONFIG_MMC_DEFAULT_DEV\0" \
+	"mmcdev=" __stringify(CONFIG_MMC_DEFAULT_DEV) "\0" \
 	"mmcbootpart=2\0" \
 	"mmcrootpart=5\0" \
 	"opts=always_resume=1\0" \
Signature · 1 line
1.7.9.5
#4 lore raw

PATCH v2 1/1 board:trats2: fix default partitions and mmc env

Quoted 26 lines · Piotr Wilczek

This patch add uuid disk to defualt partions necessary to restore gpt partitions and fixes mmcdev environmental variable.

---
Changes for V2:
- use __stringify for CONFIG_MMC_DEFAULT_DEV stringification

 include/configs/trats2.h |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
include/configs/trats2.h +1 -0
index 5d86a3d..c9ce828 100644
@@ -160,6 +160,7 @@
 #define PARTS_UMS		"ums"
 
 #define PARTS_DEFAULT \
+	"uuid_disk=${uuid_gpt_disk};" \
 	"name="PARTS_CSA",start=5MiB,size=8MiB,uuid=${uuid_gpt_"PARTS_CSA"};" \
 	"name="PARTS_BOOT",size=64MiB,uuid=${uuid_gpt_"PARTS_BOOT"};" \
 	"name="PARTS_MODEM",size=100MiB,uuid=${uuid_gpt_"PARTS_MODEM"};" \

include/configs/trats2.h line 208

Quoted 8 lines
include/configs/trats2.h +1 -1
@@ -201,7 +202,7 @@
 		"${kernelname}\0" \
 	"loaddtb=ext4load mmc ${mmcdev}:${mmcbootpart} ${fdtaddr} " \
 		"${fdtfile}\0" \
-	"mmcdev=CONFIG_MMC_DEFAULT_DEV\0" \
+	"mmcdev=" __stringify(CONFIG_MMC_DEFAULT_DEV) "\0" \
 	"mmcbootpart=2\0" \
 	"mmcrootpart=5\0" \
 	"opts=always_resume=1\0" \

applied to u-boot-samsung.

Thanks,
Minkyu Kang.