Skip to contentSkip to conversation

xfs: rename mem_to_page to xfs_bufmem_to_page

PATCH In review Jeff Liu 2 participants 3 messages Dec 24, 2013 – Dec 26, 2013 XFS filesystem

lore
Share & tools
lore

Jeff Liu

author
#0 lore raw

PATCH 4/4 xfs: rename mem_to_page to xfs_bufmem_to_page

From: Jie Liu <[email protected]>

Rename mem_to_page() to xfs_bufmem_to_page() for XFS convention.

---
 fs/xfs/xfs_buf.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
fs/xfs/xfs_buf.c +3 -3
index 544315e..286ddbe 100644
@@ -732,8 +732,8 @@ xfs_buf_set_empty(
 }
 
 static inline struct page *
-mem_to_page(
-	void			*addr)
+xfs_bufmem_to_page(
+	void		*addr)
 {
 	if ((!is_vmalloc_addr(addr))) {
 		return virt_to_page(addr);
@@ -774,7 +774,7 @@ xfs_buf_associate_memory(
 	bp->b_offset = offset;
 
 	for (i = 0; i < bp->b_page_count; i++) {
-		bp->b_pages[i] = mem_to_page((void *)pageaddr);
+		bp->b_pages[i] = xfs_bufmem_to_page((void *)pageaddr);
 		pageaddr += PAGE_SIZE;
 	}
 
Signature · 6 lines
1.8.3.2

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs
author
#2 lore raw
Quoted 7 lines · Christoph Hellwig
Quoted 3 lines · Jeff Liu

From: Jie Liu <[email protected]>

Rename mem_to_page() to xfs_bufmem_to_page() for XFS convention.

There's nothing inherently buffere related in the function, it doesn't even take an argument related to buffers.

Well, I originally want to rename to xfs_buf_mem_to_page() by following up other functions in this file with "xfs_buf_" prefix, something like a typo...

Looks this routine can not be folded into xfs_buf_associate_memory() without introducing another variable to hold the temporary type convert value of pageaddr, so I'm fine if we remains the same.

Thanks,
-Jeff

_______________________________________________
xfs mailing list
[email protected]
http://oss.sgi.com/mailman/listinfo/xfs