Skip to contentSkip to conversation

KCONFIG_ALLCONFIG + allmodconfig = brokenness

DISCUSSION H. Peter Anvin 2 participants 4 messages Dec 30, 2013 Kbuild

lore
Share & tools
lore
#0 lore raw

When KCONFIG_ALLCONFIG is used with "make allmodconfig", the result ends up being largely the same as "make allyesconfig", because the resulting kernel ends up with CONFIG_MODULES=n:

How to reproduce:

: tazenda 125 ; make O=../o.test allmodconfig
GEN /home/hpa/kernel/o.test/Makefile
scripts/kconfig/conf --allmodconfig Kconfig
#

# configuration written to .config
#
: tazenda 126 ; grep CONFIG_MODULES ../o.test/.config
CONFIG_MODULES_USE_ELF_RELA=y
CONFIG_MODULES=y
: tazenda 127 ; env KCONFIG_ALLCONFIG=/dev/null make O=../o.test
allmodconfig
  GEN     /home/hpa/kernel/o.test/Makefile
scripts/kconfig/conf --allmodconfig Kconfig
#
# configuration written to .config
#
: tazenda 128 ; grep CONFIG_MODULES ../o.test/.config
CONFIG_MODULES_USE_ELF_RELA=y
# CONFIG_MODULES is not set
#1 lore raw
Quoted 10 lines · H. Peter Anvin

When KCONFIG_ALLCONFIG is used with "make allmodconfig", the result ends up being largely the same as "make allyesconfig", because the resulting kernel ends up with CONFIG_MODULES=n:

How to reproduce:

: tazenda 125 ; make O=../o.test allmodconfig
GEN /home/hpa/kernel/o.test/Makefile
scripts/kconfig/conf --allmodconfig Kconfig
#

Quoted 16 lines
# configuration written to .config
#
: tazenda 126 ; grep CONFIG_MODULES ../o.test/.config
CONFIG_MODULES_USE_ELF_RELA=y
CONFIG_MODULES=y
: tazenda 127 ; env KCONFIG_ALLCONFIG=/dev/null make O=../o.test
allmodconfig
  GEN     /home/hpa/kernel/o.test/Makefile
scripts/kconfig/conf --allmodconfig Kconfig
#
# configuration written to .config
#
: tazenda 128 ; grep CONFIG_MODULES ../o.test/.config
CONFIG_MODULES_USE_ELF_RELA=y
# CONFIG_MODULES is not set
--

Yes, I discovered this a few weeks ago.
I just ended up adding
CONFIG_MODULES=y
to my KCONFIG_ALLCONFIG file.

There was a comment in the git commit for it about this (that I discovered during my "research" into it), but I can't find it just now.

I wasn't fond of the change either.

Signature · 1 line
~Randy
#2 lore raw
Quoted 28 lines · Randy Dunlap
Quoted 10 lines · H. Peter Anvin

When KCONFIG_ALLCONFIG is used with "make allmodconfig", the result ends up being largely the same as "make allyesconfig", because the resulting kernel ends up with CONFIG_MODULES=n:

How to reproduce:

: tazenda 125 ; make O=../o.test allmodconfig
GEN /home/hpa/kernel/o.test/Makefile
scripts/kconfig/conf --allmodconfig Kconfig
#

Quoted 16 lines
# configuration written to .config
#
: tazenda 126 ; grep CONFIG_MODULES ../o.test/.config
CONFIG_MODULES_USE_ELF_RELA=y
CONFIG_MODULES=y
: tazenda 127 ; env KCONFIG_ALLCONFIG=/dev/null make O=../o.test
allmodconfig
  GEN     /home/hpa/kernel/o.test/Makefile
scripts/kconfig/conf --allmodconfig Kconfig
#
# configuration written to .config
#
: tazenda 128 ; grep CONFIG_MODULES ../o.test/.config
CONFIG_MODULES_USE_ELF_RELA=y
# CONFIG_MODULES is not set
--
Quoted 7 lines

Yes, I discovered this a few weeks ago.
I just ended up adding
CONFIG_MODULES=y
to my KCONFIG_ALLCONFIG file.

There was a comment in the git commit for it about this (that I discovered during my "research" into it), but I can't find it just now.

See 11097a0367e48954ecf616f9b0df48d86835dd0d.

Quoted 3 lines

I wasn't fond of the change either.

Signature · 1 line
~Randy
#3 lore raw
Quoted 6 lines · Randy Dunlap
Quoted 6 lines

Yes, I discovered this a few weeks ago.
I just ended up adding
CONFIG_MODULES=y
to my KCONFIG_ALLCONFIG file.

Yes, I'm using the same workaround now. It works for me, since I keep an override file anyway.

-hpa