Skip to contentSkip to conversation

ARM : cpuidle: 3.13 fix

GIT PULL New Daniel Lezcano 2 participants 3 messages Dec 30, 2013 – Dec 31, 2013 CPU idle time management framework

lore
Share & tools
lore
#0 lore raw

Hi Rafael,

this pull request provides a single fix for the calxeda cpuidle driver. It is based on v3.13-rc6.

* Andre Przywara fixed a compilation warning due to the driver probe function prototype mismatch for the calxeda cpuidle driver

Thanks
-- Daniel

The following changes since commit 802eee95bde72fd0cd0f3a5b2098375a487d1eda:

Linux 3.13-rc6 (2013-12-29 16:01:33 -0800)

are available in the git repository at:

git://git.linaro.org/people/daniel.lezcano/linux.git cpuidle/3.13-fixes

for you to fetch changes up to 5781532ebecd9e0b7b5fc25d78030bdec635f4ac:

ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function
(2013-12-30 11:55:20 +0100)

----------------------------------------------------------------
Andre Przywara (1):
ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function

  drivers/cpuidle/cpuidle-calxeda.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 5 lines
  <http://www.linaro.org/> Linaro.org ? Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
#1 lore raw

PATCH 1/1 ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function

From: Andre Przywara <[email protected]>

Commit 60a66e370007e8535b7a561353b07b37deaf35ba changed the Calxeda cpuidle driver to a platform driver, copying the __init tag from the _init() to the newly used _probe() function. However, "probe should not be __init." (Rob said ;-)
Remove the __init tag to fix a section mismatch in the Calxeda cpuidle driver.

---
 drivers/cpuidle/cpuidle-calxeda.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/cpuidle/cpuidle-calxeda.c +1 -1
index 3679563..6e51114 100644
@@ -65,7 +65,7 @@ static struct cpuidle_driver calxeda_idle_driver = {
 	.state_count = 2,
 };
 
-static int __init calxeda_cpuidle_probe(struct platform_device *pdev)
+static int calxeda_cpuidle_probe(struct platform_device *pdev)
 {
 	return cpuidle_register(&calxeda_idle_driver, NULL);
 }
Signature · 1 line
1.7.9.5
#2 lore raw
In reply to Daniel Lezcano
Quoted 24 lines · Daniel Lezcano

Hi Rafael,

this pull request provides a single fix for the calxeda cpuidle driver. It is based on v3.13-rc6.

* Andre Przywara fixed a compilation warning due to the driver probe function prototype mismatch for the calxeda cpuidle driver

Thanks
-- Daniel

The following changes since commit 802eee95bde72fd0cd0f3a5b2098375a487d1eda:

   Linux 3.13-rc6 (2013-12-29 16:01:33 -0800)

are available in the git repository at:

git://git.linaro.org/people/daniel.lezcano/linux.git cpuidle/3.13-fixes

for you to fetch changes up to 5781532ebecd9e0b7b5fc25d78030bdec635f4ac:

ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function
(2013-12-30 11:55:20 +0100)

Quoted 6 lines

----------------------------------------------------------------
Andre Przywara (1):
ARM/cpuidle: remove __init tag from Calxeda cpuidle probe function

  drivers/cpuidle/cpuidle-calxeda.c |    2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

Pulled and pushed out (into the fixes branch).

Thanks and Happy New Year!

Rafael