exynos5250: usb: Fix VBus gpio numbers for ehci and xhci controllers
PATCH 1/2 exynos5250: usb: Fix VBus gpio numbers for ehci and xhci controllers
The gpio_*() apis require the exact gpio line number to deduce the gpio bank and the gpio pin addresses.
So fix the gpio number for VBUS used for EHCI ports as well as XHCI ports on exynos5250 boards.
--- board/samsung/dts/exynos5250-smdk5250.dts | 2 +- board/samsung/dts/exynos5250-snow.dts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
board/samsung/dts/exynos5250-smdk5250.dts +1 -1
@@ -146,6 +146,6 @@ }; ehci at 12110000 { - samsung,vbus-gpio = <&gpio 0xbe 0>; /* X26 */ + samsung,vbus-gpio = <&gpio 0x316 0>; /* X26 */ }; };
board/samsung/dts/exynos5250-snow.dts +2 -2
@@ -110,11 +110,11 @@ }; ehci at 12110000 { - samsung,vbus-gpio = <&gpio 0xb1 0>; /* X11 */ + samsung,vbus-gpio = <&gpio 0x309 0>; /* X11 */ }; xhci at 12000000 { - samsung,vbus-gpio = <&gpio 0xbf 0>; /* X27 */ + samsung,vbus-gpio = <&gpio 0x317 0>; /* X27 */ }; tmu at 10060000 {
Signature · 1 line
1.7.10.4
PATCH 1/2 exynos5250: usb: Fix VBus gpio numbers for ehci and xhci controllers
Quoted 10 lines · Vivek Gautam
The gpio_*() apis require the exact gpio line number to deduce the gpio bank and the gpio pin addresses.
So fix the gpio number for VBUS used for EHCI ports as well as XHCI ports on exynos5250 boards.Signed-off-by Vivek Gautam <[email protected]>Cc Julius Werner <[email protected]>Cc Minkyu Kang <[email protected]>Cc Marek Vasut <[email protected]>---
Based on u-boot-samsung 'master' branch.
Tested on smkd5250 and snow board for EHCI and XHCI ports.
Quoted 41 lines
board/samsung/dts/exynos5250-smdk5250.dts | 2 +- board/samsung/dts/exynos5250-snow.dts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)board/samsung/dts/exynos5250-smdk5250.dts +1
-1@@ -146,6 +146,6 @@ }; ehci at 12110000 { - samsung,vbus-gpio = <&gpio 0xbe 0>; /* X26 */ + samsung,vbus-gpio = <&gpio 0x316 0>; /* X26 */ }; };board/samsung/dts/exynos5250-snow.dts +2
-3@@ -110,11 +110,11 @@ }; ehci at 12110000 { - samsung,vbus-gpio = <&gpio 0xb1 0>; /* X11 */ + samsung,vbus-gpio = <&gpio 0x309 0>; /* X11 */ }; xhci at 12000000 { - samsung,vbus-gpio = <&gpio 0xbf 0>; /* X27 */ + samsung,vbus-gpio = <&gpio 0x317 0>; /* X27 */ }; tmu at 10060000 { --1.7.10.4
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Signature · 4 lines
Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India
PATCH 2/2 smdk5250: Remove 'board_usb_vbus_init()' function
In reply to Vivek GautamPreviously as a part of moving the VBUS gpio support to device tree following patch removed this and added relevant support in driver:
4a271cb exynos: usb: Switch USB VBUS GPIOs to be device tree configured
Recent changes for common board file migration for exynos platform added it again. So removing it now.
--- board/samsung/smdk5250/smdk5250.c | 19 ------------------- 1 file changed, 19 deletions(-)
board/samsung/smdk5250/smdk5250.c +0 -19
@@ -26,22 +26,6 @@DECLARE_GLOBAL_DATA_PTR ; -#ifdef CONFIG_USB_EHCI_EXYNOS -static int board_usb_vbus_init (void ) -{ -struct exynos5_gpio_part1 *gpio1 = (struct exynos5_gpio_part1 *) -samsung_get_base_gpio_part1 (); - -/* Enable VBUS power switch */ -s5p_gpio_direction_output (&gpio1->x2,6 ,1 ); - -/* VBUS turn ON time */ -mdelay (3 ); - -return 0 ; -} -#endif -#ifdef CONFIG_SOUND_MAX98095 static void board_enable_audio_codec (void ) {
@@ -56,9 +40,6 @@ static void board_enable_audio_codec(void)int exynos_init (void ) { -#ifdef CONFIG_USB_EHCI_EXYNOS -board_usb_vbus_init (); -#endif #ifdef CONFIG_SOUND_MAX98095 board_enable_audio_codec ();#endif
Signature · 1 line
1.7.10.4
PATCH 2/2 smdk5250: Remove 'board_usb_vbus_init()' function
Quoted 4 lines · Vivek Gautam
Previously as a part of moving the VBUS gpio support to device tree following patch removed this and added relevant support in driver:
4a271cb exynos: usb: Switch USB VBUS GPIOs to be device tree configured
Quoted 8 lines
Recent changes for common board file migration for exynos platform added it again. So removing it now.
Signed-off-by Vivek Gautam <[email protected]>Cc Julius Werner <[email protected]>Cc Minkyu Kang <[email protected]>Cc Marek Vasut <[email protected]>---
Based on u-boot-samsung 'master' branch.
Quoted 47 lines
board/samsung/smdk5250/smdk5250.c | 19 ------------------- 1 file changed, 19 deletions(-)board/samsung/smdk5250/smdk5250.c +0
-20@@ -26,22 +26,6 @@DECLARE_GLOBAL_DATA_PTR ; -#ifdef CONFIG_USB_EHCI_EXYNOS -static int board_usb_vbus_init (void ) -{ -struct exynos5_gpio_part1 *gpio1 = (struct exynos5_gpio_part1 *) -samsung_get_base_gpio_part1 (); - -/* Enable VBUS power switch */ -s5p_gpio_direction_output (&gpio1->x2,6 ,1 ); - -/* VBUS turn ON time */ -mdelay (3 ); - -return 0 ; -} -#endif -#ifdef CONFIG_SOUND_MAX98095 static void board_enable_audio_codec (void ) {@@ -56,9 +40,6 @@ static void board_enable_audio_codec(void)int exynos_init (void ) { -#ifdef CONFIG_USB_EHCI_EXYNOS -board_usb_vbus_init (); -#endif #ifdef CONFIG_SOUND_MAX98095 board_enable_audio_codec ();#endif --1.7.10.4
_______________________________________________
U-Boot mailing list
U-Boot at lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
Signature · 4 lines
Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India
PATCH 2/2 smdk5250: Remove 'board_usb_vbus_init()' function
In reply to Vivek GautamQuoted 7 lines · Vivek Gautam
Previously as a part of moving the VBUS gpio support to device tree following patch removed this and added relevant support in driver:
4a271cb exynos: usb: Switch USB VBUS GPIOs to be device tree configuredRecent changes for common board file migration for exynos platform added it again. So removing it now.
Quoted 7 lines
Signed-off-by Vivek Gautam <[email protected]>Cc Julius Werner <[email protected]>Cc Minkyu Kang <[email protected]>Cc Marek Vasut <[email protected]>--- board/samsung/smdk5250/smdk5250.c | 19 ------------------- 1 file changed, 19 deletions(-)
Minkyu, can you please pick this?
Best regards,
Marek Vasut
PATCH 2/2 smdk5250: Remove 'board_usb_vbus_init()' function
Quoted 16 lines · Marek Vasut
Quoted 7 lines · Vivek Gautam
Previously as a part of moving the VBUS gpio support to device tree following patch removed this and added relevant support in driver:
4a271cb exynos: usb: Switch USB VBUS GPIOs to be device tree configuredRecent changes for common board file migration for exynos platform added it again. So removing it now.
Quoted 7 lines
Signed-off-by Vivek Gautam <[email protected]>Cc Julius Werner <[email protected]>Cc Minkyu Kang <[email protected]>Cc Marek Vasut <[email protected]>--- board/samsung/smdk5250/smdk5250.c | 19 ------------------- 1 file changed, 19 deletions(-)
Quoted 3 lines
Reiewed-by Marek Vasut <[email protected]>Minkyu, can you please pick this?
OK.
Quoted 4 lines
Best regards,
Marek Vasut
Thanks,
Minkyu Kang.
PATCH 2/2 smdk5250: Remove 'board_usb_vbus_init()' function
In reply to Vivek GautamQuoted 7 lines · Vivek Gautam
Previously as a part of moving the VBUS gpio support to device tree following patch removed this and added relevant support in driver:
4a271cb exynos: usb: Switch USB VBUS GPIOs to be device tree configuredRecent changes for common board file migration for exynos platform added it again. So removing it now.
Quoted 8 lines
Signed-off-by Vivek Gautam <[email protected]>Cc Julius Werner <[email protected]>Cc Minkyu Kang <[email protected]>Cc Marek Vasut <[email protected]>--- board/samsung/smdk5250/smdk5250.c | 19 ------------------- 1 file changed, 19 deletions(-)
applied to u-boot-samsung.
Thanks,
Minkyu Kang.
PATCH 1/2 exynos5250: usb: Fix VBus gpio numbers for ehci and xhci controllers
In reply to Vivek GautamQuoted 9 lines · Vivek Gautam
The gpio_*() apis require the exact gpio line number to deduce the gpio bank and the gpio pin addresses.
So fix the gpio number for VBUS used for EHCI ports as well as XHCI ports on exynos5250 boards.Signed-off-by Vivek Gautam <[email protected]>Cc Julius Werner <[email protected]>Cc Minkyu Kang <[email protected]>Cc Marek Vasut <[email protected]>
Minkyu, can you please pick this?
Best regards,
Marek Vasut
PATCH 1/2 exynos5250: usb: Fix VBus gpio numbers for ehci and xhci controllers
Quoted 6 lines · Marek Vasut
Quoted 5 lines · Vivek Gautam
The gpio_*() apis require the exact gpio line number to deduce the gpio bank and the gpio pin addresses.
So fix the gpio number for VBUS used for EHCI ports as well as XHCI ports on exynos5250 boards.
Quoted 8 lines
Quoted 4 lines
Signed-off-by Vivek Gautam <[email protected]>Cc Julius Werner <[email protected]>Cc Minkyu Kang <[email protected]>Cc Marek Vasut <[email protected]>Reiewed-by Marek Vasut <[email protected]>Minkyu, can you please pick this?
OK.
Quoted 4 lines
Best regards,
Marek Vasut
Thanks,
Minkyu Kang.
PATCH 1/2 exynos5250: usb: Fix VBus gpio numbers for ehci and xhci controllers
In reply to Vivek GautamQuoted 5 lines · Vivek Gautam
The gpio_*() apis require the exact gpio line number to deduce the gpio bank and the gpio pin addresses.
So fix the gpio number for VBUS used for EHCI ports as well as XHCI ports on exynos5250 boards.
Quoted 9 lines
Signed-off-by Vivek Gautam <[email protected]>Cc Julius Werner <[email protected]>Cc Minkyu Kang <[email protected]>Cc Marek Vasut <[email protected]>--- board/samsung/dts/exynos5250-smdk5250.dts | 2 +- board/samsung/dts/exynos5250-snow.dts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-)
applied to u-boot-samsung.
Thanks,
Minkyu Kang.